)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"aa9d41e43b7ec7d23fcd1e5ce3c78897417b7abf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"But we are installing only Version(public), so the endpoint"},{"line_number":11,"context_line":"returned always corresponds to public url. This can be seen"},{"line_number":12,"context_line":"only if you define some other value for CONF.public_endpoint"},{"line_number":13,"context_line":"and CONF.admin_endpoint"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I29cdaf5fe9e5b82cc87b870a167d66d3890e75f8"},{"line_number":16,"context_line":"Closes-bug: #1483860"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa1b9901_1360d4cd","line":13,"updated":"2015-08-18 09:26:37.000000000","message":"Maybe you can update this line to indicate this bug can be found just define different value for CONF.public_endpoint and CONF.admin_endpoint.\n\nThe orginal message leads to think the bug could be reproduced by giving some value for CONF.public_endpoint or CONF.admin_endpoint, not necessary to be different.\n\nYou can keep it as is. I am just thinking out loud.","commit_id":"bbb8fbab179b1b10e2d8d968ac6f0586e7f9e45b"}],"etc/keystone-paste.ini":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"4eb9ba5754df9b4e35fb0419b0befc83abf90c68","unresolved":false,"context_lines":[{"line_number":77,"context_line":"pipeline \u003d sizelimit url_normalize request_id build_auth_context token_auth admin_token_auth json_body ec2_extension s3_extension crud_extension admin_service"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"[pipeline:public_api_v3]"},{"line_number":80,"context_line":"# The last item in this pipeline must be service_v3 or an equivalent"},{"line_number":81,"context_line":"# application. It cannot be a filter."},{"line_number":82,"context_line":"pipeline \u003d sizelimit url_normalize request_id build_auth_context token_auth admin_token_auth json_body ec2_extension_v3 s3_extension simple_cert_extension revoke_extension federation_extension oauth1_extension endpoint_filter_extension public_service_v3"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"1a4dcd0f_33192123","line":80,"updated":"2015-08-16 15:35:39.000000000","message":"there is no \u0027service_v3\u0027 anymore, update the comments to make it more accurate.","commit_id":"c1a9177aeef64e6a986b874ad6e44551c6528b8b"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"d4033da044c20631b0579cdad87d93e27d6ac218","unresolved":false,"context_lines":[{"line_number":77,"context_line":"pipeline \u003d sizelimit url_normalize request_id build_auth_context token_auth admin_token_auth json_body ec2_extension s3_extension crud_extension admin_service"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"[pipeline:public_api_v3]"},{"line_number":80,"context_line":"# The last item in this pipeline must be service_v3 or an equivalent"},{"line_number":81,"context_line":"# application. It cannot be a filter."},{"line_number":82,"context_line":"pipeline \u003d sizelimit url_normalize request_id build_auth_context token_auth admin_token_auth json_body ec2_extension_v3 s3_extension simple_cert_extension revoke_extension federation_extension oauth1_extension endpoint_filter_extension public_service_v3"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"fa1b9901_34ddd714","line":80,"in_reply_to":"1a4dcd0f_33192123","updated":"2015-08-17 22:07:34.000000000","message":"Done","commit_id":"c1a9177aeef64e6a986b874ad6e44551c6528b8b"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"4eb9ba5754df9b4e35fb0419b0befc83abf90c68","unresolved":false,"context_lines":[{"line_number":82,"context_line":"pipeline \u003d sizelimit url_normalize request_id build_auth_context token_auth admin_token_auth json_body ec2_extension_v3 s3_extension simple_cert_extension revoke_extension federation_extension oauth1_extension endpoint_filter_extension public_service_v3"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"[pipeline:admin_api_v3]"},{"line_number":85,"context_line":"# The last item in this pipeline must be service_v3 or an equivalent"},{"line_number":86,"context_line":"# application. It cannot be a filter."},{"line_number":87,"context_line":"pipeline \u003d sizelimit url_normalize request_id build_auth_context token_auth admin_token_auth json_body ec2_extension_v3 s3_extension simple_cert_extension revoke_extension federation_extension oauth1_extension endpoint_filter_extension admin_service_v3"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"1a4dcd0f_33bda102","line":85,"updated":"2015-08-16 15:35:39.000000000","message":"same here.","commit_id":"c1a9177aeef64e6a986b874ad6e44551c6528b8b"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"d4033da044c20631b0579cdad87d93e27d6ac218","unresolved":false,"context_lines":[{"line_number":82,"context_line":"pipeline \u003d sizelimit url_normalize request_id build_auth_context token_auth admin_token_auth json_body ec2_extension_v3 s3_extension simple_cert_extension revoke_extension federation_extension oauth1_extension endpoint_filter_extension public_service_v3"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"[pipeline:admin_api_v3]"},{"line_number":85,"context_line":"# The last item in this pipeline must be service_v3 or an equivalent"},{"line_number":86,"context_line":"# application. It cannot be a filter."},{"line_number":87,"context_line":"pipeline \u003d sizelimit url_normalize request_id build_auth_context token_auth admin_token_auth json_body ec2_extension_v3 s3_extension simple_cert_extension revoke_extension federation_extension oauth1_extension endpoint_filter_extension admin_service_v3"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"fa1b9901_54e2cbd6","line":85,"in_reply_to":"1a4dcd0f_33bda102","updated":"2015-08-17 22:07:34.000000000","message":"Done","commit_id":"c1a9177aeef64e6a986b874ad6e44551c6528b8b"}],"keystone/service.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"4eb9ba5754df9b4e35fb0419b0befc83abf90c68","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    return wsgi.ComposingRouter(routes.Mapper(),"},{"line_number":97,"context_line":"                                [routers.Versions(\u0027admin\u0027)])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"@fail_gracefully"},{"line_number":101,"context_line":"def v3_app_factory(global_conf, **local_conf):"},{"line_number":102,"context_line":"    controllers.register_version(\u0027v3\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_f3b899ea","line":99,"updated":"2015-08-16 15:35:39.000000000","message":"remove this decorator since this is not an independent app called from the paste.\n\ndecorator on `v3_admin_app_factory` or `v3_public_app_factory` is enough.","commit_id":"c1a9177aeef64e6a986b874ad6e44551c6528b8b"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"aa9d41e43b7ec7d23fcd1e5ce3c78897417b7abf","unresolved":false,"context_lines":[{"line_number":152,"context_line":"def v3_app_factory(global_conf, **local_conf):"},{"line_number":153,"context_line":"    # We are still keeping this factory since grenade-gate requires"},{"line_number":154,"context_line":"    # new code to run with old config. We can remove this after liberty"},{"line_number":155,"context_line":"    # https://github.com/openstack-dev/grenade#theory-of-upgrade"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    return v3_public_app_factory(global_conf, **local_conf)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_981163af","line":155,"updated":"2015-08-18 09:26:37.000000000","message":"Thanks for the detail comments here, so, you should deprected this using this annotation.\"@versionutils.deprecated\"","commit_id":"bbb8fbab179b1b10e2d8d968ac6f0586e7f9e45b"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"75a98a01434cc0edd5aea4983bf706bcfda6833e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"@fail_gracefully"},{"line_number":157,"context_line":"def v3_app_factory(global_conf, **local_conf):"},{"line_number":158,"context_line":"    # We are still keeping this factory since grenade-gate requires"},{"line_number":159,"context_line":"    # new code to run with old config. We can remove this after liberty"},{"line_number":160,"context_line":"    # https://github.com/openstack-dev/grenade#theory-of-upgrade"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    return v3_public_app_factory(global_conf, **local_conf)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_098b1320","line":159,"updated":"2015-11-20 02:25:51.000000000","message":"s/liberty/Mitaka","commit_id":"52304410f383a4846d616f3613de23366666cd53"}],"keystone/tests/unit/test_versions.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"4eb9ba5754df9b4e35fb0419b0befc83abf90c68","unresolved":false,"context_lines":[{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    def test_use_config_endpoint_if_set_v3(self):"},{"line_number":778,"context_line":"        admin_endpoint \u003d \"http://admin_endpoint:9999\""},{"line_number":779,"context_line":"        public_endpoint \u003d \"http://public_endpoint:8888\""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"        self.config_fixture.config(public_endpoint\u003dpublic_endpoint,"},{"line_number":782,"context_line":"                                   admin_endpoint\u003dadmin_endpoint)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_53994d78","line":779,"updated":"2015-08-16 15:35:39.000000000","message":"might be consider to use CONF.public_endpoint and CONF.admin_endpoint instead, but I am fine if keep it as is.","commit_id":"c1a9177aeef64e6a986b874ad6e44551c6528b8b"}]}