)]}'
{"keystone/tests/unit/common/test_authorization.py":[{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"5df7d0931ea3201c1abade6c69a44e597586e370","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertIsNone(auth_context[\u0027access_token_id\u0027])"},{"line_number":56,"context_line":"        self.assertNotIn(\u0027group_ids\u0027, auth_context)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_domain_scoped(self):"},{"line_number":59,"context_line":"        # Check contents of auth_context when token is domain-scoped."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_c9e94f1c","line":58,"updated":"2015-08-27 12:00:35.000000000","message":"you can renamed the method as \u0027test_token_is_domain_scoped\u0027","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cca5b0763ac12b0e2dcee05c0712f9f6562ea034","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertIsNone(auth_context[\u0027access_token_id\u0027])"},{"line_number":56,"context_line":"        self.assertNotIn(\u0027group_ids\u0027, auth_context)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_domain_scoped(self):"},{"line_number":59,"context_line":"        # Check contents of auth_context when token is domain-scoped."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_3796ca93","line":58,"in_reply_to":"da20952f_c9e94f1c","updated":"2015-08-28 23:49:47.000000000","message":"Done","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"5df7d0931ea3201c1abade6c69a44e597586e370","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_domain_scoped(self):"},{"line_number":59,"context_line":"        # Check contents of auth_context when token is domain-scoped."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":62,"context_line":"        del token_data[\u0027token\u0027][\u0027project\u0027]"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_89f3570a","line":60,"updated":"2015-08-27 12:00:35.000000000","message":"you can remove new line here.","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cca5b0763ac12b0e2dcee05c0712f9f6562ea034","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_domain_scoped(self):"},{"line_number":59,"context_line":"        # Check contents of auth_context when token is domain-scoped."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":62,"context_line":"        del token_data[\u0027token\u0027][\u0027project\u0027]"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_f78b7266","line":60,"in_reply_to":"da20952f_89f3570a","updated":"2015-08-28 23:49:47.000000000","message":"why?","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"5df7d0931ea3201c1abade6c69a44e597586e370","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertEqual(domain_id, auth_context[\u0027domain_id\u0027])"},{"line_number":76,"context_line":"        self.assertEqual(domain_name, auth_context[\u0027domain_name\u0027])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_unscoped(self):"},{"line_number":79,"context_line":"        # Check contents of auth_context when the token is unscoped."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_29532be3","line":78,"updated":"2015-08-27 12:00:35.000000000","message":"rename method to \u0027test_domain_is_unscoped\u0027","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cca5b0763ac12b0e2dcee05c0712f9f6562ea034","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertEqual(domain_id, auth_context[\u0027domain_id\u0027])"},{"line_number":76,"context_line":"        self.assertEqual(domain_name, auth_context[\u0027domain_name\u0027])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_unscoped(self):"},{"line_number":79,"context_line":"        # Check contents of auth_context when the token is unscoped."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_77cd22b6","line":78,"in_reply_to":"da20952f_29532be3","updated":"2015-08-28 23:49:47.000000000","message":"I renamed it to \"test_token_is_unscoped\"... not sure how a domain can be unscoped.","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"5df7d0931ea3201c1abade6c69a44e597586e370","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_unscoped(self):"},{"line_number":79,"context_line":"        # Check contents of auth_context when the token is unscoped."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":82,"context_line":"        del token_data[\u0027token\u0027][\u0027project\u0027]"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_a9cf3baf","line":80,"updated":"2015-08-27 12:00:35.000000000","message":"remove new line.","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cca5b0763ac12b0e2dcee05c0712f9f6562ea034","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_unscoped(self):"},{"line_number":79,"context_line":"        # Check contents of auth_context when the token is unscoped."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":82,"context_line":"        del token_data[\u0027token\u0027][\u0027project\u0027]"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_37c48a8f","line":80,"in_reply_to":"da20952f_a9cf3baf","updated":"2015-08-28 23:49:47.000000000","message":"why?","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"5df7d0931ea3201c1abade6c69a44e597586e370","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertNotIn(\u0027domain_id\u0027, auth_context)"},{"line_number":91,"context_line":"        self.assertNotIn(\u0027domain_name\u0027, auth_context)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_federated_user(self):"},{"line_number":94,"context_line":"        # When the token is for a federated user then group_ids is in"},{"line_number":95,"context_line":"        # auth_context."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_e90a13d2","line":93,"updated":"2015-08-27 12:00:35.000000000","message":"rename method to \u0027test_token_is_for_federated_user\u0027","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cca5b0763ac12b0e2dcee05c0712f9f6562ea034","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.assertNotIn(\u0027domain_id\u0027, auth_context)"},{"line_number":91,"context_line":"        self.assertNotIn(\u0027domain_name\u0027, auth_context)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_federated_user(self):"},{"line_number":94,"context_line":"        # When the token is for a federated user then group_ids is in"},{"line_number":95,"context_line":"        # auth_context."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_374b2a2c","line":93,"in_reply_to":"da20952f_e90a13d2","updated":"2015-08-28 23:49:47.000000000","message":"Done","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"5df7d0931ea3201c1abade6c69a44e597586e370","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def test_federated_user(self):"},{"line_number":94,"context_line":"        # When the token is for a federated user then group_ids is in"},{"line_number":95,"context_line":"        # auth_context."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        group_ids \u003d [uuid.uuid4().hex for x in range(1, 5)]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_a9141bf5","line":96,"updated":"2015-08-27 12:00:35.000000000","message":"remove new line.","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cca5b0763ac12b0e2dcee05c0712f9f6562ea034","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def test_federated_user(self):"},{"line_number":94,"context_line":"        # When the token is for a federated user then group_ids is in"},{"line_number":95,"context_line":"        # auth_context."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        group_ids \u003d [uuid.uuid4().hex for x in range(1, 5)]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_f75052d6","line":96,"in_reply_to":"da20952f_a9141bf5","updated":"2015-08-28 23:49:47.000000000","message":"why?","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"5df7d0931ea3201c1abade6c69a44e597586e370","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        self.assertItemsEqual(group_ids, auth_context[\u0027group_ids\u0027])"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_not_KeystoneToken_ex(self):"},{"line_number":115,"context_line":"        # If the token isn\u0027t a KeystoneToken then an UnexpectedError exception"},{"line_number":116,"context_line":"        # is raised."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_691e030e","line":114,"updated":"2015-08-27 12:00:35.000000000","message":"rename method to \u0027test_token_is_not_keystoneToken_raises_exception\u0027","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cca5b0763ac12b0e2dcee05c0712f9f6562ea034","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        self.assertItemsEqual(group_ids, auth_context[\u0027group_ids\u0027])"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_not_KeystoneToken_ex(self):"},{"line_number":115,"context_line":"        # If the token isn\u0027t a KeystoneToken then an UnexpectedError exception"},{"line_number":116,"context_line":"        # is raised."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_1775c662","line":114,"in_reply_to":"da20952f_691e030e","updated":"2015-08-28 23:49:47.000000000","message":"Done","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"5df7d0931ea3201c1abade6c69a44e597586e370","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def test_not_KeystoneToken_ex(self):"},{"line_number":115,"context_line":"        # If the token isn\u0027t a KeystoneToken then an UnexpectedError exception"},{"line_number":116,"context_line":"        # is raised."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        self.assertRaises(exception.UnexpectedError,"},{"line_number":119,"context_line":"                          authorization.token_to_auth_context, {})"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_89dd9744","line":117,"updated":"2015-08-27 12:00:35.000000000","message":"remove new line.","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cca5b0763ac12b0e2dcee05c0712f9f6562ea034","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def test_not_KeystoneToken_ex(self):"},{"line_number":115,"context_line":"        # If the token isn\u0027t a KeystoneToken then an UnexpectedError exception"},{"line_number":116,"context_line":"        # is raised."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        self.assertRaises(exception.UnexpectedError,"},{"line_number":119,"context_line":"                          authorization.token_to_auth_context, {})"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_d76aee80","line":117,"in_reply_to":"da20952f_89dd9744","updated":"2015-08-28 23:49:47.000000000","message":"why?","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"5df7d0931ea3201c1abade6c69a44e597586e370","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertRaises(exception.UnexpectedError,"},{"line_number":119,"context_line":"                          authorization.token_to_auth_context, {})"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_no_user_id_ex(self):"},{"line_number":122,"context_line":"        # If there\u0027s no user ID in the KeystoneToken then an Unauthorized"},{"line_number":123,"context_line":"        # exception is raised."},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_69ccc389","line":121,"updated":"2015-08-27 12:00:35.000000000","message":"rename method to \u0027test_user_id_missing_in_keystoneToken_raises_exception\u0027","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cca5b0763ac12b0e2dcee05c0712f9f6562ea034","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertRaises(exception.UnexpectedError,"},{"line_number":119,"context_line":"                          authorization.token_to_auth_context, {})"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_no_user_id_ex(self):"},{"line_number":122,"context_line":"        # If there\u0027s no user ID in the KeystoneToken then an Unauthorized"},{"line_number":123,"context_line":"        # exception is raised."},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_570d7ee6","line":121,"in_reply_to":"da20952f_69ccc389","updated":"2015-08-28 23:49:47.000000000","message":"Done","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"5df7d0931ea3201c1abade6c69a44e597586e370","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def test_no_user_id_ex(self):"},{"line_number":122,"context_line":"        # If there\u0027s no user ID in the KeystoneToken then an Unauthorized"},{"line_number":123,"context_line":"        # exception is raised."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":126,"context_line":"        del token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027]"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_49e8dfe2","line":124,"updated":"2015-08-27 12:00:35.000000000","message":"remove new line.","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cca5b0763ac12b0e2dcee05c0712f9f6562ea034","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def test_no_user_id_ex(self):"},{"line_number":122,"context_line":"        # If there\u0027s no user ID in the KeystoneToken then an Unauthorized"},{"line_number":123,"context_line":"        # exception is raised."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":126,"context_line":"        del token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027]"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_17fce6b6","line":124,"in_reply_to":"da20952f_49e8dfe2","updated":"2015-08-28 23:49:47.000000000","message":"why?","commit_id":"768083f061ec6215338e39c4c7f7ee1cb64561df"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"116eb6d94f3ee63a0c790eaa7dd5b11fd3e5c64e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.assertRaises(exception.UnexpectedError,"},{"line_number":115,"context_line":"                          authorization.token_to_auth_context, {})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_user_id_missing_in_KeystoneToken_raises_exception(self):"},{"line_number":118,"context_line":"        # If there\u0027s no user ID in the KeystoneToken then an Unauthorized"},{"line_number":119,"context_line":"        # exception is raised."},{"line_number":120,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_7cd5ba19","line":117,"updated":"2015-09-07 09:09:01.000000000","message":"better to name it as  \"test_user_id_missing_in_token_raises_exception\"","commit_id":"6a43d8bde09e91869b4cac5ad7e348c66fa59872"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"32db18a1527c9b4bef92a324e9fa9680164449c2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.assertRaises(exception.UnexpectedError,"},{"line_number":115,"context_line":"                          authorization.token_to_auth_context, {})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_user_id_missing_in_KeystoneToken_raises_exception(self):"},{"line_number":118,"context_line":"        # If there\u0027s no user ID in the KeystoneToken then an Unauthorized"},{"line_number":119,"context_line":"        # exception is raised."},{"line_number":120,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_e44e4395","line":117,"in_reply_to":"da20952f_7cd5ba19","updated":"2015-09-11 19:55:42.000000000","message":"ok... I wonder how many times I\u0027ll have to rename this method.","commit_id":"6a43d8bde09e91869b4cac5ad7e348c66fa59872"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"116eb6d94f3ee63a0c790eaa7dd5b11fd3e5c64e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                          authorization.token_to_auth_context, {})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_user_id_missing_in_KeystoneToken_raises_exception(self):"},{"line_number":118,"context_line":"        # If there\u0027s no user ID in the KeystoneToken then an Unauthorized"},{"line_number":119,"context_line":"        # exception is raised."},{"line_number":120,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":121,"context_line":"        del token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_7cbcdadb","line":118,"updated":"2015-09-07 09:09:01.000000000","message":"better to say \"user ID not in the token then...\"","commit_id":"6a43d8bde09e91869b4cac5ad7e348c66fa59872"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"072878e20ffeddc3f9ed6f4f2017cf8614498a2a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                          authorization.token_to_auth_context, {})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_user_id_missing_in_KeystoneToken_raises_exception(self):"},{"line_number":118,"context_line":"        # If there\u0027s no user ID in the KeystoneToken then an Unauthorized"},{"line_number":119,"context_line":"        # exception is raised."},{"line_number":120,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":121,"context_line":"        del token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_44606101","line":118,"in_reply_to":"ba15a1d1_d1cf667d","updated":"2015-09-23 13:56:44.000000000","message":"The only reason SAMPLE_V3_TOKEN  and token_data are used in the test code is because that\u0027s the only way to create a KeystoneToken. If I could create a KeystoneToken without it I would do it that way (and that might be a useful cleanup for later).\n\nSo this test isn\u0027t trying to verify that if the user id is removed from the token in the SAMPLE_V3_TOKEN, it\u0027s trying to verify that if the KeystoneToken doesn\u0027t have a user ID then that fails when it\u0027s passed to token_to_auth_context. It just turns out that the way the test sets up the KeystoneToken is to manipulate the token_data.","commit_id":"6a43d8bde09e91869b4cac5ad7e348c66fa59872"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"32db18a1527c9b4bef92a324e9fa9680164449c2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                          authorization.token_to_auth_context, {})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_user_id_missing_in_KeystoneToken_raises_exception(self):"},{"line_number":118,"context_line":"        # If there\u0027s no user ID in the KeystoneToken then an Unauthorized"},{"line_number":119,"context_line":"        # exception is raised."},{"line_number":120,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":121,"context_line":"        del token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_c430df09","line":118,"in_reply_to":"da20952f_7cbcdadb","updated":"2015-09-11 19:55:42.000000000","message":"not sure I figured out what the change requested is from the comment but I change KeystoneToken to token (even though it\u0027s a KeystoneToken that this test is dealing with).","commit_id":"6a43d8bde09e91869b4cac5ad7e348c66fa59872"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b8635fa15470621bc2d8060dd2316c8477438f28","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                          authorization.token_to_auth_context, {})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_user_id_missing_in_KeystoneToken_raises_exception(self):"},{"line_number":118,"context_line":"        # If there\u0027s no user ID in the KeystoneToken then an Unauthorized"},{"line_number":119,"context_line":"        # exception is raised."},{"line_number":120,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"},{"line_number":121,"context_line":"        del token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_d1cf667d","line":118,"in_reply_to":"da20952f_c430df09","updated":"2015-09-23 03:49:33.000000000","message":"since the testcase here is trying to copy V3 token and then del the user id from the token, and then verify whether it will work.\n\ntoken is the member of class: KeystoneToken, user id is the member of token.","commit_id":"6a43d8bde09e91869b4cac5ad7e348c66fa59872"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b0486ca9a74ec574d24445c0fdc931e56c5ce33d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestTokenToAuthContext(unit.BaseTestCase):"},{"line_number":28,"context_line":"    def test_project_trust(self):"},{"line_number":29,"context_line":"        token_data \u003d test_token_provider.SAMPLE_V3_TOKEN"},{"line_number":30,"context_line":"        token \u003d token_model.KeystoneToken(token_id\u003duuid.uuid4().hex,"},{"line_number":31,"context_line":"                                          token_data\u003dtoken_data)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_7a9575e2","line":28,"updated":"2015-09-14 14:03:56.000000000","message":"Is this testing a trust scoped token? The name of the test doesn\u0027t really elude to what is being tested, or how.","commit_id":"02c1fd2d7f36fc0652e29ec3d9e25c97f9018296"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"d72088fd99a1e5760328618ce7fb88f28e70b692","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestTokenToAuthContext(unit.BaseTestCase):"},{"line_number":28,"context_line":"    def test_project_trust(self):"},{"line_number":29,"context_line":"        token_data \u003d test_token_provider.SAMPLE_V3_TOKEN"},{"line_number":30,"context_line":"        token \u003d token_model.KeystoneToken(token_id\u003duuid.uuid4().hex,"},{"line_number":31,"context_line":"                                          token_data\u003dtoken_data)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_5caf347d","line":28,"in_reply_to":"ba15a1d1_7a9575e2","updated":"2015-09-21 19:17:51.000000000","message":"Done","commit_id":"02c1fd2d7f36fc0652e29ec3d9e25c97f9018296"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b0486ca9a74ec574d24445c0fdc931e56c5ce33d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self.assertNotIn(\u0027domain_id\u0027, auth_context)"},{"line_number":89,"context_line":"        self.assertNotIn(\u0027domain_name\u0027, auth_context)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_token_is_for_federated_use(self):"},{"line_number":92,"context_line":"        # When the token is for a federated user then group_ids is in"},{"line_number":93,"context_line":"        # auth_context."},{"line_number":94,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_da7e01ae","line":91,"updated":"2015-09-14 14:03:56.000000000","message":"federated_use or federated_user*?","commit_id":"02c1fd2d7f36fc0652e29ec3d9e25c97f9018296"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"d72088fd99a1e5760328618ce7fb88f28e70b692","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self.assertNotIn(\u0027domain_id\u0027, auth_context)"},{"line_number":89,"context_line":"        self.assertNotIn(\u0027domain_name\u0027, auth_context)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_token_is_for_federated_use(self):"},{"line_number":92,"context_line":"        # When the token is for a federated user then group_ids is in"},{"line_number":93,"context_line":"        # auth_context."},{"line_number":94,"context_line":"        token_data \u003d copy.deepcopy(test_token_provider.SAMPLE_V3_TOKEN)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_979a85c4","line":91,"in_reply_to":"ba15a1d1_da7e01ae","updated":"2015-09-21 19:17:51.000000000","message":"Done","commit_id":"02c1fd2d7f36fc0652e29ec3d9e25c97f9018296"}]}