)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"8da09e335af97b4feadd0c319170175a996f54f6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"rationalization makes the subsequent patches that implement data"},{"line_number":15,"context_line":"driven tests cleaner. The split out test uses the default domain"},{"line_number":16,"context_line":"rather than creating a new domain simply because this allows for"},{"line_number":17,"context_line":"a more obvious expected execption when using an LDAP assignment"},{"line_number":18,"context_line":"backend."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially Implements: bp data-driven-tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_db07a01a","line":17,"updated":"2015-08-19 08:46:56.000000000","message":"nit: s/execption/exception","commit_id":"1f5feea35b368d7e083be924b5df0453e75e9fe2"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"e19e0e574e0c4f8bcade6328ebb198e4b9a08f28","unresolved":false,"context_lines":[{"line_number":14,"context_line":"rationalization makes the subsequent patches that implement data"},{"line_number":15,"context_line":"driven tests cleaner. The split out test uses the default domain"},{"line_number":16,"context_line":"rather than creating a new domain simply because this allows for"},{"line_number":17,"context_line":"a more obvious expected execption when using an LDAP assignment"},{"line_number":18,"context_line":"backend."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially Implements: bp data-driven-tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_15d07c1e","line":17,"in_reply_to":"fa1b9901_db07a01a","updated":"2015-08-19 11:01:53.000000000","message":"Done","commit_id":"1f5feea35b368d7e083be924b5df0453e75e9fe2"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"b14a5c29179bea997fe8969f698d8febcdb54b3c","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        self.assertEqual(existing_assignments + 2, after_assignments)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    def test_list_role_assignments_filtered_by_role(self):"},{"line_number":470,"context_line":"        # Domain roles are not supported by the LDAP Assignment backend"},{"line_number":471,"context_line":"        self.assertRaises("},{"line_number":472,"context_line":"            exception.NotImplemented,"},{"line_number":473,"context_line":"            super(BaseLDAPIdentity, self)."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_c17a2688","line":470,"updated":"2015-08-25 19:26:38.000000000","message":"is \"domain roles\" the correct name? I thought that domain roles will be another concept after dynamic policies.","commit_id":"05cffdbd7a65d25bfddb1d313eac7cdb2442e2e3"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"9b60db9a0d4823aca4b26b4da4ee429884aed631","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        self.assertEqual(existing_assignments + 2, after_assignments)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    def test_list_role_assignments_filtered_by_role(self):"},{"line_number":470,"context_line":"        # Domain roles are not supported by the LDAP Assignment backend"},{"line_number":471,"context_line":"        self.assertRaises("},{"line_number":472,"context_line":"            exception.NotImplemented,"},{"line_number":473,"context_line":"            super(BaseLDAPIdentity, self)."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_a921f74e","line":470,"in_reply_to":"fa1b9901_b283a902","updated":"2015-08-26 12:16:07.000000000","message":"Sure, no problem!","commit_id":"05cffdbd7a65d25bfddb1d313eac7cdb2442e2e3"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"9a42b719daa812c2aa2892d94a14b4b9d600e652","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        self.assertEqual(existing_assignments + 2, after_assignments)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    def test_list_role_assignments_filtered_by_role(self):"},{"line_number":470,"context_line":"        # Domain roles are not supported by the LDAP Assignment backend"},{"line_number":471,"context_line":"        self.assertRaises("},{"line_number":472,"context_line":"            exception.NotImplemented,"},{"line_number":473,"context_line":"            super(BaseLDAPIdentity, self)."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_b283a902","line":470,"in_reply_to":"fa1b9901_c17a2688","updated":"2015-08-26 09:26:59.000000000","message":"maybe domain assignments would have been a better term...I\u0027ll update if I need to do another patch - if not, I\u0027ll fix up as a follow on","commit_id":"05cffdbd7a65d25bfddb1d313eac7cdb2442e2e3"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"f0fa0e4d91085428a98630880dd33d92cabd0aa7","unresolved":false,"context_lines":[{"line_number":2758,"context_line":"                      \"SQL assignment backend.\")"},{"line_number":2759,"context_line":""},{"line_number":2760,"context_line":"    def test_list_role_assignments_filtered_by_role(self):"},{"line_number":2761,"context_line":"        # Domain roles are supported by the SQL Assignment backend"},{"line_number":2762,"context_line":"        base \u003d super(BaseLDAPIdentity, self)"},{"line_number":2763,"context_line":"        base.test_list_role_assignments_filtered_by_role()"},{"line_number":2764,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_0d8758b6","line":2761,"updated":"2015-08-27 10:42:49.000000000","message":"won\u0027t the test run automatically, without this call?","commit_id":"1fdb0c6634af7f158aa99c2daf32cdb0088407b7"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5e9553229099395548d0f73fdd4e3ae11eb45418","unresolved":false,"context_lines":[{"line_number":2758,"context_line":"                      \"SQL assignment backend.\")"},{"line_number":2759,"context_line":""},{"line_number":2760,"context_line":"    def test_list_role_assignments_filtered_by_role(self):"},{"line_number":2761,"context_line":"        # Domain roles are supported by the SQL Assignment backend"},{"line_number":2762,"context_line":"        base \u003d super(BaseLDAPIdentity, self)"},{"line_number":2763,"context_line":"        base.test_list_role_assignments_filtered_by_role()"},{"line_number":2764,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_f2616aa9","line":2761,"in_reply_to":"da20952f_0d8758b6","updated":"2015-09-03 09:28:13.000000000","message":"Thanks...I think you may be right, I\u0027ll check this out, and maybe follow up with a clean up patch","commit_id":"1fdb0c6634af7f158aa99c2daf32cdb0088407b7"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"508849dd47c8b2e1006ad2d369dd594621fb3aa3","unresolved":false,"context_lines":[{"line_number":2758,"context_line":"                      \"SQL assignment backend.\")"},{"line_number":2759,"context_line":""},{"line_number":2760,"context_line":"    def test_list_role_assignments_filtered_by_role(self):"},{"line_number":2761,"context_line":"        # Domain roles are supported by the SQL Assignment backend"},{"line_number":2762,"context_line":"        base \u003d super(BaseLDAPIdentity, self)"},{"line_number":2763,"context_line":"        base.test_list_role_assignments_filtered_by_role()"},{"line_number":2764,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_78e6f617","line":2761,"in_reply_to":"da20952f_f2616aa9","updated":"2015-09-19 09:58:34.000000000","message":"Actually, no, it won\u0027t run without this override, it\u0027s parent classes have the original test override that expects an error.","commit_id":"1fdb0c6634af7f158aa99c2daf32cdb0088407b7"}]}