)]}'
{"id":"openstack%2Fkeystone~215378","triplet_id":"openstack%2Fkeystone~master~Ic4d60a046df1f231d02a45998c8a0ef7c5b7b107","project":"openstack/keystone","branch":"master","topic":"bug/1482772","hashtags":[],"change_id":"Ic4d60a046df1f231d02a45998c8a0ef7c5b7b107","subject":"Add region_id filter for List Endpoints API","status":"MERGED","created":"2015-08-20 23:43:41.000000000","updated":"2015-08-22 17:35:00.000000000","submitted":"2015-08-22 17:34:58.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8cdf92655cfdbd330339158c4a9603e02f7f9798","_number":215378,"virtual_id_number":215378,"owner":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},{"value":0,"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},{"value":0,"date":"2015-08-21 17:06:18.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":2,"date":"2015-08-22 17:34:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"all":[{"value":2,"date":"2015-08-21 18:27:44.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":1,"date":"2015-08-21 17:12:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},{"value":1,"date":"2015-08-21 23:20:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":1,"date":"2015-08-22 12:36:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},{"value":2,"date":"2015-08-21 17:37:43.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2015-08-21 18:48:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"all":[{"value":1,"date":"2015-08-21 23:31:34.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},{"value":0,"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-21 17:12:19.000000000","updated_by":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"reviewer":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"state":"REVIEWER"},{"updated":"2015-08-21 17:37:43.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-08-21 18:48:51.000000000","updated_by":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"reviewer":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"state":"REVIEWER"},{"updated":"2015-08-21 23:20:02.000000000","updated_by":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"reviewer":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"state":"REVIEWER"},{"updated":"2015-08-21 23:31:34.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2015-08-22 12:36:19.000000000","updated_by":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"reviewer":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"state":"REVIEWER"},{"updated":"2015-08-22 17:34:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0044678423f1bc9fc70eb3ea9b3c496c35623f35","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-08-20 23:43:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f6b23c8dbc82fac10942c322870a3e2a9b9da375","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-08-20 23:44:58.000000000","message":"Patch Set 1:\n\nspecs update was already merged: https://review.openstack.org/#/c/213356/","accounts_in_message":[],"_revision_number":1},{"id":"6ea7e5ab75afc5651adfbfc2f456a6bbd463e2cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-21 00:41:30.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-keystone-pep8 http://logs.openstack.org/78/215378/1/check/gate-keystone-pep8/faa1ade/ : SUCCESS in 3m 07s\n- gate-keystone-docs http://docs-draft.openstack.org/78/215378/1/check/gate-keystone-docs/b8617f0//doc/build/html/ : SUCCESS in 6m 39s\n- gate-keystone-python27 http://logs.openstack.org/78/215378/1/check/gate-keystone-python27/2fe0f8d/ : SUCCESS in 8m 25s\n- gate-keystone-python34 http://logs.openstack.org/78/215378/1/check/gate-keystone-python34/fea7ffa/ : SUCCESS in 5m 06s\n- gate-tempest-dsvm-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-full/4e87504/ : SUCCESS in 42m 05s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-postgres-full/3eee9e8/ : SUCCESS in 41m 49s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-neutron-full/030e1bd/ : SUCCESS in 57m 35s\n- gate-grenade-dsvm http://logs.openstack.org/78/215378/1/check/gate-grenade-dsvm/094bfb2/ : FAILURE in 49m 08s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-large-ops/0ef7ffe/ : SUCCESS in 34m 00s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-neutron-large-ops/331a5e9/ : SUCCESS in 32m 51s\n- gate-rally-dsvm-keystone http://logs.openstack.org/78/215378/1/check/gate-rally-dsvm-keystone/dc2d4e3/ : SUCCESS in 32m 30s (non-voting)\n- gate-keystone-tox-bandit http://logs.openstack.org/78/215378/1/check/gate-keystone-tox-bandit/b7a700d/ : SUCCESS in 2m 23s","accounts_in_message":[],"_revision_number":1},{"id":"52a1f644dace96558e48f4c7b31cacefa0244383","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-08-21 01:04:54.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"7cef07f0ea77c10dc95021fb48925a3983b33298","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-21 02:12:56.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-keystone-pep8 http://logs.openstack.org/78/215378/1/check/gate-keystone-pep8/082590b/ : SUCCESS in 3m 58s\n- gate-keystone-docs http://docs-draft.openstack.org/78/215378/1/check/gate-keystone-docs/50292b4//doc/build/html/ : SUCCESS in 4m 55s\n- gate-keystone-python27 http://logs.openstack.org/78/215378/1/check/gate-keystone-python27/2efd585/ : SUCCESS in 9m 25s\n- gate-keystone-python34 http://logs.openstack.org/78/215378/1/check/gate-keystone-python34/9e16295/ : SUCCESS in 5m 55s\n- gate-tempest-dsvm-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-full/cd41591/ : SUCCESS in 52m 14s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-postgres-full/81a24a8/ : SUCCESS in 52m 02s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-neutron-full/0362bdd/ : FAILURE in 1h 07m 51s\n- gate-grenade-dsvm http://logs.openstack.org/78/215378/1/check/gate-grenade-dsvm/651e3b8/ : SUCCESS in 45m 47s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-large-ops/4730cc5/ : SUCCESS in 35m 45s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-neutron-large-ops/458eb09/ : SUCCESS in 33m 15s\n- gate-rally-dsvm-keystone http://logs.openstack.org/78/215378/1/check/gate-rally-dsvm-keystone/b4e3966/ : SUCCESS in 37m 02s (non-voting)\n- gate-keystone-tox-bandit http://logs.openstack.org/78/215378/1/check/gate-keystone-tox-bandit/286545f/ : SUCCESS in 2m 22s","accounts_in_message":[],"_revision_number":1},{"id":"29247d924d74a623963d771cbeb4f09ed4f69df8","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-08-21 03:19:26.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"fbb9b6eb812e42c1637268bbcd5a3e15c425b55e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-21 04:35:24.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-keystone-pep8 http://logs.openstack.org/78/215378/1/check/gate-keystone-pep8/2c395f4/ : SUCCESS in 3m 53s\n- gate-keystone-docs http://docs-draft.openstack.org/78/215378/1/check/gate-keystone-docs/8f61015//doc/build/html/ : SUCCESS in 6m 43s\n- gate-keystone-python27 http://logs.openstack.org/78/215378/1/check/gate-keystone-python27/e1f3c29/ : SUCCESS in 9m 30s\n- gate-keystone-python34 http://logs.openstack.org/78/215378/1/check/gate-keystone-python34/4caa92f/ : SUCCESS in 5m 50s\n- gate-tempest-dsvm-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-full/96e55a1/ : SUCCESS in 56m 55s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-postgres-full/26df696/ : FAILURE in 53m 48s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-neutron-full/22dc4dd/ : SUCCESS in 1h 11m 49s\n- gate-grenade-dsvm http://logs.openstack.org/78/215378/1/check/gate-grenade-dsvm/e51498e/ : SUCCESS in 46m 18s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-large-ops/dad478f/ : SUCCESS in 36m 53s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-neutron-large-ops/15da3e5/ : SUCCESS in 36m 03s\n- gate-rally-dsvm-keystone http://logs.openstack.org/78/215378/1/check/gate-rally-dsvm-keystone/e5add4e/ : SUCCESS in 35m 57s (non-voting)\n- gate-keystone-tox-bandit http://logs.openstack.org/78/215378/1/check/gate-keystone-tox-bandit/55dd2c3/ : SUCCESS in 2m 04s","accounts_in_message":[],"_revision_number":1},{"id":"25c7b3dd7091e0738efd644aa7b5450acccf3e87","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-08-21 05:18:27.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"2f5b5671829878ea50802ad1089df9d42346c822","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-08-21 05:46:37.000000000","message":"Patch Set 1: Code-Review-1\n\nnot bad, but i think we need a few more test cases:\n\n  1) where region ID is user defined\n  2) where region and interface are both specified\n\nalso, whats the expected behaviour when you filter by a parent region? do you get the endpoints associated with parent and children regions?","accounts_in_message":[],"_revision_number":1},{"id":"3d9addeaa91bd93c4c83d73f25ac92e9594322c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-21 06:36:08.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-keystone-pep8 http://logs.openstack.org/78/215378/1/check/gate-keystone-pep8/3aa13ba/ : SUCCESS in 3m 47s\n- gate-keystone-docs http://docs-draft.openstack.org/78/215378/1/check/gate-keystone-docs/81649b6//doc/build/html/ : SUCCESS in 6m 47s\n- gate-keystone-python27 http://logs.openstack.org/78/215378/1/check/gate-keystone-python27/0c99657/ : SUCCESS in 9m 19s\n- gate-keystone-python34 http://logs.openstack.org/78/215378/1/check/gate-keystone-python34/b5802a7/ : SUCCESS in 8m 01s\n- gate-tempest-dsvm-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-full/70bdd7f/ : SUCCESS in 56m 27s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-postgres-full/ef09bbb/ : SUCCESS in 49m 53s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-neutron-full/da352ed/ : SUCCESS in 1h 10m 07s\n- gate-grenade-dsvm http://logs.openstack.org/78/215378/1/check/gate-grenade-dsvm/91b81bf/ : FAILURE in 34m 25s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-large-ops/86d05af/ : SUCCESS in 33m 30s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/78/215378/1/check/gate-tempest-dsvm-neutron-large-ops/9fc9183/ : SUCCESS in 30m 29s\n- gate-rally-dsvm-keystone http://logs.openstack.org/78/215378/1/check/gate-rally-dsvm-keystone/ba680be/ : SUCCESS in 34m 03s (non-voting)\n- gate-keystone-tox-bandit http://logs.openstack.org/78/215378/1/check/gate-keystone-tox-bandit/0301b63/ : SUCCESS in 2m 39s","accounts_in_message":[],"_revision_number":1},{"id":"53fc1d552a2df47234de129a84862824deb7ac4b","author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"date":"2015-08-21 09:55:08.000000000","message":"Patch Set 1: Code-Review-1\n\nI agree that there should be some negative testcase where `service_id`, `region_id`, `interface` not existing will return nothing.\n\nAnd seems like these testcase should be in \"keystone/tests/unit/test_v3_filters.py\" rather than here?","accounts_in_message":[],"_revision_number":1},{"id":"f237a558e6d93e614ff7b3a3342df42fa8ada494","author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"date":"2015-08-21 14:19:00.000000000","message":"Patch Set 1:\n\n@Lin, sorry, check it again, I saw some testcases are written in test_v3_filters.py (identity) while others are different (role assignment, catalog etc.), maybe both of them are okay.","accounts_in_message":[],"_revision_number":1},{"id":"eb61dd12a0c3c1c8492f62854966db55083467e6","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-08-21 17:03:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6c776f311bee125f35a2d46389df7a91ca4e05ab","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-08-21 17:06:18.000000000","message":"Patch Set 2:\n\nThanks for the reviews :)\n\nSteve: for the endpoint generated, it always creates a new region, would that cover the case too when the user defines it?\n\nAdded test for: combination of multiple filter, filtering by parent_region_id, and random filter values.","accounts_in_message":[],"_revision_number":2},{"id":"1bc7fe24c20a3f180bd3e65c2b17553b25730aea","author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"date":"2015-08-21 17:12:19.000000000","message":"Patch Set 2: Code-Review+1\n\nlgtm, but... shouldn\u0027t the tests from other queries like interface and service_id be added in a different patch? this one seems to only add the support to filter via region_id","accounts_in_message":[],"_revision_number":2},{"id":"799a0fb1d9f32e681e7097eeb721172b74445371","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-08-21 17:30:14.000000000","message":"Patch Set 2:\n\nRodrigo, right.. I can also do that..  for my 12 character change, I had to write 127 lines of tests. :P\n\nI am fine splitting it up too.","accounts_in_message":[],"_revision_number":2},{"id":"455cff08a19381e84c53db3e9eb0ec954d5dc148","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-08-21 17:37:43.000000000","message":"Patch Set 2: Code-Review+2\n\na 1:127 line of code ratio between function and tests should be the new minimum :)","accounts_in_message":[],"_revision_number":2},{"id":"56f40ba7229bf6b4e0ba5cd67b488bd750c94f59","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2015-08-21 18:27:44.000000000","message":"Patch Set 2: Code-Review+2\n\nSteve did raised an excellent question about returning all endpoints for an hierarchical region. We may need a separate param for like, just like hierarchical projects. But this patch looks good as is. Will A+ after Jenkins agrees.","accounts_in_message":[],"_revision_number":2},{"id":"45e85577d2a2ce37d1c399b8514c4f96166cc17c","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2015-08-21 18:48:51.000000000","message":"Patch Set 2: Code-Review+1\n\nThe code looks good!","accounts_in_message":[],"_revision_number":2},{"id":"8eb1fb44f1b72d015cfdb19ca07afdfdd8794f13","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-21 18:50:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-keystone-pep8 http://logs.openstack.org/78/215378/2/check/gate-keystone-pep8/9cc38f3/ : SUCCESS in 3m 52s\n- gate-keystone-docs http://docs-draft.openstack.org/78/215378/2/check/gate-keystone-docs/e5a10be//doc/build/html/ : SUCCESS in 6m 36s\n- gate-keystone-python27 http://logs.openstack.org/78/215378/2/check/gate-keystone-python27/a958b23/ : SUCCESS in 9m 29s\n- gate-keystone-python34 http://logs.openstack.org/78/215378/2/check/gate-keystone-python34/1157961/ : SUCCESS in 5m 37s\n- gate-tempest-dsvm-full http://logs.openstack.org/78/215378/2/check/gate-tempest-dsvm-full/5f55c00/ : SUCCESS in 52m 27s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/78/215378/2/check/gate-tempest-dsvm-postgres-full/bff19b4/ : SUCCESS in 49m 09s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/78/215378/2/check/gate-tempest-dsvm-neutron-full/fa6de71/ : SUCCESS in 55m 15s\n- gate-grenade-dsvm http://logs.openstack.org/78/215378/2/check/gate-grenade-dsvm/10e1b14/ : SUCCESS in 39m 41s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/78/215378/2/check/gate-tempest-dsvm-large-ops/cd5a364/ : SUCCESS in 37m 39s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/78/215378/2/check/gate-tempest-dsvm-neutron-large-ops/4b0ee7b/ : SUCCESS in 33m 03s\n- gate-rally-dsvm-keystone http://logs.openstack.org/78/215378/2/check/gate-rally-dsvm-keystone/495427e/ : SUCCESS in 36m 16s (non-voting)\n- gate-keystone-tox-bandit http://logs.openstack.org/78/215378/2/check/gate-keystone-tox-bandit/26bd480/ : SUCCESS in 2m 56s","accounts_in_message":[],"_revision_number":2},{"id":"071ee237007fded6d1c0496f7f18b4386a02e31f","author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"date":"2015-08-21 23:20:02.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e5a33221f970be60959b7f41d399ae17f8ccef14","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2015-08-21 23:31:34.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"ece77e6b56f502de094aa590acf680ef53502334","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-21 23:31:39.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a8574851ac745fd2028db7a9fb8b468d26a44722","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-08-22 10:26:04.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"2a5127daaca33d5d20f75f1df8ae3747af80a3e0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-22 11:20:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-keystone-pep8 http://logs.openstack.org/78/215378/2/check/gate-keystone-pep8/f6c12fc/ : SUCCESS in 3m 33s\n- gate-keystone-docs http://docs-draft.openstack.org/78/215378/2/check/gate-keystone-docs/df65025//doc/build/html/ : SUCCESS in 4m 30s\n- gate-keystone-python27 http://logs.openstack.org/78/215378/2/check/gate-keystone-python27/1c5d732/ : SUCCESS in 6m 33s\n- gate-keystone-python34 http://logs.openstack.org/78/215378/2/check/gate-keystone-python34/4e8e58a/ : SUCCESS in 4m 02s\n- gate-tempest-dsvm-full http://logs.openstack.org/78/215378/2/check/gate-tempest-dsvm-full/2ae3c44/ : SUCCESS in 50m 12s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/78/215378/2/check/gate-tempest-dsvm-postgres-full/49b9cbf/ : SUCCESS in 46m 34s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/78/215378/2/check/gate-tempest-dsvm-neutron-full/4207389/ : SUCCESS in 52m 53s\n- gate-grenade-dsvm http://logs.openstack.org/78/215378/2/check/gate-grenade-dsvm/9cc323d/ : SUCCESS in 40m 49s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/78/215378/2/check/gate-tempest-dsvm-large-ops/8cac571/ : SUCCESS in 29m 42s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/78/215378/2/check/gate-tempest-dsvm-neutron-large-ops/0f04e34/ : SUCCESS in 30m 44s\n- gate-rally-dsvm-keystone http://logs.openstack.org/78/215378/2/check/gate-rally-dsvm-keystone/fab30c6/ : SUCCESS in 26m 27s (non-voting)\n- gate-keystone-tox-bandit http://logs.openstack.org/78/215378/2/check/gate-keystone-tox-bandit/3a2caf5/ : SUCCESS in 1m 51s","accounts_in_message":[],"_revision_number":2},{"id":"6c9db2c5d4bc05ea5aacf754911730229fcda1ac","author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"date":"2015-08-22 12:36:19.000000000","message":"Patch Set 2: Code-Review+1\n\nA little bit late, but I still want to say these testcases are cool! :)","accounts_in_message":[],"_revision_number":2},{"id":"765a7a44be72fe30da8e843d137110b33d90591f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-22 17:34:58.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-keystone-docs http://docs-draft.openstack.org/78/215378/2/gate/gate-keystone-docs/94e61d2//doc/build/html/ : SUCCESS in 7m 00s\n- gate-keystone-pep8 http://logs.openstack.org/78/215378/2/gate/gate-keystone-pep8/ab5e1a7/ : SUCCESS in 2m 59s\n- gate-keystone-python27 http://logs.openstack.org/78/215378/2/gate/gate-keystone-python27/68fb4a2/ : SUCCESS in 8m 54s\n- gate-keystone-python34 http://logs.openstack.org/78/215378/2/gate/gate-keystone-python34/22df4a5/ : SUCCESS in 4m 25s\n- gate-tempest-dsvm-full http://logs.openstack.org/78/215378/2/gate/gate-tempest-dsvm-full/fdbc671/ : SUCCESS in 56m 23s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/78/215378/2/gate/gate-tempest-dsvm-postgres-full/6eec8d0/ : SUCCESS in 51m 05s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/78/215378/2/gate/gate-tempest-dsvm-neutron-full/e3744cf/ : SUCCESS in 1h 11m 47s\n- gate-grenade-dsvm http://logs.openstack.org/78/215378/2/gate/gate-grenade-dsvm/ed66b7e/ : SUCCESS in 1h 04m 55s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/78/215378/2/gate/gate-tempest-dsvm-large-ops/7e438b1/ : SUCCESS in 32m 39s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/78/215378/2/gate/gate-tempest-dsvm-neutron-large-ops/6125b53/ : SUCCESS in 34m 22s\n- gate-keystone-tox-bandit http://logs.openstack.org/78/215378/2/gate/gate-keystone-tox-bandit/473e068/ : SUCCESS in 2m 12s","accounts_in_message":[],"_revision_number":2},{"id":"c840621151f2ecec8016784dcc29733e117a99d5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-22 17:35:00.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"076af38dcfc2c135b20470e3a18a7ebbd77d7103","revisions":{"4a0ca5050383f05f8dc9686ca6879e64887303f7":{"kind":"REWORK","_number":1,"created":"2015-08-20 23:43:41.000000000","uploader":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"ref":"refs/changes/78/215378/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/78/215378/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/78/215378/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/78/215378/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/78/215378/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/78/215378/1"}}},"commit":{"parents":[{"commit":"909ed85053236b9109d948445a7dff325ee20d3e","subject":"Merge \"Extras for bandit\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/909ed85053236b9109d948445a7dff325ee20d3e"}]}],"author":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-08-20 23:43:25.000000000","tz":-420},"committer":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-08-20 23:43:25.000000000","tz":-420},"subject":"Add region_id filter for List Endpoints API","message":"Add region_id filter for List Endpoints API\n\nChange-Id: Ic4d60a046df1f231d02a45998c8a0ef7c5b7b107\nCloses-bug: #1482772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/4a0ca5050383f05f8dc9686ca6879e64887303f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/4a0ca5050383f05f8dc9686ca6879e64887303f7"}]},"branch":"refs/heads/master"},"076af38dcfc2c135b20470e3a18a7ebbd77d7103":{"kind":"REWORK","_number":2,"created":"2015-08-21 17:03:38.000000000","uploader":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"ref":"refs/changes/78/215378/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/78/215378/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/78/215378/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/78/215378/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/78/215378/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/78/215378/2"}}},"commit":{"parents":[{"commit":"909ed85053236b9109d948445a7dff325ee20d3e","subject":"Merge \"Extras for bandit\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/909ed85053236b9109d948445a7dff325ee20d3e"}]}],"author":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-08-20 23:43:25.000000000","tz":-420},"committer":{"name":"lin-hua-cheng","email":"os.lcheng@gmail.com","date":"2015-08-21 17:03:07.000000000","tz":-420},"subject":"Add region_id filter for List Endpoints API","message":"Add region_id filter for List Endpoints API\n\nChange-Id: Ic4d60a046df1f231d02a45998c8a0ef7c5b7b107\nCloses-bug: #1482772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/076af38dcfc2c135b20470e3a18a7ebbd77d7103"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/076af38dcfc2c135b20470e3a18a7ebbd77d7103"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}