)]}'
{"keystone/contrib/federation/utils.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"536a2c5c04d6ee96be495ccc52f9d2095f019a2f","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                                                        assertion)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"            # If the compare comes back as None, then the rule did not apply"},{"line_number":460,"context_line":"            # to the assertion data, go on to the next rule"},{"line_number":461,"context_line":"            if direct_maps is None:"},{"line_number":462,"context_line":"                continue"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b65b3854","line":460,"updated":"2015-08-27 00:21:56.000000000","message":"this is where the rules loop is and the continue if None.","commit_id":"5efe64e0d809968a1489ac2401503032ae2a3ee1"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"9fd28f0a6e326a460fdc05d05adc037ec2fe81b8","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            regex \u003d requirement.get(\u0027regex\u0027, False)"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"            if not direct_map_values:"},{"line_number":681,"context_line":"                return None"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"            any_one_values \u003d requirement.get(self._EvalType.ANY_ONE_OF)"},{"line_number":684,"context_line":"            if any_one_values is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_14611739","line":681,"updated":"2015-08-26 13:44:39.000000000","message":"perhaps out of scope for this change, but shouldn\u0027t we log something here about the bad config?\n\nand seemingly in scope for this change, shouldn\u0027t this be a continue (to the next requirement), not an outright abort? (if it should truly abort, then it should raise an exception, not exit cleanly)","commit_id":"5efe64e0d809968a1489ac2401503032ae2a3ee1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"536a2c5c04d6ee96be495ccc52f9d2095f019a2f","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            regex \u003d requirement.get(\u0027regex\u0027, False)"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"            if not direct_map_values:"},{"line_number":681,"context_line":"                return None"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"            any_one_values \u003d requirement.get(self._EvalType.ANY_ONE_OF)"},{"line_number":684,"context_line":"            if any_one_values is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b62258b8","line":681,"in_reply_to":"fa1b9901_14611739","updated":"2015-08-27 00:21:56.000000000","message":"It may or may not be bad config. In my case it\u0027s not it\u0027s just a mapping handling multiple scenarios.\n\nThe loop here is around the multiple \"remote\" requirements, not each rule. If any one of the remote requirements fails to apply then the corresponding local should not be applied.\n\nReturn None is used here in the same way that if the any_one_of or not_any_of values would return false from _evaluate_requirements and then none below to indicate that these requirements don\u0027t match the incoming assertion.","commit_id":"5efe64e0d809968a1489ac2401503032ae2a3ee1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"73d8de76f1ffcc308d0d6b09dfc5145c7e5120d6","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        :param regex: perform evaluation with regex"},{"line_number":745,"context_line":"        :type regex: boolean"},{"line_number":746,"context_line":"        :param assertion: dict of attributes from the IdP"},{"line_number":747,"context_line":"        :type assertion: dict"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        :returns: boolean, whether requirement is valid or not."},{"line_number":750,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_17dbf27d","line":747,"updated":"2015-09-14 13:28:06.000000000","message":"I don\u0027t think this parameter exists anymore, we should remove the docstring for it, too.","commit_id":"e44c48e3d5a319a683867d7330cb97a23ad9fb6e"}],"keystone/tests/unit/test_v3_federation.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"84b02cddcf0358370d92ad3c82f49ca1ee134a45","unresolved":false,"context_lines":[{"line_number":2004,"context_line":""},{"line_number":2005,"context_line":"        self.assertNotIn(\u0027id\u0027, mapped_properties[\u0027user\u0027])"},{"line_number":2006,"context_line":"        self.assertNotIn(\u0027name\u0027, mapped_properties[\u0027user\u0027])"},{"line_number":2007,"context_line":""},{"line_number":2008,"context_line":""},{"line_number":2009,"context_line":"class FederatedTokenTests(FederationTests, FederatedSetupMixin):"},{"line_number":2010,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_602334a8","line":2007,"updated":"2015-08-25 09:55:16.000000000","message":"I ran the test against master branch and it passed to.","commit_id":"601cfa1397bc7ca0db0094e839e4964544cba7b3"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"25f4c907c485a4b7920eb8d7de564d333f9a6e49","unresolved":false,"context_lines":[{"line_number":2004,"context_line":""},{"line_number":2005,"context_line":"        self.assertNotIn(\u0027id\u0027, mapped_properties[\u0027user\u0027])"},{"line_number":2006,"context_line":"        self.assertNotIn(\u0027name\u0027, mapped_properties[\u0027user\u0027])"},{"line_number":2007,"context_line":""},{"line_number":2008,"context_line":""},{"line_number":2009,"context_line":"class FederatedTokenTests(FederationTests, FederatedSetupMixin):"},{"line_number":2010,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_400cf093","line":2007,"in_reply_to":"fa1b9901_602334a8","updated":"2015-08-25 09:55:36.000000000","message":"too*","commit_id":"601cfa1397bc7ca0db0094e839e4964544cba7b3"}]}