)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"26c6eb5e8536556ba3ef0288ab8a3b8ee0d6493f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nina Goradia \u003cninag@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-26 16:09:38 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct docstrings in resources/core.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Docstrings were not getting rendered properly for exceptions since"},{"line_number":10,"context_line":"the format was not correct."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_f4799530","line":7,"updated":"2015-08-27 09:44:31.000000000","message":"Please correct file name.\n\ns/resources/resource","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"},{"author":{"_account_id":17254,"name":"Nina Goradia","email":"ninag@us.ibm.com","username":"ninag"},"change_message_id":"edf0e2cd5b2f69917e694121bcceee997e9ee0d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nina Goradia \u003cninag@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-26 16:09:38 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct docstrings in resources/core.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Docstrings were not getting rendered properly for exceptions since"},{"line_number":10,"context_line":"the format was not correct."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_807321b1","line":7,"in_reply_to":"da20952f_f4799530","updated":"2015-08-27 14:45:05.000000000","message":"Done","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"}],"keystone/resource/core.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b40f98d9d0fdaeb42ff758ed480f21f781761bd8","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def assert_domain_enabled(self, domain_id, domain\u003dNone):"},{"line_number":120,"context_line":"        \"\"\"Assert the Domain is enabled."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        :raise AssertionError: if domain is disabled."},{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        if domain is None:"},{"line_number":125,"context_line":"            domain \u003d self.get_domain(domain_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_a7d1c8fd","line":122,"updated":"2015-08-26 21:34:31.000000000","message":"should this be \"raise\" or \"raises\" ?","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"},{"author":{"_account_id":17254,"name":"Nina Goradia","email":"ninag@us.ibm.com","username":"ninag"},"change_message_id":"a93248f365c2594936fb06d7f852cfb954567fab","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def assert_domain_enabled(self, domain_id, domain\u003dNone):"},{"line_number":120,"context_line":"        \"\"\"Assert the Domain is enabled."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        :raise AssertionError: if domain is disabled."},{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        if domain is None:"},{"line_number":125,"context_line":"            domain \u003d self.get_domain(domain_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_ca65e1e1","line":122,"in_reply_to":"da20952f_a7d1c8fd","updated":"2015-08-26 21:47:55.000000000","message":"According to [1] either one is valid\n\n[1] http://sphinx-doc.org/domains.html#info-field-lists","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"e784173dd28f9e699dde33d1dff7a5c92469487a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def assert_domain_enabled(self, domain_id, domain\u003dNone):"},{"line_number":120,"context_line":"        \"\"\"Assert the Domain is enabled."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        :raise AssertionError: if domain is disabled."},{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        if domain is None:"},{"line_number":125,"context_line":"            domain \u003d self.get_domain(domain_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_fec41993","line":122,"in_reply_to":"da20952f_ca65e1e1","updated":"2015-08-27 07:08:52.000000000","message":"Looks like you are correct, I guess I have a personal preference for \u0027raises\u0027 (or at least to be consistent in a file), but, yep, either seem OK.","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d880406d489165a8906006079a08e43eb8ec4d74","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    def create_domain(self, domain_id, domain):"},{"line_number":566,"context_line":"        \"\"\"Creates a new domain."},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"        :raises keystone.exception.Conflict: if the domain already exists"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"        \"\"\""},{"line_number":571,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_e093fdf8","line":568,"updated":"2015-08-27 15:29:31.000000000","message":"should this be domain_id?","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"},{"author":{"_account_id":17254,"name":"Nina Goradia","email":"ninag@us.ibm.com","username":"ninag"},"change_message_id":"e6e2ec2f38a02d8e0225bca14467fc2e65116fd8","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    def create_domain(self, domain_id, domain):"},{"line_number":566,"context_line":"        \"\"\"Creates a new domain."},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"        :raises keystone.exception.Conflict: if the domain already exists"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"        \"\"\""},{"line_number":571,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_15d73e24","line":568,"in_reply_to":"da20952f_e093fdf8","updated":"2015-08-27 22:19:43.000000000","message":"Could be domain_id or the domain name. Made the corresponding updates.","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d880406d489165a8906006079a08e43eb8ec4d74","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        \"\"\"Get a domain by ID."},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        :returns: domain_ref"},{"line_number":604,"context_line":"        :raises keystone.exception.DomainNotFound: if domain does not exist"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        \"\"\""},{"line_number":607,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_c0c119e6","line":604,"updated":"2015-08-27 15:29:31.000000000","message":"same comment here","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"},{"author":{"_account_id":17254,"name":"Nina Goradia","email":"ninag@us.ibm.com","username":"ninag"},"change_message_id":"e6e2ec2f38a02d8e0225bca14467fc2e65116fd8","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        \"\"\"Get a domain by ID."},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        :returns: domain_ref"},{"line_number":604,"context_line":"        :raises keystone.exception.DomainNotFound: if domain does not exist"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        \"\"\""},{"line_number":607,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_f5bacae0","line":604,"in_reply_to":"da20952f_c0c119e6","updated":"2015-08-27 22:19:43.000000000","message":"Added the variables which caused the exceptions","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d880406d489165a8906006079a08e43eb8ec4d74","unresolved":false,"context_lines":[{"line_number":611,"context_line":"        \"\"\"Get a domain by name."},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        :returns: domain_ref"},{"line_number":614,"context_line":"        :raises keystone.exception.DomainNotFound: if domain does not exist"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        \"\"\""},{"line_number":617,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_00a8711e","line":614,"updated":"2015-08-27 15:29:31.000000000","message":"domain_name*\n\nsame comment applies throughout the file.","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"},{"author":{"_account_id":17254,"name":"Nina Goradia","email":"ninag@us.ibm.com","username":"ninag"},"change_message_id":"e6e2ec2f38a02d8e0225bca14467fc2e65116fd8","unresolved":false,"context_lines":[{"line_number":611,"context_line":"        \"\"\"Get a domain by name."},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        :returns: domain_ref"},{"line_number":614,"context_line":"        :raises keystone.exception.DomainNotFound: if domain does not exist"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        \"\"\""},{"line_number":617,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_757d5a1b","line":614,"in_reply_to":"da20952f_00a8711e","updated":"2015-08-27 22:19:43.000000000","message":"Added the variables which caused the exceptions","commit_id":"3f96d47aa120a44f0c702f068fed87c076a53eb6"}]}
