)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"2888d8a08ea81282fb7aa8396aea6eb43acbbd08","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set max on max_password_length to passlib max"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With this patch if someone overrides the PASSLIB_MAX_PASSWORD_SIZE"},{"line_number":10,"context_line":"environment variable, keystone will fail to start with a config"},{"line_number":11,"context_line":"error instead of a passlib.exc.PasswordSizeError when creating"},{"line_number":12,"context_line":"a user."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_0f03d543","line":10,"updated":"2015-08-27 08:32:09.000000000","message":"The error will be found as long as someone override PASSLIB_MAX_PASSWORD_SIZE or hit the error just in case exceed this max value defined in the CONF?","commit_id":"a7235fc0511c643a8441efd3d21fc334535066e2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"565f92bf54e589846ed96b865571e08be9e81a74","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set max on max_password_length to passlib max"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With this patch if someone overrides the PASSLIB_MAX_PASSWORD_SIZE"},{"line_number":10,"context_line":"environment variable, keystone will fail to start with a config"},{"line_number":11,"context_line":"error instead of a passlib.exc.PasswordSizeError when creating"},{"line_number":12,"context_line":"a user."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_1002fa6f","line":10,"in_reply_to":"da20952f_0f03d543","updated":"2015-08-27 17:31:38.000000000","message":"Yes if someone overrides PASSLIB_MAX_PASSWORD_SIZE to be lower than the default (4096) or lower than what is set, then you\u0027ll get a config error.\n\nAnd even if PASSLIB_MAX_PASSWORD_SIZE is still at the default of 4096, if someone tries to use a value higher, it will result in a config error.","commit_id":"a7235fc0511c643a8441efd3d21fc334535066e2"}],"keystone/common/config.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"f9cbbf0f29c0b66a61fa4d477e971d91b3cc9614","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":"import oslo_messaging"},{"line_number":17,"context_line":"import passlib.utils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_DEFAULT_AUTH_METHODS \u003d [\u0027external\u0027, \u0027password\u0027, \u0027token\u0027, \u0027oauth1\u0027]"},{"line_number":20,"context_line":"_CERTFILE \u003d \u0027/etc/keystone/ssl/certs/signing_cert.pem\u0027"},{"line_number":21,"context_line":"_KEYFILE \u003d \u0027/etc/keystone/ssl/private/signing_key.pem\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_690a9ad4","line":18,"updated":"2015-08-27 02:41:06.000000000","message":"Needs a newline here","commit_id":"1bebbe2f170ae243bd36d2876fe69e153b7ca339"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"e1ff563ace252439285e947974aed0286185bf14","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":"import oslo_messaging"},{"line_number":17,"context_line":"import passlib.utils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_DEFAULT_AUTH_METHODS \u003d [\u0027external\u0027, \u0027password\u0027, \u0027token\u0027, \u0027oauth1\u0027]"},{"line_number":20,"context_line":"_CERTFILE \u003d \u0027/etc/keystone/ssl/certs/signing_cert.pem\u0027"},{"line_number":21,"context_line":"_KEYFILE \u003d \u0027/etc/keystone/ssl/private/signing_key.pem\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_5a63d6b1","line":18,"in_reply_to":"da20952f_690a9ad4","updated":"2015-08-27 04:30:14.000000000","message":"Crap, thanks for catching this!","commit_id":"1bebbe2f170ae243bd36d2876fe69e153b7ca339"}]}