)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"change_message_id":"4cff38903b7127c8c6ae7364c0eff38ee5532422","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-08-27 06:46:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return the tenant_id as early as possible"},{"line_number":8,"context_line":"Fixes Bug1488715"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I010535803f7d5c755b24418e1bee9d75892e3ce9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_3b99436f","line":8,"updated":"2015-08-27 06:53:45.000000000","message":"Closes-Bug: #1488715\n\ngood examples here https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"d755616cac3a5f2b337eedad9abe96edcec26af5"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"308f5668c36c2a06d347d987b8f277454433b0bf","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-08-27 06:46:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return the tenant_id as early as possible"},{"line_number":8,"context_line":"Fixes Bug1488715"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I010535803f7d5c755b24418e1bee9d75892e3ce9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_308b6720","line":8,"in_reply_to":"da20952f_3b99436f","updated":"2015-10-04 04:07:05.000000000","message":"++","commit_id":"d755616cac3a5f2b337eedad9abe96edcec26af5"}],"keystone/token/controllers.py":[{"author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"change_message_id":"4cff38903b7127c8c6ae7364c0eff38ee5532422","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            if len(tenant_id) \u003e CONF.max_param_size: "},{"line_number":364,"context_line":"                raise exception.ValidationSizeError(attribute\u003d\u0027tenantId\u0027,"},{"line_number":365,"context_line":"                                                size\u003dCONF.max_param_size)"},{"line_number":366,"context_line":"            return tenant_id"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        tenant_name \u003d auth.get(\u0027tenantName\u0027)"},{"line_number":369,"context_line":"        if tenant_name and len(tenant_name) \u003e CONF.max_param_size:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_db4607bf","line":366,"updated":"2015-08-27 06:53:45.000000000","message":"why return ?","commit_id":"d755616cac3a5f2b337eedad9abe96edcec26af5"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"308f5668c36c2a06d347d987b8f277454433b0bf","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            if len(tenant_id) \u003e CONF.max_param_size: "},{"line_number":364,"context_line":"                raise exception.ValidationSizeError(attribute\u003d\u0027tenantId\u0027,"},{"line_number":365,"context_line":"                                                size\u003dCONF.max_param_size)"},{"line_number":366,"context_line":"            return tenant_id"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        tenant_name \u003d auth.get(\u0027tenantName\u0027)"},{"line_number":369,"context_line":"        if tenant_name and len(tenant_name) \u003e CONF.max_param_size:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_50761b3f","line":366,"in_reply_to":"da20952f_1d4c61c6","updated":"2015-10-04 04:07:05.000000000","message":"It isn\u0027t just about extracting and returning the tenant_id form the auth info. It also does some validation on the tenant name. Although I agree it isn\u0027t documented in the method\u0027s doc.","commit_id":"d755616cac3a5f2b337eedad9abe96edcec26af5"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"2426b54a7e2693b6f1c7425536465db9dee55c6e","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            if len(tenant_id) \u003e CONF.max_param_size: "},{"line_number":364,"context_line":"                raise exception.ValidationSizeError(attribute\u003d\u0027tenantId\u0027,"},{"line_number":365,"context_line":"                                                size\u003dCONF.max_param_size)"},{"line_number":366,"context_line":"            return tenant_id"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        tenant_name \u003d auth.get(\u0027tenantName\u0027)"},{"line_number":369,"context_line":"        if tenant_name and len(tenant_name) \u003e CONF.max_param_size:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_1d4c61c6","line":366,"in_reply_to":"da20952f_db4607bf","updated":"2015-08-27 13:20:58.000000000","message":"This method will return the tenant_id, so if \u0027tenant_id\u0027 is already present in the auth object, we don\u0027t need get the tenant_id by name.","commit_id":"d755616cac3a5f2b337eedad9abe96edcec26af5"}]}
