)]}'
{"id":"openstack%2Fkeystone~217543","triplet_id":"openstack%2Fkeystone~master~I010535803f7d5c755b24418e1bee9d75892e3ce9","project":"openstack/keystone","branch":"master","topic":"bug/1488715","hashtags":[],"change_id":"I010535803f7d5c755b24418e1bee9d75892e3ce9","subject":"Return the tenant_id as early as possible Fixes Bug1488715","status":"ABANDONED","created":"2015-08-27 06:37:41.000000000","updated":"2016-03-02 01:41:00.000000000","total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4970dfd4d79a1c602162baca0dcbe111c1b9161f","_number":217543,"virtual_id_number":217543,"owner":{"_account_id":17772,"name":"majianjun","email":"mjjun@cn.fujitsu.com","username":"majianjun"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},{"value":-1,"date":"2015-08-27 07:41:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},{"date":"2015-08-27 07:11:19.000000000","_account_id":17772,"name":"majianjun","email":"mjjun@cn.fujitsu.com","username":"majianjun"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"all":[{"value":-1,"date":"2015-08-27 13:20:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-10-04 04:07:05.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"value":-1,"date":"2015-10-13 11:02:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":-1,"date":"2015-08-27 07:03:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":-1,"date":"2015-08-27 06:53:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17772,"name":"majianjun","email":"mjjun@cn.fujitsu.com","username":"majianjun"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},{"date":"2015-10-13 11:02:16.000000000","_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":17772,"name":"majianjun","email":"mjjun@cn.fujitsu.com","username":"majianjun"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":17772,"name":"majianjun","email":"mjjun@cn.fujitsu.com","username":"majianjun"},{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-27 06:53:45.000000000","updated_by":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"reviewer":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"state":"REVIEWER"},{"updated":"2015-08-27 07:03:07.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2015-08-27 07:41:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-08-27 13:20:58.000000000","updated_by":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"reviewer":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"state":"REVIEWER"},{"updated":"2015-10-04 04:07:05.000000000","updated_by":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"reviewer":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"state":"REVIEWER"},{"updated":"2015-10-13 11:02:16.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"}],"messages":[{"id":"2ac6cd6bb560c1475ed265ec1a71a799a0b5bc69","author":{"_account_id":17772,"name":"majianjun","email":"mjjun@cn.fujitsu.com","username":"majianjun"},"date":"2015-08-27 06:37:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4cff38903b7127c8c6ae7364c0eff38ee5532422","author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"date":"2015-08-27 06:53:45.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"dbff2f9930adffe0c86d48aca956cb74e25206a6","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2015-08-27 07:03:07.000000000","message":"Patch Set 1: Code-Review-1\n\nSo I need a bit more explanation of this change...in fact it is doing more than just returning tenant_id early...it also changes the functionality in that in the old code any definition of tenant_name would override any explicit tenant_id. Is that the intention?","accounts_in_message":[],"_revision_number":1},{"id":"57696ee9c27dcedce7720927d3de640c3f6a17e7","author":{"_account_id":17772,"name":"majianjun","email":"mjjun@cn.fujitsu.com","username":"majianjun"},"date":"2015-08-27 07:11:19.000000000","message":"Patch Set 1:\n\nFirstly,the original code has problem.\nBecause,the final tenant_id is got by the self.resource_api.get_project_by_name,\nso if the tenant_id that got from auth is invalid ,however if the tenant_id can be got by the resource_api.get_project_by_name,then I think that the condition judgement about the tenant_id has negative impact.\n\nIn other words, if the tenant_id got from auth is valid,we can return it directly.","accounts_in_message":[],"_revision_number":1},{"id":"4ac168500f5881bb6c2cdd6c47547cafac0552b8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-27 07:41:29.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-keystone-pep8 http://logs.openstack.org/43/217543/1/check/gate-keystone-pep8/2ca7b90/ : FAILURE in 3m 07s\n- gate-keystone-docs http://docs-draft.openstack.org/43/217543/1/check/gate-keystone-docs/8bdcc84//doc/build/html/ : SUCCESS in 4m 44s\n- gate-keystone-python27 http://logs.openstack.org/43/217543/1/check/gate-keystone-python27/c5e787d/ : SUCCESS in 14m 26s\n- gate-keystone-python34 http://logs.openstack.org/43/217543/1/check/gate-keystone-python34/3eafc4c/ : SUCCESS in 4m 24s\n- gate-tempest-dsvm-full http://logs.openstack.org/43/217543/1/check/gate-tempest-dsvm-full/5077132/ : SUCCESS in 41m 56s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/43/217543/1/check/gate-tempest-dsvm-postgres-full/29b369c/ : SUCCESS in 50m 13s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/43/217543/1/check/gate-tempest-dsvm-neutron-full/5ef6eae/ : SUCCESS in 56m 07s\n- gate-grenade-dsvm http://logs.openstack.org/43/217543/1/check/gate-grenade-dsvm/1e49e99/ : SUCCESS in 42m 59s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/43/217543/1/check/gate-tempest-dsvm-large-ops/9ad7949/ : SUCCESS in 33m 01s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/43/217543/1/check/gate-tempest-dsvm-neutron-large-ops/fb3aaa2/ : SUCCESS in 31m 17s\n- gate-rally-dsvm-keystone http://logs.openstack.org/43/217543/1/check/gate-rally-dsvm-keystone/7a2f4de/ : SUCCESS in 29m 14s (non-voting)\n- gate-keystone-tox-bandit http://logs.openstack.org/43/217543/1/check/gate-keystone-tox-bandit/c837868/ : SUCCESS in 1m 56s","accounts_in_message":[],"_revision_number":1},{"id":"2426b54a7e2693b6f1c7425536465db9dee55c6e","author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"date":"2015-08-27 13:20:58.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nJust fix the commit message and maybe add some explanation about it and I\u0027ll go with this change. :)","accounts_in_message":[],"_revision_number":1},{"id":"308f5668c36c2a06d347d987b8f277454433b0bf","author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"date":"2015-10-04 04:07:05.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"7870fffa8f6c5cbadf48eddbf834cd14c24ecb56","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2015-10-13 11:02:40.000000000","message":"Patch Set 1: Code-Review-1\n\nThere need further work to do.","accounts_in_message":[],"_revision_number":1},{"id":"fef98ebb36bda503a09b592db2efed89fc674cd7","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-03-02 01:41:00.000000000","message":"Abandoned\n\nMarking this patch as abandoned as part of a patch clean up. Lots of negative comments, no new revision in many months, and the bug is marked as invalid. Abandoning.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d755616cac3a5f2b337eedad9abe96edcec26af5","revisions":{"d755616cac3a5f2b337eedad9abe96edcec26af5":{"kind":"REWORK","_number":1,"created":"2015-08-27 06:37:41.000000000","uploader":{"_account_id":17772,"name":"majianjun","email":"mjjun@cn.fujitsu.com","username":"majianjun"},"ref":"refs/changes/43/217543/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/43/217543/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/43/217543/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/43/217543/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/43/217543/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/43/217543/1"}}},"commit":{"parents":[{"commit":"94b9a66b51d6f9794f961a32d380c2d8392aa446","subject":"Merge \"Prevent exception for invalidly encoded parameters\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/94b9a66b51d6f9794f961a32d380c2d8392aa446"}]}],"author":{"name":"majianjun","email":"mjjun@cn.fujitsu.com","date":"2015-08-27 06:46:42.000000000","tz":0},"committer":{"name":"majianjun","email":"mjjun@cn.fujitsu.com","date":"2015-08-27 06:46:42.000000000","tz":0},"subject":"Return the tenant_id as early as possible Fixes Bug1488715","message":"Return the tenant_id as early as possible\nFixes Bug1488715\n\nChange-Id: I010535803f7d5c755b24418e1bee9d75892e3ce9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/d755616cac3a5f2b337eedad9abe96edcec26af5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/d755616cac3a5f2b337eedad9abe96edcec26af5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}