)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"a7c4e32108b135f917635aa18ddabd28c5168742","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We\u0027ve been working towards consolidating the Fernet token provider into the"},{"line_number":10,"context_line":"common.BaseProvider() class. A previous commit did this:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  https://review.openstack.org/#/c/196877/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"But we missed one detail from the fernet.core.Provider that didn\u0027t get included"},{"line_number":15,"context_line":"in the commit, which is returning exception.TokenNotFound instead of a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_3eeb487a","line":12,"updated":"2015-09-02 19:39:22.000000000","message":"is there some reason to don\u0027t change this behavior in the this previous patch since it was not merged yet?","commit_id":"5919493ea3399ea6163b550339cc6b4bb762edff"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"13a6744a102c9db0a72811ab2899036f27cf4616","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We\u0027ve been working towards consolidating the Fernet token provider into the"},{"line_number":10,"context_line":"common.BaseProvider() class. A previous commit did this:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  https://review.openstack.org/#/c/196877/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"But we missed one detail from the fernet.core.Provider that didn\u0027t get included"},{"line_number":15,"context_line":"in the commit, which is returning exception.TokenNotFound instead of a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_a82fec9f","line":12,"in_reply_to":"da20952f_3eeb487a","updated":"2015-09-03 17:17:54.000000000","message":"Morgan didn\u0027t want to reset the entire series and have all of them rerun against Jenkins: \n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2015-09-02.log.html#t2015-09-02T17:46:02","commit_id":"5919493ea3399ea6163b550339cc6b4bb762edff"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"a5e8a24a49d849c685ba8d1506046ae1856254f8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We\u0027ve been working towards consolidating the Fernet token provider into the"},{"line_number":10,"context_line":"common.BaseProvider() class. A previous commit did this:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  https://review.openstack.org/#/c/196877/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"But we missed one detail from the fernet.core.Provider that didn\u0027t get included"},{"line_number":15,"context_line":"in the commit, which is returning exception.TokenNotFound instead of a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_c3c32356","line":12,"in_reply_to":"da20952f_a82fec9f","updated":"2015-09-03 17:25:52.000000000","message":"Ok, got it, thanks.","commit_id":"5919493ea3399ea6163b550339cc6b4bb762edff"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"024efefcef709e0e4255069ea78773065d6df1d7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"in the commit, which is returning exception.TokenNotFound instead of a"},{"line_number":16,"context_line":"validation error. This commit introduces that logic into the BaseProvider so"},{"line_number":17,"context_line":"that it is consistent with what was originally implemented."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I4bb52c61bba4da172ccdab040ec2d99c85c093e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_d6fb7979","line":18,"updated":"2015-09-07 14:06:37.000000000","message":"does it deserve a bug/wishlist ?","commit_id":"5919493ea3399ea6163b550339cc6b4bb762edff"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"68835956a26e42ddaf5e4c4abeba2fc34c25107b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"in the commit, which is returning exception.TokenNotFound instead of a"},{"line_number":16,"context_line":"validation error. This commit introduces that logic into the BaseProvider so"},{"line_number":17,"context_line":"that it is consistent with what was originally implemented."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I4bb52c61bba4da172ccdab040ec2d99c85c093e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_2c927e4c","line":18,"in_reply_to":"da20952f_d6fb7979","updated":"2015-09-08 14:24:40.000000000","message":"since https://review.openstack.org/#/c/196877/21/keystone/token/providers/fernet/core.py hasn\u0027t landed yet, I\u0027m not sure... \n\nIf can open one if need though.","commit_id":"5919493ea3399ea6163b550339cc6b4bb762edff"}],"keystone/token/providers/common.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"629a93bc36db83180d8c98c3047dcb70ce2a25ee","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                federated_info, created_at, expires_at) \u003d ("},{"line_number":718,"context_line":"                    self.token_formatter.validate_token(token_id))"},{"line_number":719,"context_line":"        except exception.ValidationError as e:"},{"line_number":720,"context_line":"            # NOTE(lbragstad): The token is either invalid or not found"},{"line_number":721,"context_line":"            raise exception.TokenNotFound(e)"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        token_dict \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_b5e17b9d","line":720,"updated":"2015-09-11 03:15:27.000000000","message":"thanks for the NOTE here, I am wondering if there anything we can do to differentiate these two types of errors, just thinking out loud.","commit_id":"5919493ea3399ea6163b550339cc6b4bb762edff"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"a7c4e32108b135f917635aa18ddabd28c5168742","unresolved":false,"context_lines":[{"line_number":718,"context_line":"                    self.token_formatter.validate_token(token_id))"},{"line_number":719,"context_line":"        except exception.ValidationError as e:"},{"line_number":720,"context_line":"            # NOTE(lbragstad): The token is either invalid or not found"},{"line_number":721,"context_line":"            raise exception.TokenNotFound(e)"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        token_dict \u003d None"},{"line_number":724,"context_line":"        trust_ref \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_fe4f10bc","line":721,"updated":"2015-09-02 19:39:22.000000000","message":"why not add some message to clarify the error for the user? :)","commit_id":"5919493ea3399ea6163b550339cc6b4bb762edff"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"a5e8a24a49d849c685ba8d1506046ae1856254f8","unresolved":false,"context_lines":[{"line_number":718,"context_line":"                    self.token_formatter.validate_token(token_id))"},{"line_number":719,"context_line":"        except exception.ValidationError as e:"},{"line_number":720,"context_line":"            # NOTE(lbragstad): The token is either invalid or not found"},{"line_number":721,"context_line":"            raise exception.TokenNotFound(e)"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        token_dict \u003d None"},{"line_number":724,"context_line":"        trust_ref \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_23b0dfdc","line":721,"in_reply_to":"da20952f_6326d7bb","updated":"2015-09-03 17:25:52.000000000","message":"OK, you know more about than me, if you\u0027re saying that can have some security concerns with this, I believe :)","commit_id":"5919493ea3399ea6163b550339cc6b4bb762edff"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"13a6744a102c9db0a72811ab2899036f27cf4616","unresolved":false,"context_lines":[{"line_number":718,"context_line":"                    self.token_formatter.validate_token(token_id))"},{"line_number":719,"context_line":"        except exception.ValidationError as e:"},{"line_number":720,"context_line":"            # NOTE(lbragstad): The token is either invalid or not found"},{"line_number":721,"context_line":"            raise exception.TokenNotFound(e)"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        token_dict \u003d None"},{"line_number":724,"context_line":"        trust_ref \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_6326d7bb","line":721,"in_reply_to":"da20952f_fe4f10bc","updated":"2015-09-03 17:17:54.000000000","message":"We could, I know we try not to give much information about the error because of security concerns.","commit_id":"5919493ea3399ea6163b550339cc6b4bb762edff"}]}