)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bf8a026074fa192119a2374a63fb16dbabc8ad2a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now that we have pbr we can deprecate httpd/keystone.py.  This is"},{"line_number":10,"context_line":"done by passing a boolean variable to initialize_application since"},{"line_number":11,"context_line":"the logging has not been configured in keystone.py"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifcdfcb31e7be18b511a7c586d9ca259bc15bec44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_84a0a7f4","line":12,"updated":"2015-09-11 19:34:07.000000000","message":"This needs a bug or a blueprint.","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"14cc0e0245844c6cb66a6e879486b3d07e04be23","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now that we have pbr we can deprecate httpd/keystone.py.  This is"},{"line_number":10,"context_line":"done by passing a boolean variable to initialize_application since"},{"line_number":11,"context_line":"the logging has not been configured in keystone.py"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifcdfcb31e7be18b511a7c586d9ca259bc15bec44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_27475da4","line":12,"in_reply_to":"da20952f_84a0a7f4","updated":"2015-09-11 20:26:24.000000000","message":"Done","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"de84302f867784d527a738abd0c10ede35951988","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now that we have pbr we can deprecate httpd/keystone.py.  This is"},{"line_number":10,"context_line":"done by passing a boolean variable to initialize_application since"},{"line_number":11,"context_line":"the logging has not been configured in keystone.py"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifcdfcb31e7be18b511a7c586d9ca259bc15bec44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_a435ab45","line":12,"in_reply_to":"da20952f_84a0a7f4","updated":"2015-09-11 19:47:24.000000000","message":"Working on it","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"233cea011ecbb60e33a443545a1248e73cbbf311","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deprecate httpd/keystone.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that we have keystone-wsgi-admin or keystone-wsgi-public we can deprecate"},{"line_number":10,"context_line":"httpd/keystone.py.  This is done by passing a function that has the"},{"line_number":11,"context_line":"@versionutils.deprecated decorator to initialize_application since the"},{"line_number":12,"context_line":"logging has not been configured in keystone.py"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_fd011107","line":10,"updated":"2015-09-16 16:09:57.000000000","message":"if the commit message needs to explain the code then the code should be made clearer instead, as in, add a comment to the code that explains why it\u0027s done the way it is.\n\nThen don\u0027t explain the change in the commit message since if the implementation details change the commit message will be out of date.","commit_id":"8f05d6ceca126422ecc3053174fcf50b5512f573"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"63d647dac08a0bbd944ce6100fa77ecbbf6d5c61","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate httpd/keystone.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that we have keystone-wsgi-admin or keystone-wsgi-public we can deprecate"},{"line_number":10,"context_line":"httpd/keystone.py."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifcdfcb31e7be18b511a7c586d9ca259bc15bec44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a1a9d01_c3daac78","line":9,"updated":"2015-09-24 21:29:34.000000000","message":"(nit) s/or/and/ since we have both","commit_id":"170bb99736fa03059f301bd00c317c7442233434"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"15c24a92cd27419a53a786e061a3808f63b38073","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate httpd/keystone.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that we have keystone-wsgi-admin or keystone-wsgi-public we can deprecate"},{"line_number":10,"context_line":"httpd/keystone.py."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifcdfcb31e7be18b511a7c586d9ca259bc15bec44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a1a9d01_56583c32","line":9,"in_reply_to":"9a1a9d01_c3daac78","updated":"2015-09-28 16:56:27.000000000","message":"Done","commit_id":"170bb99736fa03059f301bd00c317c7442233434"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"873fc36b6d159f32922ab5637d3d13d2b07c8d12","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate httpd/keystone.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that we have keystone-wsgi-admin and keystone-wsgi-public"},{"line_number":10,"context_line":"we can deprecate httpd/keystone.py."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifcdfcb31e7be18b511a7c586d9ca259bc15bec44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9a1a9d01_75539617","line":9,"updated":"2015-09-30 14:15:15.000000000","message":"just for reference, keystone-wsgi-admin and keystone-wsgi-public are keystone/server/wsgi.py, right?","commit_id":"99004ef82a9237e186ea2aa8a743ff758deeb68f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"d7cc2ac2843d4277482e7b8a16d6719f51eedbbc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate httpd/keystone.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that we have keystone-wsgi-admin and keystone-wsgi-public"},{"line_number":10,"context_line":"we can deprecate httpd/keystone.py."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifcdfcb31e7be18b511a7c586d9ca259bc15bec44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9a1a9d01_be54a6c9","line":9,"in_reply_to":"9a1a9d01_75539617","updated":"2015-09-30 18:18:15.000000000","message":"Yes Lance, you are correct,  in the setup.cfg\n\nkeystone-wsgi-admin is defined as keystone.server.wsgi:initialize_admin_application and\n\nkeystone-wsgi-public is defined as keystone.server.wsgi:initialize_public_application","commit_id":"99004ef82a9237e186ea2aa8a743ff758deeb68f"}],"httpd/keystone.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bf8a026074fa192119a2374a63fb16dbabc8ad2a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from keystone.server import wsgi as wsgi_server"},{"line_number":18,"context_line":"from oslo_log import versionutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@versionutils.deprecated("}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_c481bf4e","line":18,"updated":"2015-09-11 19:34:07.000000000","message":"imports of libraries go in their own section before the keystone imports.","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"de84302f867784d527a738abd0c10ede35951988","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from keystone.server import wsgi as wsgi_server"},{"line_number":18,"context_line":"from oslo_log import versionutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@versionutils.deprecated("}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_443fef24","line":18,"in_reply_to":"da20952f_c481bf4e","updated":"2015-09-11 19:47:24.000000000","message":"Done","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bf8a026074fa192119a2374a63fb16dbabc8ad2a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@versionutils.deprecated("},{"line_number":22,"context_line":"    as_of\u003dversionutils.deprecated.LIBERTY,"},{"line_number":23,"context_line":"    in_favor_of\u003d\u0027pbr\u0027,"},{"line_number":24,"context_line":"    remove_in\u003d+2,"},{"line_number":25,"context_line":"    what\u003d\u0027httpd/keystone.py\u0027)"},{"line_number":26,"context_line":"def deprications_warning():"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_44ddaf6e","line":23,"updated":"2015-09-11 19:34:07.000000000","message":"change \"pbr\" to \"keystone-wsgi-admin or keystone-wsgi-public\"","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"de84302f867784d527a738abd0c10ede35951988","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@versionutils.deprecated("},{"line_number":22,"context_line":"    as_of\u003dversionutils.deprecated.LIBERTY,"},{"line_number":23,"context_line":"    in_favor_of\u003d\u0027pbr\u0027,"},{"line_number":24,"context_line":"    remove_in\u003d+2,"},{"line_number":25,"context_line":"    what\u003d\u0027httpd/keystone.py\u0027)"},{"line_number":26,"context_line":"def deprications_warning():"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_643c732f","line":23,"in_reply_to":"da20952f_44ddaf6e","updated":"2015-09-11 19:47:24.000000000","message":"Done","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bf8a026074fa192119a2374a63fb16dbabc8ad2a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    in_favor_of\u003d\u0027pbr\u0027,"},{"line_number":24,"context_line":"    remove_in\u003d+2,"},{"line_number":25,"context_line":"    what\u003d\u0027httpd/keystone.py\u0027)"},{"line_number":26,"context_line":"def deprications_warning():"},{"line_number":27,"context_line":"        pass"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"name \u003d os.path.basename(__file__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_44960f95","line":26,"updated":"2015-09-11 19:34:07.000000000","message":"change \"deprications\u0027 to \"deprecations\"","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"de84302f867784d527a738abd0c10ede35951988","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    in_favor_of\u003d\u0027pbr\u0027,"},{"line_number":24,"context_line":"    remove_in\u003d+2,"},{"line_number":25,"context_line":"    what\u003d\u0027httpd/keystone.py\u0027)"},{"line_number":26,"context_line":"def deprications_warning():"},{"line_number":27,"context_line":"        pass"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"name \u003d os.path.basename(__file__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_e41643a6","line":26,"in_reply_to":"da20952f_44960f95","updated":"2015-09-11 19:47:24.000000000","message":"Done","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bf8a026074fa192119a2374a63fb16dbabc8ad2a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# http://pythonpaste.org/deploy/"},{"line_number":34,"context_line":"application \u003d wsgi_server.initialize_application("},{"line_number":35,"context_line":"    name,"},{"line_number":36,"context_line":"    deprecation_keystone_py_function\u003ddeprications_warning)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_e43ba39a","line":36,"updated":"2015-09-11 19:34:07.000000000","message":"use a more generic descriptive name for the parameter, for example post_log_configured_function","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"de84302f867784d527a738abd0c10ede35951988","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# http://pythonpaste.org/deploy/"},{"line_number":34,"context_line":"application \u003d wsgi_server.initialize_application("},{"line_number":35,"context_line":"    name,"},{"line_number":36,"context_line":"    deprecation_keystone_py_function\u003ddeprications_warning)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_8407476f","line":36,"in_reply_to":"da20952f_e43ba39a","updated":"2015-09-11 19:47:24.000000000","message":"Done","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ccbd52f3201695ab3a3bb288c7eefc5a9e5b0375","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from keystone.server import wsgi as wsgi_server"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@versionutils.deprecated("},{"line_number":23,"context_line":"    as_of\u003dversionutils.deprecated.LIBERTY,"},{"line_number":24,"context_line":"    in_favor_of\u003d\u0027keystone-wsgi-admin or keystone-wsgi-public\u0027,"},{"line_number":25,"context_line":"    remove_in\u003d+2,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_9df01569","line":22,"updated":"2015-09-16 16:07:29.000000000","message":"oslo.log provides a function you can call to report deprecation, so there\u0027s no need to use the decorator. The decorator use here is a little confusing.\n\nhttp://docs.openstack.org/developer/oslo.log/api/versionutils.html#oslo_log.versionutils.report_deprecated_feature","commit_id":"8f05d6ceca126422ecc3053174fcf50b5512f573"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"950d409213949facb8e40e01f013d48b2ef3318b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_log import log"},{"line_number":18,"context_line":"from oslo_log import versionutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from keystone.i18n import _LW"},{"line_number":21,"context_line":"from keystone.server import wsgi as wsgi_server"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a1a9d01_e80d76e8","line":18,"updated":"2015-09-30 22:32:21.000000000","message":"is it sane to import oslo_log this early? before config, etc","commit_id":"70a42e7a82ddae9be75dba8f063170a1d13ce301"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e92ef6e78cdcd00760ea164e07438e0000efdb63","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_log import log"},{"line_number":18,"context_line":"from oslo_log import versionutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from keystone.i18n import _LW"},{"line_number":21,"context_line":"from keystone.server import wsgi as wsgi_server"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a2fa921_f6470e49","line":18,"in_reply_to":"7a2fa921_d61e9262","updated":"2015-10-07 16:52:05.000000000","message":"if there\u0027s a concern the imports could be moved into the deprecation_warning function rather than done up front.","commit_id":"70a42e7a82ddae9be75dba8f063170a1d13ce301"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b86104f46c193b2781e7432749afa3f6a2f79ab1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_log import log"},{"line_number":18,"context_line":"from oslo_log import versionutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from keystone.i18n import _LW"},{"line_number":21,"context_line":"from keystone.server import wsgi as wsgi_server"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a2fa921_d61e9262","line":18,"in_reply_to":"9a1a9d01_c992d39f","updated":"2015-10-07 16:50:24.000000000","message":"I can\u0027t think of any headaches this specific import will cause, but it\u0027s generally bad form to import things used by the application in WSGI scripts before the application has a chance to.","commit_id":"70a42e7a82ddae9be75dba8f063170a1d13ce301"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"c6cd21bf7007d3f9bd666df55510612484c9a544","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_log import log"},{"line_number":18,"context_line":"from oslo_log import versionutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from keystone.i18n import _LW"},{"line_number":21,"context_line":"from keystone.server import wsgi as wsgi_server"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a1a9d01_c992d39f","line":18,"in_reply_to":"9a1a9d01_e80d76e8","updated":"2015-10-01 17:00:59.000000000","message":"@Dolph, Its the only way I have found to show this deprecation warning inside keystone.py.  Do you suggest a different way of doing it?","commit_id":"70a42e7a82ddae9be75dba8f063170a1d13ce301"}],"keystone/server/wsgi.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bf8a026074fa192119a2374a63fb16dbabc8ad2a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def initialize_application(name, deprecation_keystone_py_function\u003dNone):"},{"line_number":51,"context_line":"    common.configure()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # Log the options used when starting if we\u0027re in debug mode..."}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_44f92fc7","line":50,"updated":"2015-09-11 19:34:07.000000000","message":"if the default was set to a function that didn\u0027t do anything then the code below wouldn\u0027t have to check that it\u0027s set, so this could be like\n\n deprecation_keystone_py_function\u003dlambda: None","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"de84302f867784d527a738abd0c10ede35951988","unresolved":false,"context_lines":[{"line_number":47,"context_line":"]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def initialize_application(name, deprecation_keystone_py_function\u003dNone):"},{"line_number":51,"context_line":"    common.configure()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # Log the options used when starting if we\u0027re in debug mode..."}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_c4b53fd0","line":50,"in_reply_to":"da20952f_44f92fc7","updated":"2015-09-11 19:47:24.000000000","message":"This is cool! \nDone","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bf8a026074fa192119a2374a63fb16dbabc8ad2a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    environment.use_stdlib()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Display deprecation of keystone.py"},{"line_number":60,"context_line":"    if deprecation_keystone_py_function:"},{"line_number":61,"context_line":"        deprecation_keystone_py_function()"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_0451f7d8","line":59,"updated":"2015-09-11 19:34:07.000000000","message":"remove the comment.","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"de84302f867784d527a738abd0c10ede35951988","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    environment.use_stdlib()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Display deprecation of keystone.py"},{"line_number":60,"context_line":"    if deprecation_keystone_py_function:"},{"line_number":61,"context_line":"        deprecation_keystone_py_function()"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_64231306","line":59,"in_reply_to":"da20952f_0451f7d8","updated":"2015-09-11 19:47:24.000000000","message":"Done","commit_id":"0c8a2d3b2d351eeb3f8fd3f37b132b043da46c5b"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"63d647dac08a0bbd944ce6100fa77ecbbf6d5c61","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    versionutils.report_deprecated_feature("},{"line_number":64,"context_line":"        LOG,"},{"line_number":65,"context_line":"        _LW(\u0027httpd/keystone.py is deprecated as of Mitaka\u0027"},{"line_number":66,"context_line":"            \u0027 in favor of keystone-wsgi-admin or keystone-wsgi-public\u0027"},{"line_number":67,"context_line":"            \u0027 and may be removed in O.\u0027)"},{"line_number":68,"context_line":"    )"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a1a9d01_c3486c30","line":66,"updated":"2015-09-24 21:29:34.000000000","message":"I really don\u0027t like this here since I don\u0027t think this file should even know about httpd/keystone.py. Why not setup logging in httpd/keystone.py instead?","commit_id":"170bb99736fa03059f301bd00c317c7442233434"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"15c24a92cd27419a53a786e061a3808f63b38073","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    versionutils.report_deprecated_feature("},{"line_number":64,"context_line":"        LOG,"},{"line_number":65,"context_line":"        _LW(\u0027httpd/keystone.py is deprecated as of Mitaka\u0027"},{"line_number":66,"context_line":"            \u0027 in favor of keystone-wsgi-admin or keystone-wsgi-public\u0027"},{"line_number":67,"context_line":"            \u0027 and may be removed in O.\u0027)"},{"line_number":68,"context_line":"    )"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a1a9d01_168ba4c4","line":66,"in_reply_to":"9a1a9d01_c3486c30","updated":"2015-09-28 16:56:27.000000000","message":"David,  I made your change in patch set 12, sorry I just got around to testing it this morning.  It looks like logging is not set up yet in keystone.py.  It looks like its set up in wsgi.py when common.configure() is called.  \ni think either i could;\n\n1) Pass in a function that has the decorator(patch set 5)\n\n2) Call the deprecation inside wsgi.py\n\nI am going to upload another patch that is going to be similar to number 1.   Thanks you for reviewing my patch! :)","commit_id":"170bb99736fa03059f301bd00c317c7442233434"}]}