)]}'
{"keystone/token/core.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"b643e87e0f3914b74e80c3696b4ba4ba57055be1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                msg \u003d \u0027Domain is disabled: %s\u0027 % project_domain_ref[\u0027id\u0027]"},{"line_number":104,"context_line":"                LOG.warning(msg)"},{"line_number":105,"context_line":"                raise exception.Unauthorized(msg)"},{"line_number":106,"context_line":"    return"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"@dependency.provider(\u0027token_api\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bxf8%3D","line":106,"updated":"2013-02-19 15:39:22.000000000","message":"nitpick: return not needed","commit_id":"64b3e72517608c28ad7c3cb6caafac1b1c5f661f"},{"author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"change_message_id":"aef8baca038c2380b5c20cea77ae01466357ccf3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    return timeutils.utcnow() + expire_delta"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def validate_auth_info(self, context, user_ref, tenant_ref, metadata_ref):"},{"line_number":61,"context_line":"    \"\"\"Validate user, tenant, metadata auth_info."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    Validate the user, tenant and metadata auth_into in order to ensure that"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BxLo%3D","line":60,"updated":"2013-02-19 17:15:08.000000000","message":"why accept metadata_ref if you do nothing with it here?","commit_id":"734601a19e0b5cf142f956334c2fd2d6a3dba521"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d917ed3fadc844eee03650b368478a0521f41029","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    return timeutils.utcnow() + expire_delta"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def validate_auth_info(self, context, user_ref, tenant_ref, metadata_ref):"},{"line_number":61,"context_line":"    \"\"\"Validate user, tenant, metadata auth_info."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    Validate the user, tenant and metadata auth_into in order to ensure that"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BxD4%3D","line":60,"in_reply_to":"AAAAM3%2F%2BxLo%3D","updated":"2013-02-19 17:59:13.000000000","message":"Done","commit_id":"734601a19e0b5cf142f956334c2fd2d6a3dba521"},{"author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"change_message_id":"aef8baca038c2380b5c20cea77ae01466357ccf3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    user, tenant, or metadata information is valid and not disabled."},{"line_number":65,"context_line":"    Consolidate the checks here to ensure consistency between token auth and"},{"line_number":66,"context_line":"    ec2 auth."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    # If the user is disabled don\u0027t allow them to authenticate"},{"line_number":70,"context_line":"    if not user_ref.get(\u0027enabled\u0027, True):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BxLA%3D","line":67,"updated":"2013-02-19 17:15:08.000000000","message":"since this is one of the \"core\" API pieces, we should be explicit about what this method (and it\u0027s drivers) should be doing - pls. add docstrings to add in :params:, :returns:, and :raises: with expectations","commit_id":"734601a19e0b5cf142f956334c2fd2d6a3dba521"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d917ed3fadc844eee03650b368478a0521f41029","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    user, tenant, or metadata information is valid and not disabled."},{"line_number":65,"context_line":"    Consolidate the checks here to ensure consistency between token auth and"},{"line_number":66,"context_line":"    ec2 auth."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    # If the user is disabled don\u0027t allow them to authenticate"},{"line_number":70,"context_line":"    if not user_ref.get(\u0027enabled\u0027, True):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BxDY%3D","line":67,"in_reply_to":"AAAAM3%2F%2BxLA%3D","updated":"2013-02-19 17:59:13.000000000","message":"Done\n\nskipping :returns: since there\u0027s no expected return value","commit_id":"734601a19e0b5cf142f956334c2fd2d6a3dba521"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"7e2e85bf4df29177adacaab258e5f751a7c0a4c3","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    not project_domain_ref.get(\u0027enabled\u0027, True)):"},{"line_number":101,"context_line":"                msg \u003d \u0027Domain is disabled: %s\u0027 % project_domain_ref[\u0027id\u0027]"},{"line_number":102,"context_line":"                LOG.warning(msg)"},{"line_number":103,"context_line":"                raise exception.Unauthorized(msg)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@dependency.provider(\u0027token_api\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BxME%3D","line":103,"updated":"2013-02-19 17:12:28.000000000","message":"Seems like we are duplicating domain checking code, here and in line 78. I wonder if it makes more sense to refactor the domain checking code into a separate method, like\n\nis_doman_enable(self, domain_id)","commit_id":"734601a19e0b5cf142f956334c2fd2d6a3dba521"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d917ed3fadc844eee03650b368478a0521f41029","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    not project_domain_ref.get(\u0027enabled\u0027, True)):"},{"line_number":101,"context_line":"                msg \u003d \u0027Domain is disabled: %s\u0027 % project_domain_ref[\u0027id\u0027]"},{"line_number":102,"context_line":"                LOG.warning(msg)"},{"line_number":103,"context_line":"                raise exception.Unauthorized(msg)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@dependency.provider(\u0027token_api\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BxBI%3D","line":103,"in_reply_to":"AAAAM3%2F%2BxME%3D","updated":"2013-02-19 17:59:13.000000000","message":"agree, but want to avoid extraneous refactoring in a security fix... trying to keep this as close to a copy/paste of the original code as possible","commit_id":"734601a19e0b5cf142f956334c2fd2d6a3dba521"}]}