)]}'
{"keystone/middleware/core.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"a3fe894758241f0fd766dbde8b9e0fdddb279dde","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        :returns: True if client_issuer is trusted; otherwise False"},{"line_number":263,"context_line":"        \"\"\""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Check to see if any trusted_issuers have been defined, it there"},{"line_number":266,"context_line":"        # are none, immediately return false without logging anything."},{"line_number":267,"context_line":"        if CONF.tokenless_auth.trusted_issuer:"},{"line_number":268,"context_line":"            client_issuer \u003d env.get(CONF.tokenless_auth.issuer_attribute)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_06346247","line":265,"updated":"2015-09-18 09:31:38.000000000","message":"nit: s/it/if","commit_id":"82d2d0aae94c27593e710b24e6c090fa9b720e31"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"33d44111841d933ce053e2579bdce5ede884c06d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        :returns: True if client_issuer is trusted; otherwise False"},{"line_number":263,"context_line":"        \"\"\""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Check to see if any trusted_issuers have been defined, it there"},{"line_number":266,"context_line":"        # are none, immediately return false without logging anything."},{"line_number":267,"context_line":"        if CONF.tokenless_auth.trusted_issuer:"},{"line_number":268,"context_line":"            client_issuer \u003d env.get(CONF.tokenless_auth.issuer_attribute)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_862e32a3","line":265,"in_reply_to":"ba15a1d1_06346247","updated":"2015-09-18 09:34:56.000000000","message":"Done","commit_id":"82d2d0aae94c27593e710b24e6c090fa9b720e31"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"a3fe894758241f0fd766dbde8b9e0fdddb279dde","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            if client_issuer in CONF.tokenless_auth.trusted_issuer:"},{"line_number":276,"context_line":"                return True"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"            msg \u003d _LI(\u0027The client issuer %(client_issuer)s does not match with \u0027"},{"line_number":279,"context_line":"                      \u0027the trusted issuer %(trusted_issuer)s\u0027)"},{"line_number":280,"context_line":"            LOG.info("},{"line_number":281,"context_line":"                msg, {\u0027client_issuer\u0027: client_issuer,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_46633a42","line":278,"updated":"2015-09-18 09:31:38.000000000","message":"this line is too long.","commit_id":"82d2d0aae94c27593e710b24e6c090fa9b720e31"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"33d44111841d933ce053e2579bdce5ede884c06d","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            if client_issuer in CONF.tokenless_auth.trusted_issuer:"},{"line_number":276,"context_line":"                return True"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"            msg \u003d _LI(\u0027The client issuer %(client_issuer)s does not match with \u0027"},{"line_number":279,"context_line":"                      \u0027the trusted issuer %(trusted_issuer)s\u0027)"},{"line_number":280,"context_line":"            LOG.info("},{"line_number":281,"context_line":"                msg, {\u0027client_issuer\u0027: client_issuer,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_a629f69c","line":278,"in_reply_to":"ba15a1d1_46633a42","updated":"2015-09-18 09:34:56.000000000","message":"Done","commit_id":"82d2d0aae94c27593e710b24e6c090fa9b720e31"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"3f17d6e2e1cd03ba9eb20ccb96337e6e2e4b4c12","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Check to see if any trusted_issuer has been defined, if it"},{"line_number":266,"context_line":"        # is none, immediately return false without logging anything."},{"line_number":267,"context_line":"        if CONF.tokenless_auth.trusted_issuer:"},{"line_number":268,"context_line":"            client_issuer \u003d env.get(CONF.tokenless_auth.issuer_attribute)"},{"line_number":269,"context_line":"            if not client_issuer:"},{"line_number":270,"context_line":"                msg \u003d _LI(\u0027Cannot find client issuer in env by the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_691acec7","line":267,"updated":"2015-09-18 11:38:19.000000000","message":"if you\u0027re going to do this, then do:\n\n  if not CONF.tokenless_auth.trusted_issuer:\n      return False\n\nso that you\u0027re more clearly illustrating the short circuit behavior, and avoiding unnecessarily indenting a huge block of code. it will also result in a smaller patch.","commit_id":"6b685c09dc18bdef535f15128b139afdb2de1cc4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1c0b9717beb7d171792e43ca443b2f2abb5b6c44","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Check to see if any trusted_issuer has been defined, if it"},{"line_number":266,"context_line":"        # is none, immediately return false without logging anything."},{"line_number":267,"context_line":"        if CONF.tokenless_auth.trusted_issuer:"},{"line_number":268,"context_line":"            client_issuer \u003d env.get(CONF.tokenless_auth.issuer_attribute)"},{"line_number":269,"context_line":"            if not client_issuer:"},{"line_number":270,"context_line":"                msg \u003d _LI(\u0027Cannot find client issuer in env by the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_c755faf9","line":267,"in_reply_to":"ba15a1d1_691acec7","updated":"2015-09-18 14:45:36.000000000","message":"good suggestion!","commit_id":"6b685c09dc18bdef535f15128b139afdb2de1cc4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a3e88e2774e1efcb0ed4d22d2b2ff1b0d0bc7921","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        \"\"\""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Check to see if any trusted_issuers have been defined, if there"},{"line_number":266,"context_line":"        # are none, immediately return false without logging anything."},{"line_number":267,"context_line":"        if not CONF.tokenless_auth.trusted_issuer:"},{"line_number":268,"context_line":"            return False"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_58fd47af","line":266,"updated":"2015-09-18 15:49:26.000000000","message":"2 lines of comment that say exactly what the next 2 lines already say. Comments should say why the code is there rather than what the code does.","commit_id":"c124aeb583107c5a96c7d52a430c7503e47a5a9a"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d6ed295dba8dabe9edec98a6e9ec875ee24e6ff3","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        \"\"\""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Check to see if any trusted_issuers have been defined, if there"},{"line_number":266,"context_line":"        # are none, immediately return false without logging anything."},{"line_number":267,"context_line":"        if not CONF.tokenless_auth.trusted_issuer:"},{"line_number":268,"context_line":"            return False"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_b8db434e","line":266,"in_reply_to":"ba15a1d1_58fd47af","updated":"2015-09-18 15:50:25.000000000","message":"++ this comment is redundant with the code","commit_id":"c124aeb583107c5a96c7d52a430c7503e47a5a9a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a3e88e2774e1efcb0ed4d22d2b2ff1b0d0bc7921","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        if not client_issuer:"},{"line_number":272,"context_line":"            msg \u003d _LI(\u0027Cannot find client issuer in env by the \u0027"},{"line_number":273,"context_line":"                      \u0027issuer attribute - %s.\u0027)"},{"line_number":274,"context_line":"            LOG.info(msg, CONF.tokenless_auth.issuer_attribute)"},{"line_number":275,"context_line":"            return False"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        if client_issuer in CONF.tokenless_auth.trusted_issuer:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_183d8f8e","line":274,"updated":"2015-09-18 15:49:26.000000000","message":"is there a reason this needs to be info, seems like this is a normal situation even if tokenless auth is configured.","commit_id":"c124aeb583107c5a96c7d52a430c7503e47a5a9a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ddf899cf0434d1daa1926907b5deff54931bfed4","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        \"\"\""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        if not CONF.tokenless_auth.trusted_issuer:"},{"line_number":266,"context_line":"            return False"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        client_issuer \u003d env.get(CONF.tokenless_auth.issuer_attribute)"},{"line_number":269,"context_line":"        if not client_issuer:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_787a8bbe","line":266,"updated":"2015-09-18 15:58:21.000000000","message":"would be nice to have a comment that says why it\u0027s ok to short-circuit, but it\u0027s obvious enough as-is. e.g.,\n\n  # No trusted issuers so none will be valid.","commit_id":"1bac1dfb0a71de4f28ca6aba36a39b1e4ca284d8"}]}