)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"34ae642c1631f6a27d416c0985bdab5048cb530e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"fact a UUID and the attempt to convert to bytes was successful."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change has effect on more than just user IDs.  It also resovles"},{"line_number":17,"context_line":"potential issues with project IDs, group IDs, IDP IDs, and scope IDs."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia4a4f760d67d8bbc22759c48fc800aef016b84ed"},{"line_number":20,"context_line":"Closes-Bug: #1497461"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a2fa921_71002835","line":17,"updated":"2015-10-06 14:48:11.000000000","message":"so all ID strings that can be present in a payload","commit_id":"7a7bc1d2b28752388ad37bebd74a593fdb9dc3df"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"5f377413f50b5d71629aa0717d90aec8a07310d0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"fact a UUID and the attempt to convert to bytes was successful."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change has effect on more than just user IDs.  It also resovles"},{"line_number":17,"context_line":"potential issues with project IDs, group IDs, IDP IDs, and scope IDs."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia4a4f760d67d8bbc22759c48fc800aef016b84ed"},{"line_number":20,"context_line":"Closes-Bug: #1497461"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a2fa921_581c1d77","line":17,"in_reply_to":"7a2fa921_71002835","updated":"2015-10-06 20:47:33.000000000","message":"Well, not some other IDs such as domain_id, audit_id, trust_id","commit_id":"7a7bc1d2b28752388ad37bebd74a593fdb9dc3df"}],"keystone/tests/unit/token/test_fernet_provider.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e6b7db1e171b7d3d1e312cfa3109d3ea5a834d1d","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _test_domain_scoped_payload_with_user_id(self, exp_user_id):"},{"line_number":257,"context_line":"        exp_methods \u003d [\u0027password\u0027]"},{"line_number":258,"context_line":"        exp_domain_id \u003d uuid.uuid4().hex"},{"line_number":259,"context_line":"        exp_expires_at \u003d utils.isotime(timeutils.utcnow(), subsecond\u003dTrue)"},{"line_number":260,"context_line":"        exp_audit_ids \u003d [provider.random_urlsafe_str()]"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_13741ffb","line":258,"updated":"2015-10-07 16:02:02.000000000","message":"Domain IDs can be user defined, shouldn\u0027t we test this similar to how we\u0027re testing project scoped payloads?","commit_id":"8b97bab9fd01d10ede5b3820f145d3cae4779235"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"91a5bec17b32916db006dbfead0270394aeb7872","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _test_domain_scoped_payload_with_user_id(self, exp_user_id):"},{"line_number":257,"context_line":"        exp_methods \u003d [\u0027password\u0027]"},{"line_number":258,"context_line":"        exp_domain_id \u003d uuid.uuid4().hex"},{"line_number":259,"context_line":"        exp_expires_at \u003d utils.isotime(timeutils.utcnow(), subsecond\u003dTrue)"},{"line_number":260,"context_line":"        exp_audit_ids \u003d [provider.random_urlsafe_str()]"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_8608dd92","line":258,"in_reply_to":"7a2fa921_13741ffb","updated":"2015-10-07 21:51:01.000000000","message":"So currently domain ids are assumed always UUID.  The code does not use the attempt_* function.  And I don\u0027t think you can have domains in LDAP anyway, so they should be UUID.","commit_id":"8b97bab9fd01d10ede5b3820f145d3cae4779235"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d1174a38385b6295077e374ad5ccec6d787459fc","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        self._test_project_scoped_payload_with_ids(\u0027someNonUuidUserId\u0027,"},{"line_number":443,"context_line":"                                                   \u0027someNonUuidProjectId\u0027)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def test_project_scoped_payload_with_16_char_non_uuid_user_id(self):"},{"line_number":446,"context_line":"        self._test_project_scoped_payload_with_ids(\u00270123456789abcdef\u0027,"},{"line_number":447,"context_line":"                                                   \u00270123456789abcdef\u0027)"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a2ca52d_e3f3fe08","line":445,"updated":"2015-10-14 13:05:42.000000000","message":"this is testing a non-uuid project id, too.","commit_id":"794e1510cc91fbe0277e291bc2cabdfba478bef3"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"49d6f0c824fb0a6aa4d041786df81db4fc2b2a19","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        self._test_project_scoped_payload_with_ids(\u0027someNonUuidUserId\u0027,"},{"line_number":443,"context_line":"                                                   \u0027someNonUuidProjectId\u0027)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def test_project_scoped_payload_with_16_char_non_uuid_user_id(self):"},{"line_number":446,"context_line":"        self._test_project_scoped_payload_with_ids(\u00270123456789abcdef\u0027,"},{"line_number":447,"context_line":"                                                   \u00270123456789abcdef\u0027)"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a2ca52d_d03b1dd0","line":445,"in_reply_to":"5a2ca52d_e3f3fe08","updated":"2015-10-14 16:41:26.000000000","message":"Good point, I\u0027ll do another patch that updates the name of the test.","commit_id":"794e1510cc91fbe0277e291bc2cabdfba478bef3"}],"keystone/token/providers/fernet/token_formatters.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"34ae642c1631f6a27d416c0985bdab5048cb530e","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        \"\"\"Attempt to convert value to bytes or return value."},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        :param value: value to attempt to convert to bytes"},{"line_number":341,"context_line":"        :returns: (whether uuid converted, uuid value in bytes or value)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a2fa921_9c495b8e","line":341,"updated":"2015-10-06 14:48:11.000000000","message":"we could explicitly say that this returns a tuple.","commit_id":"7a7bc1d2b28752388ad37bebd74a593fdb9dc3df"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"5f377413f50b5d71629aa0717d90aec8a07310d0","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        \"\"\"Attempt to convert value to bytes or return value."},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        :param value: value to attempt to convert to bytes"},{"line_number":341,"context_line":"        :returns: (whether uuid converted, uuid value in bytes or value)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a2fa921_183f85d7","line":341,"in_reply_to":"7a2fa921_9c495b8e","updated":"2015-10-06 20:47:33.000000000","message":"Done","commit_id":"7a7bc1d2b28752388ad37bebd74a593fdb9dc3df"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cf2b69534c93de30b742b40915f828478e6acbdf","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                 audit_ids"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        \"\"\""},{"line_number":396,"context_line":"        (is_uuid, user_id) \u003d payload[0]"},{"line_number":397,"context_line":"        if is_uuid:"},{"line_number":398,"context_line":"            user_id \u003d cls.attempt_convert_uuid_bytes_to_hex(user_id)"},{"line_number":399,"context_line":"        methods \u003d auth_plugins.convert_integer_to_method_list(payload[1])"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_d34ea795","line":396,"updated":"2015-10-07 16:26:43.000000000","message":"nit: we could name the is_uuid variable to something like is_stored_as_bytes, since the boolean is there to determine if the value was in fact converted from hex to bytes. The is_uuid variable name makes it seem like we\u0027re actually doing an isinstance() check to determine that value.","commit_id":"8b97bab9fd01d10ede5b3820f145d3cae4779235"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"91a5bec17b32916db006dbfead0270394aeb7872","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                 audit_ids"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        \"\"\""},{"line_number":396,"context_line":"        (is_uuid, user_id) \u003d payload[0]"},{"line_number":397,"context_line":"        if is_uuid:"},{"line_number":398,"context_line":"            user_id \u003d cls.attempt_convert_uuid_bytes_to_hex(user_id)"},{"line_number":399,"context_line":"        methods \u003d auth_plugins.convert_integer_to_method_list(payload[1])"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_e6f99181","line":396,"in_reply_to":"7a2fa921_d34ea795","updated":"2015-10-07 21:51:01.000000000","message":"Done","commit_id":"8b97bab9fd01d10ede5b3820f145d3cae4779235"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"15bb4fd6ce08ec6e7e40ac1cad7a341a3eac62ef","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        \"\"\""},{"line_number":408,"context_line":"        (is_stored_as_bytes, user_id) \u003d payload[0]"},{"line_number":409,"context_line":"        if is_stored_as_bytes:"},{"line_number":410,"context_line":"            user_id \u003d cls.attempt_convert_uuid_bytes_to_hex(user_id)"},{"line_number":411,"context_line":"        methods \u003d auth_plugins.convert_integer_to_method_list(payload[1])"},{"line_number":412,"context_line":"        expires_at_str \u003d cls._convert_float_to_time_string(payload[2])"},{"line_number":413,"context_line":"        audit_ids \u003d list(map(provider.base64_encode, payload[3]))"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a2ca52d_71f258d4","line":410,"updated":"2015-10-14 13:46:35.000000000","message":"As we do know it is as bytes, we could be using the method convert_uuid_bytes_to_hex instead of attempt_convert_uuid_bytes_to_hex.\n\nThis applies to all the occurrences below. In this case, the method attempt_convert_uuid_bytes_to_hex wouldn\u0027t be needed anymore.","commit_id":"794e1510cc91fbe0277e291bc2cabdfba478bef3"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"49d6f0c824fb0a6aa4d041786df81db4fc2b2a19","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        \"\"\""},{"line_number":408,"context_line":"        (is_stored_as_bytes, user_id) \u003d payload[0]"},{"line_number":409,"context_line":"        if is_stored_as_bytes:"},{"line_number":410,"context_line":"            user_id \u003d cls.attempt_convert_uuid_bytes_to_hex(user_id)"},{"line_number":411,"context_line":"        methods \u003d auth_plugins.convert_integer_to_method_list(payload[1])"},{"line_number":412,"context_line":"        expires_at_str \u003d cls._convert_float_to_time_string(payload[2])"},{"line_number":413,"context_line":"        audit_ids \u003d list(map(provider.base64_encode, payload[3]))"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a2ca52d_751c7b77","line":410,"in_reply_to":"5a2ca52d_71f258d4","updated":"2015-10-14 16:41:26.000000000","message":"True, I\u0027ll post a follow up patch.","commit_id":"794e1510cc91fbe0277e291bc2cabdfba478bef3"}]}