)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"2cc742a8b3289928a2642e6862aa49a69754761e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are several issues in the docstring, the format is not"},{"line_number":10,"context_line":"correct, not using the full path of class etc."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch correct all of them, so the docstring will be rendered"},{"line_number":13,"context_line":"correctly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I04d5818f38b5e75b6f6197ef5e13dcd64ed91bf4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a26ad4f_3bcb5f20","line":12,"updated":"2015-10-29 02:36:46.000000000","message":"s/correct/corrects","commit_id":"7c87fc78a8aa59b297565e896fdc36f41c624865"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"31ab16d8998a45f890e4d1cde4db154c2d34d72f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are several issues in the docstring, the format is not"},{"line_number":10,"context_line":"correct, not using the full path of class etc."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch correct all of them, so the docstring will be rendered"},{"line_number":13,"context_line":"correctly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I04d5818f38b5e75b6f6197ef5e13dcd64ed91bf4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a26ad4f_7b547720","line":12,"in_reply_to":"1a26ad4f_3bcb5f20","updated":"2015-10-29 02:39:45.000000000","message":"Done","commit_id":"7c87fc78a8aa59b297565e896fdc36f41c624865"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"2cc742a8b3289928a2642e6862aa49a69754761e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This patch correct all of them, so the docstring will be rendered"},{"line_number":13,"context_line":"correctly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I04d5818f38b5e75b6f6197ef5e13dcd64ed91bf4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a26ad4f_5babbb1d","line":15,"updated":"2015-10-29 02:36:46.000000000","message":"Guess we should\u0027ve a bug report showing that this docstring is really wrongly rendered and mention it here","commit_id":"7c87fc78a8aa59b297565e896fdc36f41c624865"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"31ab16d8998a45f890e4d1cde4db154c2d34d72f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This patch correct all of them, so the docstring will be rendered"},{"line_number":13,"context_line":"correctly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I04d5818f38b5e75b6f6197ef5e13dcd64ed91bf4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a26ad4f_bb5a0f4f","line":15,"in_reply_to":"1a26ad4f_5babbb1d","updated":"2015-10-29 02:39:45.000000000","message":"docstring is not operator or end user refer to, but the developer.","commit_id":"7c87fc78a8aa59b297565e896fdc36f41c624865"}],"keystone/assignment/core.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"05e995635cb6cffbbefb65b014b5440e7c3ec23f","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"        \"\"\"Updates an existing role."},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"        :raises keystone.exception.RoleNotFound: If role with the specific"},{"line_number":1300,"context_line":"                `role_id` doesn\u0027t exist."},{"line_number":1301,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry is already"},{"line_number":1302,"context_line":"                existing."},{"line_number":1303,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_b34ebd94","line":1300,"updated":"2015-10-02 16:18:32.000000000","message":"tabbed in to far","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"        \"\"\"Updates an existing role."},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"        :raises keystone.exception.RoleNotFound: If role with the specific"},{"line_number":1300,"context_line":"                `role_id` doesn\u0027t exist."},{"line_number":1301,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry is already"},{"line_number":1302,"context_line":"                existing."},{"line_number":1303,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_977c46ed","line":1300,"in_reply_to":"9a1a9d01_b34ebd94","updated":"2015-10-09 07:04:25.000000000","message":"Done","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"05e995635cb6cffbbefb65b014b5440e7c3ec23f","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"        :raises keystone.exception.RoleNotFound: If role with the specific"},{"line_number":1300,"context_line":"                `role_id` doesn\u0027t exist."},{"line_number":1301,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry is already"},{"line_number":1302,"context_line":"                existing."},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        \"\"\""},{"line_number":1305,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_5343a16c","line":1302,"updated":"2015-10-02 16:18:32.000000000","message":"tabbed in to far","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"        :raises keystone.exception.RoleNotFound: If role with the specific"},{"line_number":1300,"context_line":"                `role_id` doesn\u0027t exist."},{"line_number":1301,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry is already"},{"line_number":1302,"context_line":"                existing."},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        \"\"\""},{"line_number":1305,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_57822ec9","line":1302,"in_reply_to":"9a1a9d01_5343a16c","updated":"2015-10-09 07:04:25.000000000","message":"Done","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"05e995635cb6cffbbefb65b014b5440e7c3ec23f","unresolved":false,"context_lines":[{"line_number":1309,"context_line":"        \"\"\"Deletes an existing role."},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"        :raises keystone.exception.RoleNotFound: If role with the specific"},{"line_number":1312,"context_line":"                `role_id` doesn\u0027t exist."},{"line_number":1313,"context_line":""},{"line_number":1314,"context_line":"        \"\"\""},{"line_number":1315,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_135e8945","line":1312,"updated":"2015-10-02 16:18:32.000000000","message":"tabbed in to far","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":1309,"context_line":"        \"\"\"Deletes an existing role."},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"        :raises keystone.exception.RoleNotFound: If role with the specific"},{"line_number":1312,"context_line":"                `role_id` doesn\u0027t exist."},{"line_number":1313,"context_line":""},{"line_number":1314,"context_line":"        \"\"\""},{"line_number":1315,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_9763e641","line":1312,"in_reply_to":"9a1a9d01_135e8945","updated":"2015-10-09 07:04:25.000000000","message":"Done","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        \"\"\"Checks an assignment/grant role id."},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        :raises keystone.exception.RoleAssignmentNotFound: If the role"},{"line_number":1004,"context_line":"            assignment doesn\u0027t exist."},{"line_number":1005,"context_line":"        :returns: None or raises an exception if grant not found"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_79cdf483","line":1004,"updated":"2015-10-21 17:13:28.000000000","message":"To keep the pattern that you made before, can be something like \"If role assignment tuple with the specific `role_id`, `target_id` `actor_id` doesn\u0027t exist.\"","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0149a9be3f614c63720ac136bdb69eed05075903","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        \"\"\"Checks an assignment/grant role id."},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        :raises keystone.exception.RoleAssignmentNotFound: If the role"},{"line_number":1004,"context_line":"            assignment doesn\u0027t exist."},{"line_number":1005,"context_line":"        :returns: None or raises an exception if grant not found"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_950e8539","line":1004,"in_reply_to":"3a29b11f_79cdf483","updated":"2015-10-22 01:31:48.000000000","message":"i think we need not to be consistent at this point, but i am happy to do the update if the comments here is not understandable.\n\nif we update this, we need also update huge places, this is not what this patch want to address.","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"        \"\"\"Deletes assignments/grants."},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"        :raises keystone.exception.RoleAssignmentNotFound: If the role"},{"line_number":1017,"context_line":"            assignment doesn\u0027t exist."},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":"        \"\"\""},{"line_number":1020,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_d9a208ae","line":1017,"updated":"2015-10-21 17:13:28.000000000","message":"same here","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0149a9be3f614c63720ac136bdb69eed05075903","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"        \"\"\"Deletes assignments/grants."},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"        :raises keystone.exception.RoleAssignmentNotFound: If the role"},{"line_number":1017,"context_line":"            assignment doesn\u0027t exist."},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":"        \"\"\""},{"line_number":1020,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_10012305","line":1017,"in_reply_to":"3a29b11f_d9a208ae","updated":"2015-10-22 01:31:48.000000000","message":"ditto","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"        :raises keystone.exception.RoleNotFound: If role with the specific"},{"line_number":1300,"context_line":"            `role_id` doesn\u0027t exist."},{"line_number":1301,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry is already"},{"line_number":1302,"context_line":"            existing."},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_9996d03c","line":1301,"updated":"2015-10-21 17:13:28.000000000","message":"\"A entry with this values is already existing\" (or anything similar) makes more sense to me, since if the duplicated entry is already existing, we already have a db error.","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5b1ff54f0ab27962264f3ae770f337bb25411f8d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        inheritance."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :returns: a list of role ids."},{"line_number":94,"context_line":"        :raises keystone.exception.ProjectNotFound: If project with the"},{"line_number":95,"context_line":"            specific `project_id` doesn\u0027t exist."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_cd1e780b","line":94,"updated":"2015-11-12 14:27:52.000000000","message":"Change \"If project\" to \"If a project\".\n\nThis comment applies to all these changes.","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c8389e3a49cd57c320f349ddc007a23125dbafdf","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        inheritance."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :returns: a list of role ids."},{"line_number":94,"context_line":"        :raises keystone.exception.ProjectNotFound: If project with the"},{"line_number":95,"context_line":"            specific `project_id` doesn\u0027t exist."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_c66c16d2","line":94,"in_reply_to":"da85f559_cd1e780b","updated":"2015-11-12 21:51:07.000000000","message":"Done","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5b1ff54f0ab27962264f3ae770f337bb25411f8d","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :returns: a list of role ids."},{"line_number":94,"context_line":"        :raises keystone.exception.ProjectNotFound: If project with the"},{"line_number":95,"context_line":"            specific `project_id` doesn\u0027t exist."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        self.resource_api.get_project(tenant_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_cd70b874","line":95,"updated":"2015-11-12 14:27:52.000000000","message":"remove \"specific\" from all these. Or change it to \"supplied\" or \"given\".\n\nThis comment applies to all these changes.","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c8389e3a49cd57c320f349ddc007a23125dbafdf","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :returns: a list of role ids."},{"line_number":94,"context_line":"        :raises keystone.exception.ProjectNotFound: If project with the"},{"line_number":95,"context_line":"            specific `project_id` doesn\u0027t exist."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        self.resource_api.get_project(tenant_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_e6cb5aa2","line":95,"in_reply_to":"da85f559_cd70b874","updated":"2015-11-12 21:51:07.000000000","message":"Done","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5b1ff54f0ab27962264f3ae770f337bb25411f8d","unresolved":false,"context_lines":[{"line_number":863,"context_line":"        \"\"\"Add a role to a user within given tenant."},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry is already"},{"line_number":866,"context_line":"            existing."},{"line_number":867,"context_line":""},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_2d0864d9","line":866,"updated":"2015-11-12 14:27:52.000000000","message":"change \"already existing\" to \"exists\".\n\nThis applies to all these changes.","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c8389e3a49cd57c320f349ddc007a23125dbafdf","unresolved":false,"context_lines":[{"line_number":863,"context_line":"        \"\"\"Add a role to a user within given tenant."},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry is already"},{"line_number":866,"context_line":"            existing."},{"line_number":867,"context_line":""},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_c633b660","line":866,"in_reply_to":"da85f559_2d0864d9","updated":"2015-11-12 21:51:07.000000000","message":"Done","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8439904fb15ad58cd84dd826401cc049a84233b9","unresolved":false,"context_lines":[{"line_number":859,"context_line":"    def add_role_to_user_and_project(self, user_id, tenant_id, role_id):"},{"line_number":860,"context_line":"        \"\"\"Add a role to a user within given tenant."},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry exists."},{"line_number":863,"context_line":""},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_c931270d","line":862,"updated":"2015-11-17 16:18:56.000000000","message":"change \"duplicated\" to \"duplicate\"\n\nAlso, change \"entry\" to \"role assignment\".\n\nThis applies in other places that added a Conflict description, too.","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d060b78b7a338711de52de18eeb0f98686b1ae0f","unresolved":false,"context_lines":[{"line_number":859,"context_line":"    def add_role_to_user_and_project(self, user_id, tenant_id, role_id):"},{"line_number":860,"context_line":"        \"\"\"Add a role to a user within given tenant."},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry exists."},{"line_number":863,"context_line":""},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_3fab2cd8","line":862,"in_reply_to":"ba8a016a_c931270d","updated":"2015-11-23 21:37:36.000000000","message":"Done","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"}],"keystone/auth/plugins/mapped.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"2d2102c7dfc66f83a810ba38ee37324d848d5eff","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    :param mapped_properties: Properties issued by a RuleProcessor."},{"line_number":226,"context_line":"    :type: dictionary"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    :raises keystone.exception.Unauthorized: for authentication failure"},{"line_number":229,"context_line":"    :returns: dictionary with user identification"},{"line_number":230,"context_line":"    :rtype: dict"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_35df820e","line":228,"updated":"2015-09-29 19:15:51.000000000","message":"maybe: \"If neither user_name nor user_id is set\"\n\nIt explains it next to #1 on line number 219","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ba97f7beda0a56c5875e414faad6639f69702b78","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    :param mapped_properties: Properties issued by a RuleProcessor."},{"line_number":226,"context_line":"    :type: dictionary"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    :raises keystone.exception.Unauthorized: for authentication failure"},{"line_number":229,"context_line":"    :returns: dictionary with user identification"},{"line_number":230,"context_line":"    :rtype: dict"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_757088a4","line":228,"in_reply_to":"9a1a9d01_35df820e","updated":"2015-09-30 07:01:51.000000000","message":"Done","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"05e995635cb6cffbbefb65b014b5440e7c3ec23f","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    :type: dictionary"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    :raises keystone.exception.Unauthorized: If neither user_name nor"},{"line_number":229,"context_line":"            user_id is set."},{"line_number":230,"context_line":"    :returns: dictionary with user identification"},{"line_number":231,"context_line":"    :rtype: dict"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_9317f953","line":229,"updated":"2015-10-02 16:18:32.000000000","message":"tabbed in to far","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    :type: dictionary"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    :raises keystone.exception.Unauthorized: If neither user_name nor"},{"line_number":229,"context_line":"            user_id is set."},{"line_number":230,"context_line":"    :returns: dictionary with user identification"},{"line_number":231,"context_line":"    :rtype: dict"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_77d3aad5","line":229,"in_reply_to":"9a1a9d01_9317f953","updated":"2015-10-09 07:04:25.000000000","message":"Done","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"}],"keystone/catalog/core.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"a6e9a3db6f3f44e4d13ded8c6aab6b5c1938976f","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        \"\"\"Creates a new region."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        :raises keystone.exception.Conflict"},{"line_number":308,"context_line":"        :raises keystone.exception.RegionNotFound: if parent region invalid"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        \"\"\""},{"line_number":311,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5aadfbe7","line":308,"updated":"2015-09-25 16:47:50.000000000","message":"s/if/If  -\u003e for consistency :)","commit_id":"bc18b8cf1b8d794ab262c2d3c9b6ab29ca3232bc"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"53e3e8600bd69b0a7d6c465e5377dcaf5b5cb8c6","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        \"\"\"Creates a new region."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        :raises keystone.exception.Conflict"},{"line_number":308,"context_line":"        :raises keystone.exception.RegionNotFound: if parent region invalid"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        \"\"\""},{"line_number":311,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_1e10c4a7","line":308,"in_reply_to":"9a1a9d01_5aadfbe7","updated":"2015-09-26 10:21:37.000000000","message":"I am going to update part of them and keep rest of them as is since it is not capital before or after in the same section for some of them, this depends on the conext of these docstring. \n\nDue to the same reason, consistency :)","commit_id":"bc18b8cf1b8d794ab262c2d3c9b6ab29ca3232bc"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"90d2c9d8b16c37301a085cde35338294fce3309e","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        \"\"\"Get region by id."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        :returns: region_ref dict"},{"line_number":331,"context_line":"        :raises keystone.exception.RegionNotFound: If region with the specific"},{"line_number":332,"context_line":"                `region_id` doesn\u0027t exist."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_dd0340b7","line":331,"updated":"2015-09-25 19:11:37.000000000","message":"Shouldn\u0027t it be  \":raises: keystone.exception.RegionNotFound If .....\"\n\n(The colon before and after raises)","commit_id":"bc18b8cf1b8d794ab262c2d3c9b6ab29ca3232bc"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"53e3e8600bd69b0a7d6c465e5377dcaf5b5cb8c6","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        \"\"\"Get region by id."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        :returns: region_ref dict"},{"line_number":331,"context_line":"        :raises keystone.exception.RegionNotFound: If region with the specific"},{"line_number":332,"context_line":"                `region_id` doesn\u0027t exist."},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5e64fc47","line":331,"in_reply_to":"9a1a9d01_dd0340b7","updated":"2015-09-26 10:21:37.000000000","message":"I don\u0027t think so, you can generate the doc and see whether it is necessary.","commit_id":"bc18b8cf1b8d794ab262c2d3c9b6ab29ca3232bc"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"2d2102c7dfc66f83a810ba38ee37324d848d5eff","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        :returns: service_ref dict"},{"line_number":386,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service doesn\u0027t"},{"line_number":387,"context_line":"                                                    exist."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        \"\"\""},{"line_number":390,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_55da364d","line":387,"updated":"2015-09-29 19:15:51.000000000","message":"nit, should this be the same indentation as the above fix?","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ba97f7beda0a56c5875e414faad6639f69702b78","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        :returns: service_ref dict"},{"line_number":386,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service doesn\u0027t"},{"line_number":387,"context_line":"                                                    exist."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        \"\"\""},{"line_number":390,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_55a46406","line":387,"in_reply_to":"9a1a9d01_55da364d","updated":"2015-09-30 07:01:51.000000000","message":"Done","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"2d2102c7dfc66f83a810ba38ee37324d848d5eff","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        :returns: service_ref dict"},{"line_number":397,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service doesn\u0027t"},{"line_number":398,"context_line":"                                                    exist."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_d5cde685","line":398,"updated":"2015-09-29 19:15:51.000000000","message":"ditto","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ba97f7beda0a56c5875e414faad6639f69702b78","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        :returns: service_ref dict"},{"line_number":397,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service doesn\u0027t"},{"line_number":398,"context_line":"                                                    exist."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_35ae90e6","line":398,"in_reply_to":"9a1a9d01_d5cde685","updated":"2015-09-30 07:01:51.000000000","message":"Done","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"2d2102c7dfc66f83a810ba38ee37324d848d5eff","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        \"\"\"Deletes an existing service."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service doesn\u0027t"},{"line_number":408,"context_line":"                                                    exist."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        \"\"\""},{"line_number":411,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_35a302b4","line":408,"updated":"2015-09-29 19:15:51.000000000","message":"ditto","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ba97f7beda0a56c5875e414faad6639f69702b78","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        \"\"\"Deletes an existing service."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service doesn\u0027t"},{"line_number":408,"context_line":"                                                    exist."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        \"\"\""},{"line_number":411,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_f5b3384b","line":408,"in_reply_to":"9a1a9d01_35a302b4","updated":"2015-09-30 07:01:51.000000000","message":"Done","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        \"\"\"Get service by id."},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        :returns: service_ref dict"},{"line_number":386,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service doesn\u0027t"},{"line_number":387,"context_line":"                exist."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_67e0d0cd","line":386,"updated":"2015-09-30 14:09:54.000000000","message":"If the service with the specific service_id doesn\u0027t exist? \n\njust to be consistent with the other changes?","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        \"\"\"Get service by id."},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        :returns: service_ref dict"},{"line_number":386,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service doesn\u0027t"},{"line_number":387,"context_line":"                exist."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_9798c61d","line":386,"in_reply_to":"9a1a9d01_67e0d0cd","updated":"2015-10-09 07:04:25.000000000","message":"sure.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        \"\"\"Update service by id."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        :returns: service_ref dict"},{"line_number":397,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service doesn\u0027t"},{"line_number":398,"context_line":"                exist."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_870ac488","line":397,"updated":"2015-09-30 14:09:54.000000000","message":"same comment applies to the rest of these","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        \"\"\"Update service by id."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        :returns: service_ref dict"},{"line_number":397,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service doesn\u0027t"},{"line_number":398,"context_line":"                exist."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_3788d2c4","line":397,"in_reply_to":"9a1a9d01_870ac488","updated":"2015-10-09 07:04:25.000000000","message":"Done","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        \"\"\"Creates a new service."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry already"},{"line_number":363,"context_line":"            exists."},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        \"\"\""},{"line_number":366,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_793e5429","line":363,"updated":"2015-10-21 17:13:28.000000000","message":"some comment that I made in assignment/core.py  for this case.","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        :returns: service_ref dict"},{"line_number":386,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service with the"},{"line_number":387,"context_line":"            specific service_id doesn\u0027t exist."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        \"\"\""},{"line_number":390,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_592838e2","line":387,"updated":"2015-10-21 17:13:28.000000000","message":"s/service_id/`service_id` and the same comment for the other cases on this file","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0149a9be3f614c63720ac136bdb69eed05075903","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        :returns: service_ref dict"},{"line_number":386,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service with the"},{"line_number":387,"context_line":"            specific service_id doesn\u0027t exist."},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        \"\"\""},{"line_number":390,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_5049db5e","line":387,"in_reply_to":"3a29b11f_592838e2","updated":"2015-10-22 01:31:48.000000000","message":"Done","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"1212c5d848809f08b1332a8feaa14d1673cb3d6e","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        \"\"\"Creates a new endpoint for a service."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry already"},{"line_number":418,"context_line":"                exists."},{"line_number":419,"context_line":"        :raises keystone.exception.ServiceNotFound: If the service with the"},{"line_number":420,"context_line":"            specific `service_id` doesn\u0027t exist."},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a29b11f_d3571c56","line":418,"updated":"2015-10-22 14:33:42.000000000","message":"This is indented 8 spaces when it should be 4.","commit_id":"9e9a3a9321a30a157a69085c992fd06c1ad91ac9"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"1212c5d848809f08b1332a8feaa14d1673cb3d6e","unresolved":false,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        :returns: endpoint_ref dict"},{"line_number":430,"context_line":"        :raises keystone.exception.EndpointNotFound: If the endpoint doesn\u0027t"},{"line_number":431,"context_line":"                exist."},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        \"\"\""},{"line_number":434,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a29b11f_b3df00d5","line":431,"updated":"2015-10-22 14:33:42.000000000","message":"This is also indented 8 spaces when it should be 4.","commit_id":"9e9a3a9321a30a157a69085c992fd06c1ad91ac9"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5b1ff54f0ab27962264f3ae770f337bb25411f8d","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        \"\"\"Creates a new region."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        :raises keystone.exception.Conflict: If the region already exists."},{"line_number":334,"context_line":"        :raises keystone.exception.RegionNotFound: If parent region invalid."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        \"\"\""},{"line_number":337,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_0d9b2067","line":334,"updated":"2015-11-12 14:27:52.000000000","message":"change \"If parent region invalid.\" to \"If the parent region is invalid.\"","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c8389e3a49cd57c320f349ddc007a23125dbafdf","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        \"\"\"Creates a new region."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        :raises keystone.exception.Conflict: If the region already exists."},{"line_number":334,"context_line":"        :raises keystone.exception.RegionNotFound: If parent region invalid."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        \"\"\""},{"line_number":337,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_a0dbe44e","line":334,"in_reply_to":"da85f559_0d9b2067","updated":"2015-11-12 21:51:07.000000000","message":"Done","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f2d9d46050a88e70baf1e78c8514b2a354bcccd7","unresolved":false,"context_lines":[{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        :param project_id: identity of project to associate"},{"line_number":771,"context_line":"        :type project_id: string"},{"line_number":772,"context_line":"        :raises: exception.NotFound"},{"line_number":773,"context_line":"        :returns: None."},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_992fd13d","side":"PARENT","line":772,"updated":"2015-11-23 22:36:44.000000000","message":"why was this removed?","commit_id":"fc123debfd0e6ac9c6bcbe0cf450fdddad71100a"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"57ff9b5ff2990ebbab743569ae261ed8779875f3","unresolved":false,"context_lines":[{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        :param project_id: identity of project to associate"},{"line_number":771,"context_line":"        :type project_id: string"},{"line_number":772,"context_line":"        :raises: exception.NotFound"},{"line_number":773,"context_line":"        :returns: None."},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_f954dd54","side":"PARENT","line":772,"in_reply_to":"ba8a016a_992fd13d","updated":"2015-11-23 22:45:55.000000000","message":"I remove them intentionally, go though the code and found there is no exception raised anywhere.","commit_id":"fc123debfd0e6ac9c6bcbe0cf450fdddad71100a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f2d9d46050a88e70baf1e78c8514b2a354bcccd7","unresolved":false,"context_lines":[{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        :param endpoint_group_id: identity of endpoint to associate"},{"line_number":783,"context_line":"        :type endpoint_group_id: string"},{"line_number":784,"context_line":"        :raises: exception.NotFound"},{"line_number":785,"context_line":"        :returns: None."},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_59296936","side":"PARENT","line":784,"updated":"2015-11-23 22:36:44.000000000","message":"why was this removed?","commit_id":"fc123debfd0e6ac9c6bcbe0cf450fdddad71100a"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"57ff9b5ff2990ebbab743569ae261ed8779875f3","unresolved":false,"context_lines":[{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        :param endpoint_group_id: identity of endpoint to associate"},{"line_number":783,"context_line":"        :type endpoint_group_id: string"},{"line_number":784,"context_line":"        :raises: exception.NotFound"},{"line_number":785,"context_line":"        :returns: None."},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_b94e55bf","side":"PARENT","line":784,"in_reply_to":"ba8a016a_59296936","updated":"2015-11-23 22:45:55.000000000","message":"same here.","commit_id":"fc123debfd0e6ac9c6bcbe0cf450fdddad71100a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f2d9d46050a88e70baf1e78c8514b2a354bcccd7","unresolved":false,"context_lines":[{"line_number":812,"context_line":"        :param project_id: identity of project to associate"},{"line_number":813,"context_line":"        :type project_id: string"},{"line_number":814,"context_line":"        :raises keystone.exception.NotFound: If endpoint group project"},{"line_number":815,"context_line":"            association was not found."},{"line_number":816,"context_line":"        :returns: None."},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_39b4a5f0","line":815,"updated":"2015-11-23 22:36:44.000000000","message":"surprising this isn\u0027t EndpointNotFound and ProjectNotFound.","commit_id":"f8ee2ba78a1b792f4627e9ea9147f2dec456e900"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"57ff9b5ff2990ebbab743569ae261ed8779875f3","unresolved":false,"context_lines":[{"line_number":812,"context_line":"        :param project_id: identity of project to associate"},{"line_number":813,"context_line":"        :type project_id: string"},{"line_number":814,"context_line":"        :raises keystone.exception.NotFound: If endpoint group project"},{"line_number":815,"context_line":"            association was not found."},{"line_number":816,"context_line":"        :returns: None."},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_79954de2","line":815,"in_reply_to":"ba8a016a_39b4a5f0","updated":"2015-11-23 22:45:55.000000000","message":"double checked again, it\u0027s Endpoint Group Project Association not found.\n\nsee: https://github.com/openstack/keystone/blob/master/keystone/catalog/backends/sql.py#L505-L510","commit_id":"f8ee2ba78a1b792f4627e9ea9147f2dec456e900"}],"keystone/cmd/cli.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                             specific configurations defined"},{"line_number":373,"context_line":"        :raises Exceptions from oslo config: there is an issue with options"},{"line_number":374,"context_line":"                                              defined in the config file or its"},{"line_number":375,"context_line":"                                              format"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        The caller of this method should catch the errors raised and handle"},{"line_number":378,"context_line":"        appropriately in order that the best UX experience can be provided for"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_677c50ec","line":375,"updated":"2015-09-30 14:09:54.000000000","message":"lines 374 and 375 will need to be re-aligned with the indexing on line 373.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                             specific configurations defined"},{"line_number":373,"context_line":"        :raises Exceptions from oslo config: there is an issue with options"},{"line_number":374,"context_line":"                                              defined in the config file or its"},{"line_number":375,"context_line":"                                              format"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        The caller of this method should catch the errors raised and handle"},{"line_number":378,"context_line":"        appropriately in order that the best UX experience can be provided for"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_973446fc","line":375,"in_reply_to":"9a1a9d01_677c50ec","updated":"2015-10-09 07:04:25.000000000","message":"Done","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        :param file_name: the file containing the config options"},{"line_number":369,"context_line":"        :param domain_name: the domain name"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        :raises ValueError: the domain does not exist or already has domain"},{"line_number":372,"context_line":"            specific configurations defined."},{"line_number":373,"context_line":"        :raises Exceptions from oslo config: there is an issue with options"},{"line_number":374,"context_line":"            defined in the config file or its format."}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_796c1435","line":371,"updated":"2015-10-21 17:13:28.000000000","message":": The domain (...)","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0149a9be3f614c63720ac136bdb69eed05075903","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        :param file_name: the file containing the config options"},{"line_number":369,"context_line":"        :param domain_name: the domain name"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        :raises ValueError: the domain does not exist or already has domain"},{"line_number":372,"context_line":"            specific configurations defined."},{"line_number":373,"context_line":"        :raises Exceptions from oslo config: there is an issue with options"},{"line_number":374,"context_line":"            defined in the config file or its format."}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_b0670fe8","line":371,"in_reply_to":"3a29b11f_796c1435","updated":"2015-10-22 01:31:48.000000000","message":"do you notice all of the sentences here is started with lowercase?","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        :raises ValueError: the domain does not exist or already has domain"},{"line_number":372,"context_line":"            specific configurations defined."},{"line_number":373,"context_line":"        :raises Exceptions from oslo config: there is an issue with options"},{"line_number":374,"context_line":"            defined in the config file or its format."},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        The caller of this method should catch the errors raised and handle"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_3949bcb7","line":373,"updated":"2015-10-21 17:13:28.000000000","message":": There is (...)","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f2d9d46050a88e70baf1e78c8514b2a354bcccd7","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        :raises ValueError: the domain does not exist or already has domain"},{"line_number":374,"context_line":"            specific configurations defined."},{"line_number":375,"context_line":"        :raises Exceptions from oslo config: there is an issue with options"},{"line_number":376,"context_line":"            defined in the config file or its format."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        The caller of this method should catch the errors raised and handle"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_d9c31956","line":375,"updated":"2015-11-23 22:36:44.000000000","message":"the argument should be an exception class.","commit_id":"f8ee2ba78a1b792f4627e9ea9147f2dec456e900"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"57ff9b5ff2990ebbab743569ae261ed8779875f3","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        :raises ValueError: the domain does not exist or already has domain"},{"line_number":374,"context_line":"            specific configurations defined."},{"line_number":375,"context_line":"        :raises Exceptions from oslo config: there is an issue with options"},{"line_number":376,"context_line":"            defined in the config file or its format."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        The caller of this method should catch the errors raised and handle"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_d98eb9cf","line":375,"in_reply_to":"ba8a016a_d9c31956","updated":"2015-11-23 22:45:55.000000000","message":"correct, will address in the follow-up.","commit_id":"f8ee2ba78a1b792f4627e9ea9147f2dec456e900"}],"keystone/common/base64utils.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"9c0745aac8a2e07284dfeb39fea19c6c9ddcc184","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_8cb9c27b","line":1,"updated":"2015-10-21 12:37:36.000000000","message":"Is this file suppose to be part of this patch","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0149a9be3f614c63720ac136bdb69eed05075903","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_30a21ffe","line":1,"in_reply_to":"3a29b11f_8cb9c27b","updated":"2015-10-22 01:31:48.000000000","message":"trouble with get rebase.","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"}],"keystone/common/cache/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    :param region: optional CacheRegion object, if not provided a new region"},{"line_number":126,"context_line":"                   will be instantiated"},{"line_number":127,"context_line":"    :raises keystone.exception.ValidationError: attribute validation failed."},{"line_number":128,"context_line":"    :returns: dogpile.cache.CacheRegion"},{"line_number":129,"context_line":"    \"\"\""},{"line_number":130,"context_line":"    if not isinstance(region, dogpile.cache.CacheRegion):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_e7de20dc","line":127,"updated":"2015-09-30 14:09:54.000000000","message":"are we suppose to add punctuation to raise messages? This is super nit picky, just curious if we have a convention for it since I some doc strings with it and some without.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    :param region: optional CacheRegion object, if not provided a new region"},{"line_number":126,"context_line":"                   will be instantiated"},{"line_number":127,"context_line":"    :raises keystone.exception.ValidationError: attribute validation failed."},{"line_number":128,"context_line":"    :returns: dogpile.cache.CacheRegion"},{"line_number":129,"context_line":"    \"\"\""},{"line_number":130,"context_line":"    if not isinstance(region, dogpile.cache.CacheRegion):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_820ba223","line":127,"in_reply_to":"9a1a9d01_e7de20dc","updated":"2015-10-09 07:04:25.000000000","message":"there is no convention about this IMO, and this is not the scope of this patch. I will add the punctuation to where it looks like a complete sentence.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"}],"keystone/common/ldap/core.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"a6e9a3db6f3f44e4d13ded8c6aab6b5c1938976f","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    :param value: A basestring"},{"line_number":64,"context_line":"    :returns: UTF-8 encoded version of value"},{"line_number":65,"context_line":"    :raises TypeError: if value is not basestring"},{"line_number":66,"context_line":"    \"\"\""},{"line_number":67,"context_line":"    if isinstance(value, six.text_type):"},{"line_number":68,"context_line":"        return _utf8_encoder(value)[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_da87cb5f","line":65,"updated":"2015-09-25 16:47:50.000000000","message":"s/if/If  -\u003e for consistency :)","commit_id":"bc18b8cf1b8d794ab262c2d3c9b6ab29ca3232bc"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"53e3e8600bd69b0a7d6c465e5377dcaf5b5cb8c6","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    :param value: A basestring"},{"line_number":64,"context_line":"    :returns: UTF-8 encoded version of value"},{"line_number":65,"context_line":"    :raises TypeError: if value is not basestring"},{"line_number":66,"context_line":"    \"\"\""},{"line_number":67,"context_line":"    if isinstance(value, six.text_type):"},{"line_number":68,"context_line":"        return _utf8_encoder(value)[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_3e61083a","line":65,"in_reply_to":"9a1a9d01_da87cb5f","updated":"2015-09-26 10:21:37.000000000","message":"this is what is was but I am happy to update this.","commit_id":"bc18b8cf1b8d794ab262c2d3c9b6ab29ca3232bc"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    :param value: value to be returned as unicode"},{"line_number":86,"context_line":"    :returns: value as unicode"},{"line_number":87,"context_line":"    :raises UnicodeDecodeError: for invalid UTF-8 encoding"},{"line_number":88,"context_line":"    \"\"\""},{"line_number":89,"context_line":"    if isinstance(value, six.binary_type):"},{"line_number":90,"context_line":"        return _utf8_decoder(value)[0]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_59dd98de","line":87,"updated":"2015-10-21 17:13:28.000000000","message":"For (...)","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"}],"keystone/common/utils.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"a6e9a3db6f3f44e4d13ded8c6aab6b5c1938976f","unresolved":false,"context_lines":[{"line_number":515,"context_line":"    \"\"\"Retrieves KeystoneToken object from the auth context and returns it."},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"    :param dict context: The request context."},{"line_number":518,"context_line":"    :raises keystone.exception.Unauthorized: if auth context cannot be found."},{"line_number":519,"context_line":"    :returns: The KeystoneToken object."},{"line_number":520,"context_line":"    \"\"\""},{"line_number":521,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_7a7c7f72","line":518,"updated":"2015-09-25 16:47:50.000000000","message":"s/if/If  -\u003e for consistency :)","commit_id":"bc18b8cf1b8d794ab262c2d3c9b6ab29ca3232bc"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"53e3e8600bd69b0a7d6c465e5377dcaf5b5cb8c6","unresolved":false,"context_lines":[{"line_number":515,"context_line":"    \"\"\"Retrieves KeystoneToken object from the auth context and returns it."},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"    :param dict context: The request context."},{"line_number":518,"context_line":"    :raises keystone.exception.Unauthorized: if auth context cannot be found."},{"line_number":519,"context_line":"    :returns: The KeystoneToken object."},{"line_number":520,"context_line":"    \"\"\""},{"line_number":521,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_fe5ab082","line":518,"in_reply_to":"9a1a9d01_7a7c7f72","updated":"2015-09-26 10:21:37.000000000","message":"Done","commit_id":"bc18b8cf1b8d794ab262c2d3c9b6ab29ca3232bc"}],"keystone/contrib/ec2/controllers.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        \"\"\"Return credentials from an ID."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        :param credential_id: id of credential"},{"line_number":252,"context_line":"        :raises keystone.exception.Unauthorized: when credential id is invalid"},{"line_number":253,"context_line":"        :returns: credential: dict of ec2 credential."},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        ec2_credential_id \u003d utils.hash_access_key(credential_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_ea758563","line":252,"updated":"2015-09-30 14:09:54.000000000","message":"punctuation, or no?","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        \"\"\"Return credentials from an ID."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        :param credential_id: id of credential"},{"line_number":252,"context_line":"        :raises keystone.exception.Unauthorized: when credential id is invalid"},{"line_number":253,"context_line":"        :returns: credential: dict of ec2 credential."},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        ec2_credential_id \u003d utils.hash_access_key(credential_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_a277be9e","line":252,"in_reply_to":"9a1a9d01_ea758563","updated":"2015-10-09 07:04:25.000000000","message":"I am really not sure how to do this since this is what it was, and if add the punctuation here we might be also need to change ton of places in other place.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        \"\"\"Return credentials from an ID."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        :param credential_id: id of credential"},{"line_number":252,"context_line":"        :raises keystone.exception.Unauthorized: when credential id is invalid"},{"line_number":253,"context_line":"        :returns: credential: dict of ec2 credential."},{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        ec2_credential_id \u003d utils.hash_access_key(credential_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_19fac043","line":252,"updated":"2015-10-21 17:13:28.000000000","message":"When (...)","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        :param context: standard context"},{"line_number":317,"context_line":"        :param user_id: id of user"},{"line_number":318,"context_line":"        :raises keystone.exception.Forbidden: when token is invalid"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        \"\"\""},{"line_number":321,"context_line":"        token_ref \u003d utils.get_token_ref(context)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_999c900f","line":318,"updated":"2015-10-21 17:13:28.000000000","message":"When (...)","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        :param user_id: expected credential owner"},{"line_number":345,"context_line":"        :param credential_id: id of credential object"},{"line_number":346,"context_line":"        :raises keystone.exception.Forbidden: on failure"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        ec2_credential_id \u003d utils.hash_access_key(credential_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_d9644823","line":346,"updated":"2015-10-21 17:13:28.000000000","message":"On Failure (...)","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"}],"keystone/contrib/endpoint_filter/core.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"2d2102c7dfc66f83a810ba38ee37324d848d5eff","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        :param endpoint_group_id: identity of endpoint group to retrieve"},{"line_number":176,"context_line":"        :type endpoint_group_id: string"},{"line_number":177,"context_line":"        :raises keystone.exception.NotFound: entity not found"},{"line_number":178,"context_line":"        :returns: an endpoint group representation."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_913ea389","line":177,"updated":"2015-09-29 19:15:51.000000000","message":"maybe: \"If the entity was not found\"  \n\nditto for the rest of \u0027NotFound\u0027 exceptions if you think its an adequate change.","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ba97f7beda0a56c5875e414faad6639f69702b78","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        :param endpoint_group_id: identity of endpoint group to retrieve"},{"line_number":176,"context_line":"        :type endpoint_group_id: string"},{"line_number":177,"context_line":"        :raises keystone.exception.NotFound: entity not found"},{"line_number":178,"context_line":"        :returns: an endpoint group representation."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_f58a5863","line":177,"in_reply_to":"9a1a9d01_913ea389","updated":"2015-09-30 07:01:51.000000000","message":"Done","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :type endpoint_id: string"},{"line_number":92,"context_line":"        :param project_id: identity of the project associated with"},{"line_number":93,"context_line":"        :type project_id: string"},{"line_number":94,"context_line":"        :raises keystone.exception.NotFound: entity not found"},{"line_number":95,"context_line":"        :returns: None."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_01af842a","line":94,"updated":"2015-09-30 13:46:23.000000000","message":"maybe \"If the entity was not found\" or since they are looking for an endpoint it could be \"If the endpoint doesn\u0027t exist.\" like you did in keystone/catalog/core.py.  But I\u0027m not 100% sure what to do since these are abstract methods and if they are not overrided they will raise a not implemented error.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :type endpoint_id: string"},{"line_number":92,"context_line":"        :param project_id: identity of the project associated with"},{"line_number":93,"context_line":"        :type project_id: string"},{"line_number":94,"context_line":"        :raises keystone.exception.NotFound: entity not found"},{"line_number":95,"context_line":"        :returns: None."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_aa19cd23","line":94,"in_reply_to":"9a1a9d01_01af842a","updated":"2015-09-30 14:09:54.000000000","message":"specifically if the entity ID isn\u0027t found, right?","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :type endpoint_id: string"},{"line_number":92,"context_line":"        :param project_id: identity of the project associated with"},{"line_number":93,"context_line":"        :type project_id: string"},{"line_number":94,"context_line":"        :raises keystone.exception.NotFound: entity not found"},{"line_number":95,"context_line":"        :returns: None."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_0250f2d2","line":94,"in_reply_to":"9a1a9d01_aa19cd23","updated":"2015-10-09 07:04:25.000000000","message":"we can do this since the code show us it\u0027s ProjectEndpoint not found, but we cannot do this for other occurrences since there might be different entities cannot be found where this method was implemented.\n\nAnd I don\u0027t postive to change the condition to \"endpoint doesn\u0027t exist\", if we do that we should update the class of exception as well and hence is not within the scope of the patch.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        :type endpoint_id: string"},{"line_number":106,"context_line":"        :param project_id: identity of the project associated with"},{"line_number":107,"context_line":"        :type project_id: string"},{"line_number":108,"context_line":"        :raises keystone.exception.NotFound: entity not found"},{"line_number":109,"context_line":"        :returns: None."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_a1a9f825","line":108,"updated":"2015-09-30 13:46:23.000000000","message":"Ditto","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        :type endpoint_id: string"},{"line_number":106,"context_line":"        :param project_id: identity of the project associated with"},{"line_number":107,"context_line":"        :type project_id: string"},{"line_number":108,"context_line":"        :raises keystone.exception.NotFound: entity not found"},{"line_number":109,"context_line":"        :returns: None."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_e2c7f661","line":108,"in_reply_to":"9a1a9d01_a1a9f825","updated":"2015-10-09 07:04:25.000000000","message":"Done","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        :param endpoint_group_id: identity of endpoint group to retrieve"},{"line_number":176,"context_line":"        :type endpoint_group_id: string"},{"line_number":177,"context_line":"        :raises keystone.exception.NotFound: If the entity not found."},{"line_number":178,"context_line":"        :returns: an endpoint group representation."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_216c0807","line":177,"updated":"2015-09-30 13:46:23.000000000","message":"Ditto","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        :type endpoint_group_id: string"},{"line_number":189,"context_line":"        :param endpoint_group: A full or partial endpoint_group"},{"line_number":190,"context_line":"        :type endpoint_group: dictionary"},{"line_number":191,"context_line":"        :raises keystone.exception.NotFound: If the entity not found."},{"line_number":192,"context_line":"        :returns: an endpoint group representation."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_416fbcfb","line":191,"updated":"2015-09-30 13:46:23.000000000","message":"Ditto","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        :param endpoint_group_id: identity of endpoint group to delete"},{"line_number":202,"context_line":"        :type endpoint_group_id: string"},{"line_number":203,"context_line":"        :raises keystone.exception.NotFound: If the entity not found."},{"line_number":204,"context_line":"        :returns: None."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_e17a90bc","line":203,"updated":"2015-09-30 13:46:23.000000000","message":"Ditto","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        :type endpoint_group_id: string"},{"line_number":230,"context_line":"        :param project_id: identity of project to associate"},{"line_number":231,"context_line":"        :type project_id: string"},{"line_number":232,"context_line":"        :raises keystone.exception.NotFound: If the entity not found."},{"line_number":233,"context_line":"        :returns: a project endpoint group representation."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_0176a4d6","line":232,"updated":"2015-09-30 13:46:23.000000000","message":"Ditto","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    def list_endpoint_groups(self):"},{"line_number":240,"context_line":"        \"\"\"List all endpoint groups."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        :raises keystone.exception.NotFound: If the entity not found."},{"line_number":243,"context_line":"        :returns: None."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_a180188c","line":242,"updated":"2015-09-30 13:46:23.000000000","message":"Ditto","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    def list_endpoint_groups(self):"},{"line_number":240,"context_line":"        \"\"\"List all endpoint groups."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        :raises keystone.exception.NotFound: If the entity not found."},{"line_number":243,"context_line":"        :returns: None."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_22996e7c","line":242,"in_reply_to":"9a1a9d01_a180188c","updated":"2015-10-09 07:04:25.000000000","message":"see my expalination in the above and apply to other place.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        :param project_id: identity of project to associate"},{"line_number":253,"context_line":"        :type project_id: string"},{"line_number":254,"context_line":"        :raises keystone.exception.NotFound: If the entity not found."},{"line_number":255,"context_line":"        :returns: None."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_c17bccbc","line":254,"updated":"2015-09-30 13:46:23.000000000","message":"Ditto","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        :param endpoint_group_id: identity of endpoint to associate"},{"line_number":265,"context_line":"        :type endpoint_group_id: string"},{"line_number":266,"context_line":"        :raises keystone.exception.NotFound: If the entity not found."},{"line_number":267,"context_line":"        :returns: None."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_614d2099","line":266,"updated":"2015-09-30 13:46:23.000000000","message":"Ditto","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        :type endpoint_group_id: string"},{"line_number":279,"context_line":"        :param project_id: identity of project to associate"},{"line_number":280,"context_line":"        :type project_id: string"},{"line_number":281,"context_line":"        :raises keystone.exception.NotFound: If the entity not found."},{"line_number":282,"context_line":"        :returns: None."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_2143a86d","line":281,"updated":"2015-09-30 13:46:23.000000000","message":"Ditto","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        :param project_id: identity of the project to be associated with"},{"line_number":78,"context_line":"        :type project_id: string"},{"line_number":79,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry is already"},{"line_number":80,"context_line":"            existing."},{"line_number":81,"context_line":"        :returns: None."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_59603801","line":80,"updated":"2015-10-21 17:13:28.000000000","message":"Same comment for the duplicate case","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :type endpoint_id: string"},{"line_number":92,"context_line":"        :param project_id: identity of the project associated with"},{"line_number":93,"context_line":"        :type project_id: string"},{"line_number":94,"context_line":"        :raises keystone.exception.NotFound: if the entity not found"},{"line_number":95,"context_line":"        :returns: None."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_795df445","line":94,"updated":"2015-10-21 17:13:28.000000000","message":"If","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0149a9be3f614c63720ac136bdb69eed05075903","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :type endpoint_id: string"},{"line_number":92,"context_line":"        :param project_id: identity of the project associated with"},{"line_number":93,"context_line":"        :type project_id: string"},{"line_number":94,"context_line":"        :raises keystone.exception.NotFound: if the entity not found"},{"line_number":95,"context_line":"        :returns: None."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_90c69398","line":94,"in_reply_to":"3a29b11f_795df445","updated":"2015-10-22 01:31:48.000000000","message":"i am going to change all of those to lowercase.","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        :type endpoint_id: string"},{"line_number":106,"context_line":"        :param project_id: identity of the project associated with"},{"line_number":107,"context_line":"        :type project_id: string"},{"line_number":108,"context_line":"        :raises keystone.exception.NotFound: if the entity not found"},{"line_number":109,"context_line":"        :returns: None."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_1956402a","line":108,"updated":"2015-10-21 17:13:28.000000000","message":"If","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        :param endpoint_group: endpoint group to create"},{"line_number":163,"context_line":"        :type endpoint_group: dictionary"},{"line_number":164,"context_line":"        :raises keystone.exception.Conflict: if a duplicated entry is already"},{"line_number":165,"context_line":"            existing."},{"line_number":166,"context_line":"        :returns: an endpoint group representation."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_d9320810","line":165,"updated":"2015-10-21 17:13:28.000000000","message":"If","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5b1ff54f0ab27962264f3ae770f337bb25411f8d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        :type endpoint_id: string"},{"line_number":112,"context_line":"        :param project_id: identity of the project associated with"},{"line_number":113,"context_line":"        :type project_id: string"},{"line_number":114,"context_line":"        :raises keystone.exception.NotFound: If the entity not found"},{"line_number":115,"context_line":"        :returns: None."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_4d7fe8df","line":114,"updated":"2015-11-12 14:27:52.000000000","message":"change \"If the entity not found\" to \"If the entity was not found\".\n\nThis applies to all these changes.","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c8389e3a49cd57c320f349ddc007a23125dbafdf","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        :type endpoint_id: string"},{"line_number":112,"context_line":"        :param project_id: identity of the project associated with"},{"line_number":113,"context_line":"        :type project_id: string"},{"line_number":114,"context_line":"        :raises keystone.exception.NotFound: If the entity not found"},{"line_number":115,"context_line":"        :returns: None."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_60017c39","line":114,"in_reply_to":"da85f559_4d7fe8df","updated":"2015-11-12 21:51:07.000000000","message":"Done","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"}],"keystone/contrib/example/core.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"2d2102c7dfc66f83a810ba38ee37324d848d5eff","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :param data: example data"},{"line_number":92,"context_line":"        :type data: string"},{"line_number":93,"context_line":"        :raises keystone.exception.NotImplemented: not implemented"},{"line_number":94,"context_line":"        :returns: None."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_71674fe9","line":93,"updated":"2015-09-29 19:15:51.000000000","message":"maybe: \"If entity was not implemented\"","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ba97f7beda0a56c5875e414faad6639f69702b78","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :param data: example data"},{"line_number":92,"context_line":"        :type data: string"},{"line_number":93,"context_line":"        :raises keystone.exception.NotImplemented: not implemented"},{"line_number":94,"context_line":"        :returns: None."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_1576ec6f","line":93,"in_reply_to":"9a1a9d01_71674fe9","updated":"2015-09-30 07:01:51.000000000","message":"Done","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :param data: example data"},{"line_number":92,"context_line":"        :type data: string"},{"line_number":93,"context_line":"        :raises keystone.exception.NotImplemented: If entity was not"},{"line_number":94,"context_line":"                implemented."},{"line_number":95,"context_line":"        :returns: None."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_ca99a17a","line":94,"updated":"2015-09-30 14:09:54.000000000","message":"nit: I notice that some of these doc strings are indented 4 spaces on some and 8 spaces on others... do we have a preference?\n\nWhich of the following should we follow? \n\n\n    :raises keystone.exceptionNotImplemented: if entity was not\n            implemented\n\n    :raises keystone.exceptionNotImplemented: if entity was not\n        implemented\n\n    :raises keystone.exceptionNotImplemented: if entity was not\n                                              implemented","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        :param data: example data"},{"line_number":92,"context_line":"        :type data: string"},{"line_number":93,"context_line":"        :raises keystone.exception.NotImplemented: If entity was not"},{"line_number":94,"context_line":"                implemented."},{"line_number":95,"context_line":"        :returns: None."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_62fd266d","line":94,"in_reply_to":"9a1a9d01_ca99a17a","updated":"2015-10-09 07:04:25.000000000","message":"No difference for the first and the second if we are talking about the doc rendered, but the third one is not correct since it will be not rendered correctly. \n\nI am not sure how sphinx works but my inital thought is make it consistent within the context, which looks more neat or possibly the consideration of size limitation.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8439904fb15ad58cd84dd826401cc049a84233b9","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :param data: example data"},{"line_number":92,"context_line":"        :type data: string"},{"line_number":93,"context_line":"        :raises keystone.exception.NotImplemented: If the entity was not"},{"line_number":94,"context_line":"            implemented."},{"line_number":95,"context_line":"        :returns: None."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_746ece97","line":93,"updated":"2015-11-17 16:18:56.000000000","message":"change \"entity\" to \"operation\"","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d060b78b7a338711de52de18eeb0f98686b1ae0f","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :param data: example data"},{"line_number":92,"context_line":"        :type data: string"},{"line_number":93,"context_line":"        :raises keystone.exception.NotImplemented: If the entity was not"},{"line_number":94,"context_line":"            implemented."},{"line_number":95,"context_line":"        :returns: None."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_0dc08d29","line":93,"in_reply_to":"ba8a016a_746ece97","updated":"2015-11-23 21:37:36.000000000","message":"Done","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"}],"keystone/contrib/federation/controllers.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        :param context: request\u0027s context"},{"line_number":257,"context_line":"        :raises keystone.exception.ValidationError: ``origin`` query parameter"},{"line_number":258,"context_line":"            was not specified. The URL is deemed invalid."},{"line_number":259,"context_line":"        :raises keystone.exception.Unauthorized: URL specified in origin query"},{"line_number":260,"context_line":"            parameter does not exist in list of websso trusted dashboards."},{"line_number":261,"context_line":"        :returns: URL with the originating dashboard"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_4a9b5166","line":259,"updated":"2015-09-30 14:09:54.000000000","message":"same comment here about indentation.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        :param context: request\u0027s context"},{"line_number":257,"context_line":"        :raises keystone.exception.ValidationError: ``origin`` query parameter"},{"line_number":258,"context_line":"            was not specified. The URL is deemed invalid."},{"line_number":259,"context_line":"        :raises keystone.exception.Unauthorized: URL specified in origin query"},{"line_number":260,"context_line":"            parameter does not exist in list of websso trusted dashboards."},{"line_number":261,"context_line":"        :returns: URL with the originating dashboard"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_c2667a50","line":259,"in_reply_to":"9a1a9d01_4a9b5166","updated":"2015-10-09 07:04:25.000000000","message":"has already replied.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"}],"keystone/contrib/federation/core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8439904fb15ad58cd84dd826401cc049a84233b9","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def delete_idp(self, idp_id):"},{"line_number":108,"context_line":"        \"\"\"Delete an identity provider."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        :raises keystone.exception.IdentityProviderNotFound: If the IDP"},{"line_number":111,"context_line":"            doesn\u0027t exist."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_b4299639","line":110,"updated":"2015-11-17 16:18:56.000000000","message":"\"IDP\" should be \"IdP\" thoughout these changes.","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d060b78b7a338711de52de18eeb0f98686b1ae0f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def delete_idp(self, idp_id):"},{"line_number":108,"context_line":"        \"\"\"Delete an identity provider."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        :raises keystone.exception.IdentityProviderNotFound: If the IDP"},{"line_number":111,"context_line":"            doesn\u0027t exist."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_ede509a8","line":110,"in_reply_to":"ba8a016a_b4299639","updated":"2015-11-23 21:37:36.000000000","message":"Done","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"}],"keystone/contrib/federation/idp.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5b1ff54f0ab27962264f3ae770f337bb25411f8d","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        consumed by a federated Service Provider."},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        :return: XML \u003cEntityDescriptor\u003e object."},{"line_number":467,"context_line":"        :raises keystone.exception.ValidationError: Raises if the required"},{"line_number":468,"context_line":"            config options aren\u0027t set."},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_2df1446b","line":467,"updated":"2015-11-12 14:27:52.000000000","message":"Remove \"Raises\"","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c8389e3a49cd57c320f349ddc007a23125dbafdf","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        consumed by a federated Service Provider."},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        :return: XML \u003cEntityDescriptor\u003e object."},{"line_number":467,"context_line":"        :raises keystone.exception.ValidationError: Raises if the required"},{"line_number":468,"context_line":"            config options aren\u0027t set."},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"da85f559_4b47b94b","line":467,"in_reply_to":"da85f559_2df1446b","updated":"2015-11-12 21:51:07.000000000","message":"Done","commit_id":"d92ffe82f17b8c46460cfc9b9a6d06adc8fb5dab"}],"keystone/contrib/federation/utils.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4cb4e16c12ed1dee3612d0c373fda4f5a1be1653","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    :returns: generator object with group ids"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    :raises keystone.excepton.MappedGroupNotFound: in case asked group doesn\u0027t"},{"line_number":327,"context_line":"        exist in the backend."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_995dc6ee","line":326,"updated":"2015-11-23 01:15:59.000000000","message":"(nit) Please fix excepton to exception","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d060b78b7a338711de52de18eeb0f98686b1ae0f","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    :returns: generator object with group ids"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    :raises keystone.excepton.MappedGroupNotFound: in case asked group doesn\u0027t"},{"line_number":327,"context_line":"        exist in the backend."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_6d44b973","line":326,"in_reply_to":"ba8a016a_995dc6ee","updated":"2015-11-23 21:37:36.000000000","message":"Done","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"}],"keystone/contrib/revoke/core.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"fcebb33eb9c4b6deb61bf92bb0515253a8960fc5","unresolved":false,"context_lines":[{"line_number":220,"context_line":"         normalized for differences between v2 and v3. The checked values are a"},{"line_number":221,"context_line":"         subset of the attributes of model.TokenEvent"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        :raises keystone.exception.TokenNotFound: if the token is invalid"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"         \"\"\""},{"line_number":226,"context_line":"        if self._get_revoke_tree().is_revoked(token_values):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_d919a889","line":223,"updated":"2015-10-21 17:13:28.000000000","message":"If","commit_id":"8736fe81e8cff50c7c4b0d331f692eca302da592"}],"keystone/credential/core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f2d9d46050a88e70baf1e78c8514b2a354bcccd7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        \"\"\"Get a credential by ID."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        :returns: credential_ref"},{"line_number":95,"context_line":"        :raises keystone.exception.CredentialNotFound: If credential doesn\u0027t"},{"line_number":96,"context_line":"            exist."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7988ed22","line":95,"updated":"2015-11-23 22:36:44.000000000","message":"change \"credential\" to \"the credential\" (applies to the rest of these, too)","commit_id":"f8ee2ba78a1b792f4627e9ea9147f2dec456e900"}],"keystone/endpoint_policy/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        :param region_id: identity of the region to associate"},{"line_number":306,"context_line":"        :type region_id: string"},{"line_number":307,"context_line":"        :raises keystone.exception.PolicyAssociationNotFound: if there is no"},{"line_number":308,"context_line":"                 match for the specified association"},{"line_number":309,"context_line":"        :returns: None"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_2ae61de8","line":308,"updated":"2015-09-30 14:09:54.000000000","message":"indentation doesn\u0027t match up here","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        :param region_id: identity of the region to associate"},{"line_number":306,"context_line":"        :type region_id: string"},{"line_number":307,"context_line":"        :raises keystone.exception.PolicyAssociationNotFound: if there is no"},{"line_number":308,"context_line":"                 match for the specified association"},{"line_number":309,"context_line":"        :returns: None"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_c2cd1a32","line":308,"in_reply_to":"9a1a9d01_2ae61de8","updated":"2015-10-09 07:04:25.000000000","message":"Done","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"}],"keystone/identity/core.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"2d2102c7dfc66f83a810ba38ee37324d848d5eff","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"    def authenticate(self, user_id, password):"},{"line_number":1185,"context_line":"        \"\"\"Authenticate a given user and password."},{"line_number":1186,"context_line":"        :returns: user_ref"},{"line_number":1187,"context_line":"        :raises AssertionError: invalid user or password"},{"line_number":1188,"context_line":"        \"\"\""},{"line_number":1189,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"},{"line_number":1190,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_42436342","line":1187,"updated":"2015-09-29 19:15:51.000000000","message":"Maybe: \"If there is an invalid user or password","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ba97f7beda0a56c5875e414faad6639f69702b78","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"    def authenticate(self, user_id, password):"},{"line_number":1185,"context_line":"        \"\"\"Authenticate a given user and password."},{"line_number":1186,"context_line":"        :returns: user_ref"},{"line_number":1187,"context_line":"        :raises AssertionError: invalid user or password"},{"line_number":1188,"context_line":"        \"\"\""},{"line_number":1189,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"},{"line_number":1190,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_d56b9483","line":1187,"in_reply_to":"9a1a9d01_42436342","updated":"2015-09-30 07:01:51.000000000","message":"Done","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"        \"\"\"Creates a new user."},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        :raises keystone.exception.Conflict: If a duplicated entry is already"},{"line_number":1198,"context_line":"            existing."},{"line_number":1199,"context_line":""},{"line_number":1200,"context_line":"        \"\"\""},{"line_number":1201,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_cad521e5","line":1198,"updated":"2015-09-30 14:09:54.000000000","message":"same indentation comment applies here.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"7913cf4aa4ea8e8275b2de7a8d5259697b4b632c","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"    def remove_user_from_group(self, user_id, group_id):"},{"line_number":1273,"context_line":"        \"\"\"Removes a user from a group."},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"        :raises keystone.exception.NotFound: entity not found"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"        \"\"\""},{"line_number":1278,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_c4d51ae5","line":1275,"updated":"2015-09-30 13:46:23.000000000","message":"maybe \"If the entity was not found\"","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"    def remove_user_from_group(self, user_id, group_id):"},{"line_number":1273,"context_line":"        \"\"\"Removes a user from a group."},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"        :raises keystone.exception.NotFound: entity not found"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"        \"\"\""},{"line_number":1278,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_c2f43a5c","line":1275,"in_reply_to":"9a1a9d01_c4d51ae5","updated":"2015-10-09 07:04:25.000000000","message":"Done","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4cb4e16c12ed1dee3612d0c373fda4f5a1be1653","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"    def authenticate(self, user_id, password):"},{"line_number":1174,"context_line":"        \"\"\"Authenticate a given user and password."},{"line_number":1175,"context_line":"        :returns: user_ref"},{"line_number":1176,"context_line":"        :raises AssertionError: If there is an invalid user or password."},{"line_number":1177,"context_line":"        \"\"\""},{"line_number":1178,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"},{"line_number":1179,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_b9620aac","line":1176,"updated":"2015-11-23 01:15:59.000000000","message":"(nit) Looks like \"If user or password is invalid.\" would sound better ?","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d060b78b7a338711de52de18eeb0f98686b1ae0f","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"    def authenticate(self, user_id, password):"},{"line_number":1174,"context_line":"        \"\"\"Authenticate a given user and password."},{"line_number":1175,"context_line":"        :returns: user_ref"},{"line_number":1176,"context_line":"        :raises AssertionError: If there is an invalid user or password."},{"line_number":1177,"context_line":"        \"\"\""},{"line_number":1178,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"},{"line_number":1179,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_185e8912","line":1176,"in_reply_to":"ba8a016a_b9620aac","updated":"2015-11-23 21:37:36.000000000","message":"Done","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"}],"keystone/policy/backends/rules.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4cb4e16c12ed1dee3612d0c373fda4f5a1be1653","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                   creation this should be a dictionary representing the"},{"line_number":52,"context_line":"                   location of the object e.g. {\u0027project_id\u0027:"},{"line_number":53,"context_line":"                   object.project_id}"},{"line_number":54,"context_line":"    :raises keystone.exception.Forbidden: if verification fails."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Actions should be colon separated for clarity. For example:"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_1972367d","line":54,"updated":"2015-11-23 01:15:59.000000000","message":"(nit) if/If (just to be consistent with the other places you fixed","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d060b78b7a338711de52de18eeb0f98686b1ae0f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                   creation this should be a dictionary representing the"},{"line_number":52,"context_line":"                   location of the object e.g. {\u0027project_id\u0027:"},{"line_number":53,"context_line":"                   object.project_id}"},{"line_number":54,"context_line":"    :raises keystone.exception.Forbidden: if verification fails."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Actions should be colon separated for clarity. For example:"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_b82c1d4b","line":54,"in_reply_to":"ba8a016a_1972367d","updated":"2015-11-23 21:37:36.000000000","message":"this was kept as lowcase since all the docstring here didn\u0027t capital the \u0027i\u0027, but it\u0027s okay to do the update.","commit_id":"52cb4e4de97b6bbbc772595828b6b6ac6a1fffe1"}],"keystone/resource/core.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"2d2102c7dfc66f83a810ba38ee37324d848d5eff","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"        :param type: type of registration"},{"line_number":1395,"context_line":"        :returns: domain_id of who is registered."},{"line_number":1396,"context_line":"        :raises keystone.exception.ConfigRegistrationNotFound: nobody is"},{"line_number":1397,"context_line":"                registered."},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"        \"\"\""},{"line_number":1400,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_cf06bccd","line":1397,"updated":"2015-09-29 19:15:51.000000000","message":"nit   s/nobody is registered./ if nobody is registered./","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ba97f7beda0a56c5875e414faad6639f69702b78","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"        :param type: type of registration"},{"line_number":1395,"context_line":"        :returns: domain_id of who is registered."},{"line_number":1396,"context_line":"        :raises keystone.exception.ConfigRegistrationNotFound: nobody is"},{"line_number":1397,"context_line":"                registered."},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"        \"\"\""},{"line_number":1400,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_550ea4e5","line":1397,"in_reply_to":"9a1a9d01_cf06bccd","updated":"2015-09-30 07:01:51.000000000","message":"Done","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        :param type: type of registration"},{"line_number":1395,"context_line":"        :returns: domain_id of who is registered."},{"line_number":1396,"context_line":"        :raises keystone.exception.ConfigRegistrationNotFound: if nobody is"},{"line_number":1397,"context_line":"                registered."},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_4a37d14c","line":1396,"updated":"2015-09-30 14:09:54.000000000","message":"I see some of these have been capitalized and others haven\u0027t.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"        :param type: type of registration"},{"line_number":1395,"context_line":"        :returns: domain_id of who is registered."},{"line_number":1396,"context_line":"        :raises keystone.exception.ConfigRegistrationNotFound: if nobody is"},{"line_number":1397,"context_line":"                registered."},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_228deed5","line":1396,"in_reply_to":"9a1a9d01_4a37d14c","updated":"2015-10-09 07:04:25.000000000","message":"based on the context, based on whether others has been capitalized for the fields in the same section.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"}],"keystone/trust/core.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"2d2102c7dfc66f83a810ba38ee37324d848d5eff","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        :raises keystone.exception.TrustUseLimitReached: If no remaining uses"},{"line_number":251,"context_line":"            for trust."},{"line_number":252,"context_line":"        :raises keystone.exception.TrustNotFound: If the token doesn\u0027t exist."},{"line_number":253,"context_line":"        \"\"\""},{"line_number":254,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_8fad2486","line":252,"updated":"2015-09-29 19:15:51.000000000","message":"Shouldn\u0027t this be: \"If the trust doesn\u0027t exist.\"?","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ba97f7beda0a56c5875e414faad6639f69702b78","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        :raises keystone.exception.TrustUseLimitReached: If no remaining uses"},{"line_number":251,"context_line":"            for trust."},{"line_number":252,"context_line":"        :raises keystone.exception.TrustNotFound: If the token doesn\u0027t exist."},{"line_number":253,"context_line":"        \"\"\""},{"line_number":254,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_351f7009","line":252,"in_reply_to":"9a1a9d01_8fad2486","updated":"2015-09-30 07:01:51.000000000","message":"Done","commit_id":"c3fddb376c6e12557351197b95290f69b2bd4669"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"49c7db5faa0140939cda356e0c0ee64cc9ffb91f","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        uses, provided there are still uses available."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        :raises keystone.exception.TrustUseLimitReached: If no remaining uses"},{"line_number":251,"context_line":"                for trust."},{"line_number":252,"context_line":"        :raises keystone.exception.TrustNotFound: If the trust doesn\u0027t exist."},{"line_number":253,"context_line":"        \"\"\""},{"line_number":254,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_ca71a10d","line":251,"updated":"2015-09-30 14:09:54.000000000","message":"same indentation comment as before.","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"98b34393919514095b8e041771052b79dca3e331","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        uses, provided there are still uses available."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        :raises keystone.exception.TrustUseLimitReached: If no remaining uses"},{"line_number":251,"context_line":"                for trust."},{"line_number":252,"context_line":"        :raises keystone.exception.TrustNotFound: If the trust doesn\u0027t exist."},{"line_number":253,"context_line":"        \"\"\""},{"line_number":254,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_028eb2cf","line":251,"in_reply_to":"9a1a9d01_ca71a10d","updated":"2015-10-09 07:04:25.000000000","message":"Done","commit_id":"677f21241adf16e79baf25eeb3214de78b17557f"}]}