)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"4fa6e0637fe60fed55adadee815355f03c952332","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brant Knudson \u003cbknudson@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-22 16:17:45 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unit tests for fernet test_validate_v3_token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There were no unit tests for test_validate_v3_token."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_e6ad7932","line":7,"updated":"2015-09-25 02:18:39.000000000","message":"s/test_validate_v3_token/validate_v3_token","commit_id":"9a8a20b3b707031434425ff837ac94a438edb786"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"314f983b76d5691eebe792ed81081e1e7ff7dce3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brant Knudson \u003cbknudson@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-22 16:17:45 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unit tests for fernet test_validate_v3_token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There were no unit tests for test_validate_v3_token."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_1a99a71f","line":7,"in_reply_to":"9a1a9d01_65ccec89","updated":"2015-09-28 13:59:47.000000000","message":"Done","commit_id":"9a8a20b3b707031434425ff837ac94a438edb786"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"0ee953303892cebf1beffcd19100e0c5f85d758a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brant Knudson \u003cbknudson@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-22 16:17:45 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unit tests for fernet test_validate_v3_token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There were no unit tests for test_validate_v3_token."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_65ccec89","line":7,"in_reply_to":"9a1a9d01_e6ad7932","updated":"2015-09-25 14:29:53.000000000","message":"I think it\u0027s just a prefix for the tests being added.\nThough it\u0027d be good to have something more human readable here.","commit_id":"9a8a20b3b707031434425ff837ac94a438edb786"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"4fa6e0637fe60fed55adadee815355f03c952332","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unit tests for fernet test_validate_v3_token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There were no unit tests for test_validate_v3_token."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I68e18af27e40556472b27ceb11bd79d580874bad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_66c169e4","line":9,"updated":"2015-09-25 02:18:39.000000000","message":"i think it should be the unit tests for \u0027validate_v3_token\u0027","commit_id":"9a8a20b3b707031434425ff837ac94a438edb786"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"314f983b76d5691eebe792ed81081e1e7ff7dce3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unit tests for fernet test_validate_v3_token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There were no unit tests for test_validate_v3_token."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I68e18af27e40556472b27ceb11bd79d580874bad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_ba9f5b02","line":9,"in_reply_to":"9a1a9d01_66c169e4","updated":"2015-09-28 13:59:47.000000000","message":"Done","commit_id":"9a8a20b3b707031434425ff837ac94a438edb786"}],"keystone/tests/unit/token/test_fernet_provider.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"849ab31011837ea1f6e380a1bce07a7b22b708da","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        user_ref \u003d unit.new_user_ref(domain_ref[\u0027id\u0027])"},{"line_number":114,"context_line":"        user_ref \u003d self.identity_api.create_user(user_ref)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        method_names \u003d [\u0027password\u0027]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        group_ids \u003d [uuid.uuid4().hex, ]"},{"line_number":119,"context_line":"        identity_provider \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_471df50d","line":116,"updated":"2015-09-28 12:52:32.000000000","message":"we should rather put \u0027mapped\u0027 or \u0027saml2\u0027 here.","commit_id":"68b35be397389869c1da1f78929f95d461b8ab6e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7782f554aaf6b30023e370ee819ea98a30ffdf10","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        user_ref \u003d unit.new_user_ref(domain_ref[\u0027id\u0027])"},{"line_number":114,"context_line":"        user_ref \u003d self.identity_api.create_user(user_ref)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        method_names \u003d [\u0027password\u0027]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        group_ids \u003d [uuid.uuid4().hex, ]"},{"line_number":119,"context_line":"        identity_provider \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_139c1b68","line":116,"in_reply_to":"9a1a9d01_471df50d","updated":"2015-09-28 14:13:45.000000000","message":"Done","commit_id":"68b35be397389869c1da1f78929f95d461b8ab6e"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"7822326b997f54c965a126c26891a84e6dc958a8","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self.assignment_api.create_grant("},{"line_number":165,"context_line":"            role_ref[\u0027id\u0027], user_id\u003duser_ref[\u0027id\u0027],"},{"line_number":166,"context_line":"            project_id\u003dproject_ref[\u0027id\u0027])"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.assignment_api.create_grant("},{"line_number":169,"context_line":"            role_ref[\u0027id\u0027], user_id\u003dtrustor_user_ref[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_4de8af7c","line":166,"updated":"2015-10-05 13:31:31.000000000","message":"The trustee doesn\u0027t need to have the role in the project too, otherwise we wouldn\u0027t need to create a trust :)\n\nTesting trusts behavior isn\u0027t in the scope of this patch though ..","commit_id":"c28163ab74b6af132ece930335585eb4fbac38ab"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"7822326b997f54c965a126c26891a84e6dc958a8","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            project_id\u003dproject_ref[\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        trustor_user_id \u003d trustor_user_ref[\u0027id\u0027]"},{"line_number":173,"context_line":"        trustee_user_id \u003d user_ref[\u0027id\u0027]"},{"line_number":174,"context_line":"        trust_ref \u003d unit.new_trust_ref("},{"line_number":175,"context_line":"            trustor_user_id, trustee_user_id, project_id\u003dproject_ref[\u0027id\u0027],"},{"line_number":176,"context_line":"            role_ids\u003d[role_ref[\u0027id\u0027], ])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_6d01f369","line":173,"updated":"2015-10-05 13:31:31.000000000","message":"(nit) It would be clearer if calling user_ref as trustee_user_ref from the start","commit_id":"c28163ab74b6af132ece930335585eb4fbac38ab"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0ba3e2400c6e800870efdc14e94e64e93e3d9fb7","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            project_id\u003dproject_ref[\u0027id\u0027])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        trustor_user_id \u003d trustor_user_ref[\u0027id\u0027]"},{"line_number":173,"context_line":"        trustee_user_id \u003d user_ref[\u0027id\u0027]"},{"line_number":174,"context_line":"        trust_ref \u003d unit.new_trust_ref("},{"line_number":175,"context_line":"            trustor_user_id, trustee_user_id, project_id\u003dproject_ref[\u0027id\u0027],"},{"line_number":176,"context_line":"            role_ids\u003d[role_ref[\u0027id\u0027], ])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_b97d30b3","line":173,"in_reply_to":"9a1a9d01_6d01f369","updated":"2015-10-07 00:30:46.000000000","message":"but it is a trustee","commit_id":"c28163ab74b6af132ece930335585eb4fbac38ab"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"7822326b997f54c965a126c26891a84e6dc958a8","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        # When the token format isn\u0027t recognized, TokenNotFound is raised."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # A uuid string isn\u0027t a valid fernet token."},{"line_number":200,"context_line":"        token_id \u003d uuid.uuid4().hex"},{"line_number":201,"context_line":"        self.assertRaises(exception.TokenNotFound,"},{"line_number":202,"context_line":"                          self.token_provider_api.validate_v3_token, token_id)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_7038e83d","line":200,"updated":"2015-10-05 13:31:31.000000000","message":"I don\u0027t know why it is being called token_id all over the place, when it actually is the token itself. I checked and it has the same naming inside the issue_v3_token method.","commit_id":"c28163ab74b6af132ece930335585eb4fbac38ab"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0ba3e2400c6e800870efdc14e94e64e93e3d9fb7","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        # When the token format isn\u0027t recognized, TokenNotFound is raised."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # A uuid string isn\u0027t a valid fernet token."},{"line_number":200,"context_line":"        token_id \u003d uuid.uuid4().hex"},{"line_number":201,"context_line":"        self.assertRaises(exception.TokenNotFound,"},{"line_number":202,"context_line":"                          self.token_provider_api.validate_v3_token, token_id)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_393fe0d7","line":200,"in_reply_to":"9a1a9d01_7038e83d","updated":"2015-10-07 00:30:46.000000000","message":"there\u0027s a difference between token_id and token data. token_id is passed in X-Auth-Token or X-Subject-Token headers. Token data is something you get back in the response body for token validation.","commit_id":"c28163ab74b6af132ece930335585eb4fbac38ab"}]}