)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"db5f1471278c0fe4d60c0a5464e8acdd7b0c6667","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add test that validate whether the _set_default_is_domain_project method"},{"line_number":10,"context_line":"in resource LDAP driver accepts only project refs or a list of project"},{"line_number":11,"context_line":"refs. If so, it sets the is_domain project ref attribute to False."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifd0c8ef9ea422f167eda0a786a93febefebb4c6b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_bf43c06b","line":11,"updated":"2015-10-04 20:57:02.000000000","message":"\"it sets the is_domain project ref attribute to False.\"; we aren\u0027t checking it does so in the added tests.","commit_id":"4a00bd359aee32354c48b81f6fcd1edd8279863e"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"db5f1471278c0fe4d60c0a5464e8acdd7b0c6667","unresolved":false,"context_lines":[{"line_number":1786,"context_line":""},{"line_number":1787,"context_line":"    def test_set_default_is_domain_project(self):"},{"line_number":1788,"context_line":"        # Tests the internal method _set_default_is_domain_project, which"},{"line_number":1789,"context_line":"        # allows either a project ref or a list or project refs"},{"line_number":1790,"context_line":"        project \u003d {\u0027id\u0027: uuid.uuid4().hex,"},{"line_number":1791,"context_line":"                   \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":1792,"context_line":"                   \u0027description\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_9f727ce2","line":1789,"updated":"2015-10-04 20:57:02.000000000","message":"(nit) a list *of* project refs","commit_id":"4a00bd359aee32354c48b81f6fcd1edd8279863e"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"df74c71c8a0941f6e2482e251a762d1c7c5306ba","unresolved":false,"context_lines":[{"line_number":1786,"context_line":""},{"line_number":1787,"context_line":"    def test_set_default_is_domain_project(self):"},{"line_number":1788,"context_line":"        # Tests the internal method _set_default_is_domain_project, which"},{"line_number":1789,"context_line":"        # allows either a project ref or a list or project refs"},{"line_number":1790,"context_line":"        project \u003d {\u0027id\u0027: uuid.uuid4().hex,"},{"line_number":1791,"context_line":"                   \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":1792,"context_line":"                   \u0027description\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_c119df7a","line":1789,"in_reply_to":"9a1a9d01_9f727ce2","updated":"2015-10-07 21:55:07.000000000","message":"Done","commit_id":"4a00bd359aee32354c48b81f6fcd1edd8279863e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f924de0f759e996d820fe5ae931fe24d16ee745a","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"        project \u003d {\u0027id\u0027: uuid.uuid4().hex,"},{"line_number":1791,"context_line":"                   \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":1792,"context_line":"                   \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":1793,"context_line":"                   \u0027is_domain\u0027: False}"},{"line_number":1794,"context_line":""},{"line_number":1795,"context_line":"        # Calling it with a dict is valid"},{"line_number":1796,"context_line":"        self.resource_api.driver._set_default_is_domain_project(project)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_af80f28b","line":1793,"updated":"2015-09-30 17:31:38.000000000","message":"use new_project_ref: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/core.py#n267","commit_id":"4a00bd359aee32354c48b81f6fcd1edd8279863e"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"df74c71c8a0941f6e2482e251a762d1c7c5306ba","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"        project \u003d {\u0027id\u0027: uuid.uuid4().hex,"},{"line_number":1791,"context_line":"                   \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":1792,"context_line":"                   \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":1793,"context_line":"                   \u0027is_domain\u0027: False}"},{"line_number":1794,"context_line":""},{"line_number":1795,"context_line":"        # Calling it with a dict is valid"},{"line_number":1796,"context_line":"        self.resource_api.driver._set_default_is_domain_project(project)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_6127abb6","line":1793,"in_reply_to":"9a1a9d01_7f7768d4","updated":"2015-10-07 21:55:07.000000000","message":"Done","commit_id":"4a00bd359aee32354c48b81f6fcd1edd8279863e"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"db5f1471278c0fe4d60c0a5464e8acdd7b0c6667","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"        project \u003d {\u0027id\u0027: uuid.uuid4().hex,"},{"line_number":1791,"context_line":"                   \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":1792,"context_line":"                   \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":1793,"context_line":"                   \u0027is_domain\u0027: False}"},{"line_number":1794,"context_line":""},{"line_number":1795,"context_line":"        # Calling it with a dict is valid"},{"line_number":1796,"context_line":"        self.resource_api.driver._set_default_is_domain_project(project)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_7f7768d4","line":1793,"in_reply_to":"9a1a9d01_af80f28b","updated":"2015-10-04 20:57:02.000000000","message":"++\nAlso, if we are checking the field is being set, the original project ref shouldn\u0027t contain the is_domain field, do you agree?","commit_id":"4a00bd359aee32354c48b81f6fcd1edd8279863e"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"db5f1471278c0fe4d60c0a5464e8acdd7b0c6667","unresolved":false,"context_lines":[{"line_number":1793,"context_line":"                   \u0027is_domain\u0027: False}"},{"line_number":1794,"context_line":""},{"line_number":1795,"context_line":"        # Calling it with a dict is valid"},{"line_number":1796,"context_line":"        self.resource_api.driver._set_default_is_domain_project(project)"},{"line_number":1797,"context_line":""},{"line_number":1798,"context_line":"        # So it is with a list of refs"},{"line_number":1799,"context_line":"        refs_list \u003d [project, project]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_3f81f08f","line":1796,"updated":"2015-10-04 20:57:02.000000000","message":"How do I know the field was set ?","commit_id":"4a00bd359aee32354c48b81f6fcd1edd8279863e"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"df74c71c8a0941f6e2482e251a762d1c7c5306ba","unresolved":false,"context_lines":[{"line_number":1793,"context_line":"                   \u0027is_domain\u0027: False}"},{"line_number":1794,"context_line":""},{"line_number":1795,"context_line":"        # Calling it with a dict is valid"},{"line_number":1796,"context_line":"        self.resource_api.driver._set_default_is_domain_project(project)"},{"line_number":1797,"context_line":""},{"line_number":1798,"context_line":"        # So it is with a list of refs"},{"line_number":1799,"context_line":"        refs_list \u003d [project, project]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_812a077d","line":1796,"in_reply_to":"9a1a9d01_3f81f08f","updated":"2015-10-07 21:55:07.000000000","message":"Done","commit_id":"4a00bd359aee32354c48b81f6fcd1edd8279863e"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"db5f1471278c0fe4d60c0a5464e8acdd7b0c6667","unresolved":false,"context_lines":[{"line_number":1797,"context_line":""},{"line_number":1798,"context_line":"        # So it is with a list of refs"},{"line_number":1799,"context_line":"        refs_list \u003d [project, project]"},{"line_number":1800,"context_line":"        self.resource_api.driver._set_default_is_domain_project(refs_list)"},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"        # Passing another type is not allowed"},{"line_number":1803,"context_line":"        self.assertRaises(ValueError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_5f7ce4b4","line":1800,"updated":"2015-10-04 20:57:02.000000000","message":"Same as above. Also, as both are the same object, how do I know it is setting the field for both objects and not for just one ?","commit_id":"4a00bd359aee32354c48b81f6fcd1edd8279863e"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"df74c71c8a0941f6e2482e251a762d1c7c5306ba","unresolved":false,"context_lines":[{"line_number":1797,"context_line":""},{"line_number":1798,"context_line":"        # So it is with a list of refs"},{"line_number":1799,"context_line":"        refs_list \u003d [project, project]"},{"line_number":1800,"context_line":"        self.resource_api.driver._set_default_is_domain_project(refs_list)"},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"        # Passing another type is not allowed"},{"line_number":1803,"context_line":"        self.assertRaises(ValueError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_2121b39f","line":1800,"in_reply_to":"9a1a9d01_5f7ce4b4","updated":"2015-10-07 21:55:07.000000000","message":"Done","commit_id":"4a00bd359aee32354c48b81f6fcd1edd8279863e"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"557fbad28f82d475e23b6b5360d737add6d8d758","unresolved":false,"context_lines":[{"line_number":1798,"context_line":"        self.assertFalse(updated_project_ref[\u0027is_domain\u0027])"},{"line_number":1799,"context_line":""},{"line_number":1800,"context_line":"        # So it is with a list of refs"},{"line_number":1801,"context_line":"        refs_list \u003d [new_project_ref, new_project_ref]"},{"line_number":1802,"context_line":"        new_refs_list \u003d (self.resource_api.driver."},{"line_number":1803,"context_line":"                         _set_default_is_domain_project(refs_list))"},{"line_number":1804,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_82b6e4da","line":1801,"updated":"2015-10-13 20:50:35.000000000","message":"How do we know all the itens in the list have been updated vs a single one ? Since all the elements in the list are the same ...","commit_id":"07ab6b47b3d656342497aa3dae7e778ff76b3eed"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"e0dea027c07f2a06a91c80bbd03553be69c50741","unresolved":false,"context_lines":[{"line_number":1798,"context_line":"        self.assertFalse(updated_project_ref[\u0027is_domain\u0027])"},{"line_number":1799,"context_line":""},{"line_number":1800,"context_line":"        # So it is with a list of refs"},{"line_number":1801,"context_line":"        refs_list \u003d [new_project_ref, new_project_ref]"},{"line_number":1802,"context_line":"        new_refs_list \u003d (self.resource_api.driver."},{"line_number":1803,"context_line":"                         _set_default_is_domain_project(refs_list))"},{"line_number":1804,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_fd7912c9","line":1801,"in_reply_to":"5a2ca52d_82b6e4da","updated":"2015-10-15 19:39:00.000000000","message":"Done","commit_id":"07ab6b47b3d656342497aa3dae7e778ff76b3eed"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd60e6f69b9bc50d9b5ca8a66aa5531559589d7f","unresolved":false,"context_lines":[{"line_number":1791,"context_line":"        # allows either a project ref or a list of project refs"},{"line_number":1792,"context_line":"        new_project_ref \u003d {\u0027id\u0027: uuid.uuid4().hex,"},{"line_number":1793,"context_line":"                           \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":1794,"context_line":"                           \u0027description\u0027: uuid.uuid4().hex}"},{"line_number":1795,"context_line":""},{"line_number":1796,"context_line":"        # Calling it with a dict is valid"},{"line_number":1797,"context_line":"        updated_project_ref \u003d (self.resource_api.driver."}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_40f15300","line":1794,"updated":"2015-11-10 21:47:41.000000000","message":"use new_project_ref: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/core.py#n267","commit_id":"46e737c41f565bba4208a383068054591e83cf55"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd60e6f69b9bc50d9b5ca8a66aa5531559589d7f","unresolved":false,"context_lines":[{"line_number":1797,"context_line":"        updated_project_ref \u003d (self.resource_api.driver."},{"line_number":1798,"context_line":"                               _set_default_is_domain_project(new_project_ref))"},{"line_number":1799,"context_line":""},{"line_number":1800,"context_line":"        self.assertFalse(updated_project_ref[\u0027is_domain\u0027])"},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"        # So it is with a list of refs"},{"line_number":1803,"context_line":"        another_new_project_ref \u003d {\u0027id\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_c05303e1","line":1800,"updated":"2015-11-10 21:47:41.000000000","message":"this should use self.assertIs(False, updated_project_ref[\u0027is_domain\u0027])","commit_id":"46e737c41f565bba4208a383068054591e83cf55"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd60e6f69b9bc50d9b5ca8a66aa5531559589d7f","unresolved":false,"context_lines":[{"line_number":1802,"context_line":"        # So it is with a list of refs"},{"line_number":1803,"context_line":"        another_new_project_ref \u003d {\u0027id\u0027: uuid.uuid4().hex,"},{"line_number":1804,"context_line":"                                   \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":1805,"context_line":"                                   \u0027description\u0027: uuid.uuid4().hex}"},{"line_number":1806,"context_line":"        refs_list \u003d [new_project_ref, another_new_project_ref]"},{"line_number":1807,"context_line":"        new_refs_list \u003d (self.resource_api.driver."},{"line_number":1808,"context_line":"                         _set_default_is_domain_project(refs_list))"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_a0659fb5","line":1805,"updated":"2015-11-10 21:47:41.000000000","message":"use new_project_ref()","commit_id":"46e737c41f565bba4208a383068054591e83cf55"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd60e6f69b9bc50d9b5ca8a66aa5531559589d7f","unresolved":false,"context_lines":[{"line_number":1808,"context_line":"                         _set_default_is_domain_project(refs_list))"},{"line_number":1809,"context_line":""},{"line_number":1810,"context_line":"        for ref in new_refs_list:"},{"line_number":1811,"context_line":"            self.assertFalse(ref[\u0027is_domain\u0027])"},{"line_number":1812,"context_line":""},{"line_number":1813,"context_line":"        # Passing another type is not allowed"},{"line_number":1814,"context_line":"        self.assertRaises(ValueError,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_204bef2b","line":1811,"updated":"2015-11-10 21:47:41.000000000","message":"this should use self.assertIs(False, ref[\u0027is_domain\u0027])","commit_id":"46e737c41f565bba4208a383068054591e83cf55"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd60e6f69b9bc50d9b5ca8a66aa5531559589d7f","unresolved":false,"context_lines":[{"line_number":1814,"context_line":"        self.assertRaises(ValueError,"},{"line_number":1815,"context_line":"                          self.resource_api.driver."},{"line_number":1816,"context_line":"                          _set_default_is_domain_project,"},{"line_number":1817,"context_line":"                          \u0027foo_bar\u0027)"},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"        # A list with another type is not allowed either"},{"line_number":1820,"context_line":"        wrong_list \u003d [new_project_ref, \u0027foo_bar\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_00fcabb6","line":1817,"updated":"2015-11-10 21:47:41.000000000","message":"use uuid.uuid4().hex for random strings.","commit_id":"46e737c41f565bba4208a383068054591e83cf55"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cd60e6f69b9bc50d9b5ca8a66aa5531559589d7f","unresolved":false,"context_lines":[{"line_number":1817,"context_line":"                          \u0027foo_bar\u0027)"},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"        # A list with another type is not allowed either"},{"line_number":1820,"context_line":"        wrong_list \u003d [new_project_ref, \u0027foo_bar\u0027]"},{"line_number":1821,"context_line":"        self.assertRaises(ValueError,"},{"line_number":1822,"context_line":"                          self.resource_api.driver."},{"line_number":1823,"context_line":"                          _set_default_is_domain_project,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_20f9afc7","line":1820,"updated":"2015-11-10 21:47:41.000000000","message":"use uuid.uuid4().hex for random strings.","commit_id":"46e737c41f565bba4208a383068054591e83cf55"}]}