)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0d501dfde769edef6bb6067c58aefba9e8896729","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-10-01 13:27:23 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expose 1501698 bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: 1501698"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7443a7e4c65c2e40c02826b53130738bc7689a07"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_30d503e4","line":8,"updated":"2015-10-01 11:16:15.000000000","message":"I\u0027d certainly prefer at least a line or two here as to what we are exposing, rather than having to look up the bug - a commit comment should be able to stand alone.","commit_id":"25db8dff9015c45ad0542f4528b9fd2033789aa1"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"8e610baabb66dddaa5dfd2697ccdd4d648f7112b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-10-01 13:27:23 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expose 1501698 bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: 1501698"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7443a7e4c65c2e40c02826b53130738bc7689a07"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_377df8b1","line":8,"in_reply_to":"9a1a9d01_30d503e4","updated":"2015-10-01 12:07:25.000000000","message":"Done","commit_id":"25db8dff9015c45ad0542f4528b9fd2033789aa1"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0d501dfde769edef6bb6067c58aefba9e8896729","unresolved":false,"context_lines":[{"line_number":2084,"context_line":"        self.assertEqual(\u0027Foo Bar\u0027, user_ref[\u0027name\u0027])"},{"line_number":2085,"context_line":""},{"line_number":2086,"context_line":""},{"line_number":2087,"context_line":"class LDAPUserList(BaseLDAPIdentity, unit.TestCase):"},{"line_number":2088,"context_line":""},{"line_number":2089,"context_line":"    def setUp(self):"},{"line_number":2090,"context_line":"        # NOTE(dstanek): The database must be setup prior to calling the"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_703dbb29","line":2087,"updated":"2015-10-01 11:16:15.000000000","message":"won\u0027t this cause ALL the backend tests to be run?  If so, seems  a bit of overkill","commit_id":"25db8dff9015c45ad0542f4528b9fd2033789aa1"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"8e610baabb66dddaa5dfd2697ccdd4d648f7112b","unresolved":false,"context_lines":[{"line_number":2084,"context_line":"        self.assertEqual(\u0027Foo Bar\u0027, user_ref[\u0027name\u0027])"},{"line_number":2085,"context_line":""},{"line_number":2086,"context_line":""},{"line_number":2087,"context_line":"class LDAPUserList(BaseLDAPIdentity, unit.TestCase):"},{"line_number":2088,"context_line":""},{"line_number":2089,"context_line":"    def setUp(self):"},{"line_number":2090,"context_line":"        # NOTE(dstanek): The database must be setup prior to calling the"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_1780f48a","line":2087,"in_reply_to":"9a1a9d01_703dbb29","updated":"2015-10-01 12:07:25.000000000","message":"Done","commit_id":"25db8dff9015c45ad0542f4528b9fd2033789aa1"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"8b73d4a73371e49ca7e5762d434a34bf9b0ce2c0","unresolved":false,"context_lines":[{"line_number":2110,"context_line":""},{"line_number":2111,"context_line":"    def test_returned_list_size_is_limited(self):"},{"line_number":2112,"context_line":"        users \u003d self.identity_api.list_users()"},{"line_number":2113,"context_line":"        # NOTE(amakarov): this exposes bug 1501698"},{"line_number":2114,"context_line":"        # list_limit number of entries should be returned"},{"line_number":2115,"context_line":"        self.assertNotEqual(CONF.identity.list_limit, len(users))"},{"line_number":2116,"context_line":"        self.assertEqual(len(default_fixtures.USERS), len(users))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_2b854c06","line":2113,"updated":"2015-10-02 20:13:16.000000000","message":"Should we explain the bug here instead of just putting the bug number?","commit_id":"daf0fb70d03e8f081ddb7e90bfe658de30b187af"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a2c46ce8ccdec45d0bc5b4359a29f760efdf8a92","unresolved":false,"context_lines":[{"line_number":2110,"context_line":""},{"line_number":2111,"context_line":"    def test_returned_list_size_is_limited(self):"},{"line_number":2112,"context_line":"        users \u003d self.identity_api.list_users()"},{"line_number":2113,"context_line":"        # NOTE(amakarov): this exposes bug 1501698"},{"line_number":2114,"context_line":"        # list_limit number of entries should be returned"},{"line_number":2115,"context_line":"        self.assertNotEqual(CONF.identity.list_limit, len(users))"},{"line_number":2116,"context_line":"        self.assertEqual(len(default_fixtures.USERS), len(users))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_6a061122","line":2113,"in_reply_to":"9a1a9d01_2b854c06","updated":"2015-10-05 21:27:44.000000000","message":"the next line explains what\u0027s wrong.","commit_id":"daf0fb70d03e8f081ddb7e90bfe658de30b187af"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"f41a9c1dd1ae5b018f6f129f4eccfc02adc1c13a","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"        users \u003d self.identity_api.list_users()"},{"line_number":2113,"context_line":"        # NOTE(amakarov): this exposes bug 1501698"},{"line_number":2114,"context_line":"        # list_limit number of entries should be returned"},{"line_number":2115,"context_line":"        self.assertNotEqual(CONF.identity.list_limit, len(users))"},{"line_number":2116,"context_line":"        self.assertEqual(len(default_fixtures.USERS), len(users))"},{"line_number":2117,"context_line":""},{"line_number":2118,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_05986c1a","line":2115,"updated":"2015-10-03 11:21:35.000000000","message":"I think we should use the @wip annotation here.\n\nYou should make the test as it should be. Theorically it would then fail, but will be skipped if using @wip. Once fixed in a subsequent patch, the test will pass and the @wip will make it to fail, and everything we will need to do is to remove the annotation, the test won\u0027t be touched anymore.\n\nSee [1] and test_get_policy_association at [2] for an example.\n\nThis test would be like:\n\n    @wip(\"reason for marking as wip, etc\")\n    def test_returned_list_size_is_limited(self):\n        self.assertNotEqual(CONF.identity.list_limit, len(default_fixtures.USERS))\n\n        users \u003d self.identity_api.list_users()\n        self.assertEqual(CONF.identity.list_limit, len(users))\n\n[1] https://github.com/openstack/keystone/blob/master/keystone/tests/unit/utils.py#L55\n\n[2] https://review.openstack.org/#/c/212006/6/keystone/tests/unit/backend/endpoint_policy/test_sql.py","commit_id":"daf0fb70d03e8f081ddb7e90bfe658de30b187af"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8b40902f9fb27bb18a25a36092cbefe3fd521cbb","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"        users \u003d self.identity_api.list_users()"},{"line_number":2113,"context_line":"        # NOTE(amakarov): this exposes bug 1501698"},{"line_number":2114,"context_line":"        # list_limit number of entries should be returned"},{"line_number":2115,"context_line":"        self.assertNotEqual(CONF.identity.list_limit, len(users))"},{"line_number":2116,"context_line":"        self.assertEqual(len(default_fixtures.USERS), len(users))"},{"line_number":2117,"context_line":""},{"line_number":2118,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_3d8377ce","line":2115,"in_reply_to":"7a2fa921_4a1d5572","updated":"2015-10-06 07:45:43.000000000","message":"++","commit_id":"daf0fb70d03e8f081ddb7e90bfe658de30b187af"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e3d5c1a17e47aa68fed1c85b7fa41055d1f387b3","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"        users \u003d self.identity_api.list_users()"},{"line_number":2113,"context_line":"        # NOTE(amakarov): this exposes bug 1501698"},{"line_number":2114,"context_line":"        # list_limit number of entries should be returned"},{"line_number":2115,"context_line":"        self.assertNotEqual(CONF.identity.list_limit, len(users))"},{"line_number":2116,"context_line":"        self.assertEqual(len(default_fixtures.USERS), len(users))"},{"line_number":2117,"context_line":""},{"line_number":2118,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_4a1d5572","line":2115,"in_reply_to":"9a1a9d01_05986c1a","updated":"2015-10-05 21:27:12.000000000","message":"According to the developer docs it\u0027s up to developer whether to use wip or not, see http://docs.openstack.org/developer/keystone/developing.html#work-in-progress-tests -- this was to prevent -1s and extra rework.","commit_id":"daf0fb70d03e8f081ddb7e90bfe658de30b187af"}]}