)]}'
{"keystone/common/wsgi.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"faac14f5e624f68282269131f84fd6c305b82c38","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            eventlet.wsgi.server(socket, application, custom_pool\u003dself.pool,"},{"line_number":134,"context_line":"                                 log\u003dWritableLogger(log))"},{"line_number":135,"context_line":"        except Exception as e:"},{"line_number":136,"context_line":"            log.error(\u0027Server error: %s\u0027 % e)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"class Request(webob.Request):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BkTo%3D","line":136,"updated":"2013-02-27 05:05:01.000000000","message":"not sure why you want to eat the error here. may want to raise e","commit_id":"20f667ed3544441d44b6087ab7b9fa0d5d191340"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ea4cb771b7b4351958bc2b36e205a9054e1ce9c5","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            eventlet.wsgi.server(socket, application, custom_pool\u003dself.pool,"},{"line_number":134,"context_line":"                                 log\u003dWritableLogger(log))"},{"line_number":135,"context_line":"        except Exception as e:"},{"line_number":136,"context_line":"            log.error(\u0027Server error: %s\u0027 % e)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"class Request(webob.Request):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BjXA%3D","line":136,"in_reply_to":"AAAAM3%2F%2BkTo%3D","updated":"2013-02-27 17:16:51.000000000","message":"Done","commit_id":"20f667ed3544441d44b6087ab7b9fa0d5d191340"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4b24378c49458cba2d077370a9d9efdb4842f9b3","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            eventlet.wsgi.server(socket, application, custom_pool\u003dself.pool,"},{"line_number":134,"context_line":"                                 log\u003dWritableLogger(log))"},{"line_number":135,"context_line":"        except Exception as e:"},{"line_number":136,"context_line":"            log.error(_(\u0027Server error: %s\u0027) % e)"},{"line_number":137,"context_line":"            raise"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BjE0%3D","line":136,"updated":"2013-02-27 19:45:39.000000000","message":"LOG.error()? See line 40. May want to use the global one.","commit_id":"872c3ddf4065a273a9a886d6033241290c1188c4"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"3f75ef06875f519029436b308b20d5161aba4e4a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        try:"},{"line_number":133,"context_line":"            eventlet.wsgi.server(socket, application, custom_pool\u003dself.pool,"},{"line_number":134,"context_line":"                                 log\u003dWritableLogger(log))"},{"line_number":135,"context_line":"        except Exception as e:"},{"line_number":136,"context_line":"            LOG.exception(_(\u0027Server error\u0027))"},{"line_number":137,"context_line":"            raise"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2FyVs%3D","line":135,"updated":"2013-03-12 16:31:16.000000000","message":"s/except Exception as e/except/\n\nsince we are not using e in this block.","commit_id":"4f4101c133500be4914347e6265487beea21cbc0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"168999362e922454f4533f7c21db81a0ad001769","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        try:"},{"line_number":133,"context_line":"            eventlet.wsgi.server(socket, application, custom_pool\u003dself.pool,"},{"line_number":134,"context_line":"                                 log\u003dWritableLogger(log))"},{"line_number":135,"context_line":"        except Exception as e:"},{"line_number":136,"context_line":"            LOG.exception(_(\u0027Server error\u0027))"},{"line_number":137,"context_line":"            raise"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2Fx%2Fk%3D","line":135,"in_reply_to":"AAAAN3%2F%2FyVs%3D","updated":"2013-03-12 18:54:01.000000000","message":"I changed it to \"except Exception\", see https://github.com/openstack/keystone/blame/master/HACKING.rst#L16","commit_id":"4f4101c133500be4914347e6265487beea21cbc0"}]}