)]}'
{"keystone/tests/unit/test_catalog.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"75e5791432df1332d02d1c43abac867299852912","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _service_create(self):"},{"line_number":86,"context_line":"        service_id \u003d uuid.uuid4().hex"},{"line_number":87,"context_line":"        service \u003d unit.new_service_ref()"},{"line_number":88,"context_line":"        service[\u0027id\u0027] \u003d service_id"},{"line_number":89,"context_line":"        self.catalog_api.create_service(service_id, service)"},{"line_number":90,"context_line":"        return service_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_d96f73fa","side":"PARENT","line":87,"updated":"2015-10-08 15:42:46.000000000","message":"Good catch, its funny that this line was doing the same thing as the line below it. http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/core.py#n244","commit_id":"43bd7944fe64f8387bc1c5c4e3a0937137a73ff3"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"a9f9ac07974a85402d773e077d59797459a864a5","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _service_create(self):"},{"line_number":86,"context_line":"        service_id \u003d uuid.uuid4().hex"},{"line_number":87,"context_line":"        service \u003d unit.new_service_ref()"},{"line_number":88,"context_line":"        service[\u0027id\u0027] \u003d service_id"},{"line_number":89,"context_line":"        self.catalog_api.create_service(service_id, service)"},{"line_number":90,"context_line":"        return service_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_f12cc39a","side":"PARENT","line":87,"in_reply_to":"7a2fa921_84b2ee92","updated":"2015-10-08 16:16:02.000000000","message":"Oh i\u0027m sorry, i was just saying your change was a good catch!","commit_id":"43bd7944fe64f8387bc1c5c4e3a0937137a73ff3"},{"author":{"_account_id":14413,"name":"Tony Wang","username":"tony","inactive":true},"change_message_id":"7a54cba5d58e6dcbb80111d1173dc49e7f61afa3","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _service_create(self):"},{"line_number":86,"context_line":"        service_id \u003d uuid.uuid4().hex"},{"line_number":87,"context_line":"        service \u003d unit.new_service_ref()"},{"line_number":88,"context_line":"        service[\u0027id\u0027] \u003d service_id"},{"line_number":89,"context_line":"        self.catalog_api.create_service(service_id, service)"},{"line_number":90,"context_line":"        return service_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_84b2ee92","side":"PARENT","line":87,"in_reply_to":"7a2fa921_d96f73fa","updated":"2015-10-08 16:10:54.000000000","message":"sorry I don\u0027t understand, this line calls what you pasted","commit_id":"43bd7944fe64f8387bc1c5c4e3a0937137a73ff3"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"75e5791432df1332d02d1c43abac867299852912","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(service_id, v3_endpoint[\u0027service_id\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_pure_v3_endpoint_without_publicurl_invisible_from_v2(self):"},{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_bea85d8d","line":143,"updated":"2015-10-08 15:42:46.000000000","message":"instead of: \n\n\u0027Test v2 API can\u0027t fetch endpoints of a service has no public url.\u0027\n\nmaybe:\n\nTest v3 endpoint without public url which can\u0027t be fetched via v2 API.\n\nNote: i think this should be changed back since the signature of the function says its testing the v3 API","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":14413,"name":"Tony Wang","username":"tony","inactive":true},"change_message_id":"885091e64659087979f11951179e3000d3b149e5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(service_id, v3_endpoint[\u0027service_id\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_pure_v3_endpoint_without_publicurl_invisible_from_v2(self):"},{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_318b1b6a","line":143,"in_reply_to":"7a2fa921_11329ff2","updated":"2015-10-08 16:19:21.000000000","message":"I don\u0027t know, I\u0027m not very good in English.\nIs \"from v2\" at the end misleading, or should I move v2 forward?\nI didn\u0027t emphasize it is also because the whole file is to test v2 APIs","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"f4d7315be2479284583c331686d43d0962861fdf","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(service_id, v3_endpoint[\u0027service_id\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_pure_v3_endpoint_without_publicurl_invisible_from_v2(self):"},{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_94fbfd7a","line":143,"in_reply_to":"7a2fa921_318b1b6a","updated":"2015-10-08 16:44:22.000000000","message":"Oh okay, I\u0027m sorry if my English is confusing.\n\nWhat about:\n\nTest the v2 API which can\u0027t fetch pure v3 endpoints of a service because they have no public url.\u0027","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"e510c2c5a701e351c5c3a6044e4d432fa7828785","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(service_id, v3_endpoint[\u0027service_id\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_pure_v3_endpoint_without_publicurl_invisible_from_v2(self):"},{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_368f40ce","line":143,"in_reply_to":"7a2fa921_94668428","updated":"2015-11-20 11:11:01.000000000","message":"I just think we should specify v3 endpoints can\u0027t be fetched.\n\n\"... v3 endpoints without public url.\" ?\n\nThe old text wasn\u0027t bad too, in my opinion.","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":14413,"name":"Tony Wang","username":"tony","inactive":true},"change_message_id":"f7a00ede45a64806bda37803de69925b88031bdd","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(service_id, v3_endpoint[\u0027service_id\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_pure_v3_endpoint_without_publicurl_invisible_from_v2(self):"},{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_c706a5cd","line":143,"in_reply_to":"7a2fa921_94fbfd7a","updated":"2015-10-08 16:58:12.000000000","message":"I think it\u0027s not better, because\n1) as a docstring, I\u0027d rather a simple structure, your suggestion is clear, but a bit more complex IMO.\n2) longer than 80 chars.\n\nI think your point is that the missing part is \"v3\", I\u0027ll try to add that, to make it clearer.","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"a9f9ac07974a85402d773e077d59797459a864a5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(service_id, v3_endpoint[\u0027service_id\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_pure_v3_endpoint_without_publicurl_invisible_from_v2(self):"},{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_11329ff2","line":143,"in_reply_to":"7a2fa921_9fda3be7","updated":"2015-10-08 16:16:02.000000000","message":"Should the signature of this function be changed?","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b829b222c71ad592ca65494c2c5458f4d3459efa","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(service_id, v3_endpoint[\u0027service_id\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_pure_v3_endpoint_without_publicurl_invisible_from_v2(self):"},{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_94668428","line":143,"in_reply_to":"7a2fa921_b3dcfd73","updated":"2015-10-09 05:49:05.000000000","message":"In v3 API, one service should normally have three endpoints with different interfaces (admin, internal, public), all of these endpoints which associated with the service will be ignored if there is no endpoint with public interface associated with that service. This happened in the latest change, i.e. when converting v3 endpoints to v2 endpoints.","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":14413,"name":"Tony Wang","username":"tony","inactive":true},"change_message_id":"495d78f03a70af0b3227e29b72cc67434933f36a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(service_id, v3_endpoint[\u0027service_id\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_pure_v3_endpoint_without_publicurl_invisible_from_v2(self):"},{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_b3dcfd73","line":143,"in_reply_to":"7a2fa921_bb114406","updated":"2015-10-09 00:49:00.000000000","message":"That\u0027s my initial version.\nIt\u0027s not v3 endpoints have (or not) public url, but the service has (or not)\n\nYou can see it\u0027s a bit tricky. I was doing compromises here.","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":14413,"name":"Tony Wang","username":"tony","inactive":true},"change_message_id":"7a54cba5d58e6dcbb80111d1173dc49e7f61afa3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(service_id, v3_endpoint[\u0027service_id\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_pure_v3_endpoint_without_publicurl_invisible_from_v2(self):"},{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_9fda3be7","line":143,"in_reply_to":"7a2fa921_bea85d8d","updated":"2015-10-08 16:10:54.000000000","message":"no, it\u0027s testing v2 API, to get v3 endpoints","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"df9ce1528d5ba63076bb0d756460e39737a19bc9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual(service_id, v3_endpoint[\u0027service_id\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_pure_v3_endpoint_without_publicurl_invisible_from_v2(self):"},{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_bb114406","line":143,"in_reply_to":"7a2fa921_c706a5cd","updated":"2015-10-08 18:21:21.000000000","message":"Yes you are right that last one was to long. \n\nHow does this work for you:\n\"Test that the v2 API can\u0027t fetch v3 endpoints that have no public url.\"","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"75e5791432df1332d02d1c43abac867299852912","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"},{"line_number":147,"context_line":"        public url will be ignored."},{"line_number":148,"context_line":"        \"\"\""},{"line_number":149,"context_line":"        region_id \u003d self._region_create()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_befb7d7a","line":146,"updated":"2015-10-08 15:42:46.000000000","message":"instead of: \n\n\u0027v3 endpoints of service which doesn\u0027t has public url will be ignored\u0027  \n\nmaybe:\n\n\u0027therefore v3 endpoints of a service which don\u0027t have public url will be ignored\u0027","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"e510c2c5a701e351c5c3a6044e4d432fa7828785","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        \"\"\"Test v2 API can\u0027t fetch endpoints of a service has no public url."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        v2 API will return endpoints created by v3 API, but public url is"},{"line_number":146,"context_line":"        required for v2 API, v3 endpoints of service which doesn\u0027t has"},{"line_number":147,"context_line":"        public url will be ignored."},{"line_number":148,"context_line":"        \"\"\""},{"line_number":149,"context_line":"        region_id \u003d self._region_create()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_b638103f","line":146,"in_reply_to":"7a2fa921_befb7d7a","updated":"2015-11-20 11:11:01.000000000","message":"++ As we are talking about v3 endpoints, I agree with Tom\u0027s suggestion:\n\ns/doesn\u0027t has/don\u0027t have","commit_id":"93712f1e11e27db2a2344a302d79c77d5f89aa34"}]}