)]}'
{"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"afd7396bca8b3ce63c0aa5d1544c7f664d6212ca","unresolved":false,"context_lines":[{"line_number":2091,"context_line":"    def setUp(self):"},{"line_number":2092,"context_line":"        super(LDAPLimitTests, self).setUp()"},{"line_number":2093,"context_line":""},{"line_number":2094,"context_line":"        self.useFixture(ldapdb.LDAPDatabase())"},{"line_number":2095,"context_line":"        self.useFixture(database.Database())"},{"line_number":2096,"context_line":"        self.load_backends()"},{"line_number":2097,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_4b93f25b","line":2094,"updated":"2015-10-28 21:44:57.000000000","message":"Hopefully we\u0027ll move them into func tests with a real LDAP server in the near future.","commit_id":"8f01f978f09e5fcad2d60b22eafb07d42a708d0a"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"afd7396bca8b3ce63c0aa5d1544c7f664d6212ca","unresolved":false,"context_lines":[{"line_number":2122,"context_line":"    def test_list_groups_filtered_and_limited(self):"},{"line_number":2123,"context_line":"        self._test_list_entity_filtered_and_limited(\u0027group\u0027)"},{"line_number":2124,"context_line":""},{"line_number":2125,"context_line":"    def test_list_projects_filtered_and_limited(self):"},{"line_number":2126,"context_line":"        self.skipTest(\"ldap for storing projects is deprecated\")"},{"line_number":2127,"context_line":""},{"line_number":2128,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_6bab4e8a","line":2125,"updated":"2015-10-28 21:44:57.000000000","message":"why bother to put the test here?","commit_id":"8f01f978f09e5fcad2d60b22eafb07d42a708d0a"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"513592592935f5e528c32fe8660bebe5a1022984","unresolved":false,"context_lines":[{"line_number":2122,"context_line":"    def test_list_groups_filtered_and_limited(self):"},{"line_number":2123,"context_line":"        self._test_list_entity_filtered_and_limited(\u0027group\u0027)"},{"line_number":2124,"context_line":""},{"line_number":2125,"context_line":"    def test_list_projects_filtered_and_limited(self):"},{"line_number":2126,"context_line":"        self.skipTest(\"ldap for storing projects is deprecated\")"},{"line_number":2127,"context_line":""},{"line_number":2128,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_61ddaf41","line":2125,"in_reply_to":"1a26ad4f_6bab4e8a","updated":"2015-10-28 23:24:25.000000000","message":"The class is inherited from test_backend.LimitTests and the method is defined there. It works in SQL and shouldn\u0027t work in LDAP.","commit_id":"8f01f978f09e5fcad2d60b22eafb07d42a708d0a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8c6468df51e8f7ce20fd0296274d4d4126144a71","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"        self.assertEqual(\u0027Foo Bar\u0027, user_ref[\u0027name\u0027])"},{"line_number":2054,"context_line":""},{"line_number":2055,"context_line":""},{"line_number":2056,"context_line":"class LDAPLimitTests(unit.TestCase, test_backend.LimitTests):"},{"line_number":2057,"context_line":"    def setUp(self):"},{"line_number":2058,"context_line":"        super(LDAPLimitTests, self).setUp()"},{"line_number":2059,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_645426ca","line":2056,"updated":"2015-11-30 17:09:38.000000000","message":"do you still need to inherit unit.TestCase? Shouldn\u0027t that already be in the hierarchy of test_backend.LimitTests?","commit_id":"396bb400f257726112e9c4121d0191bfe1a8b6a7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d63c0d84de8dddc6d36d7c4d653295c8a8cd7eed","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"        self.assertEqual(\u0027Foo Bar\u0027, user_ref[\u0027name\u0027])"},{"line_number":2054,"context_line":""},{"line_number":2055,"context_line":""},{"line_number":2056,"context_line":"class LDAPLimitTests(unit.TestCase, test_backend.LimitTests):"},{"line_number":2057,"context_line":"    def setUp(self):"},{"line_number":2058,"context_line":"        super(LDAPLimitTests, self).setUp()"},{"line_number":2059,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_044aff83","line":2056,"in_reply_to":"9a8ffd7b_58088d2d","updated":"2015-12-03 18:07:07.000000000","message":"interesting, it would be nice if it used the same inheritance, but that can be done in a separate patch.","commit_id":"396bb400f257726112e9c4121d0191bfe1a8b6a7"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"18b32301913dd7ca090e7084d9440d054d75933c","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"        self.assertEqual(\u0027Foo Bar\u0027, user_ref[\u0027name\u0027])"},{"line_number":2054,"context_line":""},{"line_number":2055,"context_line":""},{"line_number":2056,"context_line":"class LDAPLimitTests(unit.TestCase, test_backend.LimitTests):"},{"line_number":2057,"context_line":"    def setUp(self):"},{"line_number":2058,"context_line":"        super(LDAPLimitTests, self).setUp()"},{"line_number":2059,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_cd396eda","line":2056,"in_reply_to":"9a8ffd7b_645426ca","updated":"2015-11-30 20:02:42.000000000","message":"Yes. LimitTests inherits from FilterTests, FilterTests from object. So inheriting is still needed.","commit_id":"396bb400f257726112e9c4121d0191bfe1a8b6a7"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"537d98edf1895770fe93e29e4b8cb031e93e8350","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"        self.assertEqual(\u0027Foo Bar\u0027, user_ref[\u0027name\u0027])"},{"line_number":2054,"context_line":""},{"line_number":2055,"context_line":""},{"line_number":2056,"context_line":"class LDAPLimitTests(unit.TestCase, test_backend.LimitTests):"},{"line_number":2057,"context_line":"    def setUp(self):"},{"line_number":2058,"context_line":"        super(LDAPLimitTests, self).setUp()"},{"line_number":2059,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_58088d2d","line":2056,"in_reply_to":"9a8ffd7b_cd396eda","updated":"2015-12-02 00:08:44.000000000","message":"Lance, yes it is needed still. See\n\nhttps://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_backend.py#L6760\nhttps://github.com/openstack/keystone/blob/master/keystone/tests/unit/filtering.py#L24","commit_id":"396bb400f257726112e9c4121d0191bfe1a8b6a7"}]}