)]}'
{"keystone/common/sql/migrate_repo/versions/082_add_federation_tables.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4586d2beb9285e2ef04407705786ef199c070b31","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    except Exception:"},{"line_number":30,"context_line":"        extension_version \u003d 0"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # This extension corresponds to federation extension migration 8. Only"},{"line_number":33,"context_line":"    # update if it has not been run."},{"line_number":34,"context_line":"    if extension_version \u003e\u003d 8:"},{"line_number":35,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a26ad4f_70cb2454","line":32,"updated":"2015-10-29 13:35:59.000000000","message":"change \u0027extension\u0027 to \u0027migration\u0027","commit_id":"1463b17ef7201bde1fd10e75a9b10db6f4c66114"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f5ed9bf674830620c3906f75b29d9d72498c559b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    except Exception:"},{"line_number":30,"context_line":"        extension_version \u003d 0"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # This extension corresponds to federation extension migration 8. Only"},{"line_number":33,"context_line":"    # update if it has not been run."},{"line_number":34,"context_line":"    if extension_version \u003e\u003d 8:"},{"line_number":35,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a26ad4f_7fb76386","line":32,"in_reply_to":"1a26ad4f_70cb2454","updated":"2015-10-30 01:08:22.000000000","message":"Done","commit_id":"1463b17ef7201bde1fd10e75a9b10db6f4c66114"}],"keystone/contrib/federation/migrate_repo/versions/008_add_relay_state_to_sp.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4586d2beb9285e2ef04407705786ef199c070b31","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def upgrade(migrate_engine):"},{"line_number":17,"context_line":"    migration_helpers.migration_moved_failure(\u0027federation\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a26ad4f_d0b318e8","line":17,"updated":"2015-10-29 13:35:59.000000000","message":"should be changed to:\n\n  raise exception.MigrationMovedFailure(extension\u003d\u0027federation\u0027)\n\nand for all from 001-007","commit_id":"1463b17ef7201bde1fd10e75a9b10db6f4c66114"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f5ed9bf674830620c3906f75b29d9d72498c559b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def upgrade(migrate_engine):"},{"line_number":17,"context_line":"    migration_helpers.migration_moved_failure(\u0027federation\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a26ad4f_4243b042","line":17,"in_reply_to":"1a26ad4f_d0b318e8","updated":"2015-10-30 01:08:22.000000000","message":"Done","commit_id":"1463b17ef7201bde1fd10e75a9b10db6f4c66114"}],"keystone/tests/unit/test_sql_migrate_extensions.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"13de39fce874a9e2aa00ddc324a1e9b7cdb710a3","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        self.upgrade(8, repository\u003dself.repo_path)"},{"line_number":365,"context_line":"        self.assertTableColumns(self.service_provider,"},{"line_number":366,"context_line":"                                [\u0027id\u0027, \u0027description\u0027, \u0027enabled\u0027, \u0027auth_url\u0027,"},{"line_number":367,"context_line":"                                 \u0027relay_state_prefix\u0027, \u0027sp_url\u0027])"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"class RevokeExtension(test_sql_upgrade.SqlMigrateBase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_2146f723","side":"PARENT","line":367,"updated":"2015-10-19 08:34:18.000000000","message":"am i missing something and this should but is not moved somewhere else or this piece of code is completely removed intentionally?\nIf so - why?","commit_id":"be9731101f9c80026460834563f90436dc4c72dc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4ebb1ffd72a7e8562cb4d2711d209026c7f30c15","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        self.upgrade(8, repository\u003dself.repo_path)"},{"line_number":365,"context_line":"        self.assertTableColumns(self.service_provider,"},{"line_number":366,"context_line":"                                [\u0027id\u0027, \u0027description\u0027, \u0027enabled\u0027, \u0027auth_url\u0027,"},{"line_number":367,"context_line":"                                 \u0027relay_state_prefix\u0027, \u0027sp_url\u0027])"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"class RevokeExtension(test_sql_upgrade.SqlMigrateBase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_c4605838","side":"PARENT","line":367,"in_reply_to":"3a29b11f_2146f723","updated":"2015-10-19 16:12:14.000000000","message":"these all tested the individual migrations that were in the federation repo, since they are being squashed into one, i just created a single test, here: https://review.openstack.org/#/c/234537/8/keystone/tests/unit/test_sql_upgrade.py\n\ni should still create a test here to make sure an exception is raised, refer to: https://review.openstack.org/#/c/171916/19/keystone/tests/unit/test_sql_migrate_extensions.py","commit_id":"be9731101f9c80026460834563f90436dc4c72dc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4586d2beb9285e2ef04407705786ef199c070b31","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def test_upgrade(self):"},{"line_number":178,"context_line":"        for version in range(8):"},{"line_number":179,"context_line":"            self.assertRaises(exception.MigrationMovedFailure,"},{"line_number":180,"context_line":"                              self.upgrade, version\u003d+1,"},{"line_number":181,"context_line":"                              repository\u003dself.repo_path)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a26ad4f_90912055","line":180,"updated":"2015-10-29 13:35:59.000000000","message":"shouldn\u0027t this be version\u003dversion?","commit_id":"1463b17ef7201bde1fd10e75a9b10db6f4c66114"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f5ed9bf674830620c3906f75b29d9d72498c559b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def test_upgrade(self):"},{"line_number":178,"context_line":"        for version in range(8):"},{"line_number":179,"context_line":"            self.assertRaises(exception.MigrationMovedFailure,"},{"line_number":180,"context_line":"                              self.upgrade, version\u003d+1,"},{"line_number":181,"context_line":"                              repository\u003dself.repo_path)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a26ad4f_024db86b","line":180,"in_reply_to":"1a26ad4f_90912055","updated":"2015-10-30 01:08:22.000000000","message":"Done","commit_id":"1463b17ef7201bde1fd10e75a9b10db6f4c66114"}],"keystone/tests/unit/test_sql_upgrade.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6d5d8b4f1e8cbc97a5fc4c9a636f9249102de11f","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        self.assertTableColumns(self.service_provider,"},{"line_number":590,"context_line":"                                [\u0027id\u0027, \u0027description\u0027, \u0027enabled\u0027, \u0027auth_url\u0027,"},{"line_number":591,"context_line":"                                 \u0027relay_state_prefix\u0027, \u0027sp_url\u0027])"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"        federation_protocol \u003d sqlalchemy.Table(self.federation_protocol,"},{"line_number":594,"context_line":"                                               self.metadata,"},{"line_number":595,"context_line":"                                               autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":18,"id":"da85f559_4b1b90ca","line":592,"updated":"2015-11-11 15:50:21.000000000","message":"Add an assertion here for the \u0027idp_remote_ids\u0027 table. \n\n    self.assertTableColumns(self.remote_ids, columns)","commit_id":"92cd56d80bf1df27dfc34225e610cca88cbf4aa0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b9779e8ce32686953f70a2c281467e1175d202dc","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        self.assertTableColumns(self.service_provider,"},{"line_number":590,"context_line":"                                [\u0027id\u0027, \u0027description\u0027, \u0027enabled\u0027, \u0027auth_url\u0027,"},{"line_number":591,"context_line":"                                 \u0027relay_state_prefix\u0027, \u0027sp_url\u0027])"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"        federation_protocol \u003d sqlalchemy.Table(self.federation_protocol,"},{"line_number":594,"context_line":"                                               self.metadata,"},{"line_number":595,"context_line":"                                               autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba8a016a_2741f0a9","line":592,"in_reply_to":"da85f559_4b1b90ca","updated":"2015-11-17 19:34:17.000000000","message":"will do in the next patch","commit_id":"92cd56d80bf1df27dfc34225e610cca88cbf4aa0"}]}