)]}'
{"keystone/token/providers/fernet/core.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"205cf85b73579fba6b0f131993943e26d8baa453","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        :param token_data: token information"},{"line_number":276,"context_line":"        :type token_data: dict"},{"line_number":277,"context_line":"        :raises keystone.exception.NotImplemented: if the action that is"},{"line_number":278,"context_line":"                                                  requested is not implemented"},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        return self.token_formatter.create_token("},{"line_number":281,"context_line":"            token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_2d28dce1","line":278,"updated":"2015-10-15 08:33:33.000000000","message":"These docstring will not be rendered since it is a private method, and this is over-indent which will cause the docstring rendered has a bad format.\n\n\nAs I replied to you and lance before either one of following is acceptable per my understanding.\n\nraises keystone.exception.NotImplemented: if the action that is\n    requested is not implemented   \n\nor\n\nraises keystone.exception.NotImplemented: if the action that is \n       requested is not implemented","commit_id":"153814df4070fd67da094c58d962fc3afcc8b324"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"647ab97b45c2675f96b43296ef5536a767dad215","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        :param token_data: token information"},{"line_number":276,"context_line":"        :type token_data: dict"},{"line_number":277,"context_line":"        :raises keystone.exception.NotImplemented: if the action that is"},{"line_number":278,"context_line":"                                                  requested is not implemented"},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        return self.token_formatter.create_token("},{"line_number":281,"context_line":"            token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_13d4fee9","line":278,"in_reply_to":"5a2ca52d_2d28dce1","updated":"2015-10-15 20:49:02.000000000","message":"Done","commit_id":"153814df4070fd67da094c58d962fc3afcc8b324"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"a16ca2b8ace58bea5e9961f9a7a7971f1022b1e4","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        :param token_data: token information"},{"line_number":276,"context_line":"        :type token_data: dict"},{"line_number":277,"context_line":"        :raises keystone.exception.NotImplemented: if the action that is"},{"line_number":278,"context_line":"                                                  requested is not implemented"},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        return self.token_formatter.create_token("},{"line_number":281,"context_line":"            token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_2e6f64c6","line":278,"in_reply_to":"5a2ca52d_2d28dce1","updated":"2015-10-15 13:47:36.000000000","message":"I was sticking to the format in this doc to keep it consistent.  I also generated the docs and all the docstrings that are over indented generate perfectly.","commit_id":"153814df4070fd67da094c58d962fc3afcc8b324"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5160b8d3a7147689e6b6647112ffcdf88717f620","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        :param token: a string describing the token to validate"},{"line_number":238,"context_line":"        :returns: the token data"},{"line_number":239,"context_line":"        :raises keystone.exception.TokenNotFound: if token format version isn\u0027t"},{"line_number":240,"context_line":"                                                 supported"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_e7ad5389","line":239,"updated":"2015-10-19 17:22:27.000000000","message":"should this one be fixed to be consistent?","commit_id":"1d0ce11a6dfb25cc703529d16f94a6bc4820a8dc"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"b2b0805ee50f85dbd7ebba55f683109b5dd44e2f","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        :param token: a string describing the token to validate"},{"line_number":238,"context_line":"        :returns: the token data"},{"line_number":239,"context_line":"        :raises keystone.exception.TokenNotFound: if token format version isn\u0027t"},{"line_number":240,"context_line":"                                                 supported"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_807245e4","line":239,"in_reply_to":"3a29b11f_e7ad5389","updated":"2015-10-19 18:36:15.000000000","message":"Done","commit_id":"1d0ce11a6dfb25cc703529d16f94a6bc4820a8dc"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0799eeb31c2a6562654f321e4e66751823db3c03","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        :param token_dict: dictionary with data used for building token"},{"line_number":187,"context_line":"        :param federated_dict: federated information such as identity provider"},{"line_number":188,"context_line":"                protocol and set of group IDs"},{"line_number":189,"context_line":"        :param user_id: user ID"},{"line_number":190,"context_line":"        :param project_id: project ID the token is being scoped to"},{"line_number":191,"context_line":"        :param domain_id: domain ID the token is being scoped to"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_69c2ff35","line":188,"updated":"2015-10-21 20:45:10.000000000","message":"If we\u0027re going to pick a convention for indenting for params, it should be you indent by 4 spaces or you indent to where the text starts after the : . Indenting by 8 spaces isn\u0027t part of any convention.\n\nThis comment also applies to the change at line 240.","commit_id":"076257c5b635a4d69f1c5d0254aa57af80d5d0f7"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"21cfe387957e27fbfd60ff839b2eaa46143f7605","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        :param token_dict: dictionary with data used for building token"},{"line_number":187,"context_line":"        :param federated_dict: federated information such as identity provider"},{"line_number":188,"context_line":"                protocol and set of group IDs"},{"line_number":189,"context_line":"        :param user_id: user ID"},{"line_number":190,"context_line":"        :param project_id: project ID the token is being scoped to"},{"line_number":191,"context_line":"        :param domain_id: domain ID the token is being scoped to"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_049da609","line":188,"updated":"2015-10-20 22:10:24.000000000","message":"same as below, and this is a private method","commit_id":"076257c5b635a4d69f1c5d0254aa57af80d5d0f7"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"55ac48049a77c449333afac600bfd958b79beb73","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        :param token_dict: dictionary with data used for building token"},{"line_number":187,"context_line":"        :param federated_dict: federated information such as identity provider"},{"line_number":188,"context_line":"                protocol and set of group IDs"},{"line_number":189,"context_line":"        :param user_id: user ID"},{"line_number":190,"context_line":"        :param project_id: project ID the token is being scoped to"},{"line_number":191,"context_line":"        :param domain_id: domain ID the token is being scoped to"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_8d574725","line":188,"in_reply_to":"3a29b11f_69c2ff35","updated":"2015-10-22 14:19:20.000000000","message":"Done","commit_id":"076257c5b635a4d69f1c5d0254aa57af80d5d0f7"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"21cfe387957e27fbfd60ff839b2eaa46143f7605","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        :param token: a string describing the token to validate"},{"line_number":238,"context_line":"        :returns: the token data"},{"line_number":239,"context_line":"        :raises keystone.exception.TokenNotFound: if token format version isn\u0027t"},{"line_number":240,"context_line":"                supported"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        \"\"\""},{"line_number":243,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_44971eec","line":240,"updated":"2015-10-20 22:10:24.000000000","message":"? This does not impact the rendered output.\n\nOriginal: http://docs.openstack.org/developer/keystone/api/keystone.token.providers.fernet.html#keystone.token.providers.fernet.core.Provider.validate_v3_token\n\nThis patchset: http://docs-draft.openstack.org/81/234881/4/check/gate-keystone-docs/9aef689//doc/build/html/api/keystone.token.providers.fernet.html#keystone.token.providers.fernet.core.Provider.validate_v3_token","commit_id":"076257c5b635a4d69f1c5d0254aa57af80d5d0f7"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"acdece3eada406e367af13bbcbe8cb1f32a36ab2","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        :param token: a string describing the token to validate"},{"line_number":238,"context_line":"        :returns: the token data"},{"line_number":239,"context_line":"        :raises keystone.exception.TokenNotFound: if token format version isn\u0027t"},{"line_number":240,"context_line":"                supported"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        \"\"\""},{"line_number":243,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_9e1d5664","line":240,"in_reply_to":"3a29b11f_44971eec","updated":"2015-10-21 16:36:03.000000000","message":"I know but it was pointed out that the tabbing should be the same through out the file.  Thanks for showing me that the gate auto generates the docs, this will be helpful in the future.","commit_id":"076257c5b635a4d69f1c5d0254aa57af80d5d0f7"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"21cfe387957e27fbfd60ff839b2eaa46143f7605","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        :param token_data: token information"},{"line_number":276,"context_line":"        :type token_data: dict"},{"line_number":277,"context_line":"        :raises keystone.exception.NotImplemented: if the action that is"},{"line_number":278,"context_line":"                requested is not implemented"},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        return self.token_formatter.create_token("},{"line_number":281,"context_line":"            token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_c48b2ec2","line":278,"updated":"2015-10-20 22:10:24.000000000","message":"+1","commit_id":"076257c5b635a4d69f1c5d0254aa57af80d5d0f7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0799eeb31c2a6562654f321e4e66751823db3c03","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        :param token_data: token information"},{"line_number":276,"context_line":"        :type token_data: dict"},{"line_number":277,"context_line":"        :raises keystone.exception.NotImplemented: if the action that is"},{"line_number":278,"context_line":"                requested is not implemented"},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        return self.token_formatter.create_token("},{"line_number":281,"context_line":"            token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_d42406c6","line":278,"updated":"2015-10-21 20:45:10.000000000","message":"I thought this was just left over from when the implementation was copied from the base class since that raises NotImplemented. I think this should just be removed instead since we\u0027re not expecting a NotImplemented error here.","commit_id":"076257c5b635a4d69f1c5d0254aa57af80d5d0f7"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"55ac48049a77c449333afac600bfd958b79beb73","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        :param token_data: token information"},{"line_number":276,"context_line":"        :type token_data: dict"},{"line_number":277,"context_line":"        :raises keystone.exception.NotImplemented: if the action that is"},{"line_number":278,"context_line":"                requested is not implemented"},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        return self.token_formatter.create_token("},{"line_number":281,"context_line":"            token_data[\u0027token\u0027][\u0027user\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_e1de0adc","line":278,"in_reply_to":"3a29b11f_d42406c6","updated":"2015-10-22 14:19:20.000000000","message":"Stepping through the code there is no way that \u0027NotImplemented\u0027 will be raised.  Good Catch!","commit_id":"076257c5b635a4d69f1c5d0254aa57af80d5d0f7"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b4425b946d61abc744c2c100c56d3fac67ff676a","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        \"\"\"Return if the token provider supports bind authentication methods."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        :returns: False"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        \"\"\""},{"line_number":297,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_ff73ace5","line":295,"updated":"2015-10-26 09:11:15.000000000","message":"this change might not necessary as there is no guideline anywhere tell us there should be blank line before \"\"\"\n\nBut you said this should be consistent through the file so I am fine with it.","commit_id":"b74775f03375819da3e3fe33103c32595d9ffd45"}]}