)]}'
{"keystone/contrib/revoke/backends/sql.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4bde48d6d49f59070f8b96cb1f52d0caf9a89088","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @versionutils.deprecated(versionutils.deprecated.MITAKA,"},{"line_number":25,"context_line":"                             in_favor_of\u003d_NEW,"},{"line_number":26,"context_line":"                             what\u003d_OLD)"},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(Revoke, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_8b18971f","line":26,"updated":"2015-11-11 16:02:55.000000000","message":"missing remove_in","commit_id":"d627826e418bf8d4bcd16b2b5b1acebcbe2a0794"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0ce0e94f9e9afe97ef9687ec9512f20d6aa7c6b3","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @versionutils.deprecated(versionutils.deprecated.MITAKA,"},{"line_number":25,"context_line":"                             in_favor_of\u003d_NEW,"},{"line_number":26,"context_line":"                             what\u003d_OLD)"},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(Revoke, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_6b8b0169","line":26,"in_reply_to":"ba8a016a_ea1baf19","updated":"2015-11-18 21:01:29.000000000","message":"makes sense, thanks for updating me!","commit_id":"d627826e418bf8d4bcd16b2b5b1acebcbe2a0794"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"f351757b83c444ae265b76a10b1969b2bb4d9d18","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @versionutils.deprecated(versionutils.deprecated.MITAKA,"},{"line_number":25,"context_line":"                             in_favor_of\u003d_NEW,"},{"line_number":26,"context_line":"                             what\u003d_OLD)"},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(Revoke, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_fa324b5d","line":26,"in_reply_to":"da85f559_8b18971f","updated":"2015-11-11 17:18:22.000000000","message":"I think this was required to be removed per the comments in the earlier review since remove in +2 was the default setting.\n\nBut I am okay to add it back.","commit_id":"d627826e418bf8d4bcd16b2b5b1acebcbe2a0794"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8560aa5fcafe9e1606c6b40514d5fcf7b879c6cc","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @versionutils.deprecated(versionutils.deprecated.MITAKA,"},{"line_number":25,"context_line":"                             in_favor_of\u003d_NEW,"},{"line_number":26,"context_line":"                             what\u003d_OLD)"},{"line_number":27,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":28,"context_line":"        super(Revoke, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_ea1baf19","line":26,"in_reply_to":"da85f559_fa324b5d","updated":"2015-11-17 19:49:30.000000000","message":"i was asked to remove that since it\u0027s default","commit_id":"d627826e418bf8d4bcd16b2b5b1acebcbe2a0794"}],"keystone/revoke/backends/kvs.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"f72a57b3328e383fc5a9da2c7ad319afb799381d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        versionutils.deprecated.JUNO,"},{"line_number":34,"context_line":"        in_favor_of\u003d\u0027keystone.revoke.backends.sql\u0027,"},{"line_number":35,"context_line":"        remove_in\u003d+1,"},{"line_number":36,"context_line":"        what\u003d\u0027keystone.revoke.backends.kvs\u0027)"},{"line_number":37,"context_line":"    def __init__(self, **kwargs):"},{"line_number":38,"context_line":"        super(Revoke, self).__init__()"},{"line_number":39,"context_line":"        self._store \u003d kvs.get_key_value_store(\u0027os-revoke-driver\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_8a261415","line":36,"updated":"2015-10-18 12:51:43.000000000","message":"interesting, this is still hanging around.","commit_id":"8dbc7d3e2f2c85d26dd1bc5a8179eaac25995b5f"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5875f873970320efec9be1b77548739ffa58d473","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        versionutils.deprecated.JUNO,"},{"line_number":34,"context_line":"        in_favor_of\u003d\u0027keystone.revoke.backends.sql\u0027,"},{"line_number":35,"context_line":"        remove_in\u003d+1,"},{"line_number":36,"context_line":"        what\u003d\u0027keystone.revoke.backends.kvs\u0027)"},{"line_number":37,"context_line":"    def __init__(self, **kwargs):"},{"line_number":38,"context_line":"        super(Revoke, self).__init__()"},{"line_number":39,"context_line":"        self._store \u003d kvs.get_key_value_store(\u0027os-revoke-driver\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_467eb4e5","line":36,"in_reply_to":"3a29b11f_8a261415","updated":"2015-10-18 18:29:08.000000000","message":"yeah, when i last investigated this, we decided to keep the kvs backend around. i moved it to keep things in this patch consistent, but we should determine if we\u0027re keeping it or not (it was deprecated in juno...)","commit_id":"8dbc7d3e2f2c85d26dd1bc5a8179eaac25995b5f"}],"keystone/revoke/core.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"f72a57b3328e383fc5a9da2c7ad319afb799381d","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        \"\"\"register a revocation event"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        :param event: An instance of"},{"line_number":256,"context_line":"            keystone.contrib.model.RevocationEvent"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        \"\"\""},{"line_number":259,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_4afc7c3e","line":256,"updated":"2015-10-18 12:51:43.000000000","message":"nits: keystone.revoke.model.RevocationEvent","commit_id":"8dbc7d3e2f2c85d26dd1bc5a8179eaac25995b5f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d80e69c073391752b40f1353efe6f396522a914a","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        \"\"\"register a revocation event"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        :param event: An instance of"},{"line_number":256,"context_line":"            keystone.contrib.model.RevocationEvent"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        \"\"\""},{"line_number":259,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_6a037810","line":256,"in_reply_to":"3a29b11f_4afc7c3e","updated":"2015-10-18 13:07:17.000000000","message":"Done","commit_id":"8dbc7d3e2f2c85d26dd1bc5a8179eaac25995b5f"}]}