)]}'
{"keystone/common/validation/parameter_types.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7e0b75d3963faa70afffea1b2981b8483a3ab942","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027maxLength\u0027: 225,"},{"line_number":54,"context_line":"    # NOTE(edmondsw): we could do more to validate per various RFCs, but"},{"line_number":55,"context_line":"    # decision was made to err on the side of leniency. The following is based"},{"line_number":56,"context_line":"    # on rfc1738 section 2.1"},{"line_number":57,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9+.-]+:.+\u0027"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_7af08391","line":56,"updated":"2015-10-16 13:30:17.000000000","message":"Not sure if we should amend this comment or not to include the match for whitespace at the beginning of the string. I don\u0027t think that is something that is included in rfc1738. \n\nTaking a look at https://www.ietf.org/rfc/rfc1738.txt and I\u0027m not seeing any docs saying what we\u0027re adding breaks.","commit_id":"9dbc5ca16b3c359670d7c3073f3aef09088350cb"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"aa7d8edb98b216a1cc8555d6b8b7bc175d423493","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027maxLength\u0027: 225,"},{"line_number":54,"context_line":"    # NOTE(edmondsw): we could do more to validate per various RFCs, but"},{"line_number":55,"context_line":"    # decision was made to err on the side of leniency. The following is based"},{"line_number":56,"context_line":"    # on rfc1738 section 2.1"},{"line_number":57,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9+.-]+:.+\u0027"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_bab29b92","line":56,"in_reply_to":"5a2ca52d_7af08391","updated":"2015-10-16 13:34:56.000000000","message":"I think we should leave the comment as is. The rfc doesn\u0027t propose a regex for an url. However, it says that \u003cscheme\u003e doesn\u0027t contain any whitespace characters and should be the first part of the url. The regex enforces this now.","commit_id":"9dbc5ca16b3c359670d7c3073f3aef09088350cb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f71f1dbae5521c753ee01720c1b5a29b60b6cf65","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027maxLength\u0027: 225,"},{"line_number":54,"context_line":"    # NOTE(edmondsw): we could do more to validate per various RFCs, but"},{"line_number":55,"context_line":"    # decision was made to err on the side of leniency. The following is based"},{"line_number":56,"context_line":"    # on rfc1738 section 2.1"},{"line_number":57,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9+.-]+:.+\u0027"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_2adaac4c","line":56,"in_reply_to":"5a2ca52d_a0502ad5","updated":"2015-10-16 17:27:54.000000000","message":"works for me!","commit_id":"9dbc5ca16b3c359670d7c3073f3aef09088350cb"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9fc48ec36f9876a648696055f05a96b2e58cda13","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027maxLength\u0027: 225,"},{"line_number":54,"context_line":"    # NOTE(edmondsw): we could do more to validate per various RFCs, but"},{"line_number":55,"context_line":"    # decision was made to err on the side of leniency. The following is based"},{"line_number":56,"context_line":"    # on rfc1738 section 2.1"},{"line_number":57,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9+.-]+:.+\u0027"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_a0502ad5","line":56,"in_reply_to":"5a2ca52d_bab29b92","updated":"2015-10-16 14:03:46.000000000","message":"I agree with Boris. Section 2.1 lists the acceptable characters and whitespace isn\u0027t in that list.","commit_id":"9dbc5ca16b3c359670d7c3073f3aef09088350cb"}]}