)]}'
{"keystone/tests/unit/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a9fe49b8a35aa14e956bc62d4acbbbbbdfae4c06","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        \u0027domain_id\u0027: domain_id"},{"line_number":346,"context_line":"    }"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    ref[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":349,"context_line":"    ref.update(**kwargs)"},{"line_number":350,"context_line":"    return ref"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_ec6d4f33","line":348,"updated":"2015-11-16 19:17:37.000000000","message":"this is not necessary","commit_id":"e73c891ea497c40380dd065d7b2381fc4a7d1a44"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"159ff45ec8b266f1292117f92e439a87c36e449a","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        \u0027domain_id\u0027: domain_id"},{"line_number":346,"context_line":"    }"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    ref[\u0027domain_id\u0027] \u003d domain_id"},{"line_number":349,"context_line":"    ref.update(**kwargs)"},{"line_number":350,"context_line":"    return ref"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_8feef520","line":348,"in_reply_to":"ba8a016a_ec6d4f33","updated":"2015-11-16 19:31:23.000000000","message":"Done","commit_id":"e73c891ea497c40380dd065d7b2381fc4a7d1a44"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"ff13089b21460b089f3ea96db489078895760305","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    ref \u003d {"},{"line_number":327,"context_line":"        \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":328,"context_line":"        \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":329,"context_line":"        \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":330,"context_line":"        \u0027enabled\u0027: True,"},{"line_number":331,"context_line":"        \u0027domain_id\u0027: domain_id,"},{"line_number":332,"context_line":"        \u0027email\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_8fa6f5bf","line":329,"updated":"2015-11-16 19:34:11.000000000","message":"I had to remove \u0027description\u0027 in my patchset moving everything to use_*_ref() because it broke all of the LDAP tests and a few others. Since the LDAP tests derive from the same tests none of them could have description.","commit_id":"06195d2b53b35831187f8ad5ab1a514a4e90770c"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a70f5987b388a554d8795b2f4f4edb058644924d","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    ref \u003d {"},{"line_number":327,"context_line":"        \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":328,"context_line":"        \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":329,"context_line":"        \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":330,"context_line":"        \u0027enabled\u0027: True,"},{"line_number":331,"context_line":"        \u0027domain_id\u0027: domain_id,"},{"line_number":332,"context_line":"        \u0027email\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_320c0c94","line":329,"in_reply_to":"ba8a016a_8fa6f5bf","updated":"2015-11-16 19:55:05.000000000","message":"it might be a good idea to go through and remove *all* optional fields once the other refactoring is done.","commit_id":"06195d2b53b35831187f8ad5ab1a514a4e90770c"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"83400f3bb1cb9e96696be3090913a6d8152cefac","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":246,"context_line":"        \u0027parent_region_id\u0027: parent_region_id}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    ref.update(kwargs)"},{"line_number":249,"context_line":"    return ref"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_0ffb6c48","line":248,"updated":"2015-11-18 17:31:19.000000000","message":"should we extract the keyword parameters before we pass them to update just like all the other functions?","commit_id":"712462625be4a626816362b6b05f427f18aaa313"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d8d23dc215ecb0adccc28b113aad08f0bf8adcb0","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":246,"context_line":"        \u0027parent_region_id\u0027: parent_region_id}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    ref.update(kwargs)"},{"line_number":249,"context_line":"    return ref"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_6df9e0c6","line":248,"in_reply_to":"ba8a016a_0ffb6c48","updated":"2015-11-18 17:53:11.000000000","message":"extract? The only thing in kwargs will be the unnamed kw args.","commit_id":"712462625be4a626816362b6b05f427f18aaa313"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"defb0734a133db99014e627b49aab42c7ed08607","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":246,"context_line":"        \u0027parent_region_id\u0027: parent_region_id}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    ref.update(kwargs)"},{"line_number":249,"context_line":"    return ref"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_ff61ef39","line":248,"in_reply_to":"ba8a016a_68af8ee2","updated":"2015-11-18 19:31:56.000000000","message":"can i make a patch changing all these to use \u0027kwargs\u0027? To me it seems not to make sense to use \u0027**kwargs\u0027   Does anyone have a reason on why use \u0027**kwargs\u0027 in this situation?","commit_id":"712462625be4a626816362b6b05f427f18aaa313"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"d89ba2c24820a6c397179426dee72d23e2ad9531","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":246,"context_line":"        \u0027parent_region_id\u0027: parent_region_id}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    ref.update(kwargs)"},{"line_number":249,"context_line":"    return ref"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_8d6be4f0","line":248,"in_reply_to":"ba8a016a_6df9e0c6","updated":"2015-11-18 17:58:45.000000000","message":"I think he\u0027s asking if the ref.update(kwargs) lines should all be ref.update(**kwargs) (see line 260 for example).","commit_id":"712462625be4a626816362b6b05f427f18aaa313"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"3a35af32f093f7b0b0cf65ae10da068ef611dfca","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":246,"context_line":"        \u0027parent_region_id\u0027: parent_region_id}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    ref.update(kwargs)"},{"line_number":249,"context_line":"    return ref"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_68af8ee2","line":248,"in_reply_to":"ba8a016a_8d6be4f0","updated":"2015-11-18 18:04:54.000000000","message":"I was inconsistent with this in my own patches.\n\nkwargs is a dict. It is ok to call dict.update(another_dict). The **kwargs form simply expands the dict to then reform the dict and then use it. So for this case we should prefer the no asterisk version.","commit_id":"712462625be4a626816362b6b05f427f18aaa313"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"3a3fd0220bd2c179222eb827a97151ada86a7b15","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":246,"context_line":"        \u0027parent_region_id\u0027: parent_region_id}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    ref.update(kwargs)"},{"line_number":249,"context_line":"    return ref"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_7f273fca","line":248,"in_reply_to":"ba8a016a_ff61ef39","updated":"2015-11-18 19:36:50.000000000","message":"Either this review can be updated to be consistent or another review can be sent. Either way works.","commit_id":"712462625be4a626816362b6b05f427f18aaa313"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"83400f3bb1cb9e96696be3090913a6d8152cefac","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        raise NotImplementedError(\"use new_endpoint_ref_with_region\")"},{"line_number":284,"context_line":"    else:"},{"line_number":285,"context_line":"        ref[\u0027region_id\u0027] \u003d region_id"},{"line_number":286,"context_line":"    ref.update(kwargs)"},{"line_number":287,"context_line":"    return ref"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_0fe4cca9","line":286,"updated":"2015-11-18 17:31:19.000000000","message":"dito","commit_id":"712462625be4a626816362b6b05f427f18aaa313"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"76ae385441145e7644ec77d0b03697aa61692b1a","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":380,"context_line":"        \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":381,"context_line":"        \u0027enabled\u0027: True,"},{"line_number":382,"context_line":"        \u0027blob\u0027: uuid.uuid4().hex,"},{"line_number":383,"context_line":"        \u0027type\u0027: uuid.uuid4().hex,"},{"line_number":384,"context_line":"    }"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_bb481ecd","line":382,"updated":"2015-11-19 18:36:28.000000000","message":"It was pointed out during my new_policy_ref review that this is expected to be a dict encoded as JSON data. I made this change in my patchset. One of us will end up dealing with the merge conflict.","commit_id":"712462625be4a626816362b6b05f427f18aaa313"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cbbd80cb762f7f9c35f3d18f559fe3a66a028071","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    return ref"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"def new_policy_ref():"},{"line_number":378,"context_line":"    return {"},{"line_number":379,"context_line":"        \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":380,"context_line":"        \u0027name\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_93945743","line":377,"updated":"2015-12-08 04:50:51.000000000","message":"rebase this on: https://review.openstack.org/#/c/247257/ ?","commit_id":"2d6904511480c6333f7cbc7fbf9953f5712be4ce"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d9512960450a98e750df69e2edbf7c0100a18e48","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    return ref"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"def new_policy_ref():"},{"line_number":378,"context_line":"    return {"},{"line_number":379,"context_line":"        \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":380,"context_line":"        \u0027name\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_eed586e4","line":377,"in_reply_to":"7a740942_93945743","updated":"2015-12-08 18:35:23.000000000","message":"One of us will have to handle the merge conflict at some point.","commit_id":"2d6904511480c6333f7cbc7fbf9953f5712be4ce"}]}