)]}'
{"keystone/tests/unit/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"91e5de40baa12cb7099bc7a1a85e383112bfaffd","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    return ref"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"def new_service_ref(**kwargs):"},{"line_number":245,"context_line":"    ref \u003d new_ref()"},{"line_number":246,"context_line":"    ref[\u0027type\u0027] \u003d uuid.uuid4().hex"},{"line_number":247,"context_line":"    ref.update(**kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_b4edf3f0","line":244,"updated":"2015-11-05 19:52:50.000000000","message":"we don\u0027t pass any kwargs in this commit, do we?","commit_id":"1c1fb946bf211452d9defcddca92971de2d3aa16"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"d97332b8325a3250a0689296ef994c3ce7088f6e","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    return ref"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"def new_service_ref(**kwargs):"},{"line_number":245,"context_line":"    ref \u003d new_ref()"},{"line_number":246,"context_line":"    ref[\u0027type\u0027] \u003d uuid.uuid4().hex"},{"line_number":247,"context_line":"    ref.update(**kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_c5e23c2f","line":244,"in_reply_to":"fa80f949_22b45e80","updated":"2015-11-05 22:56:08.000000000","message":"Actually it can be used to override attributes, such as id, etc.\n\nIt isn\u0027t needed at this patch, but I\u0027d be okay with keeping it for consistency with other methods in this chain (endpoint and region). So we might need to use it in the future ?","commit_id":"1c1fb946bf211452d9defcddca92971de2d3aa16"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"cca636a4945ccf42e760ffc8b8778ba68f436757","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    return ref"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"def new_service_ref(**kwargs):"},{"line_number":245,"context_line":"    ref \u003d new_ref()"},{"line_number":246,"context_line":"    ref[\u0027type\u0027] \u003d uuid.uuid4().hex"},{"line_number":247,"context_line":"    ref.update(**kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_22b45e80","line":244,"in_reply_to":"fa80f949_b4edf3f0","updated":"2015-11-05 22:44:34.000000000","message":"No, and we don\u0027t need it, as it will contain all the attributes of a service already.","commit_id":"1c1fb946bf211452d9defcddca92971de2d3aa16"}],"keystone/tests/unit/test_backend.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"91e5de40baa12cb7099bc7a1a85e383112bfaffd","unresolved":false,"context_lines":[{"line_number":5302,"context_line":""},{"line_number":5303,"context_line":"    def test_service_crud(self):"},{"line_number":5304,"context_line":"        # create"},{"line_number":5305,"context_line":"        new_service \u003d unit.new_service_ref()"},{"line_number":5306,"context_line":"        service_id \u003d new_service[\u0027id\u0027]"},{"line_number":5307,"context_line":"        res \u003d self.catalog_api.create_service("},{"line_number":5308,"context_line":"            service_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_d44c3744","line":5305,"updated":"2015-11-05 19:52:50.000000000","message":"would it make more sense to name these:\n\n    service_reference \u003d unit.new_service_ref()\n\nor \n\n    service_ref \u003d unit.new_service_ref()\n\n?","commit_id":"1c1fb946bf211452d9defcddca92971de2d3aa16"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1230f5c5b1ef715fa0013c09c7632b1901571952","unresolved":false,"context_lines":[{"line_number":5302,"context_line":""},{"line_number":5303,"context_line":"    def test_service_crud(self):"},{"line_number":5304,"context_line":"        # create"},{"line_number":5305,"context_line":"        new_service \u003d unit.new_service_ref()"},{"line_number":5306,"context_line":"        service_id \u003d new_service[\u0027id\u0027]"},{"line_number":5307,"context_line":"        res \u003d self.catalog_api.create_service("},{"line_number":5308,"context_line":"            service_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_b472d347","line":5305,"in_reply_to":"fa80f949_d44c3744","updated":"2015-11-05 19:56:24.000000000","message":"Actually, I just noticed that this is just using the same name as an existing convention. Never mind!","commit_id":"1c1fb946bf211452d9defcddca92971de2d3aa16"}],"keystone/tests/unit/test_catalog.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5a901f1fe23e3459579261969f1ccbddc4deed9c","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":338,"context_line":"        tenant_id \u003d uuid.uuid4().hex"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # create a service, with a name"},{"line_number":341,"context_line":"        named_svc \u003d unit.new_service_ref()"},{"line_number":342,"context_line":"        self.catalog_api.create_service(named_svc[\u0027id\u0027], named_svc)"},{"line_number":343,"context_line":"        self.create_endpoint(service_id\u003dnamed_svc[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_b4f7fc57","line":340,"updated":"2015-11-11 16:54:08.000000000","message":"This is kinda reads confusing, just because we say we\u0027re creating a service with \u0027name\u0027, but we don\u0027t pass anything to new_service_ref(). It would be helpful to update the comment here just saying that it is the default behavior of new_service_ref (and ultimately new_ref()) to populate \u0027name\u0027.","commit_id":"3587faa828cf64fc1ce15861598031e3aa2a9349"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"65882a8497e6af19c1a5c73bd3dac5aadc16d960","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":338,"context_line":"        tenant_id \u003d uuid.uuid4().hex"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # create a service, with a name"},{"line_number":341,"context_line":"        named_svc \u003d unit.new_service_ref()"},{"line_number":342,"context_line":"        self.catalog_api.create_service(named_svc[\u0027id\u0027], named_svc)"},{"line_number":343,"context_line":"        self.create_endpoint(service_id\u003dnamed_svc[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_80faae41","line":340,"in_reply_to":"da85f559_b4f7fc57","updated":"2015-11-11 17:59:12.000000000","message":"Agreed. Thanks. Sometimes automation gets the better of us :-)","commit_id":"3587faa828cf64fc1ce15861598031e3aa2a9349"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5a901f1fe23e3459579261969f1ccbddc4deed9c","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        self.create_endpoint(service_id\u003dnamed_svc[\u0027id\u0027])"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # create a service, with no name"},{"line_number":346,"context_line":"        unnamed_svc \u003d unit.new_service_ref(name\u003dNone)"},{"line_number":347,"context_line":"        del unnamed_svc[\u0027name\u0027]"},{"line_number":348,"context_line":"        self.catalog_api.create_service(unnamed_svc[\u0027id\u0027], unnamed_svc)"},{"line_number":349,"context_line":"        self.create_endpoint(service_id\u003dunnamed_svc[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_74519435","line":346,"updated":"2015-11-11 16:54:08.000000000","message":"We shouldn\u0027t have to pass None here for the name, since it will still exist in the unnamed_svc reference. Instead we could just update the comment saying: \n\n    # Service references returned from self.new_service_ref() have `name`\n    # attributes by default. We must manually delete the attribute from the\n    # dictionary before using it.\n\nand keep the delete statement.","commit_id":"3587faa828cf64fc1ce15861598031e3aa2a9349"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"65882a8497e6af19c1a5c73bd3dac5aadc16d960","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        self.create_endpoint(service_id\u003dnamed_svc[\u0027id\u0027])"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # create a service, with no name"},{"line_number":346,"context_line":"        unnamed_svc \u003d unit.new_service_ref(name\u003dNone)"},{"line_number":347,"context_line":"        del unnamed_svc[\u0027name\u0027]"},{"line_number":348,"context_line":"        self.catalog_api.create_service(unnamed_svc[\u0027id\u0027], unnamed_svc)"},{"line_number":349,"context_line":"        self.create_endpoint(service_id\u003dunnamed_svc[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_404cc69d","line":346,"in_reply_to":"da85f559_74519435","updated":"2015-11-11 17:59:12.000000000","message":"I passed the None as an indication of intent. If I had my way passing None would delete the item but I can\u0027t because occasionally None is a possible value to check for. I can remove the None in the function call. No biggy.","commit_id":"3587faa828cf64fc1ce15861598031e3aa2a9349"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f64ec4dbabc1283c81fec47bedc19aba3a7004e1","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":338,"context_line":"        tenant_id \u003d uuid.uuid4().hex"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # new_service_ref() returns a ref with a `name`."},{"line_number":341,"context_line":"        named_svc \u003d unit.new_service_ref()"},{"line_number":342,"context_line":"        self.catalog_api.create_service(named_svc[\u0027id\u0027], named_svc)"},{"line_number":343,"context_line":"        self.create_endpoint(service_id\u003dnamed_svc[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_b7fa9973","line":340,"updated":"2015-11-11 18:31:04.000000000","message":"++ thanks!","commit_id":"18c230a0fc042682c2c6409ea8dcefaf0f7872dc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f64ec4dbabc1283c81fec47bedc19aba3a7004e1","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        self.catalog_api.create_service(named_svc[\u0027id\u0027], named_svc)"},{"line_number":343,"context_line":"        self.create_endpoint(service_id\u003dnamed_svc[\u0027id\u0027])"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # This time manually delete the generated `name`."},{"line_number":346,"context_line":"        unnamed_svc \u003d unit.new_service_ref()"},{"line_number":347,"context_line":"        del unnamed_svc[\u0027name\u0027]"},{"line_number":348,"context_line":"        self.catalog_api.create_service(unnamed_svc[\u0027id\u0027], unnamed_svc)"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_570b2d8e","line":345,"updated":"2015-11-11 18:31:04.000000000","message":"++ thanks!","commit_id":"18c230a0fc042682c2c6409ea8dcefaf0f7872dc"}],"keystone/tests/unit/test_sql_upgrade.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"91e5de40baa12cb7099bc7a1a85e383112bfaffd","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                \u0027url\u0027: uuid.uuid4().hex,"},{"line_number":371,"context_line":"                \u0027region\u0027: region"},{"line_number":372,"context_line":"            }"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"            self.insert_dict(session, \u0027endpoint\u0027, endpoint)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"            return endpoint_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_3413430f","line":373,"updated":"2015-11-05 19:52:50.000000000","message":"nit: irrelevant whitespace change?","commit_id":"1c1fb946bf211452d9defcddca92971de2d3aa16"}]}