)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"c53c8b7a953ae0be4ad1ad29b52cbdfa4f32d2af","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change tests that are setting incorrect Distinguished Names"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are many tests throughout Keystone that are setting"},{"line_number":10,"context_line":"LDAP distinguished names incorrectly. With this patch I will"},{"line_number":11,"context_line":"go through and set test distinguished names to"},{"line_number":12,"context_line":"commonName(CN)"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da85f559_94856fae","line":10,"updated":"2015-11-10 06:40:01.000000000","message":"I\u0027m not sure I understand this change.  Yes, using an uuid is not a good example of a DN, but why go through and change  them all.  Is the testing somehow different?\n\nMaybe you could clarify this more in this commit message.  Thanks","commit_id":"2e8ea210f3ebdbbe0f2e775b5fd3dd6a25103678"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"bf64616622b8f8cf2b213e2310cb7d5ca1a3dbff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change tests that are setting incorrect Distinguished Names"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are many tests throughout Keystone that are setting"},{"line_number":10,"context_line":"LDAP distinguished names incorrectly. With this patch I will"},{"line_number":11,"context_line":"go through and set test distinguished names to"},{"line_number":12,"context_line":"commonName(CN)"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da85f559_72355ff5","line":10,"in_reply_to":"da85f559_94856fae","updated":"2015-11-10 16:31:56.000000000","message":"Good call I clarified it in the next patch set.","commit_id":"2e8ea210f3ebdbbe0f2e775b5fd3dd6a25103678"}],"keystone/tests/unit/backend/domain_config/core.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6c4c4d67531941f8ec037acf6db3deeef2bdc6d7","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def test_create_domain_config_including_sensitive_option(self):"},{"line_number":216,"context_line":"        config \u003d {\u0027ldap\u0027: {\u0027url\u0027: uuid.uuid4().hex,"},{"line_number":217,"context_line":"                           \u0027user_tree_dn\u0027: \u0027CN\u003d\u0027 + uuid.uuid4().hex,"},{"line_number":218,"context_line":"                           \u0027password\u0027: uuid.uuid4().hex}}"},{"line_number":219,"context_line":"        self.domain_config_api.create_config(self.domain[\u0027id\u0027], config)"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_7fa014f5","line":217,"updated":"2015-11-04 08:17:38.000000000","message":"So while there is nothing wrong with these changes, this is a unit tests for our storage of domain config params....it never actually gets sent to any kind of LDAP server....\n\nSame for all the tests here...","commit_id":"a85a9cac6a8a9143812a78384132bdb135816d95"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"db5a9bacccda2d578c58a2f711ee4a875ee5a409","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def test_create_domain_config_including_sensitive_option(self):"},{"line_number":216,"context_line":"        config \u003d {\u0027ldap\u0027: {\u0027url\u0027: uuid.uuid4().hex,"},{"line_number":217,"context_line":"                           \u0027user_tree_dn\u0027: \u0027CN\u003d\u0027 + uuid.uuid4().hex,"},{"line_number":218,"context_line":"                           \u0027password\u0027: uuid.uuid4().hex}}"},{"line_number":219,"context_line":"        self.domain_config_api.create_config(self.domain[\u0027id\u0027], config)"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_b63be5d0","line":217,"in_reply_to":"fa80f949_7fa014f5","updated":"2015-11-04 22:55:10.000000000","message":"That makes sense, The bug that I fix in the patch that is dependent on this patch is to validate distinguished names in the config.  Since the ldap config is created in this test it will need to be in the correct format.    :)","commit_id":"a85a9cac6a8a9143812a78384132bdb135816d95"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"adbf235780e73aae18d0561cf1fcd4b98d483aed","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        return config"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_create_domain_config_including_sensitive_option(self):"},{"line_number":225,"context_line":"        config \u003d self._new_ldap_config()"},{"line_number":226,"context_line":"        self.domain_config_api.create_config(self.domain[\u0027id\u0027], config)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # password is sensitive, so check that the whitelisted portion and"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_eb2db895","line":225,"updated":"2015-11-06 13:40:43.000000000","message":"Personally (although I\u0027m OK with it if others really like it) I\u0027m not sure this use of a method is helpful...the various options used further down seem a bit convoluted and you lose track of what the ldap config is.\n\nI know you were responding to Brant\u0027s comment on this - I *think* Brant\u0027s point was to do simply do something like:\n\nuser_tree_dn: _make_CN()\n\nwhere\n\n_make_CN() returned \u0027CN\u003d\u0027 + uuid.uuid4().hex","commit_id":"f9e29f2ea3fdadd902d5c4b78e06c9d70024b7b7"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"db1da6b039180b8baa3b6786d8aa679ce3a70ce9","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        return config"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_create_domain_config_including_sensitive_option(self):"},{"line_number":225,"context_line":"        config \u003d self._new_ldap_config()"},{"line_number":226,"context_line":"        self.domain_config_api.create_config(self.domain[\u0027id\u0027], config)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # password is sensitive, so check that the whitelisted portion and"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_012edba4","line":225,"in_reply_to":"fa80f949_463dd9c2","updated":"2015-11-06 15:05:54.000000000","message":"Haha I may have over thought your comment. Done","commit_id":"f9e29f2ea3fdadd902d5c4b78e06c9d70024b7b7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"45d8960727d5c39ee3c6ed0245736569f60874d5","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        return config"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_create_domain_config_including_sensitive_option(self):"},{"line_number":225,"context_line":"        config \u003d self._new_ldap_config()"},{"line_number":226,"context_line":"        self.domain_config_api.create_config(self.domain[\u0027id\u0027], config)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # password is sensitive, so check that the whitelisted portion and"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_463dd9c2","line":225,"in_reply_to":"fa80f949_eb2db895","updated":"2015-11-06 14:00:16.000000000","message":"yes, I was suggesting to have a function to create a DN that could be used everywhere. e.g.\n\n  def make_random_dn():\n      return \u0027CN\u003d\u0027 + uuid.uuid4().hex","commit_id":"f9e29f2ea3fdadd902d5c4b78e06c9d70024b7b7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6ac6623e2068afc7a7895a3bdfa4bffd5c1f69c1","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        # And finally just some bad groups/options"},{"line_number":413,"context_line":"        bad_group \u003d uuid.uuid4().hex"},{"line_number":414,"context_line":"        config \u003d {bad_group: {\u0027user\u0027: self._make_random_dn()}}"},{"line_number":415,"context_line":"        self.assertRaises(exception.InvalidDomainConfig,"},{"line_number":416,"context_line":"                          self.domain_config_api.update_config,"},{"line_number":417,"context_line":"                          self.domain[\u0027id\u0027], config, group\u003dbad_group,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_5f7d1ee6","line":414,"range":{"start_line":414,"start_character":31,"end_line":414,"end_character":35},"updated":"2016-01-07 18:50:09.000000000","message":"is this suppose to be a dn?","commit_id":"41b8251ebc7817edbea77cf5382276337ad1bc71"}]}