)]}'
{"doc/source/federation/shibboleth.rst":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"4ac33ccf0936065c291fe46f23c7d3e16cbab18e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      The same name is used inside the shibboleth2.xml configuration file but they could"},{"line_number":62,"context_line":"      be different."},{"line_number":63,"context_line":"    * The ``ShibRequireSession`` and ``ShibRequireAll`` rules are invalid in"},{"line_number":64,"context_line":"      Apache 2.4+ and should be dropped in that specific setup."},{"line_number":65,"context_line":"    * You are advised to carefully examine `Shibboleth Apache configuration"},{"line_number":66,"context_line":"      documentation"},{"line_number":67,"context_line":"      \u003chttps://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPApacheConfig\u003e`_"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa80f949_8221b14f","side":"PARENT","line":64,"updated":"2015-11-05 05:59:43.000000000","message":"I think the `NOTE` here is still useful, just say these rules are invalid in Apache 2.4+ is enough.","commit_id":"c00797d97230236413496274a30ea3c7d66069ab"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a3e582afa866807de0e3fe294758e7436d0422bb","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      The same name is used inside the shibboleth2.xml configuration file but they could"},{"line_number":62,"context_line":"      be different."},{"line_number":63,"context_line":"    * The ``ShibRequireSession`` and ``ShibRequireAll`` rules are invalid in"},{"line_number":64,"context_line":"      Apache 2.4+ and should be dropped in that specific setup."},{"line_number":65,"context_line":"    * You are advised to carefully examine `Shibboleth Apache configuration"},{"line_number":66,"context_line":"      documentation"},{"line_number":67,"context_line":"      \u003chttps://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPApacheConfig\u003e`_"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa80f949_a02aa22a","side":"PARENT","line":64,"in_reply_to":"fa80f949_8221b14f","updated":"2015-11-05 12:34:36.000000000","message":"++","commit_id":"c00797d97230236413496274a30ea3c7d66069ab"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f29754dbb9f14727faa61902dc1928a891ddc3a3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    * ``idp_1`` has to be replaced with the name associated with the idp in Keystone."},{"line_number":64,"context_line":"      The same name is used inside the shibboleth2.xml configuration file but they could"},{"line_number":65,"context_line":"      be different."},{"line_number":66,"context_line":"    * The ``ShibRequireSession`` and ``ShibRequireAll`` rules are invalid in"},{"line_number":67,"context_line":"      Apache 2.4+."},{"line_number":68,"context_line":"    * You are advised to carefully examine `Shibboleth Apache configuration"},{"line_number":69,"context_line":"      documentation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_c6770201","line":66,"updated":"2015-11-16 21:23:44.000000000","message":"This whole bullet could be removed since the example already says this. It would be more interesting to say what effect it has. (e.g., is it less secure)","commit_id":"c7047d832185b9cc5f6f88d4447b4e0b7026a23c"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"2a817f06be880123c43501e8564f6a53cb0ca440","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    * ``idp_1`` has to be replaced with the name associated with the idp in Keystone."},{"line_number":64,"context_line":"      The same name is used inside the shibboleth2.xml configuration file but they could"},{"line_number":65,"context_line":"      be different."},{"line_number":66,"context_line":"    * The ``ShibRequireSession`` and ``ShibRequireAll`` rules are invalid in"},{"line_number":67,"context_line":"      Apache 2.4+."},{"line_number":68,"context_line":"    * You are advised to carefully examine `Shibboleth Apache configuration"},{"line_number":69,"context_line":"      documentation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_39db7a7e","line":66,"in_reply_to":"ba8a016a_324cfa41","updated":"2015-11-17 08:19:37.000000000","message":"I also prefer keeping the notes here even if it is redundant with the example.","commit_id":"c7047d832185b9cc5f6f88d4447b4e0b7026a23c"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0403a775f2c48b890342c497eaf1233bd8c631db","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    * ``idp_1`` has to be replaced with the name associated with the idp in Keystone."},{"line_number":64,"context_line":"      The same name is used inside the shibboleth2.xml configuration file but they could"},{"line_number":65,"context_line":"      be different."},{"line_number":66,"context_line":"    * The ``ShibRequireSession`` and ``ShibRequireAll`` rules are invalid in"},{"line_number":67,"context_line":"      Apache 2.4+."},{"line_number":68,"context_line":"    * You are advised to carefully examine `Shibboleth Apache configuration"},{"line_number":69,"context_line":"      documentation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_324cfa41","line":66,"in_reply_to":"ba8a016a_78eeea23","updated":"2015-11-17 03:23:41.000000000","message":"I am fine with just remove them all, but keep them here will let us know why this should be configured like this, or else, some guys like me maybe curios about that and may not aware that it\u0027s invalid when the version is \u003c 2.4.","commit_id":"c7047d832185b9cc5f6f88d4447b4e0b7026a23c"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"bd06a7529c2e9b49f38ffba9da580f8f32f77ce8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    * ``idp_1`` has to be replaced with the name associated with the idp in Keystone."},{"line_number":64,"context_line":"      The same name is used inside the shibboleth2.xml configuration file but they could"},{"line_number":65,"context_line":"      be different."},{"line_number":66,"context_line":"    * The ``ShibRequireSession`` and ``ShibRequireAll`` rules are invalid in"},{"line_number":67,"context_line":"      Apache 2.4+."},{"line_number":68,"context_line":"    * You are advised to carefully examine `Shibboleth Apache configuration"},{"line_number":69,"context_line":"      documentation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba8a016a_78eeea23","line":66,"in_reply_to":"ba8a016a_c6770201","updated":"2015-11-17 00:59:02.000000000","message":"It fails completely - they\u0027re invalid commands in 2.4. I agree the first version of the patch just removed the whole bullet, it was requested to be added back.","commit_id":"c7047d832185b9cc5f6f88d4447b4e0b7026a23c"}]}
