)]}'
{"keystone/tests/unit/test_backend.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"0843d65ef6d4831cc4e4a3c9edd5898a3bc84568","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"        # Can delete a grant where the user doesn\u0027t exist."},{"line_number":1610,"context_line":"        role \u003d unit.new_role_ref()"},{"line_number":1611,"context_line":"        role_id \u003d role[\u0027id\u0027]"},{"line_number":1612,"context_line":"        self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":1615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_f23bc1e9","line":1612,"updated":"2015-11-09 20:00:33.000000000","message":"this is kind of an irreverent change","commit_id":"ddc8e7e4e6833a9aee810b2f8b4b3827d329a41b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"40133111c2094deeccf6dd6f2ca3e9a2e345aebc","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"        # Can delete a grant where the user doesn\u0027t exist."},{"line_number":1610,"context_line":"        role \u003d unit.new_role_ref()"},{"line_number":1611,"context_line":"        role_id \u003d role[\u0027id\u0027]"},{"line_number":1612,"context_line":"        self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":1615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_d533bea9","line":1612,"in_reply_to":"da85f559_265b4730","updated":"2015-11-11 02:51:19.000000000","message":"Lets keep the rold_id changes. Easier to read anyway. No big deal.","commit_id":"ddc8e7e4e6833a9aee810b2f8b4b3827d329a41b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"13b299a14ade8211a2232fc5fda7acfbcf50fdbb","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"        # Can delete a grant where the user doesn\u0027t exist."},{"line_number":1610,"context_line":"        role \u003d unit.new_role_ref()"},{"line_number":1611,"context_line":"        role_id \u003d role[\u0027id\u0027]"},{"line_number":1612,"context_line":"        self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":1615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_265b4730","line":1612,"in_reply_to":"da85f559_28647620","updated":"2015-11-09 20:54:01.000000000","message":"lol I was thinking about asking you to make them all role[\u0027id\u0027] but I figured you were going to say the same thing back to me.","commit_id":"ddc8e7e4e6833a9aee810b2f8b4b3827d329a41b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"b40a2d2dfa8a3dffd62a237b7df5f14d4b147405","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"        # Can delete a grant where the user doesn\u0027t exist."},{"line_number":1610,"context_line":"        role \u003d unit.new_role_ref()"},{"line_number":1611,"context_line":"        role_id \u003d role[\u0027id\u0027]"},{"line_number":1612,"context_line":"        self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":1615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_e8350e46","line":1612,"in_reply_to":"da85f559_8819e27b","updated":"2015-11-09 20:23:43.000000000","message":"That makes sense.  Just to clear it up i meant that \u0027role[\u0027id\u0027]\u0027 does not have to be changed. It can be left as \u0027role_id\u0027","commit_id":"ddc8e7e4e6833a9aee810b2f8b4b3827d329a41b"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"15d51a917676950dcb6bbfca73a8a038b9a1d091","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"        # Can delete a grant where the user doesn\u0027t exist."},{"line_number":1610,"context_line":"        role \u003d unit.new_role_ref()"},{"line_number":1611,"context_line":"        role_id \u003d role[\u0027id\u0027]"},{"line_number":1612,"context_line":"        self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":1615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_6960e401","line":1612,"in_reply_to":"da85f559_d533bea9","updated":"2015-11-11 14:16:01.000000000","message":"I agree with Tom. Whatever we are going to use, let\u0027s use it consistently within the method (L1616 and L1619).","commit_id":"ddc8e7e4e6833a9aee810b2f8b4b3827d329a41b"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"aad0d1837d8c3c0ebe44e7cd50b10481bd7dd763","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"        # Can delete a grant where the user doesn\u0027t exist."},{"line_number":1610,"context_line":"        role \u003d unit.new_role_ref()"},{"line_number":1611,"context_line":"        role_id \u003d role[\u0027id\u0027]"},{"line_number":1612,"context_line":"        self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":1615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_28647620","line":1612,"in_reply_to":"da85f559_e8350e46","updated":"2015-11-09 20:26:56.000000000","message":"Ah. Yes. I had removed role_id and put it back avoid the irrelevant change complaints. Fair point.","commit_id":"ddc8e7e4e6833a9aee810b2f8b4b3827d329a41b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"3793d3f6a39ff4aadc3b2aa4a51a297070f79741","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"        # Can delete a grant where the user doesn\u0027t exist."},{"line_number":1610,"context_line":"        role \u003d unit.new_role_ref()"},{"line_number":1611,"context_line":"        role_id \u003d role[\u0027id\u0027]"},{"line_number":1612,"context_line":"        self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":1615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_2896b6f0","line":1612,"in_reply_to":"da85f559_e8350e46","updated":"2015-11-09 20:25:16.000000000","message":"e.g.\n\nself.role_api.create_role(role_id, role)","commit_id":"ddc8e7e4e6833a9aee810b2f8b4b3827d329a41b"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"ad60660669ad33ff5f9aae831911cbb1ec031951","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"        # Can delete a grant where the user doesn\u0027t exist."},{"line_number":1610,"context_line":"        role \u003d unit.new_role_ref()"},{"line_number":1611,"context_line":"        role_id \u003d role[\u0027id\u0027]"},{"line_number":1612,"context_line":"        self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":1615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_8819e27b","line":1612,"in_reply_to":"da85f559_f23bc1e9","updated":"2015-11-09 20:11:10.000000000","message":"Note it isn\u0027t. The ID is now generated by the call to new_role_ref. The test writer rarely needs to make a new UUID for themself. If the original code is left the ID is generated here _AND_ in the call to new_role_ref. Why duplicate needlessly? Especially when it has zero effect on the intent of the test.","commit_id":"ddc8e7e4e6833a9aee810b2f8b4b3827d329a41b"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"0843d65ef6d4831cc4e4a3c9edd5898a3bc84568","unresolved":false,"context_lines":[{"line_number":1623,"context_line":"        # Can delete a grant where the group doesn\u0027t exist."},{"line_number":1624,"context_line":"        role \u003d unit.new_role_ref()"},{"line_number":1625,"context_line":"        role_id \u003d role[\u0027id\u0027]"},{"line_number":1626,"context_line":"        self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1627,"context_line":""},{"line_number":1628,"context_line":"        group_id \u003d uuid.uuid4().hex"},{"line_number":1629,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_b22699cc","line":1626,"updated":"2015-11-09 20:00:33.000000000","message":"ditto","commit_id":"ddc8e7e4e6833a9aee810b2f8b4b3827d329a41b"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"15d51a917676950dcb6bbfca73a8a038b9a1d091","unresolved":false,"context_lines":[{"line_number":1623,"context_line":"        # Can delete a grant where the group doesn\u0027t exist."},{"line_number":1624,"context_line":"        role \u003d unit.new_role_ref()"},{"line_number":1625,"context_line":"        role_id \u003d role[\u0027id\u0027]"},{"line_number":1626,"context_line":"        self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1627,"context_line":""},{"line_number":1628,"context_line":"        group_id \u003d uuid.uuid4().hex"},{"line_number":1629,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_49e08096","line":1626,"in_reply_to":"da85f559_b22699cc","updated":"2015-11-11 14:16:01.000000000","message":"++, same too.\n\nInconsistent with L1630 and L1633.","commit_id":"ddc8e7e4e6833a9aee810b2f8b4b3827d329a41b"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"17d3afaad775153d102d1c4a08ea97e649aa5720","unresolved":false,"context_lines":[{"line_number":1884,"context_line":""},{"line_number":1885,"context_line":"        role_list \u003d []"},{"line_number":1886,"context_line":"        for _ in range(2):"},{"line_number":1887,"context_line":"            role \u003d unit.new_domain_ref()"},{"line_number":1888,"context_line":"            self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1889,"context_line":"            role_list.append(role)"},{"line_number":1890,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_07347ddb","line":1887,"updated":"2015-11-12 03:40:47.000000000","message":"should be new_role_ref, not domain.","commit_id":"e8366236f96b931823bc2f4cfb1c4acf6781f45b"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"ef930339edeca4a99856535f98795e0f9faa7f3c","unresolved":false,"context_lines":[{"line_number":1884,"context_line":""},{"line_number":1885,"context_line":"        role_list \u003d []"},{"line_number":1886,"context_line":"        for _ in range(2):"},{"line_number":1887,"context_line":"            role \u003d unit.new_domain_ref()"},{"line_number":1888,"context_line":"            self.role_api.create_role(role[\u0027id\u0027], role)"},{"line_number":1889,"context_line":"            role_list.append(role)"},{"line_number":1890,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_9c1f5bb6","line":1887,"in_reply_to":"da85f559_07347ddb","updated":"2015-11-12 08:26:05.000000000","message":"doh!","commit_id":"e8366236f96b931823bc2f4cfb1c4acf6781f45b"}]}
