)]}'
{"keystone/tests/unit/core.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"90248405e6b0823e2325e1df2c27ec05fbc84bdf","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    return ref"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def new_group_ref(domain_id, **kwargs):"},{"line_number":326,"context_line":"    ref \u003d new_ref()"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    # Many tests fail if \u0027enabled\u0027 is added to the ref. Delete it here but"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_55ceee82","line":325,"updated":"2015-11-11 02:55:20.000000000","message":"no need for **kwargs. I don\u0027t think groups have the \u0027enabled\u0027 flag in its schema.","commit_id":"3ed9dbae6299a81e2666cf33e2768677051d9716"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"99394d2dee11baaae97bebd08b6dcaa248060333","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    return ref"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def new_group_ref(domain_id, **kwargs):"},{"line_number":326,"context_line":"    ref \u003d new_ref()"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    # Many tests fail if \u0027enabled\u0027 is added to the ref. Delete it here but"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_bc592c37","line":325,"in_reply_to":"da85f559_55ceee82","updated":"2015-11-11 14:18:20.000000000","message":"No they don\u0027t, see the model: https://github.com/openstack/keystone/blob/master/keystone/common/models.py#L105-L120","commit_id":"3ed9dbae6299a81e2666cf33e2768677051d9716"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"7978bfd154ee060378b50e83ba9f5c7882459adb","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    return ref"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def new_group_ref(domain_id, **kwargs):"},{"line_number":326,"context_line":"    ref \u003d new_ref()"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    # Many tests fail if \u0027enabled\u0027 is added to the ref. Delete it here but"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_45be1866","line":325,"in_reply_to":"da85f559_55ceee82","updated":"2015-11-11 17:39:43.000000000","message":"This allows developers to set ID or any other field not just \u0027enabled\u0027.\n\n\u0027enabled\u0027 is created by \u0027new_ref\u0027\u0027. I can fix the comment and adjust the code. Thanks for the catch.","commit_id":"3ed9dbae6299a81e2666cf33e2768677051d9716"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"990f18fb226da870e38299089c2013c0dd9436a8","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    return ref"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def new_group_ref(domain_id, **kwargs):"},{"line_number":326,"context_line":"    ref \u003d new_ref()"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    # Group does not have enabled field"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_0250c130","line":325,"updated":"2015-11-12 17:28:24.000000000","message":"why is **kwargs needed?","commit_id":"b69f6d728f49c362b6ad126c609f90ff6b934769"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"46e7add2958ab9148d7387e4f399cc9cd85f3037","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    return ref"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def new_group_ref(domain_id, **kwargs):"},{"line_number":326,"context_line":"    ref \u003d new_ref()"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    # Group does not have enabled field"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_bbd240cf","line":325,"in_reply_to":"da85f559_0250c130","updated":"2015-11-12 18:31:15.000000000","message":"It is there for developers to override any of the members. This series of patches makes all of the new_type_ref() functions take kwargs to reduce the need for creating refs manually.\n\nInstead of:\n\n    ref \u003d dict(a\u003d1, b\u003d2)\n\nThe dev can call:\n\n    ref \u003d new_type_ref(a\u003d1, b\u003d2)\n\nUsing kwargs makes the code resilient to changes in the models. We can always police the inputs if and when needed.","commit_id":"b69f6d728f49c362b6ad126c609f90ff6b934769"}],"keystone/tests/unit/test_backend.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4edc9b6b3f602a9096b91a7973eb679db261b2c3","unresolved":false,"context_lines":[{"line_number":3066,"context_line":"                          new_user)"},{"line_number":3067,"context_line":""},{"line_number":3068,"context_line":"    def test_check_user_not_in_group(self):"},{"line_number":3069,"context_line":"        new_group \u003d unit.new_group_ref(domain_id\u003dDEFAULT_DOMAIN_ID,)"},{"line_number":3070,"context_line":"        new_group \u003d self.identity_api.create_group(new_group)"},{"line_number":3071,"context_line":""},{"line_number":3072,"context_line":"        new_user \u003d {\u0027name\u0027: \u0027new_user\u0027, \u0027password\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_485dbf45","line":3069,"updated":"2015-11-11 23:33:01.000000000","message":"(nit) unnecessary leading comma","commit_id":"860baf66c1146e050760108ed0da708ed01929e4"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"c5acd71c01c5088e52a6bb4e4e5a160753216ac6","unresolved":false,"context_lines":[{"line_number":3066,"context_line":"                          new_user)"},{"line_number":3067,"context_line":""},{"line_number":3068,"context_line":"    def test_check_user_not_in_group(self):"},{"line_number":3069,"context_line":"        new_group \u003d unit.new_group_ref(domain_id\u003dDEFAULT_DOMAIN_ID,)"},{"line_number":3070,"context_line":"        new_group \u003d self.identity_api.create_group(new_group)"},{"line_number":3071,"context_line":""},{"line_number":3072,"context_line":"        new_user \u003d {\u0027name\u0027: \u0027new_user\u0027, \u0027password\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_735758ca","line":3069,"in_reply_to":"da85f559_485dbf45","updated":"2015-11-11 23:40:00.000000000","message":"Left over from a transform. Doh.","commit_id":"860baf66c1146e050760108ed0da708ed01929e4"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4edc9b6b3f602a9096b91a7973eb679db261b2c3","unresolved":false,"context_lines":[{"line_number":3194,"context_line":""},{"line_number":3195,"context_line":"    def test_remove_user_from_group(self):"},{"line_number":3196,"context_line":"        domain \u003d self._get_domain_fixture()"},{"line_number":3197,"context_line":"        new_group \u003d unit.new_group_ref(domain_id\u003ddomain[\u0027id\u0027],)"},{"line_number":3198,"context_line":"        new_group \u003d self.identity_api.create_group(new_group)"},{"line_number":3199,"context_line":"        new_user \u003d {\u0027name\u0027: \u0027new_user\u0027, \u0027password\u0027: uuid.uuid4().hex,"},{"line_number":3200,"context_line":"                    \u0027enabled\u0027: True, \u0027domain_id\u0027: domain[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_0853373a","line":3197,"updated":"2015-11-11 23:33:01.000000000","message":"(nit) unnecessary leading comma","commit_id":"860baf66c1146e050760108ed0da708ed01929e4"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4edc9b6b3f602a9096b91a7973eb679db261b2c3","unresolved":false,"context_lines":[{"line_number":3250,"context_line":""},{"line_number":3251,"context_line":"    def test_get_group_by_name(self):"},{"line_number":3252,"context_line":"        group_orig \u003d unit.new_group_ref(domain_id\u003dDEFAULT_DOMAIN_ID)"},{"line_number":3253,"context_line":"        group \u003d self.identity_api.create_group(group_orig)"},{"line_number":3254,"context_line":"        spoiler \u003d unit.new_group_ref(domain_id\u003dDEFAULT_DOMAIN_ID)"},{"line_number":3255,"context_line":"        self.identity_api.create_group(spoiler)"},{"line_number":3256,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_28107b56","line":3253,"updated":"2015-11-11 23:33:01.000000000","message":"We could also have kept group_name, like:\n\n    group \u003d unit.new_group_ref(domain_id\u003dDEFAULT_DOMAIN_ID)\n    group_name \u003d group[\u0027name\u0027]\n    group \u003d self.identity_api.create_group(group)","commit_id":"860baf66c1146e050760108ed0da708ed01929e4"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"c5acd71c01c5088e52a6bb4e4e5a160753216ac6","unresolved":false,"context_lines":[{"line_number":3250,"context_line":""},{"line_number":3251,"context_line":"    def test_get_group_by_name(self):"},{"line_number":3252,"context_line":"        group_orig \u003d unit.new_group_ref(domain_id\u003dDEFAULT_DOMAIN_ID)"},{"line_number":3253,"context_line":"        group \u003d self.identity_api.create_group(group_orig)"},{"line_number":3254,"context_line":"        spoiler \u003d unit.new_group_ref(domain_id\u003dDEFAULT_DOMAIN_ID)"},{"line_number":3255,"context_line":"        self.identity_api.create_group(spoiler)"},{"line_number":3256,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_7325185a","line":3253,"in_reply_to":"da85f559_28107b56","updated":"2015-11-11 23:40:00.000000000","message":"Indeed. Hmm. Not sure why this happened. I think I was trying to fix a tox failure.","commit_id":"860baf66c1146e050760108ed0da708ed01929e4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"94c9f790c7d30b76c64f0e4aa523c512a04eeda3","unresolved":false,"context_lines":[{"line_number":4046,"context_line":"        # Create a group."},{"line_number":4047,"context_line":"        new_group \u003d unit.new_group_ref("},{"line_number":4048,"context_line":"            domain_id\u003dDEFAULT_DOMAIN_ID,"},{"line_number":4049,"context_line":"            name\u003dself.getUniqueString(prefix\u003d\u0027tdgrra\u0027))"},{"line_number":4050,"context_line":"        new_group \u003d self.identity_api.create_group(new_group)"},{"line_number":4051,"context_line":""},{"line_number":4052,"context_line":"        # Create a project."}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_07418639","line":4049,"updated":"2015-11-13 13:05:55.000000000","message":"i would think:\n\n  self.getUniqueString(prefix\u003d\u0027tdgrra\u0027)\n\ncan be replaced with some uuid","commit_id":"b69f6d728f49c362b6ad126c609f90ff6b934769"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"94c9f790c7d30b76c64f0e4aa523c512a04eeda3","unresolved":false,"context_lines":[{"line_number":4052,"context_line":"        # Create a project."},{"line_number":4053,"context_line":"        new_project \u003d {"},{"line_number":4054,"context_line":"            \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":4055,"context_line":"            \u0027name\u0027: self.getUniqueString(prefix\u003d\u0027tdgrra\u0027),"},{"line_number":4056,"context_line":"            \u0027domain_id\u0027: DEFAULT_DOMAIN_ID}"},{"line_number":4057,"context_line":"        self.resource_api.create_project(new_project[\u0027id\u0027], new_project)"},{"line_number":4058,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_e747a249","line":4055,"updated":"2015-11-13 13:05:55.000000000","message":"same here","commit_id":"b69f6d728f49c362b6ad126c609f90ff6b934769"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"94c9f790c7d30b76c64f0e4aa523c512a04eeda3","unresolved":false,"context_lines":[{"line_number":828,"context_line":"                break"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        # Create a group"},{"line_number":831,"context_line":"        group \u003d unit.new_group_ref(name\u003dself.getUniqueString(prefix\u003d\u0027tuidc\u0027),"},{"line_number":832,"context_line":"                                   description\u003dself.getUniqueString(),"},{"line_number":833,"context_line":"                                   domain_id\u003dCONF.identity.default_domain_id)"},{"line_number":834,"context_line":"        group_id \u003d group[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_67f732f6","line":831,"updated":"2015-11-13 13:05:55.000000000","message":"same here","commit_id":"b69f6d728f49c362b6ad126c609f90ff6b934769"}],"keystone/tests/unit/test_v3_identity.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4edc9b6b3f602a9096b91a7973eb679db261b2c3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super(IdentityTestCase, self).setUp()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.group \u003d unit.new_group_ref(domain_id\u003dself.domain_id, enabled\u003dTrue)"},{"line_number":40,"context_line":"        self.group \u003d self.identity_api.create_group(self.group)"},{"line_number":41,"context_line":"        self.group_id \u003d self.group[\u0027id\u0027]"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_d353a415","line":39,"updated":"2015-11-11 23:33:01.000000000","message":"Need to remove this enable attribute, as groups don\u0027t contain it.","commit_id":"860baf66c1146e050760108ed0da708ed01929e4"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"c5acd71c01c5088e52a6bb4e4e5a160753216ac6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super(IdentityTestCase, self).setUp()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.group \u003d unit.new_group_ref(domain_id\u003dself.domain_id, enabled\u003dTrue)"},{"line_number":40,"context_line":"        self.group \u003d self.identity_api.create_group(self.group)"},{"line_number":41,"context_line":"        self.group_id \u003d self.group[\u0027id\u0027]"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_b3d62026","line":39,"in_reply_to":"da85f559_d353a415","updated":"2015-11-11 23:40:00.000000000","message":"Thanks, thought I had them all.","commit_id":"860baf66c1146e050760108ed0da708ed01929e4"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4edc9b6b3f602a9096b91a7973eb679db261b2c3","unresolved":false,"context_lines":[{"line_number":392,"context_line":"    def test_create_group(self):"},{"line_number":393,"context_line":"        \"\"\"Call ``POST /groups``.\"\"\""},{"line_number":394,"context_line":"        # Create a new group to avoid a duplicate check failure"},{"line_number":395,"context_line":"        ref \u003d unit.new_group_ref(domain_id\u003dself.domain_id, enabled\u003dTrue)"},{"line_number":396,"context_line":"        r \u003d self.post("},{"line_number":397,"context_line":"            \u0027/groups\u0027,"},{"line_number":398,"context_line":"            body\u003d{\u0027group\u0027: ref})"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_b377009f","line":395,"updated":"2015-11-11 23:33:01.000000000","message":"Ditto","commit_id":"860baf66c1146e050760108ed0da708ed01929e4"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4edc9b6b3f602a9096b91a7973eb679db261b2c3","unresolved":false,"context_lines":[{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    def test_update_group(self):"},{"line_number":420,"context_line":"        \"\"\"Call ``PATCH /groups/{group_id}``.\"\"\""},{"line_number":421,"context_line":"        group \u003d unit.new_group_ref(domain_id\u003dself.domain_id, enabled\u003dTrue)"},{"line_number":422,"context_line":"        del group[\u0027id\u0027]"},{"line_number":423,"context_line":"        r \u003d self.patch(\u0027/groups/%(group_id)s\u0027 % {"},{"line_number":424,"context_line":"            \u0027group_id\u0027: self.group_id},"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_9370bca5","line":421,"updated":"2015-11-11 23:33:01.000000000","message":"Ditto","commit_id":"860baf66c1146e050760108ed0da708ed01929e4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"d32d67a7e8452e97013ab542ec57df9079835ab1","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            body\u003d{\u0027group\u0027: self.group},"},{"line_number":434,"context_line":"            expected_status\u003dexception.ValidationError.code)"},{"line_number":435,"context_line":"        self.config_fixture.config(domain_id_immutable\u003dFalse)"},{"line_number":436,"context_line":"        self.group[\u0027domain_id\u0027] \u003d self.domain[\u0027id\u0027]"},{"line_number":437,"context_line":"        r \u003d self.patch(\u0027/groups/%(group_id)s\u0027 % {"},{"line_number":438,"context_line":"            \u0027group_id\u0027: self.group[\u0027id\u0027]},"},{"line_number":439,"context_line":"            body\u003d{\u0027group\u0027: self.group})"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_fca98291","line":436,"updated":"2015-11-13 09:53:01.000000000","message":"hmm, as an aside, is this even a valid test?  Isn\u0027t the group already in self.domain[\u0027id\u0027]?","commit_id":"b69f6d728f49c362b6ad126c609f90ff6b934769"}]}