)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e7fa80eb7eef86897fbb51113cf705a21c121c48","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lance Bragstad \u003clbragstad@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-10 17:30:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove sql.DateTime from Revocation Events"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The schema for revocation events relied on using the sql.DateTime format to"},{"line_number":10,"context_line":"store timestamps and datetime objects. Some versions of SQL don\u0027t support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_014b5a2b","line":7,"updated":"2015-11-10 17:53:43.000000000","message":"Sounds like you\u0027re just ripping things out, but in fact you are replacing it.\n\n\"Use sql.BigInteger instead of sql.DateTime for revocation events\"?","commit_id":"34284f859669cf733961402f62922a2f0d6d16a1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bd66dffb32d844a72f222b29b0afcfdcd88b93eb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lance Bragstad \u003clbragstad@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-10 17:30:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove sql.DateTime from Revocation Events"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The schema for revocation events relied on using the sql.DateTime format to"},{"line_number":10,"context_line":"store timestamps and datetime objects. Some versions of SQL don\u0027t support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_a1d92e24","line":7,"in_reply_to":"da85f559_014b5a2b","updated":"2015-11-10 18:26:36.000000000","message":"++ good point","commit_id":"34284f859669cf733961402f62922a2f0d6d16a1"}],"keystone/common/sql/migrate_repo/versions/087_revoke_convert_datetime_to_integer.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"dd094c01f3520330de679c4e8c5e3eae669364c5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            v \u003d timeutils.parse_isotime(v)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # nuke the tz info because it messes with determining the total seconds"},{"line_number":42,"context_line":"        v \u003d v.replace(tzinfo\u003dNone)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # figure out the number of microseconds since epoch"},{"line_number":45,"context_line":"        timestamp \u003d int((v - epoch).total_seconds() * 1e6)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_cf138c5b","line":42,"updated":"2016-01-26 16:57:55.000000000","message":"Shouldn\u0027t the TZ be UTC already? Either way, can you expand on \"messed with\"? Otherwise, this smells is launching a nuke based on assumptions, and that\u0027s not good diplomacy.","commit_id":"94d61dd4862b5921eb504e4b27474c2fb597eb56"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"dd094c01f3520330de679c4e8c5e3eae669364c5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    # drop the columns that we don\u0027t need anymore"},{"line_number":84,"context_line":"    revocation_event_table.c.issued_before.drop()"},{"line_number":85,"context_line":"    revocation_event_table.c.expires_at.drop()"},{"line_number":86,"context_line":"    revocation_event_table.c.revoked_at.drop()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    # rename the new column to the old names"},{"line_number":89,"context_line":"    revocation_event_table.c.issued_before_int.alter(name\u003d\u0027issued_before\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_ec4a2327","line":86,"updated":"2016-01-26 16:57:55.000000000","message":"This bit is going to fail against online migrations tests!","commit_id":"94d61dd4862b5921eb504e4b27474c2fb597eb56"}],"keystone/contrib/revoke/backends/sql.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e7fa80eb7eef86897fbb51113cf705a21c121c48","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _prune_expired_events(self):"},{"line_number":67,"context_line":"        oldest_dt \u003d revoke.revoked_before_cutoff_time()"},{"line_number":68,"context_line":"        oldest \u003d int((oldest_dt - self.epoch).total_seconds() * 1e6)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        session \u003d sql.get_session()"},{"line_number":71,"context_line":"        dialect \u003d session.bind.dialect.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_01e7da11","line":68,"updated":"2015-11-10 17:53:43.000000000","message":"maybe create a constant for 1e6? and add a comment saying why it\u0027s needed?","commit_id":"34284f859669cf733961402f62922a2f0d6d16a1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bd66dffb32d844a72f222b29b0afcfdcd88b93eb","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _prune_expired_events(self):"},{"line_number":67,"context_line":"        oldest_dt \u003d revoke.revoked_before_cutoff_time()"},{"line_number":68,"context_line":"        oldest \u003d int((oldest_dt - self.epoch).total_seconds() * 1e6)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        session \u003d sql.get_session()"},{"line_number":71,"context_line":"        dialect \u003d session.bind.dialect.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_c1ed52b8","line":68,"in_reply_to":"da85f559_01e7da11","updated":"2015-11-10 18:26:36.000000000","message":"++ will do","commit_id":"34284f859669cf733961402f62922a2f0d6d16a1"}]}