)]}'
{"doc/source/configuration.rst":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"c474c72f1461f94f968956224c497b4b1ad29b1e","unresolved":false,"context_lines":[{"line_number":1651,"context_line":"``cn\u003denabled_users,$user_tree_dn`` and ``cn\u003denabled_tenants,$project_tree_dn``"},{"line_number":1652,"context_line":"respectively."},{"line_number":1653,"context_line":""},{"line_number":1654,"context_line":"If a different LDAP schema is used for group membership, is is possible to use"},{"line_number":1655,"context_line":"the ``group_objectclass`` and ``group_member_attribute`` attributes to"},{"line_number":1656,"context_line":"determine membership in the enabled emulation group by setting the"},{"line_number":1657,"context_line":"``user_enabled_emulation_use_group_config`` and"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da85f559_22dcce17","line":1654,"updated":"2015-11-13 03:33:37.000000000","message":"s/is is/it is/","commit_id":"f30076504069f8e00967e2f011143911dbd20b35"}],"keystone/common/ldap/core.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"87a5d7a9c39f5a745089daf4aa7c7933577850bc","unresolved":false,"context_lines":[{"line_number":1802,"context_line":"                            self.options_name)"},{"line_number":1803,"context_line":"        self.use_group_config \u003d getattr(conf.ldap, use_group_config)"},{"line_number":1804,"context_line":""},{"line_number":1805,"context_line":"        if not self.use_group_config:"},{"line_number":1806,"context_line":"            self.member_attribute \u003d self.DEFAULT_MEMBER_ATTRIBUTE"},{"line_number":1807,"context_line":"            self.group_objectclass \u003d self.DEFAULT_GROUP_OBJECTCLASS"},{"line_number":1808,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_9ff5d6cc","line":1805,"updated":"2015-11-13 02:04:13.000000000","message":"this is such a nit i feel like an idiot even mentioning it.\n\nif not X with an else always bugs me. I always have to double take by the time you get to else because it\u0027s a double negative.\n\nThis pattern is below and not something you need to change. Just a rant.","commit_id":"bcffc5c1ef768740efea3f15c9a76998bf1d5f86"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"3420adf71e19fc7df8e84261957108d46e655568","unresolved":false,"context_lines":[{"line_number":1809,"context_line":"            self.member_attribute \u003d (conf.ldap.group_member_attribute"},{"line_number":1810,"context_line":"                                     or self.DEFAULT_MEMBER_ATTRIBUTE)"},{"line_number":1811,"context_line":"            self.group_objectclass \u003d (conf.ldap.group_objectclass"},{"line_number":1812,"context_line":"                                      or self.DEFAULT_GROUP_OBJECTCLASS)"},{"line_number":1813,"context_line":""},{"line_number":1814,"context_line":"        if not self.enabled_emulation_dn:"},{"line_number":1815,"context_line":"            naming_attr_name \u003d \u0027cn\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_f3022372","line":1812,"updated":"2015-11-13 00:16:20.000000000","message":"why would I want a fallback here? If i\u0027ve enabled use_group_config but not set a group_member_attribute and/or group_objectclass wouldn\u0027t that be a config error?\n\nThese come with defaults so having them be None would seem unlikey and breaks other things.","commit_id":"bcffc5c1ef768740efea3f15c9a76998bf1d5f86"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"7678605e6531adbc1bf8df0c2b30f0f39b686160","unresolved":false,"context_lines":[{"line_number":1809,"context_line":"            self.member_attribute \u003d (conf.ldap.group_member_attribute"},{"line_number":1810,"context_line":"                                     or self.DEFAULT_MEMBER_ATTRIBUTE)"},{"line_number":1811,"context_line":"            self.group_objectclass \u003d (conf.ldap.group_objectclass"},{"line_number":1812,"context_line":"                                      or self.DEFAULT_GROUP_OBJECTCLASS)"},{"line_number":1813,"context_line":""},{"line_number":1814,"context_line":"        if not self.enabled_emulation_dn:"},{"line_number":1815,"context_line":"            naming_attr_name \u003d \u0027cn\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_bfc8daa9","line":1812,"in_reply_to":"da85f559_6402e70d","updated":"2015-11-13 01:57:50.000000000","message":"I would remove the or part, because of the defaults i\u0027m not even sure you could trigger it.","commit_id":"bcffc5c1ef768740efea3f15c9a76998bf1d5f86"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"f540699d4f8bfa8882eea1a25140452706c60481","unresolved":false,"context_lines":[{"line_number":1809,"context_line":"            self.member_attribute \u003d (conf.ldap.group_member_attribute"},{"line_number":1810,"context_line":"                                     or self.DEFAULT_MEMBER_ATTRIBUTE)"},{"line_number":1811,"context_line":"            self.group_objectclass \u003d (conf.ldap.group_objectclass"},{"line_number":1812,"context_line":"                                      or self.DEFAULT_GROUP_OBJECTCLASS)"},{"line_number":1813,"context_line":""},{"line_number":1814,"context_line":"        if not self.enabled_emulation_dn:"},{"line_number":1815,"context_line":"            naming_attr_name \u003d \u0027cn\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_5f1c4d6a","line":1812,"in_reply_to":"da85f559_bfc8daa9","updated":"2015-11-13 02:28:04.000000000","message":"Done","commit_id":"bcffc5c1ef768740efea3f15c9a76998bf1d5f86"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"ef6da8996192ea88b85d9d44cede7f5e649d0b19","unresolved":false,"context_lines":[{"line_number":1809,"context_line":"            self.member_attribute \u003d (conf.ldap.group_member_attribute"},{"line_number":1810,"context_line":"                                     or self.DEFAULT_MEMBER_ATTRIBUTE)"},{"line_number":1811,"context_line":"            self.group_objectclass \u003d (conf.ldap.group_objectclass"},{"line_number":1812,"context_line":"                                      or self.DEFAULT_GROUP_OBJECTCLASS)"},{"line_number":1813,"context_line":""},{"line_number":1814,"context_line":"        if not self.enabled_emulation_dn:"},{"line_number":1815,"context_line":"            naming_attr_name \u003d \u0027cn\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_6402e70d","line":1812,"in_reply_to":"da85f559_f3022372","updated":"2015-11-13 01:55:21.000000000","message":"It\u0027s likely not necessary because of the defaults.  I can remove the \"or\" portion of these if you like.","commit_id":"bcffc5c1ef768740efea3f15c9a76998bf1d5f86"}]}