)]}'
{"keystone/federation/controllers.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"6ae970b32e1a331063dd25cfa79c6fef83b3b84b","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        :param ref: response dictionary"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        \"\"\""},{"line_number":150,"context_line":"        ref.setdefault(\u0027links\u0027, {})"},{"line_number":151,"context_line":"        base_path \u003d ref[\u0027links\u0027].get(\u0027identity_provider\u0027)"},{"line_number":152,"context_line":"        if base_path is None:"},{"line_number":153,"context_line":"            base_path \u003d [IdentityProvider.base_url(context), ref[\u0027idp_id\u0027]]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_e4cdb731","line":150,"updated":"2015-11-19 14:55:15.000000000","message":"What about this .get(), shouldn\u0027t it at least have an empty dictionary(as set above)?","commit_id":"4acff5e619dcad7462c0af14d8504ca08164dfdf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1ae5c025c29a5f17fc0ad0351f7387c60d36e9da","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        :param ref: response dictionary"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        \"\"\""},{"line_number":150,"context_line":"        ref.setdefault(\u0027links\u0027, {})"},{"line_number":151,"context_line":"        base_path \u003d ref[\u0027links\u0027].get(\u0027identity_provider\u0027)"},{"line_number":152,"context_line":"        if base_path is None:"},{"line_number":153,"context_line":"            base_path \u003d [IdentityProvider.base_url(context), ref[\u0027idp_id\u0027]]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_ca5c3d1b","line":150,"in_reply_to":"ba8a016a_e4cdb731","updated":"2015-11-19 14:59:03.000000000","message":"line 151 does .get() which can return None. line 152 checks for None. So the code as is makes sense.","commit_id":"4acff5e619dcad7462c0af14d8504ca08164dfdf"}]}