)]}'
{"keystone/tests/unit/test_contrib_ec2.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"1da610eb3d76d21c45bb9fd5e8b73986695e43af","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            project_id\u003dself.project_id)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.creds_ref \u003d (controllers.Ec2Controller"},{"line_number":43,"context_line":"                          ._convert_v3_to_ec2_credential(tmp_ref))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_signature_validate_no_host_port(self):"},{"line_number":46,"context_line":"        \"\"\"Test signature validation with the access/secret provided.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_16aedfe5","line":43,"updated":"2015-11-19 18:49:21.000000000","message":"i don\u0027t know if using  a private method to do this is the best idea.  I tried to used self.controller.get_credential(self.user_id)\nBut that user does not have any credentials.  you may need to call self.controller.create_credentials() which returns the credentials formatted with _convert_v3_to_ec2_credential()","commit_id":"509bc9558317c04e6f0e5fd0272fe68ba208926c"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"631d5a1c3179823517d28121e8e03581662d4bd3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            project_id\u003dself.project_id)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.creds_ref \u003d (controllers.Ec2Controller"},{"line_number":43,"context_line":"                          ._convert_v3_to_ec2_credential(tmp_ref))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_signature_validate_no_host_port(self):"},{"line_number":46,"context_line":"        \"\"\"Test signature validation with the access/secret provided.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_942e488a","line":43,"in_reply_to":"ba8a016a_16aedfe5","updated":"2015-11-19 19:04:45.000000000","message":"Shouldn\u0027t the test code be allowed to use these methods?","commit_id":"509bc9558317c04e6f0e5fd0272fe68ba208926c"}],"keystone/tests/unit/test_v3_credential.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"199377a3e3d81f139f021fdbef179b117c7ffcb2","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # because the type must be in the list of supported types"},{"line_number":123,"context_line":"        ec2_credential \u003d unit.new_credential_ref(user_id\u003duuid.uuid4().hex,"},{"line_number":124,"context_line":"                                                 project_id\u003dself.project_id,"},{"line_number":125,"context_line":"                                                 cred_type\u003d\u0027ec2\u0027)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        ec2_resp \u003d self.credential_api.create_credential("},{"line_number":128,"context_line":"            ec2_credential[\u0027id\u0027], ec2_credential)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_fc736b7e","line":125,"updated":"2015-11-18 02:25:01.000000000","message":"this, and a few lines below are the only instances of \"cred_type\", i\u0027d prefer to see either \"type\" or \"cred_type\" in the tests, there\u0027s no need to keep both around (and the exception handling in core)","commit_id":"345b679c56f00d96227dcac731c45d1542f44858"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"09200f061221a1fe939f1d7d9f58e3a1e54695ca","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def test_ec2_credential_signature_validate_legacy(self):"},{"line_number":383,"context_line":"        \"\"\"Test signature validation with a legacy v3 ec2 credential.\"\"\""},{"line_number":384,"context_line":"        cred_json, _ \u003d self._create_dict_blob_credential()"},{"line_number":385,"context_line":"        cred_blob \u003d json.loads(cred_json)"},{"line_number":386,"context_line":"        self._validate_signature(access\u003dcred_blob[\u0027access\u0027],"},{"line_number":387,"context_line":"                                 secret\u003dcred_blob[\u0027secret\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_032d7994","line":384,"updated":"2015-11-18 22:27:35.000000000","message":"can we do \n\ncred_json \u003d self._create_dict_blob_credential()[0]\n\nto get rid of that un-used variable?","commit_id":"87752a80deb62e0b5a8a44cc7f88c833a815884d"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"e27b4222803612d2755c43b3eb1fbb13603a1bd3","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def test_ec2_credential_signature_validate_legacy(self):"},{"line_number":383,"context_line":"        \"\"\"Test signature validation with a legacy v3 ec2 credential.\"\"\""},{"line_number":384,"context_line":"        cred_json, _ \u003d self._create_dict_blob_credential()"},{"line_number":385,"context_line":"        cred_blob \u003d json.loads(cred_json)"},{"line_number":386,"context_line":"        self._validate_signature(access\u003dcred_blob[\u0027access\u0027],"},{"line_number":387,"context_line":"                                 secret\u003dcred_blob[\u0027secret\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_236afd81","line":384,"in_reply_to":"ba8a016a_032d7994","updated":"2015-11-18 22:31:52.000000000","message":"Why? Assign to underscore is the usual Python idiom for this.","commit_id":"87752a80deb62e0b5a8a44cc7f88c833a815884d"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"bdb3fdcc092a78ed0ec5f494960b4473220916dc","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def test_ec2_credential_signature_validate_legacy(self):"},{"line_number":383,"context_line":"        \"\"\"Test signature validation with a legacy v3 ec2 credential.\"\"\""},{"line_number":384,"context_line":"        cred_json, _ \u003d self._create_dict_blob_credential()"},{"line_number":385,"context_line":"        cred_blob \u003d json.loads(cred_json)"},{"line_number":386,"context_line":"        self._validate_signature(access\u003dcred_blob[\u0027access\u0027],"},{"line_number":387,"context_line":"                                 secret\u003dcred_blob[\u0027secret\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_f88f9e72","line":384,"in_reply_to":"ba8a016a_236afd81","updated":"2015-11-19 16:39:46.000000000","message":"I guess the only reason i would worry is because i18n uses \u0027_\u0027 for translation. Since this is at test file i don\u0027t think we would see it here.  I am fine with leaving it as is.","commit_id":"87752a80deb62e0b5a8a44cc7f88c833a815884d"}]}