)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8fe0d744aadf784c9a6eb52292d7e00abc85ba3a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"we should use ref[\u0027id\u0027] instead of service_id"},{"line_number":13,"context_line":"when calling \u0027notifications.Audit.updated\u0027.Because the function of"},{"line_number":14,"context_line":"test_create_service in test_notifications has implemted with  service_ref[\u0027id\u0027],"},{"line_number":15,"context_line":"I do not need to change the test code."},{"line_number":16,"context_line":"Fixes Bug #1517751"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I18d57669400f5a241a04f1803b98f6b90e4edf44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_788e607a","line":15,"updated":"2015-11-19 08:56:02.000000000","message":"This all sounds a bit convoluted.  Maybe something a little simpler like:\n\n\"When we issue an audit notification on service creation we currently include the service_id that was passed into the create call. Instead we should be using the ID from the created entity that was returned from the driver (since we do not support caller-defined service IDs).\"","commit_id":"e045b84762e3b9633814cf16cf68427ea97b44a6"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"77953ed2dbe03082101e827ca76cdf5956601916","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"notifications.Audit.created parameter wrong"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"notification.Audit.update needed to be changed from service_id to ref[\u0027id\u0027],"},{"line_number":10,"context_line":"when u call create_service function with service_id and service_ref parameters,"},{"line_number":11,"context_line":"because service_id may be not equal to ref[\u0027id\u0027],"},{"line_number":12,"context_line":"we should use ref[\u0027id\u0027] instead of service_id"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba8a016a_5fc9f457","line":9,"updated":"2015-11-19 13:18:10.000000000","message":"this whole message is confuse, you should be clearer on what the problem is. What about rephrase it to: \n\nNotification.Audit.update needed to be changed from service_id to ref[\u0027id\u0027] when create_service is called with service_id and service_ref parameters, once service_id may be not equal to ref[\u0027id\u0027].\nWe should use ref[\u0027id\u0027] instead of service_id when calling notifications.Audit.updated\u0027.","commit_id":"6e33f832682c4fee35a65b958f3a4d98f975136f"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"77953ed2dbe03082101e827ca76cdf5956601916","unresolved":false,"context_lines":[{"line_number":13,"context_line":"when calling \u0027notifications.Audit.updated\u0027.Because the function of"},{"line_number":14,"context_line":"test_create_service in test_notifications has implemted with  service_ref[\u0027id\u0027],"},{"line_number":15,"context_line":"I do not need to change the test code."},{"line_number":16,"context_line":"Fixes Bug #1517751"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I18d57669400f5a241a04f1803b98f6b90e4edf44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba8a016a_67b5547c","line":16,"updated":"2015-11-19 13:18:10.000000000","message":"the correct usage is \n\nCloses-Bug: 1517751","commit_id":"6e33f832682c4fee35a65b958f3a4d98f975136f"}],"keystone/tests/unit/common/test_notifications.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6bec3330f2a5b8daee12c167dbadfb94d7394e29","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        self._assert_last_audit(service_ref[\u0027id\u0027], CREATED_OPERATION,"},{"line_number":477,"context_line":"                                \u0027service\u0027, cadftaxonomy.SECURITY_SERVICE)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def test_create_service_with_service_id(self):"},{"line_number":480,"context_line":"        service_ref \u003d unit.new_service_ref()"},{"line_number":481,"context_line":"        service_id \u003d self.service_id"},{"line_number":482,"context_line":"        self.catalog_api.create_service(service_id, service_ref)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_41bec7ae","line":479,"updated":"2015-11-20 08:53:54.000000000","message":"maybe this is \"test_create_service_with_bad_service_id\"","commit_id":"9f5636911312ec65a3a2222baf4b2a8b5f6b7557"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6bec3330f2a5b8daee12c167dbadfb94d7394e29","unresolved":false,"context_lines":[{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def test_create_service_with_service_id(self):"},{"line_number":480,"context_line":"        service_ref \u003d unit.new_service_ref()"},{"line_number":481,"context_line":"        service_id \u003d self.service_id"},{"line_number":482,"context_line":"        self.catalog_api.create_service(service_id, service_ref)"},{"line_number":483,"context_line":"        self._assert_notify_not_sent(service_id, CREATED_OPERATION, \u0027service\u0027)"},{"line_number":484,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_61d42beb","line":481,"updated":"2015-11-20 08:53:54.000000000","message":"maybe a new uuid?","commit_id":"9f5636911312ec65a3a2222baf4b2a8b5f6b7557"}]}