)]}'
{"keystone/auth/controllers.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"839087d3b7cb4c13f2178de28662d3dac3d35c2f","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        elif \u0027domain\u0027 in self.auth[\u0027scope\u0027]:"},{"line_number":183,"context_line":"            domain_ref \u003d self._lookup_domain(self.auth[\u0027scope\u0027][\u0027domain\u0027])"},{"line_number":184,"context_line":"            self._scope_data \u003d (domain_ref[\u0027id\u0027], None, None)"},{"line_number":185,"context_line":"        elif not CONF.trust.enabled and \u0027trust\u0027 in self.auth[\u0027scope\u0027]:"},{"line_number":186,"context_line":"            raise exception.Forbidden(\u0027Trusts are disabled.\u0027)"},{"line_number":187,"context_line":"        elif CONF.trust.enabled and \u0027trust\u0027 in self.auth[\u0027scope\u0027]:"},{"line_number":188,"context_line":"            trust_ref \u003d self._lookup_trust(self.auth[\u0027scope\u0027][\u0027trust\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F6eE%3D","line":185,"updated":"2013-03-21 04:24:59.000000000","message":"please change this to:\nif \u0027trust\u0027 in self.auth[\u0027scope\u0027]:\n     if  not CONF.trust.enabled:\n          raise exception.Forbidden(\u0027Trusts are disabled.\u0027)","commit_id":"3c0df9d9fd56de4570d4c3d823de4c2650014038"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0173250a643606d3831bb9b5db776f6fd4e4b9be","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        elif \u0027domain\u0027 in self.auth[\u0027scope\u0027]:"},{"line_number":183,"context_line":"            domain_ref \u003d self._lookup_domain(self.auth[\u0027scope\u0027][\u0027domain\u0027])"},{"line_number":184,"context_line":"            self._scope_data \u003d (domain_ref[\u0027id\u0027], None, None)"},{"line_number":185,"context_line":"        elif not CONF.trust.enabled and \u0027trust\u0027 in self.auth[\u0027scope\u0027]:"},{"line_number":186,"context_line":"            raise exception.Forbidden(\u0027Trusts are disabled.\u0027)"},{"line_number":187,"context_line":"        elif CONF.trust.enabled and \u0027trust\u0027 in self.auth[\u0027scope\u0027]:"},{"line_number":188,"context_line":"            trust_ref \u003d self._lookup_trust(self.auth[\u0027scope\u0027][\u0027trust\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F6dg%3D","line":185,"in_reply_to":"AAAAOH%2F%2F6eE%3D","updated":"2013-03-21 04:41:14.000000000","message":"Done","commit_id":"3c0df9d9fd56de4570d4c3d823de4c2650014038"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"839087d3b7cb4c13f2178de28662d3dac3d35c2f","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                context, auth_context, auth_info)"},{"line_number":290,"context_line":"            return token_factory.render_token_data_response("},{"line_number":291,"context_line":"                token_id, token_data, created\u003dTrue)"},{"line_number":292,"context_line":"        except exception.SecurityError:"},{"line_number":293,"context_line":"            raise"},{"line_number":294,"context_line":"        except Exception as e:"},{"line_number":295,"context_line":"            LOG.exception(e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F6eA%3D","line":292,"updated":"2013-03-21 04:24:59.000000000","message":"Good cleanup, although, this probably should be in a separate patch.","commit_id":"3c0df9d9fd56de4570d4c3d823de4c2650014038"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0173250a643606d3831bb9b5db776f6fd4e4b9be","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                context, auth_context, auth_info)"},{"line_number":290,"context_line":"            return token_factory.render_token_data_response("},{"line_number":291,"context_line":"                token_id, token_data, created\u003dTrue)"},{"line_number":292,"context_line":"        except exception.SecurityError:"},{"line_number":293,"context_line":"            raise"},{"line_number":294,"context_line":"        except Exception as e:"},{"line_number":295,"context_line":"            LOG.exception(e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F6dc%3D","line":292,"in_reply_to":"AAAAOH%2F%2F6eA%3D","updated":"2013-03-21 04:41:14.000000000","message":"it\u0027s required to raise forbidden to the api","commit_id":"3c0df9d9fd56de4570d4c3d823de4c2650014038"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"839087d3b7cb4c13f2178de28662d3dac3d35c2f","unresolved":false,"context_lines":[{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def _check_and_set_default_scoping(self, context, auth_info, auth_context):"},{"line_number":299,"context_line":"        (domain_id, project_id, trust) \u003d auth_info.get_scope()"},{"line_number":300,"context_line":"        if CONF.trust.enabled and trust:"},{"line_number":301,"context_line":"            project_id \u003d trust[\u0027project_id\u0027]"},{"line_number":302,"context_line":"        if domain_id or project_id or trust:"},{"line_number":303,"context_line":"            # scope is specified"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F6d0%3D","line":300,"updated":"2013-03-21 04:24:59.000000000","message":"please remove the checks like these.","commit_id":"3c0df9d9fd56de4570d4c3d823de4c2650014038"}],"keystone/auth/token_factory.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"839087d3b7cb4c13f2178de28662d3dac3d35c2f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                       trust):"},{"line_number":108,"context_line":"        user_ref \u003d self.identity_api.get_user(self.context,"},{"line_number":109,"context_line":"                                              user_id)"},{"line_number":110,"context_line":"        if CONF.trust.enabled and trust:"},{"line_number":111,"context_line":"            trustor_user_ref \u003d (self.identity_api.get_user(self.context,"},{"line_number":112,"context_line":"                                trust[\u0027trustor_user_id\u0027]))"},{"line_number":113,"context_line":"            if not trustor_user_ref[\u0027enabled\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F6ec%3D","line":110,"updated":"2013-03-21 04:24:59.000000000","message":"These are still the wrong logic, even if the y should never be executed.  If you are going to have the check in there, throw the exception.","commit_id":"3c0df9d9fd56de4570d4c3d823de4c2650014038"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0173250a643606d3831bb9b5db776f6fd4e4b9be","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                       trust):"},{"line_number":108,"context_line":"        user_ref \u003d self.identity_api.get_user(self.context,"},{"line_number":109,"context_line":"                                              user_id)"},{"line_number":110,"context_line":"        if CONF.trust.enabled and trust:"},{"line_number":111,"context_line":"            trustor_user_ref \u003d (self.identity_api.get_user(self.context,"},{"line_number":112,"context_line":"                                trust[\u0027trustor_user_id\u0027]))"},{"line_number":113,"context_line":"            if not trustor_user_ref[\u0027enabled\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F6dQ%3D","line":110,"in_reply_to":"AAAAOH%2F%2F6ec%3D","updated":"2013-03-21 04:41:14.000000000","message":"the goal of a feature flag is to enable/disable impact of the feature, not to introduce new behaviors","commit_id":"3c0df9d9fd56de4570d4c3d823de4c2650014038"}]}