)]}'
{"id":"openstack%2Fkeystone~25065","triplet_id":"openstack%2Fkeystone~master~I389b83397addc5901aa94b584856fbd7f5cef485","project":"openstack/keystone","branch":"master","topic":"bug/1158544","hashtags":[],"change_id":"I389b83397addc5901aa94b584856fbd7f5cef485","subject":"close db migration session","status":"MERGED","created":"2013-03-21 22:26:15.000000000","updated":"2013-04-23 13:25:32.000000000","submitted":"2013-04-23 13:25:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"63e69f100242a9393a7a73d841fe991fb21924d7","_number":25065,"virtual_id_number":25065,"owner":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},{"value":0,"_account_id":7291,"name":"Malcolm Anderson","email":"dufm1958@gmail.com"},{"value":0,"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2013-03-27 01:57:52.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":2,"date":"2013-04-23 13:25:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"recommended":{"_account_id":7291,"name":"Malcolm Anderson","email":"dufm1958@gmail.com"},"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":1,"date":"2013-04-19 17:31:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},{"value":1,"date":"2013-04-18 03:07:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7291,"name":"Malcolm Anderson","email":"dufm1958@gmail.com"},{"value":0,"date":"2013-04-23 12:41:34.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"date":"2013-04-13 14:02:36.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-04-18 02:11:35.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":1,"date":"2013-04-17 00:32:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},{"value":0,"_account_id":7291,"name":"Malcolm Anderson","email":"dufm1958@gmail.com"},{"value":1,"date":"2013-04-23 12:41:34.000000000","_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"date":"2013-04-13 14:02:36.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2013-04-18 02:11:35.000000000","_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"value":0,"date":"2013-04-17 00:32:30.000000000","_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"_account_id":7291,"name":"Malcolm Anderson","email":"dufm1958@gmail.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-27 01:57:52.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-04-13 14:02:36.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-04-17 00:32:30.000000000","updated_by":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"reviewer":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"state":"REVIEWER"},{"updated":"2013-04-18 02:11:35.000000000","updated_by":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"reviewer":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"state":"REVIEWER"},{"updated":"2013-04-18 03:07:53.000000000","updated_by":{"_account_id":7291,"name":"Malcolm Anderson","email":"dufm1958@gmail.com"},"reviewer":{"_account_id":7291,"name":"Malcolm Anderson","email":"dufm1958@gmail.com"},"state":"REVIEWER"},{"updated":"2013-04-19 17:31:47.000000000","updated_by":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"reviewer":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"state":"REVIEWER"},{"updated":"2013-04-23 12:41:34.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2013-04-23 13:25:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"45b32903132c8b0cca3ae4e5d4b89fa9b6e4a962","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-21 22:45:12.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/79338\n","accounts_in_message":[],"_revision_number":1},{"id":"837508b8c4d49ec50a568887407afc6ba8df5b91","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-03-21 22:58:39.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nHow do you reproduce this? This should be an issue on nearly every migration across openstack and a sqlalchemy-migrate best practice","accounts_in_message":[],"_revision_number":1},{"id":"d857e3a3984a0f5d85371ae9939f6c94f68f1b19","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-21 23:06:45.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25065/1/check/gate-keystone-pep8/4455 : SUCCESS\n- http://logs.openstack.org/25065/1/check/gate-keystone-docs/2838 : SUCCESS\n- http://logs.openstack.org/25065/1/check/gate-keystone-python26/3361 : SUCCESS\n- http://logs.openstack.org/25065/1/check/gate-keystone-python26-rhel6/14 : SUCCESS (non-voting)\n- http://logs.openstack.org/25065/1/check/gate-keystone-python27/3373 : SUCCESS\n- http://logs.openstack.org/25065/1/check/gate-tempest-devstack-vm-full/9961 : SUCCESS\n- http://logs.openstack.org/25065/1/check/gate-tempest-devstack-vm-postgres-full/9676 : SUCCESS\n- http://logs.openstack.org/25065/1/check/gate-tempest-devstack-vm-quantum/15423 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"f873795301eb76abc0ad5f954e1006de4654e8f2","author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"date":"2013-03-22 02:01:55.000000000","message":"Patch Set 1:\n\nDolph - As i mentioned on IRC https://review.openstack.org/#/c/23660/ picks this up. \n\nAlthough most other openstack projects have similar test_migrations testcases the problem isn\u0027t seen because they don\u0027t use orm.sessionmaker in db migrations (is there an assumption in other projects that no one is access the db during upgrades? Can we do the same here?). Perhaps this is also why it doesn\u0027t appear in best practice migration guides.\n\nTriggering the problem using db_sync is not straightforward. The problem occurs only when a session is left unclosed or uncommited, the sqlalchemy engine is disposed of and then an attempt is made to drop the database. An error occurs because there is still an active connection to the db. This scenario of course won\u0027t happen during the normal operation of the keystone server.\n\nI did check the the sqlalchemy engine dispose only guarantees closure of connections returned to the pool. This won\u0027t happen if the session is not closed or committed. From the docs:\n\n\"It is critical to note that dispose() does not guarantee that the application will release all open database connections - only those connections that are checked into the pool are closed. Connections which remain checked out or have been detached from the engine are not affected.\"\n\nIs there a downside to having the session.close() in the db migrations?","accounts_in_message":[],"_revision_number":1},{"id":"d19a2c059e979cadeaa13c9c643f8f054989dd3b","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-03-22 14:39:23.000000000","message":"Patch Set 1:\n\nI\u0027m simply opposed to the inconsistency presented here, and would like to better understand and fix the underlying problem, if there is one.\n\nMigrations 8, 9, 10, 12, 15, 16, 17, 20, 21 and 22 currently use sessionmaker\n\nMigrations 9, 10, 12, 15, 16, 17, 20, and 22 use session.query()\n\nMigrations 8, 10, 12, 15, 16 currently call session.commit()\n\nMigrations 12, 15, 16, 17, and 20 currently call session.close()\n\nSo, migrations 9, 10 and 22 use sessionmaker and session.query() but don\u0027t call session.close() and -- so why isn\u0027t this fix necessary for migrations 9 and 10?","accounts_in_message":[],"_revision_number":1},{"id":"93ad6387199ed8e8148e2adffef18cc5a43f053e","author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"date":"2013-03-22 21:01:44.000000000","message":"Patch Set 1:\n\nWith migration 9 session maker is only used in the code path where SQLite is the engine so it doesn\u0027t trigger the problem. With migration 10 there is a session.commit in the function level above in upgrade/downgrade","accounts_in_message":[],"_revision_number":1},{"id":"b50f334c85ffd0ecb739515b1d9cc27edd3ccc54","author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"date":"2013-03-22 21:07:24.000000000","message":"Patch Set 1:\n\nSorry misread your earlier comment. With migration 10 it does do a commit, though not a close. Either an explicit commit or a close on the session does avoid the problem. Given the docs on commit I think it returns any active connections to the engine pool on a commit even with autocommit set. These connections can then get cleaned  up on engine,dispose()","accounts_in_message":[],"_revision_number":1},{"id":"59b2e163f90a1db5a3e01a1a8e6a2a9e21e9e4fd","author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"date":"2013-03-27 01:36:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8fe1d2de5ef728dd418c2279984e8348ef6632ab","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-03-27 01:36:28.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nAutomatically re-added by Gerrit trivial rebase detection script.","accounts_in_message":[],"_revision_number":2},{"id":"abb83079e2b67c876c4f55d3c446b196537f65fe","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-27 01:57:52.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/80150\n","accounts_in_message":[],"_revision_number":2},{"id":"156075afa696e24c54088dcb49d52dfea94fb26f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-27 02:13:42.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25065/2/check/gate-keystone-pep8/4503 : SUCCESS\n- http://logs.openstack.org/25065/2/check/gate-keystone-docs/2881 : SUCCESS\n- http://logs.openstack.org/25065/2/check/gate-keystone-python26/3404 : SUCCESS\n- http://logs.openstack.org/25065/2/check/gate-keystone-python26-rhel6/46 : SUCCESS (non-voting)\n- http://logs.openstack.org/25065/2/check/gate-keystone-python27/3416 : SUCCESS\n- http://logs.openstack.org/25065/2/check/gate-tempest-devstack-vm-full/10604 : SUCCESS\n- http://logs.openstack.org/25065/2/check/gate-tempest-devstack-vm-postgres-full/10320 : SUCCESS\n- http://logs.openstack.org/25065/2/check/gate-tempest-devstack-vm-quantum/16163 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"84cdcbb200b38abaac292af6079a96df301b683e","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-03 06:03:03.000000000","message":"Patch Set 2:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"74ad82af3ee2882f5f6bcae482cbc8f573f6b784","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-04-03 06:03:03.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"172c94da02343a9dc4002997bc1d9640c2319c1b","author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"date":"2013-04-12 22:58:51.000000000","message":"Patch Set 2: Restored\n\nStill need this patch for new db migration tests to work","accounts_in_message":[],"_revision_number":2},{"id":"915c4bddc91a68e82133ff98bf9871a67d88d04b","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-04-13 14:02:36.000000000","message":"Patch Set 2: No score\n\n","accounts_in_message":[],"_revision_number":2},{"id":"24a5453dcaa51edb19a741d316bdf89b8e23e84c","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2013-04-17 00:32:47.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"afed28dfe9777f684b62c26c59a69f9b274368ec","author":{"_account_id":6,"name":"Joe Heck","email":"heckj@mac.com","username":"heckj"},"date":"2013-04-18 02:11:35.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"3ab533a7c3c5e43428ce51ba365d3c4132f29455","author":{"_account_id":7291,"name":"Malcolm Anderson","email":"dufm1958@gmail.com"},"date":"2013-04-18 03:07:53.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"4e0fc030c33aec91011b9cea82fcc1e9eac9bbf6","author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"date":"2013-04-19 17:31:47.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"eac116495a39a88130d8f609016f2d0f361eb80b","author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"date":"2013-04-23 12:41:34.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ee8cc518e0c5238d580483aaf8c95636cf98fb93","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-23 12:41:41.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"82636ee3f704972636d9dc6799fecb41a555b733","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-23 13:25:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"638f72452d6d5400fab9fa9a7e94ef0fae1e5159","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-23 13:25:32.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/25065/2/gate/gate-keystone-docs/3160/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/25065/2/gate/gate-keystone-pep8/4786 : SUCCESS\n- http://logs.openstack.org/25065/2/gate/gate-keystone-python26/3681 : SUCCESS\n- http://logs.openstack.org/25065/2/gate/gate-keystone-python27/3692 : SUCCESS\n- http://logs.openstack.org/25065/2/gate/gate-tempest-devstack-vm-full/13312 : SUCCESS\n- http://logs.openstack.org/25065/2/gate/gate-tempest-devstack-vm-postgres-full/13027 : SUCCESS\n- http://logs.openstack.org/25065/2/gate/gate-tempest-devstack-vm-quantum/19240 : SUCCESS\n- http://logs.openstack.org/25065/2/gate/gate-grenade-devstack-vm/1193 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9467a6602ef31c1976b64539fdd4bfc4b63a2c95","revisions":{"d904a92fa3395f439b3f6723746bd31d995e577d":{"kind":"REWORK","_number":1,"created":"2013-03-21 22:26:15.000000000","uploader":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"ref":"refs/changes/65/25065/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/65/25065/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/65/25065/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/65/25065/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/65/25065/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/65/25065/1"}}},"commit":{"parents":[{"commit":"747b457bb046e2cf9fa0fe0134f3add526859561","subject":"Merge \"Make versions aware of enabled pipelines.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/747b457bb046e2cf9fa0fe0134f3add526859561"}]}],"author":{"name":"Chris Yeoh","email":"cyeoh@au1.ibm.com","date":"2013-03-21 22:15:13.000000000","tz":630},"committer":{"name":"Chris Yeoh","email":"cyeoh@au1.ibm.com","date":"2013-03-21 22:15:13.000000000","tz":630},"subject":"close db migration session","message":"close db migration session\n\nExplicitly close sessions in db migration 022. With the postgresql backend\nif the session is not closed explicitly it leaves a user of the db behind\nwhich can cause problems later on\n\nFixes bug #1158544\n\nChange-Id: I389b83397addc5901aa94b584856fbd7f5cef485\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/d904a92fa3395f439b3f6723746bd31d995e577d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/d904a92fa3395f439b3f6723746bd31d995e577d"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"747b457bb046e2cf9fa0fe0134f3add526859561","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"9467a6602ef31c1976b64539fdd4bfc4b63a2c95":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2013-03-27 01:36:19.000000000","uploader":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"ref":"refs/changes/65/25065/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/65/25065/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/65/25065/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/65/25065/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/65/25065/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/65/25065/2"}}},"commit":{"parents":[{"commit":"4561612ccedd4ceab8c648c0028950ab4d4c2263","subject":"Merge \"keystone commands don\u0027t print any version information\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/4561612ccedd4ceab8c648c0028950ab4d4c2263"}]}],"author":{"name":"Chris Yeoh","email":"cyeoh@au1.ibm.com","date":"2013-03-21 22:15:13.000000000","tz":630},"committer":{"name":"Chris Yeoh","email":"cyeoh@au1.ibm.com","date":"2013-03-27 00:57:07.000000000","tz":630},"subject":"close db migration session","message":"close db migration session\n\nExplicitly close sessions in db migration 022. With the postgresql backend\nif the session is not closed explicitly it leaves a user of the db behind\nwhich can cause problems later on\n\nFixes bug #1158544\n\nChange-Id: I389b83397addc5901aa94b584856fbd7f5cef485\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/9467a6602ef31c1976b64539fdd4bfc4b63a2c95"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/9467a6602ef31c1976b64539fdd4bfc4b63a2c95"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4561612ccedd4ceab8c648c0028950ab4d4c2263","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}