)]}'
{"keystone/auth/plugins/password.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"344abc2a442f4b93f12c05c03a15bfe2778ff411","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        user_info \u003d auth_plugins.UserAuthInfo.create(auth_payload, METHOD_NAME)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # FIXME(gyee): identity.authenticate() can use some refactoring since"},{"line_number":37,"context_line":"        # all we care is password matches"},{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            self.identity_api.authenticate("},{"line_number":40,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_5a31c2eb","side":"PARENT","line":37,"updated":"2015-12-03 18:34:37.000000000","message":"And this is all it does today.\n\nhttps://github.com/openstack/keystone/blob/5070039/keystone/identity/core.py#L804","commit_id":"8dd27d3368ce0aa396386010f6aec5ed6304d687"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"0ce4377be55c49903efbfff458a66ae61dabba74","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        user_info \u003d auth_plugins.UserAuthInfo.create(auth_payload, METHOD_NAME)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # FIXME(gyee): identity.authenticate() can use some refactoring since"},{"line_number":37,"context_line":"        # all we care is password matches"},{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            self.identity_api.authenticate("},{"line_number":40,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_5ff1b1cc","side":"PARENT","line":37,"in_reply_to":"7a740942_5a31c2eb","updated":"2015-12-03 19:19:59.000000000","message":"But this is still valid. Guang is talking about not passing the context to that method anymore.","commit_id":"8dd27d3368ce0aa396386010f6aec5ed6304d687"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4765821787b00536ac4f54340d649c921420703e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        user_info \u003d auth_plugins.UserAuthInfo.create(auth_payload, METHOD_NAME)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # FIXME(gyee): identity.authenticate() can use some refactoring since"},{"line_number":37,"context_line":"        # all we care is password matches"},{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            self.identity_api.authenticate("},{"line_number":40,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_8517c6ec","side":"PARENT","line":37,"updated":"2015-12-03 20:01:54.000000000","message":"We need context for the audit event.","commit_id":"8dd27d3368ce0aa396386010f6aec5ed6304d687"}],"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"344abc2a442f4b93f12c05c03a15bfe2778ff411","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"        # valid."},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"        # FIXME(blk-u): This isn\u0027t working correctly. The scoped token should"},{"line_number":1403,"context_line":"        # be revoked. See bug 1347318."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":"        unscoped_token \u003d self.get_v2_token()"},{"line_number":1406,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_1a79fa93","side":"PARENT","line":1403,"updated":"2015-12-03 18:34:37.000000000","message":"Bug is now fixed: https://bugs.launchpad.net/keystone/+bug/1347318","commit_id":"8dd27d3368ce0aa396386010f6aec5ed6304d687"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"67e40c939587ce466a0683ed5af65a6cd0448b39","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"        # valid."},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"        # FIXME(blk-u): This isn\u0027t working correctly. The scoped token should"},{"line_number":1403,"context_line":"        # be revoked. See bug 1347318."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":"        unscoped_token \u003d self.get_v2_token()"},{"line_number":1406,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_f009752d","side":"PARENT","line":1403,"range":{"start_line":1403,"start_character":30,"end_line":1403,"end_character":37},"updated":"2015-12-04 17:30:24.000000000","message":"this has been closed:","commit_id":"8dd27d3368ce0aa396386010f6aec5ed6304d687"}],"keystone/token/provider.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"344abc2a442f4b93f12c05c03a15bfe2778ff411","unresolved":false,"context_lines":[{"line_number":338,"context_line":"            # project-scoped token, fill in the v2 token data"},{"line_number":339,"context_line":"            # all we care are the role IDs"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"            # FIXME(gyee): is there really a need to store roles in metadata?"},{"line_number":342,"context_line":"            role_ids \u003d [r[\u0027id\u0027] for r in token_data[\u0027token\u0027][\u0027roles\u0027]]"},{"line_number":343,"context_line":"            metadata_ref \u003d {\u0027roles\u0027: role_ids}"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_da7292ad","side":"PARENT","line":341,"updated":"2015-12-03 18:34:37.000000000","message":"We aren\u0027t accessing roles by metadata here.","commit_id":"8dd27d3368ce0aa396386010f6aec5ed6304d687"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"0466855554f8b01b72c54a09037b5a12211b965e","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"            # FIXME(gyee): is there really a need to store roles in metadata?"},{"line_number":342,"context_line":"            role_ids \u003d [r[\u0027id\u0027] for r in token_data[\u0027token\u0027][\u0027roles\u0027]]"},{"line_number":343,"context_line":"            metadata_ref \u003d {\u0027roles\u0027: role_ids}"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if trust:"},{"line_number":346,"context_line":"            metadata_ref.setdefault(\u0027trust_id\u0027, trust[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_bc2223b8","side":"PARENT","line":343,"updated":"2015-12-03 19:13:35.000000000","message":"We keep storing the roles in metadata, I think that this FIXME still valid. (Or we don\u0027t need add this roles on metadata and we can remove this FIXME)","commit_id":"8dd27d3368ce0aa396386010f6aec5ed6304d687"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"0ce4377be55c49903efbfff458a66ae61dabba74","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"            # FIXME(gyee): is there really a need to store roles in metadata?"},{"line_number":342,"context_line":"            role_ids \u003d [r[\u0027id\u0027] for r in token_data[\u0027token\u0027][\u0027roles\u0027]]"},{"line_number":343,"context_line":"            metadata_ref \u003d {\u0027roles\u0027: role_ids}"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if trust:"},{"line_number":346,"context_line":"            metadata_ref.setdefault(\u0027trust_id\u0027, trust[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_1f4d6972","side":"PARENT","line":343,"in_reply_to":"7a740942_bc2223b8","updated":"2015-12-03 19:19:59.000000000","message":"That\u0027s true Raildo. Thanks","commit_id":"8dd27d3368ce0aa396386010f6aec5ed6304d687"}]}
