)]}'
{"keystone/client.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"5dbde3fe47e95fea2a81583d58f091485a3c7611","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import keystone.common.exception"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"logger \u003d logging.getLogger(\u0027keystone.client\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ServiceClient(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7I0%3D","line":23,"updated":"2011-12-22 07:02:54.000000000","message":"__name__","commit_id":"1f94f218406c30cf0c0483a972b92ca5b86bc983"},{"author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"change_message_id":"b4612483547dfa68a26ffaacd43acc58aea4a97d","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import keystone.common.exception"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"logger \u003d logging.getLogger(\u0027keystone.client\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ServiceClient(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F67M%3D","line":23,"in_reply_to":"AAAAC3%2F%2F7I0%3D","updated":"2011-12-22 21:17:47.000000000","message":"Done","commit_id":"1f94f218406c30cf0c0483a972b92ca5b86bc983"}],"keystone/server.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"5dbde3fe47e95fea2a81583d58f091485a3c7611","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                         ca_certs\u003dca_certs,"},{"line_number":186,"context_line":"                         cert_required\u003dcert_required,"},{"line_number":187,"context_line":"                         key\u003dself.key)"},{"line_number":188,"context_line":"            self.port \u003d port"},{"line_number":189,"context_line":"            self.host \u003d host"},{"line_number":190,"context_line":"            self.protocol \u003d \u0027https\u0027"},{"line_number":191,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7Iw%3D","line":188,"updated":"2011-12-22 07:02:54.000000000","message":"port/host can be set outside the if block","commit_id":"1f94f218406c30cf0c0483a972b92ca5b86bc983"},{"author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"change_message_id":"b4612483547dfa68a26ffaacd43acc58aea4a97d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                         ca_certs\u003dca_certs,"},{"line_number":186,"context_line":"                         cert_required\u003dcert_required,"},{"line_number":187,"context_line":"                         key\u003dself.key)"},{"line_number":188,"context_line":"            self.port \u003d port"},{"line_number":189,"context_line":"            self.host \u003d host"},{"line_number":190,"context_line":"            self.protocol \u003d \u0027https\u0027"},{"line_number":191,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F67A%3D","line":188,"in_reply_to":"AAAAC3%2F%2F7Iw%3D","updated":"2011-12-22 21:17:47.000000000","message":"Done","commit_id":"1f94f218406c30cf0c0483a972b92ca5b86bc983"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3e56e4e260d49379a39f22481c5742d42a394c52","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                         cert_required\u003dcert_required,"},{"line_number":187,"context_line":"                         key\u003dself.key)"},{"line_number":188,"context_line":"            self.port \u003d port"},{"line_number":189,"context_line":"            self.host \u003d host"},{"line_number":190,"context_line":"            self.protocol \u003d \u0027https\u0027"},{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            self.server \u003d wsgi.Server()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7Dw%3D","line":189,"updated":"2011-12-22 16:07:45.000000000","message":"+1 on Dolph\u0027s comment","commit_id":"1f94f218406c30cf0c0483a972b92ca5b86bc983"},{"author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"change_message_id":"b4612483547dfa68a26ffaacd43acc58aea4a97d","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                         cert_required\u003dcert_required,"},{"line_number":187,"context_line":"                         key\u003dself.key)"},{"line_number":188,"context_line":"            self.port \u003d port"},{"line_number":189,"context_line":"            self.host \u003d host"},{"line_number":190,"context_line":"            self.protocol \u003d \u0027https\u0027"},{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            self.server \u003d wsgi.Server()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F668%3D","line":189,"in_reply_to":"AAAAC3%2F%2F7Dw%3D","updated":"2011-12-22 21:17:47.000000000","message":"Done","commit_id":"1f94f218406c30cf0c0483a972b92ca5b86bc983"}],"keystone/test/__init__.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3e56e4e260d49379a39f22481c5742d42a394c52","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        template_fpath \u003d os.path.join(TEST_DIR, \u0027etc\u0027, self.config_name)"},{"line_number":378,"context_line":"        conf_contents \u003d open(template_fpath).read()"},{"line_number":379,"context_line":"        self.CONF_PARAMS[\u0027service_port\u0027] \u003d utils.get_unused_port()"},{"line_number":380,"context_line":"        self.CONF_PARAMS[\u0027admin_port\u0027] \u003d utils.get_unused_port()"},{"line_number":381,"context_line":"        conf_contents \u003d conf_contents % self.CONF_PARAMS"},{"line_number":382,"context_line":"        self.conf_fp \u003d tempfile.NamedTemporaryFile()"},{"line_number":383,"context_line":"        self.conf_fp.write(conf_contents)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7Ds%3D","line":380,"updated":"2011-12-22 16:07:45.000000000","message":"I know that this wasn\u0027t part of this change, but why is \u0027CONF_PARAMS\u0027 capitalized? That usually indicates a constant, and you\u0027re clearly modifying it here.","commit_id":"1f94f218406c30cf0c0483a972b92ca5b86bc983"},{"author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"change_message_id":"b4612483547dfa68a26ffaacd43acc58aea4a97d","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        template_fpath \u003d os.path.join(TEST_DIR, \u0027etc\u0027, self.config_name)"},{"line_number":378,"context_line":"        conf_contents \u003d open(template_fpath).read()"},{"line_number":379,"context_line":"        self.CONF_PARAMS[\u0027service_port\u0027] \u003d utils.get_unused_port()"},{"line_number":380,"context_line":"        self.CONF_PARAMS[\u0027admin_port\u0027] \u003d utils.get_unused_port()"},{"line_number":381,"context_line":"        conf_contents \u003d conf_contents % self.CONF_PARAMS"},{"line_number":382,"context_line":"        self.conf_fp \u003d tempfile.NamedTemporaryFile()"},{"line_number":383,"context_line":"        self.conf_fp.write(conf_contents)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F66w%3D","line":380,"in_reply_to":"AAAAC3%2F%2F7Ds%3D","updated":"2011-12-22 21:17:47.000000000","message":"Done","commit_id":"1f94f218406c30cf0c0483a972b92ca5b86bc983"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3e56e4e260d49379a39f22481c5742d42a394c52","unresolved":false,"context_lines":[{"line_number":427,"context_line":"            # the server is"},{"line_number":428,"context_line":"            client_tests.TEST_TARGET_SERVER_SERVICE_PROTOCOL \u003d service.protocol"},{"line_number":429,"context_line":"            client_tests.TEST_TARGET_SERVER_SERVICE_ADDRESS \u003d service.host"},{"line_number":430,"context_line":"            client_tests.TEST_TARGET_SERVER_SERVICE_PORT \u003d service.port"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        except RuntimeError, e:"},{"line_number":433,"context_line":"            sys.exit(\"ERROR: %s\" % e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7Do%3D","line":430,"updated":"2011-12-22 16:07:45.000000000","message":"Again, why the capitalization for these attributes?","commit_id":"1f94f218406c30cf0c0483a972b92ca5b86bc983"},{"author":{"_account_id":5,"name":"Ziad Sawalha","email":"ziad.sawalha@rackspace.com","username":"ziad-sawalha"},"change_message_id":"b4612483547dfa68a26ffaacd43acc58aea4a97d","unresolved":false,"context_lines":[{"line_number":427,"context_line":"            # the server is"},{"line_number":428,"context_line":"            client_tests.TEST_TARGET_SERVER_SERVICE_PROTOCOL \u003d service.protocol"},{"line_number":429,"context_line":"            client_tests.TEST_TARGET_SERVER_SERVICE_ADDRESS \u003d service.host"},{"line_number":430,"context_line":"            client_tests.TEST_TARGET_SERVER_SERVICE_PORT \u003d service.port"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        except RuntimeError, e:"},{"line_number":433,"context_line":"            sys.exit(\"ERROR: %s\" % e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F66o%3D","line":430,"in_reply_to":"AAAAC3%2F%2F7Do%3D","updated":"2011-12-22 21:17:47.000000000","message":"These are global variables used by all tests.","commit_id":"1f94f218406c30cf0c0483a972b92ca5b86bc983"}]}