)]}'
{"keystone/tests/unit/test_v3_protection.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"9b0c024283434c33856a277e1da61a7df7722a25","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        self.delete(member_url, auth\u003dself.auth,"},{"line_number":748,"context_line":"                    expected_status\u003dstatus_no_data)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def _test_role_management(self, read_status_OK\u003dFalse, expected\u003dNone):"},{"line_number":751,"context_line":"        status_OK, status_created, status_no_data \u003d self._stati(expected)"},{"line_number":752,"context_line":"        entity_url \u003d \u0027/roles/%s\u0027 % self.role[\u0027id\u0027]"},{"line_number":753,"context_line":"        list_url \u003d \u0027/roles\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_354de972","line":750,"range":{"start_line":750,"start_character":8,"end_line":750,"end_character":29},"updated":"2015-12-30 12:37:26.000000000","message":"better to rename this method, we will see the trouble for python 3 unittest since there is \"test\" keyword in this method.\n\nsee: https://review.openstack.org/#/c/205352/","commit_id":"5d7a642baf9ec95509b4f5f71ef4aa2c60a79bc9"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0e8768c8201890b69fc0741aae5621ae1e561cca","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        self.delete(member_url, auth\u003dself.auth,"},{"line_number":748,"context_line":"                    expected_status\u003dstatus_no_data)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def _test_role_management(self, read_status_OK\u003dFalse, expected\u003dNone):"},{"line_number":751,"context_line":"        status_OK, status_created, status_no_data \u003d self._stati(expected)"},{"line_number":752,"context_line":"        entity_url \u003d \u0027/roles/%s\u0027 % self.role[\u0027id\u0027]"},{"line_number":753,"context_line":"        list_url \u003d \u0027/roles\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_e3ff8932","line":750,"range":{"start_line":750,"start_character":8,"end_line":750,"end_character":29},"in_reply_to":"fa69d971_354de972","updated":"2015-12-30 21:41:35.000000000","message":"Done","commit_id":"5d7a642baf9ec95509b4f5f71ef4aa2c60a79bc9"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"9b0c024283434c33856a277e1da61a7df7722a25","unresolved":false,"context_lines":[{"line_number":748,"context_line":"                    expected_status\u003dstatus_no_data)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def _test_role_management(self, read_status_OK\u003dFalse, expected\u003dNone):"},{"line_number":751,"context_line":"        status_OK, status_created, status_no_data \u003d self._stati(expected)"},{"line_number":752,"context_line":"        entity_url \u003d \u0027/roles/%s\u0027 % self.role[\u0027id\u0027]"},{"line_number":753,"context_line":"        list_url \u003d \u0027/roles\u0027"},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_d837e4e1","line":751,"range":{"start_line":751,"start_character":8,"end_line":751,"end_character":49},"updated":"2015-12-30 12:37:26.000000000","message":"Is it possible to rename these vars? status_OK makes me believe the status is always `OK`, `created` etc. but actually, it could be ForbiddenAction for example.\n\nGood as it is, I saw this is used in other places.","commit_id":"5d7a642baf9ec95509b4f5f71ef4aa2c60a79bc9"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0e8768c8201890b69fc0741aae5621ae1e561cca","unresolved":false,"context_lines":[{"line_number":748,"context_line":"                    expected_status\u003dstatus_no_data)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def _test_role_management(self, read_status_OK\u003dFalse, expected\u003dNone):"},{"line_number":751,"context_line":"        status_OK, status_created, status_no_data \u003d self._stati(expected)"},{"line_number":752,"context_line":"        entity_url \u003d \u0027/roles/%s\u0027 % self.role[\u0027id\u0027]"},{"line_number":753,"context_line":"        list_url \u003d \u0027/roles\u0027"},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_a3f9914f","line":751,"range":{"start_line":751,"start_character":8,"end_line":751,"end_character":49},"in_reply_to":"fa69d971_d837e4e1","updated":"2015-12-30 21:41:35.000000000","message":"I added a comment to make this clearer.","commit_id":"5d7a642baf9ec95509b4f5f71ef4aa2c60a79bc9"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"8a7cb00bb13eedb4aa9626d4e66e85e79ace6ba9","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"        self.assertEqual(self.project[\u0027id\u0027],"},{"line_number":1431,"context_line":"                         jsonutils.loads(resp.body)[\u0027project\u0027][\u0027id\u0027])"},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"    def test_role_management_no_admin_no_rights(self):"},{"line_number":1434,"context_line":"        # A non-admin domain user shouldn\u0027t be able to manipulate roles"},{"line_number":1435,"context_line":"        self.auth \u003d self.build_authentication_request("},{"line_number":1436,"context_line":"            user_id\u003dself.just_a_user[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_59a09043","line":1433,"updated":"2016-01-28 23:14:29.000000000","message":"Great job. I love the comments for each test. Very readable!!!","commit_id":"a932d68d7dbc1a2fa0632610e03ce125da6ff1ac"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"8a7cb00bb13eedb4aa9626d4e66e85e79ace6ba9","unresolved":false,"context_lines":[{"line_number":1455,"context_line":"            password\u003dself.project_admin_user[\u0027password\u0027],"},{"line_number":1456,"context_line":"            project_id\u003dself.project[\u0027id\u0027])"},{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"        self._role_management_cases(read_status_OK\u003dTrue,"},{"line_number":1459,"context_line":"                                    expected\u003dexception.ForbiddenAction.code)"},{"line_number":1460,"context_line":""},{"line_number":1461,"context_line":"    def test_role_management_with_domain_admin(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_392274ba","line":1458,"updated":"2016-01-28 23:14:29.000000000","message":"I really like how you use read_status_OK to control what to test","commit_id":"a932d68d7dbc1a2fa0632610e03ce125da6ff1ac"}]}