)]}'
{"keystone/federation/core.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"79f7af15347494618f7d05b8e13c8a173c9731eb","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    \"\"\""},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def __init__(self, wrapped_driver):"},{"line_number":435,"context_line":"        self.driver \u003d wrapped_driver"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def create_idp(self, idp_id, idp):"},{"line_number":438,"context_line":"        return self.driver.create_idp(idp_id, idp)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_06a3b250","line":435,"range":{"start_line":434,"start_character":0,"end_line":435,"end_character":36},"updated":"2016-01-01 11:29:41.000000000","message":"looks like you forgot to deprecate this.","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1b3826ebb2f351c70b0def677a3569dc6eb4b790","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    \"\"\""},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def __init__(self, wrapped_driver):"},{"line_number":435,"context_line":"        self.driver \u003d wrapped_driver"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def create_idp(self, idp_id, idp):"},{"line_number":438,"context_line":"        return self.driver.create_idp(idp_id, idp)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_99ee24b3","line":435,"range":{"start_line":434,"start_character":0,"end_line":435,"end_character":36},"in_reply_to":"fa69d971_06a3b250","updated":"2016-01-01 19:21:31.000000000","message":"oops, yes, you are right - will fix that","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"52702dbac7d79976aa778d6b44e01e7893463c6b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            self.driver \u003d V9FederationWrapperForV8Driver(self.driver)"},{"line_number":64,"context_line":"        elif not isinstance(self.driver, FederationDriverV9):"},{"line_number":65,"context_line":"            raise exception.UnsupportedDriverVersion("},{"line_number":66,"context_line":"                driver\u003dCONF.federation.driver)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def get_enabled_service_providers(self):"},{"line_number":69,"context_line":"        \"\"\"List enabled service providers for Service Catalog"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_e8f02f93","line":66,"updated":"2016-01-11 20:59:34.000000000","message":"Shouldn\u0027t these be common code? Seem like a common pattern across all drivers.","commit_id":"2774d53355cdfc1c7b5d518fc4a5426d03d4f922"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b3f697c3869141c873f078947beeb8f707e7a9eb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            self.driver \u003d V9FederationWrapperForV8Driver(self.driver)"},{"line_number":64,"context_line":"        elif not isinstance(self.driver, FederationDriverV9):"},{"line_number":65,"context_line":"            raise exception.UnsupportedDriverVersion("},{"line_number":66,"context_line":"                driver\u003dCONF.federation.driver)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def get_enabled_service_providers(self):"},{"line_number":69,"context_line":"        \"\"\"List enabled service providers for Service Catalog"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_a8beb762","line":66,"in_reply_to":"fa69d971_e8f02f93","updated":"2016-01-11 21:02:05.000000000","message":"I think that\u0027s a good idea. Once these merge, I\u0027ll come back in and extract this from the V9 drivers we have done.","commit_id":"2774d53355cdfc1c7b5d518fc4a5426d03d4f922"}],"keystone/tests/unit/backend/legacy_drivers/federation/V8/api_v3.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"79f7af15347494618f7d05b8e13c8a173c9731eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#      http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Unless required by applicable law or agreed to in writing, software"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_617858f3","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":1},"updated":"2016-01-01 11:29:41.000000000","message":"just out of curiosity, why you name this as `api_v3.py` but `sql.py` for other similar work you have done.","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1b3826ebb2f351c70b0def677a3569dc6eb4b790","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#      http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Unless required by applicable law or agreed to in writing, software"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_592f4cf6","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":1},"in_reply_to":"fa69d971_617858f3","updated":"2016-01-01 19:21:31.000000000","message":"well the other ones where testing the manager sql tests...for federation we don\u0027t have such tests, so I was indicating that in this case we are using the v3 API tests for legacy testing","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"79f7af15347494618f7d05b8e13c8a173c9731eb","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class FederatedIdentityProviderTestsV8("},{"line_number":17,"context_line":"        test_v3_federation.FederatedIdentityProviderTests):"},{"line_number":18,"context_line":"    \"\"\"Test that a V8 driver still passes the same tests."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    We use the SQL driver as an example of a V8 legacy driver."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_41643448","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":57},"updated":"2016-01-01 11:29:41.000000000","message":"what about other testcases? ServiceProviderTests or MappingCRUDTests for example.","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1b3826ebb2f351c70b0def677a3569dc6eb4b790","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class FederatedIdentityProviderTestsV8("},{"line_number":17,"context_line":"        test_v3_federation.FederatedIdentityProviderTests):"},{"line_number":18,"context_line":"    \"\"\"Test that a V8 driver still passes the same tests."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    We use the SQL driver as an example of a V8 legacy driver."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_1910f4a7","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":57},"in_reply_to":"fa69d971_41643448","updated":"2016-01-01 19:21:31.000000000","message":"yes, agreed....it\u0027s a balance.  I think this is up to who is adding the new methods to determine which tests will cover what they are changing...feel free to modify this","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"79f7af15347494618f7d05b8e13c8a173c9731eb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            group\u003d\u0027federation\u0027,"},{"line_number":29,"context_line":"            driver\u003d\u0027keystone.federation.V8_backends.sql.Federation\u0027)"},{"line_number":30,"context_line":"        self.use_specific_sql_driver_version("},{"line_number":31,"context_line":"            \u0027keystone.federation\u0027, \u0027backends\u0027, \u0027V8_\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_cc0ffb2c","line":31,"updated":"2016-01-01 11:29:41.000000000","message":"L29 haven\u0027t cover this?","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1b3826ebb2f351c70b0def677a3569dc6eb4b790","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            group\u003d\u0027federation\u0027,"},{"line_number":29,"context_line":"            driver\u003d\u0027keystone.federation.V8_backends.sql.Federation\u0027)"},{"line_number":30,"context_line":"        self.use_specific_sql_driver_version("},{"line_number":31,"context_line":"            \u0027keystone.federation\u0027, \u0027backends\u0027, \u0027V8_\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_b9276811","line":31,"in_reply_to":"fa69d971_cc0ffb2c","updated":"2016-01-01 19:21:31.000000000","message":"due to the fact that some components have multiple backend (e.g. in assignment we have backends and role_backends), we need to be a bit more specific.","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"}],"keystone/tests/unit/core.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"79f7af15347494618f7d05b8e13c8a173c9731eb","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            config, \u0027_register_auth_plugin_opt\u0027,"},{"line_number":597,"context_line":"            new\u003dmocked_register_auth_plugin_opt))"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        self.sql_driver_version_overrides \u003d {}"},{"line_number":600,"context_line":"        self.config_overrides()"},{"line_number":601,"context_line":"        # NOTE(morganfainberg): ensure config_overrides has been called."},{"line_number":602,"context_line":"        self.addCleanup(self._assert_config_overrides_called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_61305802","line":599,"updated":"2016-01-01 11:29:41.000000000","message":"why do this change?","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1b3826ebb2f351c70b0def677a3569dc6eb4b790","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            config, \u0027_register_auth_plugin_opt\u0027,"},{"line_number":597,"context_line":"            new\u003dmocked_register_auth_plugin_opt))"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        self.sql_driver_version_overrides \u003d {}"},{"line_number":600,"context_line":"        self.config_overrides()"},{"line_number":601,"context_line":"        # NOTE(morganfainberg): ensure config_overrides has been called."},{"line_number":602,"context_line":"        self.addCleanup(self._assert_config_overrides_called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_d9225c01","line":599,"in_reply_to":"fa69d971_61305802","updated":"2016-01-01 19:21:31.000000000","message":"so that it is in the ancestry of all restful test classes...some of which don\u0027t use the SQLDriverOverrides","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"}],"keystone/tests/unit/ksfixtures/database.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"79f7af15347494618f7d05b8e13c8a173c9731eb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            # \u0027keystone.assignment\u0027, while this_backend might be something"},{"line_number":111,"context_line":"            # \u0027V8_backends\u0027."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            if module_without_backends.startswith(\u0027keystone.contrib\u0027):"},{"line_number":114,"context_line":"                # All the sql modules have now been moved into the core tree"},{"line_number":115,"context_line":"                # so no point in loading these again here (and, in fact, doing"},{"line_number":116,"context_line":"                # so might break trying to load a versioned driver."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_ac140744","line":113,"updated":"2016-01-01 11:29:41.000000000","message":"nice!","commit_id":"0a088321f5d0507eea12962c8af808bfca5ebacd"}],"releasenotes/notes/v9FederationDriver-cbebcf5f97e1eae2.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"fd417247a7f81ddca927fc8d54b454831b0168d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da6ed579_37f17bce","updated":"2016-01-12 06:55:26.000000000","message":"mention that we created a v9 driver too?","commit_id":"2774d53355cdfc1c7b5d518fc4a5426d03d4f922"}]}