)]}'
{"tests/_test_import_auth_token.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7b8ce5f2246a2129d113b2977b54096a44d7cb99","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        from oslo.config import cfg"},{"line_number":18,"context_line":"        conf \u003d cfg.CONF"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        try:"},{"line_number":21,"context_line":"            # define some config options"},{"line_number":22,"context_line":"            conf.register_opt(cfg.BoolOpt(\u0027debug\u0027, default\u003dFalse))"},{"line_number":23,"context_line":"        except cfg.DuplicateOptError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F%2Fis%3D","line":20,"updated":"2013-04-08 22:06:09.000000000","message":"would be nice to have a comment in the code as to why the register_opt needs to be wrapped in try/except.\n\nwould it be better to change to a different option name to avoid the problem?\n\nIf the DuplicateOptError is expected, then test that with assertRaises .\n\nWhy not remove call to register_opt?","commit_id":"1e60f3d153b7f8a6d74b782a19834ecad07ec12a"},{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"5f297466afd9987e66ec499782076145207d7268","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        from oslo.config import cfg"},{"line_number":18,"context_line":"        conf \u003d cfg.CONF"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        try:"},{"line_number":21,"context_line":"            # define some config options"},{"line_number":22,"context_line":"            conf.register_opt(cfg.BoolOpt(\u0027debug\u0027, default\u003dFalse))"},{"line_number":23,"context_line":"        except cfg.DuplicateOptError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F99g%3D","line":20,"in_reply_to":"AAAAOn%2F%2F%2Fis%3D","updated":"2013-04-22 16:21:08.000000000","message":"brant: i can add a note, but it only errors when run under certain circumstances in the tests, i don\u0027t know what the original goal of this test is so I made the minimal change. \n\nAs far as I can tell we are not testing that we can set a config value, just that importing oslo before before auth_token works","commit_id":"1e60f3d153b7f8a6d74b782a19834ecad07ec12a"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"7d091fe4a62f40e5fc6a79746a6dc53f39070819","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        from oslo.config import cfg"},{"line_number":18,"context_line":"        conf \u003d cfg.CONF"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        try:"},{"line_number":21,"context_line":"            # define some config options"},{"line_number":22,"context_line":"            conf.register_opt(cfg.BoolOpt(\u0027debug\u0027, default\u003dFalse))"},{"line_number":23,"context_line":"        except cfg.DuplicateOptError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fz5E%3D","line":20,"in_reply_to":"AAAAOn%2F%2F99g%3D","updated":"2013-04-22 16:37:09.000000000","message":"The test written to ensure that DuplicateOptError isn\u0027t raised (see the original bug: https://review.openstack.org/#/c/24701/ ) when oslo.config options are registered in addition to importing keystone.middleware.auth_token","commit_id":"1e60f3d153b7f8a6d74b782a19834ecad07ec12a"}]}