)]}'
{"keystone/tests/unit/test_cli.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0ca718278212496168b58ca90d803dba1e3ca10a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from six.moves import range"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from keystone.cmd import cli"},{"line_number":25,"context_line":"from keystone.common import dependency"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_346b8b20","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":27},"updated":"2015-12-31 12:42:09.000000000","message":"consider to import like this,\n\n from six.moves import builtins, range\n\nand use range.print instead, this will avoid to expose all the module from six.","commit_id":"392ffc40609259d27e6afc47297858800e1d891a"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"5f2013f95a423ee2659ebe315433d1e30ab31617","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from six.moves import range"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from keystone.cmd import cli"},{"line_number":25,"context_line":"from keystone.common import dependency"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_65494b8b","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":27},"in_reply_to":"fa69d971_346b8b20","updated":"2015-12-31 14:52:41.000000000","message":"I agree with Dave","commit_id":"392ffc40609259d27e6afc47297858800e1d891a"},{"author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"change_message_id":"ef7fec1299deba567fee812af8698cf9ab669d27","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from six.moves import range"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from keystone.cmd import cli"},{"line_number":25,"context_line":"from keystone.common import dependency"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_8e23eda6","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":27},"in_reply_to":"fa69d971_346b8b20","updated":"2016-01-05 08:59:30.000000000","message":"Thanks for the comments Dave.\n\nFirst of all I think you mean \u0027builtins.print\u0027 in the comment.\nSecondly to mock an object we need to specify its fully qualified name like \u0027six.moves.buitlins.print\u0027. Another example: https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_kvs.py#L574\n\nKindly Refer: https://docs.python.org/3/library/unittest.mock.html#patch","commit_id":"392ffc40609259d27e6afc47297858800e1d891a"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c0a5042cb38f511394463871cc00298474c39ecf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from six.moves import range"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from keystone.cmd import cli"},{"line_number":25,"context_line":"from keystone.common import dependency"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_6f884ce8","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":27},"in_reply_to":"fa69d971_346b8b20","updated":"2015-12-31 13:12:49.000000000","message":"s/range.print/builtins.print","commit_id":"392ffc40609259d27e6afc47297858800e1d891a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"266c0574f85227a04819ee5b29e3a3ad16459841","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from six.moves import range"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from keystone.cmd import cli"},{"line_number":25,"context_line":"from keystone.common import dependency"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_127a14f2","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":27},"in_reply_to":"fa69d971_65494b8b","updated":"2015-12-31 16:26:15.000000000","message":"hi,\n\nimport six was not required as it is used in mock, so i have removed it.\n\nThank you for your reviews.","commit_id":"392ffc40609259d27e6afc47297858800e1d891a"},{"author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"change_message_id":"ef7fec1299deba567fee812af8698cf9ab669d27","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from six.moves import range"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from keystone.cmd import cli"},{"line_number":25,"context_line":"from keystone.common import dependency"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_ce548500","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":27},"in_reply_to":"fa69d971_6f884ce8","updated":"2016-01-05 08:59:30.000000000","message":"I think you mean \u0027s/six.moves.builtins.print/builtins.print\u0027 but again IMO this is not required as per my above comment.","commit_id":"392ffc40609259d27e6afc47297858800e1d891a"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"666c098852b9dc3142724cb7327250cb1d8294d8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from six.moves import range"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from keystone.cmd import cli"},{"line_number":25,"context_line":"from keystone.common import dependency"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_bc894b77","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":27},"in_reply_to":"fa69d971_ce548500","updated":"2016-01-05 09:30:17.000000000","message":"yep, just remove the import is fine, i agree this is needn\u0027t.","commit_id":"392ffc40609259d27e6afc47297858800e1d891a"}]}