)]}'
{"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"317731ebee9e5fad2c59298052dcb0b49ced6bb6","unresolved":false,"context_lines":[{"line_number":3901,"context_line":"        self.delete(\u0027/OS-TRUST/trusts/%(trust_id)s\u0027 % {"},{"line_number":3902,"context_line":"            \u0027trust_id\u0027: trust[\u0027id\u0027]})"},{"line_number":3903,"context_line":""},{"line_number":3904,"context_line":"        self.get(\u0027/OS-TRUST/trusts/%(trust_id)s\u0027 % {"},{"line_number":3905,"context_line":"            \u0027trust_id\u0027: trust[\u0027id\u0027]},"},{"line_number":3906,"context_line":"            expected_status\u003dhttp_client.NOT_FOUND)"},{"line_number":3907,"context_line":""},{"line_number":3908,"context_line":"        self.get(\u0027/OS-TRUST/trusts/%(trust_id)s\u0027 % {"},{"line_number":3909,"context_line":"            \u0027trust_id\u0027: trust[\u0027id\u0027]},"},{"line_number":3910,"context_line":"            expected_status\u003dhttp_client.NOT_FOUND)"},{"line_number":3911,"context_line":""},{"line_number":3912,"context_line":"        auth_data \u003d self.build_authentication_request("},{"line_number":3913,"context_line":"            user_id\u003dself.trustee_user[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_55e4793a","side":"PARENT","line":3910,"range":{"start_line":3904,"start_character":0,"end_line":3910,"end_character":50},"updated":"2016-01-11 19:10:30.000000000","message":"why were these deleted?","commit_id":"d446a4e2971b9a7c8f19e3865f3614141ce98012"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"23aad0351d7eaf9c388fb56e4cff6bf2e2f75fd2","unresolved":false,"context_lines":[{"line_number":3901,"context_line":"        self.delete(\u0027/OS-TRUST/trusts/%(trust_id)s\u0027 % {"},{"line_number":3902,"context_line":"            \u0027trust_id\u0027: trust[\u0027id\u0027]})"},{"line_number":3903,"context_line":""},{"line_number":3904,"context_line":"        self.get(\u0027/OS-TRUST/trusts/%(trust_id)s\u0027 % {"},{"line_number":3905,"context_line":"            \u0027trust_id\u0027: trust[\u0027id\u0027]},"},{"line_number":3906,"context_line":"            expected_status\u003dhttp_client.NOT_FOUND)"},{"line_number":3907,"context_line":""},{"line_number":3908,"context_line":"        self.get(\u0027/OS-TRUST/trusts/%(trust_id)s\u0027 % {"},{"line_number":3909,"context_line":"            \u0027trust_id\u0027: trust[\u0027id\u0027]},"},{"line_number":3910,"context_line":"            expected_status\u003dhttp_client.NOT_FOUND)"},{"line_number":3911,"context_line":""},{"line_number":3912,"context_line":"        auth_data \u003d self.build_authentication_request("},{"line_number":3913,"context_line":"            user_id\u003dself.trustee_user[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_a291f648","side":"PARENT","line":3910,"range":{"start_line":3904,"start_character":0,"end_line":3910,"end_character":50},"in_reply_to":"fa69d971_55e4793a","updated":"2016-01-11 20:04:03.000000000","message":"We separated these out because they are more of a crud assertion than an authentication assertion. The authentication assertion is kept on line 3917.","commit_id":"d446a4e2971b9a7c8f19e3865f3614141ce98012"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"317731ebee9e5fad2c59298052dcb0b49ced6bb6","unresolved":false,"context_lines":[{"line_number":3268,"context_line":"        trust \u003d r.result.get(\u0027trust\u0027)"},{"line_number":3269,"context_line":"        self.assertIsNotNone(trust)"},{"line_number":3270,"context_line":"        self.assertEqual(1, trust[\u0027remaining_uses\u0027])"},{"line_number":3271,"context_line":"        # FIXME(lbragstad): Assert the role that is returned is the right role."},{"line_number":3272,"context_line":""},{"line_number":3273,"context_line":"    def test_create_one_time_use_trust(self):"},{"line_number":3274,"context_line":"        trust \u003d self._initialize_test_consume_trust(1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_35ef851f","line":3271,"range":{"start_line":3271,"start_character":8,"end_line":3271,"end_character":78},"updated":"2016-01-11 19:10:30.000000000","message":"unrelated, but OK","commit_id":"010ed3c1d237c54b3fd451c1ddafae59633055db"}],"keystone/tests/unit/test_v3_trust.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"23aad0351d7eaf9c388fb56e4cff6bf2e2f75fd2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def config_overrides(self):"},{"line_number":28,"context_line":"        super(TestTrustOperations, self).config_overrides()"},{"line_number":29,"context_line":"        self.config_fixture.config(group\u003d\u0027revoke\u0027, driver\u003d\u0027kvs\u0027)"},{"line_number":30,"context_line":"        self.config_fixture.config("},{"line_number":31,"context_line":"            group\u003d\u0027token\u0027,"},{"line_number":32,"context_line":"            provider\u003d\u0027pki\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_b53ff5b2","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":64},"updated":"2016-01-11 20:04:03.000000000","message":"This should be specific to trust crud operations, investigate if this is still needed.","commit_id":"010ed3c1d237c54b3fd451c1ddafae59633055db"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"23aad0351d7eaf9c388fb56e4cff6bf2e2f75fd2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def config_overrides(self):"},{"line_number":28,"context_line":"        super(TestTrustOperations, self).config_overrides()"},{"line_number":29,"context_line":"        self.config_fixture.config(group\u003d\u0027revoke\u0027, driver\u003d\u0027kvs\u0027)"},{"line_number":30,"context_line":"        self.config_fixture.config("},{"line_number":31,"context_line":"            group\u003d\u0027token\u0027,"},{"line_number":32,"context_line":"            provider\u003d\u0027pki\u0027,"},{"line_number":33,"context_line":"            revoke_by_id\u003dFalse)"},{"line_number":34,"context_line":"        self.config_fixture.config(group\u003d\u0027trust\u0027, enabled\u003dTrue)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_154e016f","line":33,"range":{"start_line":30,"start_character":8,"end_line":33,"end_character":31},"updated":"2016-01-11 20:04:03.000000000","message":"I don\u0027t think this is specific to trust crud operations. Investigate if this can be removed.","commit_id":"010ed3c1d237c54b3fd451c1ddafae59633055db"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"317731ebee9e5fad2c59298052dcb0b49ced6bb6","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def config_overrides(self):"},{"line_number":28,"context_line":"        super(TestTrustOperations, self).config_overrides()"},{"line_number":29,"context_line":"        self.config_fixture.config(group\u003d\u0027revoke\u0027, driver\u003d\u0027kvs\u0027)"},{"line_number":30,"context_line":"        self.config_fixture.config("},{"line_number":31,"context_line":"            group\u003d\u0027token\u0027,"},{"line_number":32,"context_line":"            provider\u003d\u0027pki\u0027,"},{"line_number":33,"context_line":"            revoke_by_id\u003dFalse)"},{"line_number":34,"context_line":"        self.config_fixture.config(group\u003d\u0027trust\u0027, enabled\u003dTrue)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_b5f7f5d1","line":33,"range":{"start_line":29,"start_character":8,"end_line":33,"end_character":31},"updated":"2016-01-11 19:10:30.000000000","message":"are these needed? they don\u0027t seem to be exercised or checked","commit_id":"010ed3c1d237c54b3fd451c1ddafae59633055db"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"317731ebee9e5fad2c59298052dcb0b49ced6bb6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            group\u003d\u0027token\u0027,"},{"line_number":32,"context_line":"            provider\u003d\u0027pki\u0027,"},{"line_number":33,"context_line":"            revoke_by_id\u003dFalse)"},{"line_number":34,"context_line":"        self.config_fixture.config(group\u003d\u0027trust\u0027, enabled\u003dTrue)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super(TestTrustOperations, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_f559edfd","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":63},"updated":"2016-01-11 19:10:30.000000000","message":"this is already enabled by default: https://github.com/openstack/keystone/blob/master/etc/keystone.conf.sample#L2011","commit_id":"010ed3c1d237c54b3fd451c1ddafae59633055db"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"23aad0351d7eaf9c388fb56e4cff6bf2e2f75fd2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            group\u003d\u0027token\u0027,"},{"line_number":32,"context_line":"            provider\u003d\u0027pki\u0027,"},{"line_number":33,"context_line":"            revoke_by_id\u003dFalse)"},{"line_number":34,"context_line":"        self.config_fixture.config(group\u003d\u0027trust\u0027, enabled\u003dTrue)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super(TestTrustOperations, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_c2942a38","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":63},"in_reply_to":"fa69d971_f559edfd","updated":"2016-01-11 20:04:03.000000000","message":"Done","commit_id":"010ed3c1d237c54b3fd451c1ddafae59633055db"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"317731ebee9e5fad2c59298052dcb0b49ced6bb6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        trusts \u003d r.result[\u0027trusts\u0027]"},{"line_number":79,"context_line":"        self.assertEqual(0, len(trusts))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_delete_trust(self):"},{"line_number":82,"context_line":"        ref \u003d unit.new_trust_ref("},{"line_number":83,"context_line":"            trustor_user_id\u003dself.user_id,"},{"line_number":84,"context_line":"            trustee_user_id\u003dself.trustee_user_id,"},{"line_number":85,"context_line":"            project_id\u003dself.project_id,"},{"line_number":86,"context_line":"            impersonation\u003dFalse,"},{"line_number":87,"context_line":"            expires\u003ddict(minutes\u003d1),"},{"line_number":88,"context_line":"            role_ids\u003d[self.role_id])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        r \u003d self.post(\u0027/OS-TRUST/trusts\u0027, body\u003d{\u0027trust\u0027: ref})"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        trust \u003d self.assertValidTrustResponse(r, ref)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.delete(\u0027/OS-TRUST/trusts/%(trust_id)s\u0027 % {"},{"line_number":95,"context_line":"            \u0027trust_id\u0027: trust[\u0027id\u0027]})"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        self.get(\u0027/OS-TRUST/trusts/%(trust_id)s\u0027 % {"},{"line_number":98,"context_line":"            \u0027trust_id\u0027: trust[\u0027id\u0027]},"},{"line_number":99,"context_line":"            expected_status\u003dhttp_client.NOT_FOUND)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_invalid_trust_request_without_trustee(self):"},{"line_number":102,"context_line":"        ref \u003d unit.new_trust_ref("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_957d111e","line":99,"range":{"start_line":81,"start_character":0,"end_line":99,"end_character":50},"updated":"2016-01-11 19:10:30.000000000","message":"new test, but alright i guess","commit_id":"010ed3c1d237c54b3fd451c1ddafae59633055db"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"23aad0351d7eaf9c388fb56e4cff6bf2e2f75fd2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                  body\u003d{\u0027trust\u0027: ref},"},{"line_number":145,"context_line":"                  expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    # test create trust"},{"line_number":148,"context_line":"    # test get trust"},{"line_number":149,"context_line":"    # test trust cannot be updated"},{"line_number":150,"context_line":"    # test delete trust"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_trust_crud(self):"},{"line_number":153,"context_line":"        ref \u003d unit.new_trust_ref("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_956991c0","line":150,"range":{"start_line":147,"start_character":5,"end_line":150,"end_character":23},"updated":"2016-01-11 20:04:03.000000000","message":"reorganize this and/or remove","commit_id":"010ed3c1d237c54b3fd451c1ddafae59633055db"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5e6715527d8a111d3bfdb5a221c4e20936369e1a","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                  expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_create_trust_with_bad_remaining_uses_returns_bad_request(self):"},{"line_number":189,"context_line":"        # negative numbers, strings, non-integers, and 0 are not value values"},{"line_number":190,"context_line":"        for value in [-1, 0, \"a bad value\", 7.2]:"},{"line_number":191,"context_line":"            ref \u003d unit.new_trust_ref("},{"line_number":192,"context_line":"                trustor_user_id\u003dself.user_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_22cd0666","line":189,"range":{"start_line":189,"start_character":65,"end_line":189,"end_character":71},"updated":"2016-01-11 20:05:25.000000000","message":"valid*","commit_id":"947db5e313bc9376939e7ee3ee0fe402c10b5dc7"}]}