)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"de5c57f4c3b908a296749f2c6ff41717b05aacb1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Martinelli \u003cstevemar@ca.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-22 12:18:50 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check for circular references when expanding implied roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"closes-bug #1536321"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a68dd71_d849a761","line":7,"updated":"2016-01-22 17:23:59.000000000","message":"Why not prevent on the creation ?","commit_id":"59b0183903bf3eebd9dcad75911d15a1324fdbce"}],"keystone/assignment/core.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"72c9526629a5af85dd6fffd308eb07b772a5345a","unresolved":false,"context_lines":[{"line_number":627,"context_line":"                    implied_ref \u003d ("},{"line_number":628,"context_line":"                        _make_implied_ref_copy("},{"line_number":629,"context_line":"                            next_ref, implied_role[\u0027implied_role_id\u0027]))"},{"line_number":630,"context_line":"                    if implied_ref in checked_role_refs:"},{"line_number":631,"context_line":"                        pass"},{"line_number":632,"context_line":"                    else:"},{"line_number":633,"context_line":"                        ref_results.append(implied_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_869696ee","line":630,"range":{"start_line":630,"start_character":23,"end_line":630,"end_character":55},"updated":"2016-01-22 06:56:48.000000000","message":"this doesn\u0027t stop the actual circular ref being included in the output (but does mean that the next time around we ignore all the implied roles)....if checked_role_refs was actually a list of role_ids, would that prevent it?","commit_id":"f3af24613c7dee8ee8a7b50472d74ce779747a61"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"13e1d99191bb32d19f5a01f3fd750b65566a9e14","unresolved":false,"context_lines":[{"line_number":627,"context_line":"                    implied_ref \u003d ("},{"line_number":628,"context_line":"                        _make_implied_ref_copy("},{"line_number":629,"context_line":"                            next_ref, implied_role[\u0027implied_role_id\u0027]))"},{"line_number":630,"context_line":"                    if implied_ref in checked_role_refs:"},{"line_number":631,"context_line":"                        pass"},{"line_number":632,"context_line":"                    else:"},{"line_number":633,"context_line":"                        ref_results.append(implied_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_72c8dca8","line":630,"range":{"start_line":630,"start_character":23,"end_line":630,"end_character":55},"in_reply_to":"9a68dd71_869696ee","updated":"2016-01-22 16:54:43.000000000","message":"I don\u0027t think we need to avoid putting the refs into the token.  This just prevents an endless loop on lookup.  We can do more elsewhere to prevent cycles if we so desire.  \"checked_role_refs was actually a list of role_ids\" would still reqwuire logive to prevent following the same path multiple times.","commit_id":"f3af24613c7dee8ee8a7b50472d74ce779747a61"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"de5c57f4c3b908a296749f2c6ff41717b05aacb1","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                        _make_implied_ref_copy("},{"line_number":629,"context_line":"                            next_ref, implied_role[\u0027implied_role_id\u0027]))"},{"line_number":630,"context_line":"                    if implied_ref in checked_role_refs:"},{"line_number":631,"context_line":"                        pass"},{"line_number":632,"context_line":"                    else:"},{"line_number":633,"context_line":"                        ref_results.append(implied_ref)"},{"line_number":634,"context_line":"                        role_refs_to_check.append(implied_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_d81be771","line":631,"updated":"2016-01-22 17:23:59.000000000","message":"Please add a LOG here, as we do for hierarchical projects if we find a circular reference. See https://github.com/openstack/keystone/blob/fc3c719/keystone/resource/core.py#L608-L610","commit_id":"59b0183903bf3eebd9dcad75911d15a1324fdbce"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44709967102f88072816652a8bd1fda46016e9ff","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                        msg \u003d _LE(\u0027Circular reference found \u0027"},{"line_number":632,"context_line":"                                  \u0027role inference rules - %(prior_role_id)s.\u0027)"},{"line_number":633,"context_line":"                        LOG.error(msg, {\u0027prior_role_id\u0027: next_ref[\u0027role_id\u0027]})"},{"line_number":634,"context_line":"                        pass"},{"line_number":635,"context_line":"                    else:"},{"line_number":636,"context_line":"                        ref_results.append(implied_ref)"},{"line_number":637,"context_line":"                        role_refs_to_check.append(implied_ref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_c12d2fff","line":634,"updated":"2016-01-22 20:48:04.000000000","message":"pass can be removed","commit_id":"5ba8c31cd09c13f5e42662239d3762f854d1f515"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"bb5714e464c6cd82a48ea177dc17d02a2e4f9db1","unresolved":false,"context_lines":[{"line_number":630,"context_line":"                    if implied_ref in checked_role_refs:"},{"line_number":631,"context_line":"                        msg \u003d _LE(\u0027Circular reference found \u0027"},{"line_number":632,"context_line":"                                  \u0027role inference rules - %(prior_role_id)s.\u0027)"},{"line_number":633,"context_line":"                        LOG.error(msg, {\u0027prior_role_id\u0027: next_ref[\u0027role_id\u0027]})"},{"line_number":634,"context_line":"                    else:"},{"line_number":635,"context_line":"                        ref_results.append(implied_ref)"},{"line_number":636,"context_line":"                        role_refs_to_check.append(implied_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_8110975a","line":633,"range":{"start_line":633,"start_character":57,"end_line":633,"end_character":76},"updated":"2016-01-22 20:55:34.000000000","message":"nit: this would be better as next_role_id in case we ever change what we set the next role id from....","commit_id":"e382f66057ccb9d0aa15f7ce29d7b0b3095d72d6"}],"keystone/tests/unit/test_backend.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"72c9526629a5af85dd6fffd308eb07b772a5345a","unresolved":false,"context_lines":[{"line_number":6472,"context_line":"                # expanded out"},{"line_number":6473,"context_line":"                {\u0027params\u0027: {\u0027user\u0027: 0, \u0027effective\u0027: True},"},{"line_number":6474,"context_line":"                 \u0027results\u0027: [{\u0027user\u0027: 0, \u0027role\u0027: 0, \u0027project\u0027: 0},"},{"line_number":6475,"context_line":"                             {\u0027user\u0027: 0, \u0027role\u0027: 0, \u0027project\u0027: 0,"},{"line_number":6476,"context_line":"                              \u0027indirect\u0027: {\u0027role\u0027: 3}},"},{"line_number":6477,"context_line":"                             {\u0027user\u0027: 0, \u0027role\u0027: 1, \u0027project\u0027: 0,"},{"line_number":6478,"context_line":"                              \u0027indirect\u0027: {\u0027role\u0027: 0}},"},{"line_number":6479,"context_line":"                             {\u0027user\u0027: 0, \u0027role\u0027: 2, \u0027project\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_86c8d623","line":6476,"range":{"start_line":6475,"start_character":30,"end_line":6476,"end_character":54},"updated":"2016-01-22 06:56:48.000000000","message":"so i guess a question is whether we should see this in the results or not...i..e should the circular reference itself appear? see comment in the core.py file.","commit_id":"f3af24613c7dee8ee8a7b50472d74ce779747a61"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"13e1d99191bb32d19f5a01f3fd750b65566a9e14","unresolved":false,"context_lines":[{"line_number":6472,"context_line":"                # expanded out"},{"line_number":6473,"context_line":"                {\u0027params\u0027: {\u0027user\u0027: 0, \u0027effective\u0027: True},"},{"line_number":6474,"context_line":"                 \u0027results\u0027: [{\u0027user\u0027: 0, \u0027role\u0027: 0, \u0027project\u0027: 0},"},{"line_number":6475,"context_line":"                             {\u0027user\u0027: 0, \u0027role\u0027: 0, \u0027project\u0027: 0,"},{"line_number":6476,"context_line":"                              \u0027indirect\u0027: {\u0027role\u0027: 3}},"},{"line_number":6477,"context_line":"                             {\u0027user\u0027: 0, \u0027role\u0027: 1, \u0027project\u0027: 0,"},{"line_number":6478,"context_line":"                              \u0027indirect\u0027: {\u0027role\u0027: 0}},"},{"line_number":6479,"context_line":"                             {\u0027user\u0027: 0, \u0027role\u0027: 2, \u0027project\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_d20c28ef","line":6476,"range":{"start_line":6475,"start_character":30,"end_line":6476,"end_character":54},"in_reply_to":"9a68dd71_86c8d623","updated":"2016-01-22 16:54:43.000000000","message":"Not on this patch.  Treat this as a bug fix, and anything more should be a change to the spec first.","commit_id":"f3af24613c7dee8ee8a7b50472d74ce779747a61"}]}
