)]}'
{"keystone/tests/unit/test_validation.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"63f06ff70fb288ab2cc5ca6a0d36acc6703087b4","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    invalid_entity \u003d {}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @validation.validated(entity_schema, \u0027entity\u0027)"},{"line_number":127,"context_line":"    def do_something(self, entity):"},{"line_number":128,"context_line":"        pass"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @validation.validated(entity_create, \u0027entity\u0027)"},{"line_number":131,"context_line":"    def create_entity(self, entity):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_7ca3c600","line":128,"range":{"start_line":126,"start_character":0,"end_line":128,"end_character":12},"updated":"2016-01-22 20:59:31.000000000","message":"It doesn\u0027t look like this is used anymore. Can we remove it?","commit_id":"170c96d1b17c9ab4f1f2a5c2b99cc1eeff72425b"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"dba5dc03303f639abe3d1555166bed19455e846f","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        \"\"\"Test the case when client passing in an empty entity reference.\"\"\""},{"line_number":164,"context_line":"        self._assert_call_entity_method_fails(self.create_entity, entity\u003d{})"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_update_entity_no_request_body_with_decorator(self):"},{"line_number":167,"context_line":"        \"\"\"Test the case when request body is not provided.\"\"\""},{"line_number":168,"context_line":"        self._assert_call_entity_method_fails(self.update_entity,"},{"line_number":169,"context_line":"                                              uuid.uuid4().hex)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def test_update_entity_empty_request_body_with_decorator(self):"},{"line_number":172,"context_line":"        \"\"\"Test the case when client passing in an empty entity reference.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_102dc194","side":"PARENT","line":169,"range":{"start_line":166,"start_character":0,"end_line":169,"end_character":63},"updated":"2016-01-23 07:22:25.000000000","message":"where is this testcase got covered? this testcase is created to test that request body is not passed at all but was missed after refactoring.\n\n\n[1] self._assert_call_entity_method_fails(self.update_entity,\n                                      uuid.uuid4().hex)\n\npls not that it is different with this after refactoring.\n\n[2] self.update_entity(uuid.uuid4().hex, self.invalid_entity)\n\n\n\n[1] throw index error as following\n\u003e /opt/stack/keystone/keystone/common/validation/__init__.py(67)wrapper()\n-\u003e except IndexError:\n\n\nwhile [2] throw \n\n\u003e /opt/stack/keystone/keystone/common/validation/__init__.py(63)wrapper()\n-\u003e raise exception.ValidationError(","commit_id":"7766a4af6f0cfb845583c41f514209b0d146be5d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"baab422b207223991dddd16eb49abe6abd5ac164","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        \"\"\"Test the case when client passing in an empty entity reference.\"\"\""},{"line_number":164,"context_line":"        self._assert_call_entity_method_fails(self.create_entity, entity\u003d{})"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_update_entity_no_request_body_with_decorator(self):"},{"line_number":167,"context_line":"        \"\"\"Test the case when request body is not provided.\"\"\""},{"line_number":168,"context_line":"        self._assert_call_entity_method_fails(self.update_entity,"},{"line_number":169,"context_line":"                                              uuid.uuid4().hex)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def test_update_entity_empty_request_body_with_decorator(self):"},{"line_number":172,"context_line":"        \"\"\"Test the case when client passing in an empty entity reference.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_2156792a","side":"PARENT","line":169,"range":{"start_line":166,"start_character":0,"end_line":169,"end_character":63},"in_reply_to":"9a68dd71_102dc194","updated":"2016-01-23 11:35:28.000000000","message":"keystone.tests.unit.test_validation.ValidatedDecoratorTests.test_calling_create_without_an_entity_fails causes the index error to be raised.","commit_id":"7766a4af6f0cfb845583c41f514209b0d146be5d"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"f37b179c80ccc9856778eac39b13a577c38e1dac","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @validation.validated(entity_update, \u0027entity\u0027)"},{"line_number":131,"context_line":"    def update_entity(self, entity_id, entity):"},{"line_number":132,"context_line":"        \"\"\"Used to test cases where validated param is not the only param.\"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_calling_create_with_valid_entity_kwarg_succeeds(self):"},{"line_number":135,"context_line":"        self.create_entity(entity\u003dself.valid_entity)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_5cf8427b","line":132,"updated":"2016-01-22 21:18:42.000000000","message":"I had to test this, cool!","commit_id":"a52438fb0fb905c6d73b096a18f02b48c44cb087"}]}