)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"dba04bcd7e671994940b6963d1a86618edf87ab2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Consolidate `test_contrib_ec2.py` into `test_credential.py`"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Both of them are for V2 ec2 credential, no need two separated files"},{"line_number":10,"context_line":"to test the same things, two files also make it hard to fine where"},{"line_number":11,"context_line":"the new cases should be added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`test_credential.py` will be added to py34 testenv in the follow on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_55eb5c13","line":10,"updated":"2016-02-05 01:04:12.000000000","message":"nit: find*","commit_id":"a500dda4b4d3fd381d4aea175625ecb0ea6aff99"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0ff3c9f088f0656a2619b665f01181877a3e6de5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Consolidate `test_contrib_ec2.py` into `test_credential.py`"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Both of them are for V2 ec2 credential, no need two separated files"},{"line_number":10,"context_line":"to test the same things, two files also make it hard to fine where"},{"line_number":11,"context_line":"the new cases should be added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"`test_credential.py` will be added to py34 testenv in the follow on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_f8f7dd88","line":10,"in_reply_to":"5a5ae5dd_55eb5c13","updated":"2016-02-05 01:54:23.000000000","message":"Done","commit_id":"a500dda4b4d3fd381d4aea175625ecb0ea6aff99"}],"keystone/tests/unit/test_credential.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"01d753beb9117cab7d3eaba69d2c05e4fe6b398a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class RestfulTestCases(rest.RestfulTestCase):"},{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(RestfulTestCases, self).setUp()"},{"line_number":34,"context_line":"        self.user_id \u003d self.user_foo[\u0027id\u0027]"},{"line_number":35,"context_line":"        self.project_id \u003d self.tenant_bar[\u0027id\u0027]"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_c954f122","line":33,"updated":"2016-01-26 16:53:15.000000000","message":"I see the need for a rename, but I\u0027m not really a fan of renaming this test class to be so similar to rest.RestfulTestCase. If something else references this new class, that\u0027s going to be really confusing.","commit_id":"f7a7f438dffa1a61e750e02b09066266aa0fa320"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"a4e907314892294496f572fdb3499e6bfbd1123d","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class RestfulTestCases(rest.RestfulTestCase):"},{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(RestfulTestCases, self).setUp()"},{"line_number":34,"context_line":"        self.user_id \u003d self.user_foo[\u0027id\u0027]"},{"line_number":35,"context_line":"        self.project_id \u003d self.tenant_bar[\u0027id\u0027]"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_a2bc196d","line":33,"in_reply_to":"9a68dd71_c954f122","updated":"2016-01-28 09:43:48.000000000","message":"yep, thanks for catching this!","commit_id":"f7a7f438dffa1a61e750e02b09066266aa0fa320"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"dba04bcd7e671994940b6963d1a86618edf87ab2","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.assertEqual(cred_list[0], cred_list_2[0])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class V2CredentialController(unit.TestCase):"},{"line_number":102,"context_line":"    def setUp(self):"},{"line_number":103,"context_line":"        super(V2CredentialController, self).setUp()"},{"line_number":104,"context_line":"        self.useFixture(database.Database())"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_b55090d5","line":101,"updated":"2016-02-05 01:04:12.000000000","message":"Should this class name include ec2 somewhere since these tests are ec2 specific?\n\nOtherwise - these tests look like a clean copy from test_contrib_ec2.py","commit_id":"a500dda4b4d3fd381d4aea175625ecb0ea6aff99"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0ff3c9f088f0656a2619b665f01181877a3e6de5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.assertEqual(cred_list[0], cred_list_2[0])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class V2CredentialController(unit.TestCase):"},{"line_number":102,"context_line":"    def setUp(self):"},{"line_number":103,"context_line":"        super(V2CredentialController, self).setUp()"},{"line_number":104,"context_line":"        self.useFixture(database.Database())"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_18fc3971","line":101,"in_reply_to":"5a5ae5dd_b55090d5","updated":"2016-02-05 01:54:23.000000000","message":"yes, this is just a copy of \u0027test_contrib_ec2.py\u0027, the name didn\u0027t include \u0027ec2\u0027 since we only have ec2 APIs for V2.","commit_id":"a500dda4b4d3fd381d4aea175625ecb0ea6aff99"}]}