)]}'
{"keystone/tests/unit/test_validation.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a70f4c9c9162df7eac7299589ca3ca1c858f3063","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    def test_calling_create_with_invalid_entity_fails(self):"},{"line_number":170,"context_line":"        self.create_entity(self.invalid_entity)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @expected_validation_failure( \u0027Expecting to find entity in request body\u0027)"},{"line_number":173,"context_line":"    def test_calling_create_with_entity_arg_as_None_fails(self):"},{"line_number":174,"context_line":"        self.create_entity(None)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_6e01bf05","line":172,"updated":"2016-02-05 18:28:49.000000000","message":"remove space.","commit_id":"03d5e1eb281bb6ffb5dae3a8d4a1978f23101689"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"14eca5f3273e0b1a297fd329164f5a64ad794f86","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    def test_calling_create_with_invalid_entity_fails(self):"},{"line_number":170,"context_line":"        self.create_entity(self.invalid_entity)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @expected_validation_failure( \u0027Expecting to find entity in request body\u0027)"},{"line_number":173,"context_line":"    def test_calling_create_with_entity_arg_as_None_fails(self):"},{"line_number":174,"context_line":"        self.create_entity(None)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_25e3e5a5","line":172,"in_reply_to":"5a5ae5dd_6e01bf05","updated":"2016-02-05 19:16:04.000000000","message":"Done","commit_id":"03d5e1eb281bb6ffb5dae3a8d4a1978f23101689"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"13f5065e18a2d918a3240636132bb5ac5998d2c0","unresolved":false,"context_lines":[{"line_number":107,"context_line":"_INVALID_FILTERS \u003d [\u0027some string\u0027, 1, 0, True, False]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def expected_validation_failure(msg):"},{"line_number":111,"context_line":"    def wrapper(f):"},{"line_number":112,"context_line":"        def wrapped(self, *args, **kwargs):"},{"line_number":113,"context_line":"            args \u003d (self,) + args"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_787bc428","line":110,"updated":"2016-02-05 19:51:14.000000000","message":"The new and improved expected_validation_failure. Now with customizable msg :-)  #I\u0027ll_order_two_of_these","commit_id":"7b4fa69256e223476828026fb1c0621ae1f127b5"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ffc5fed044086a3088ebb111e317dfb4e7804fa2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"_INVALID_FILTERS \u003d [\u0027some string\u0027, 1, 0, True, False]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def expected_validation_failure(msg):"},{"line_number":111,"context_line":"    def wrapper(f):"},{"line_number":112,"context_line":"        def wrapped(self, *args, **kwargs):"},{"line_number":113,"context_line":"            args \u003d (self,) + args"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_476701b7","line":110,"range":{"start_line":110,"start_character":4,"end_line":110,"end_character":37},"updated":"2016-02-05 21:57:18.000000000","message":"maybe have a default message? so we don\u0027t have to write \"Expecting to find entity in request body\" in all the fails? or is your intention to force the author to be specific?","commit_id":"7b4fa69256e223476828026fb1c0621ae1f127b5"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"41f966991c41ee05d7988c5ddcbd3190260ae723","unresolved":false,"context_lines":[{"line_number":107,"context_line":"_INVALID_FILTERS \u003d [\u0027some string\u0027, 1, 0, True, False]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def expected_validation_failure(msg):"},{"line_number":111,"context_line":"    def wrapper(f):"},{"line_number":112,"context_line":"        def wrapped(self, *args, **kwargs):"},{"line_number":113,"context_line":"            args \u003d (self,) + args"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_67dd5ddf","line":110,"range":{"start_line":110,"start_character":4,"end_line":110,"end_character":37},"in_reply_to":"5a5ae5dd_476701b7","updated":"2016-02-05 22:13:37.000000000","message":"I originally used \"\" as the default, but I thought it was too tricky. Tricky because \"\" in any string (including another empty string) is True. Since I always provide a message I didn\u0027t think adding a \u0027if msg\u0027 line (instead of defaulting to empty) was worth it.","commit_id":"7b4fa69256e223476828026fb1c0621ae1f127b5"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4503d593c91296e477b66cf67d0c1697ce04ad7f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    def wrapper(f):"},{"line_number":112,"context_line":"        def wrapped(self, *args, **kwargs):"},{"line_number":113,"context_line":"            args \u003d (self,) + args"},{"line_number":114,"context_line":"            e \u003d self.assertRaises(exception.ValidationError, f, *args, **kwargs)"},{"line_number":115,"context_line":"            self.assertIn(msg, six.text_type(e))"},{"line_number":116,"context_line":"        return wrapped"},{"line_number":117,"context_line":"    return wrapper"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_215bccf7","line":114,"range":{"start_line":114,"start_character":12,"end_line":114,"end_character":80},"updated":"2016-02-06 03:29:25.000000000","message":"pep8 failz","commit_id":"7b4fa69256e223476828026fb1c0621ae1f127b5"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"13f5065e18a2d918a3240636132bb5ac5998d2c0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    invalid_entity \u003d {"},{"line_number":135,"context_line":"        \u0027name\u0027: 1.0,  # NOTE(dstanek): this is the incorrect type for name"},{"line_number":136,"context_line":"    }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @validation.validated(entity_create, \u0027entity\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_f8a7b4ba","line":135,"updated":"2016-02-05 19:51:14.000000000","message":"Nice of you to make it clear that this is for an incorrect type.  Although you could have called the variable decent_browns_quarterback and it would then be obvious this was an invalid_entity","commit_id":"7b4fa69256e223476828026fb1c0621ae1f127b5"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"41f966991c41ee05d7988c5ddcbd3190260ae723","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    invalid_entity \u003d {"},{"line_number":135,"context_line":"        \u0027name\u0027: 1.0,  # NOTE(dstanek): this is the incorrect type for name"},{"line_number":136,"context_line":"    }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @validation.validated(entity_create, \u0027entity\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_67047d49","line":135,"in_reply_to":"5a5ae5dd_b154f7fd","updated":"2016-02-05 22:13:37.000000000","message":"It\u0027s too soon until we get a quarterback. So it\u0027s always too soon","commit_id":"7b4fa69256e223476828026fb1c0621ae1f127b5"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0952c7a11852204f9bfc3c3d0f973e6b8cadcaec","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    invalid_entity \u003d {"},{"line_number":135,"context_line":"        \u0027name\u0027: 1.0,  # NOTE(dstanek): this is the incorrect type for name"},{"line_number":136,"context_line":"    }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @validation.validated(entity_create, \u0027entity\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_5ba5a29f","line":135,"in_reply_to":"5a5ae5dd_f8a7b4ba","updated":"2016-02-05 20:14:15.000000000","message":"always hitting below the belt","commit_id":"7b4fa69256e223476828026fb1c0621ae1f127b5"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"32743a6bd8f48d04d609ec143e78613e9ae1651f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    invalid_entity \u003d {"},{"line_number":135,"context_line":"        \u0027name\u0027: 1.0,  # NOTE(dstanek): this is the incorrect type for name"},{"line_number":136,"context_line":"    }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @validation.validated(entity_create, \u0027entity\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_b154f7fd","line":135,"in_reply_to":"5a5ae5dd_f8a7b4ba","updated":"2016-02-05 20:55:10.000000000","message":"too soon? Sorry...","commit_id":"7b4fa69256e223476828026fb1c0621ae1f127b5"}]}