)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8c8e389e209c27b8a5514b372fa8a62398b46bf7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"created from trusts"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I76b94faf094721c254caa6f9d7289d084c957d80"},{"line_number":13,"context_line":"Closes-Bug: 1539240"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_ab2ba493","line":13,"updated":"2016-02-09 14:50:45.000000000","message":"add: \n\n    Related-Bug: 1543318","commit_id":"c96ec89f5cd50129b697efe80fdac5937a2750d8"}],"keystone/tests/unit/test_v3_assignment.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"9a2fc039c498f7f0bca0b097c401c8d4b77846b8","unresolved":false,"context_lines":[{"line_number":2584,"context_line":"        self._create_implied_role(self.role_list[1], self.role_list[2])"},{"line_number":2585,"context_line":"        self._assign_top_role_to_user_on_project(self.user, self.project)"},{"line_number":2586,"context_line":""},{"line_number":2587,"context_line":"        # Create a trustee and assign the prior role to her"},{"line_number":2588,"context_line":"        trustee \u003d unit.create_user(self.identity_api, domain_id\u003dself.domain_id)"},{"line_number":2589,"context_line":"        ref \u003d unit.new_trust_ref("},{"line_number":2590,"context_line":"            trustor_user_id\u003dself.user[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_a0da3615","line":2587,"range":{"start_line":2587,"start_character":56,"end_line":2587,"end_character":59},"updated":"2016-02-08 10:27:08.000000000","message":"nice","commit_id":"a6d33a74031129302154d1301658cc19da54fa87"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"9a2fc039c498f7f0bca0b097c401c8d4b77846b8","unresolved":false,"context_lines":[{"line_number":2605,"context_line":"            trust_id\u003dtrust[\u0027id\u0027])"},{"line_number":2606,"context_line":"        r \u003d self.v3_create_token(auth_data)"},{"line_number":2607,"context_line":""},{"line_number":2608,"context_line":"        # All the role assignments are in the token"},{"line_number":2609,"context_line":"        # Why is no token returned?"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_34768bd7","line":2608,"range":{"start_line":2608,"start_character":10,"end_line":2608,"end_character":51},"updated":"2016-02-08 10:27:08.000000000","message":"how do you know this, if no token is returned? does it raise an exception or just return empty?","commit_id":"a6d33a74031129302154d1301658cc19da54fa87"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8ad0f22815b6f746e1a31cf2b8ce195301660fe2","unresolved":false,"context_lines":[{"line_number":2605,"context_line":"            trust_id\u003dtrust[\u0027id\u0027])"},{"line_number":2606,"context_line":"        r \u003d self.v3_create_token(auth_data)"},{"line_number":2607,"context_line":""},{"line_number":2608,"context_line":"        # All the role assignments are in the token"},{"line_number":2609,"context_line":"        # Why is no token returned?"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_8de1602c","line":2608,"range":{"start_line":2608,"start_character":10,"end_line":2608,"end_character":51},"in_reply_to":"5a5ae5dd_34768bd7","updated":"2016-02-08 15:19:12.000000000","message":"should have marked the patch in WIP. this comment is my assumption, I hope that\u0027s the result. \n\nStill scratching my head at why r.result didn\u0027t have what looked like a usual token response","commit_id":"a6d33a74031129302154d1301658cc19da54fa87"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"96b5726c500b0877015800d81a1278ededd3dde4","unresolved":false,"context_lines":[{"line_number":2609,"context_line":"        # FIXME(stevemar): Only one role appears in the tokn, it should"},{"line_number":2610,"context_line":"        # have all the implied roles."},{"line_number":2611,"context_line":"        self.assertEqual(self.role_list[0][\u0027id\u0027], token[\u0027roles\u0027][0][\u0027id\u0027])"},{"line_number":2612,"context_line":"        self.assertThat(trust[\u0027roles\u0027], matchers.HasLength(1))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_4ea4b049","line":2612,"range":{"start_line":2612,"start_character":24,"end_line":2612,"end_character":29},"updated":"2016-02-08 21:02:10.000000000","message":"I think you mean \u0027token\u0027 here....","commit_id":"4032bf32389b2db20f7e7d2e2f1c19a5a4fdbf2c"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"39eca840bbc349e04d4b68f07b3cd4a522b57de9","unresolved":false,"context_lines":[{"line_number":2609,"context_line":"        # FIXME(stevemar): Only one role appears in the tokn, it should"},{"line_number":2610,"context_line":"        # have all the implied roles."},{"line_number":2611,"context_line":"        self.assertEqual(self.role_list[0][\u0027id\u0027], token[\u0027roles\u0027][0][\u0027id\u0027])"},{"line_number":2612,"context_line":"        self.assertThat(trust[\u0027roles\u0027], matchers.HasLength(1))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_ee1a3c7c","line":2612,"range":{"start_line":2612,"start_character":24,"end_line":2612,"end_character":29},"in_reply_to":"5a5ae5dd_4ea4b049","updated":"2016-02-08 21:03:42.000000000","message":"yep, the issue is still there though :)","commit_id":"4032bf32389b2db20f7e7d2e2f1c19a5a4fdbf2c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8c8e389e209c27b8a5514b372fa8a62398b46bf7","unresolved":false,"context_lines":[{"line_number":2594,"context_line":"        r \u003d self.post(\u0027/OS-TRUST/trusts\u0027, body\u003d{\u0027trust\u0027: ref})"},{"line_number":2595,"context_line":"        trust \u003d r.result[\u0027trust\u0027]"},{"line_number":2596,"context_line":""},{"line_number":2597,"context_line":"        # Only the role that was specified is in the trust, NOT implies roles"},{"line_number":2598,"context_line":"        self.assertEqual(self.role_list[0][\u0027id\u0027], trust[\u0027roles\u0027][0][\u0027id\u0027])"},{"line_number":2599,"context_line":"        self.assertThat(trust[\u0027roles\u0027], matchers.HasLength(1))"},{"line_number":2600,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_ebac3c37","line":2597,"updated":"2016-02-09 14:50:45.000000000","message":"implied*","commit_id":"c96ec89f5cd50129b697efe80fdac5937a2750d8"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"cbb3948025b6b46e6e699a5779476bdc1db4c1c5","unresolved":false,"context_lines":[{"line_number":2578,"context_line":"        url \u003d \u0027/roles/%s/implies/%s\u0027 % (prior[\u0027id\u0027], root_role[\u0027id\u0027])"},{"line_number":2579,"context_line":"        self.put(url, expected_status\u003dhttp_client.FORBIDDEN)"},{"line_number":2580,"context_line":""},{"line_number":2581,"context_line":""},{"line_number":2582,"context_line":"class DomainSpecificRoleTests(test_v3.RestfulTestCase, unit.TestCase):"},{"line_number":2583,"context_line":"    def setUp(self):"},{"line_number":2584,"context_line":"        def create_role(domain_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_51c9e657","side":"PARENT","line":2581,"range":{"start_line":2581,"start_character":0,"end_line":2581,"end_character":0},"updated":"2016-02-12 20:16:32.000000000","message":"Re-add this line, it\u0027s making pep8 to fail","commit_id":"3eb718b9dca5e15b5b9154ecdf5b7cd512d76607"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"cbb3948025b6b46e6e699a5779476bdc1db4c1c5","unresolved":false,"context_lines":[{"line_number":2680,"context_line":"        # FIXME(stevemar): See bug 1543318: Only one role appears in the"},{"line_number":2681,"context_line":"        # token, it should have all the implied roles."},{"line_number":2682,"context_line":"        self.assertEqual(self.role_list[0][\u0027id\u0027], token[\u0027roles\u0027][0][\u0027id\u0027])"},{"line_number":2683,"context_line":"        self.assertThat(token[\u0027roles\u0027], matchers.HasLength(1))"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_919bde65","line":2683,"updated":"2016-02-12 20:16:32.000000000","message":"Nice! We could just use a @wip annotation here and get this test exposing the bug merged","commit_id":"c5e88a4e7d855fc076e0144dc08a213025cfc4d3"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"ac2d0d0732be153fb167a23db9d03a83681aee01","unresolved":false,"context_lines":[{"line_number":2612,"context_line":"        # token, it should have all the implied roles (3)."},{"line_number":2613,"context_line":"        self.assertThat(token[\u0027roles\u0027],"},{"line_number":2614,"context_line":"                        matchers.HasLength(len(self.role_list)))"},{"line_number":2615,"context_line":""},{"line_number":2616,"context_line":""},{"line_number":2617,"context_line":"class DomainSpecificRoleTests(test_v3.RestfulTestCase, unit.TestCase):"},{"line_number":2618,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a57f1b5_f9579823","line":2615,"updated":"2016-02-12 21:32:41.000000000","message":"Can also add\n\n        for role in token[\u0027roles\u0027]:\n            self.assertIn(role, self.role_list)\n\n        for role  in self.role_list:\n            self.assertIn(role, token[\u0027roles\u0027])","commit_id":"3df2b2d8988c81cbac227732e0783664c8db104e"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"b1a741a65c488b408859325176f9df684091f00b","unresolved":false,"context_lines":[{"line_number":2618,"context_line":"        self._create_implied_role(self.role_list[1], self.role_list[2])"},{"line_number":2619,"context_line":"        self._assign_top_role_to_user_on_project(self.user, self.project)"},{"line_number":2620,"context_line":""},{"line_number":2621,"context_line":"        # Create a trustee and assign the prior role to her"},{"line_number":2622,"context_line":"        trustee \u003d unit.create_user(self.identity_api, domain_id\u003dself.domain_id)"},{"line_number":2623,"context_line":"        ref \u003d unit.new_trust_ref("},{"line_number":2624,"context_line":"            trustor_user_id\u003dself.user[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a54edaf_2c5297de","line":2621,"range":{"start_line":2621,"start_character":56,"end_line":2621,"end_character":59},"updated":"2016-02-13 05:07:10.000000000","message":"I assume you mean \"the user\"?","commit_id":"98934a3e548f8abd8722b01493356fcc8586b1ba"}]}
